Bumped version

Fixed out of order

.gitignore

@@ -0,0 +1 @@
+build

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "app/packages/redis-oplog"]
+	path = app/packages/redis-oplog
+	url = https://github.com/ramezrafla/redis-oplog.git

README.md

@@ -1,7 +1,7 @@
 DiceCloud
 ========
 
-This is the repo for [DiceCloud](dicecloud.com).
+This is the repo for [DiceCloud](https://dicecloud.com).
 
 DiceCloud is a free, auditable, real-time character sheet for D&D 5e.
 
@@ -66,5 +66,24 @@ You should see this:
 => App running at: http://localhost:3000/
 ```
 
+Environmental Variables
+-----------------------
+
+```
+MAIL_URL=smtp://<your smtp mail url>
+METEOR_SETTINGS={ "public": { "environment": "production", "patreon": { "clientId": "<your patreon client ID>", "campaignId": "<your campaign id>" } }, "patreon": { "clientSecret": "<your client secret>", "creatorAccessToken": "<your creator access token>" } }
+MONGO_OPLOG_URL=mongodb+srv://<your url for the oplog account of your mongo database>
+MONGO_URL=mongodb+srv://<your url for the read/write account of your mongo database>
+NPM_CONFIG_PRODUCTION=true
+PROJECT_DIR=app
+ROOT_URL=https://<url of your DiceCloud instance>
+DEFAULT_LIBRARIES=<comma separated list of library ids that will be subscribed by default: "abc123,def456">
+```
+
+To disable Patreon features and unlock all paid restrictions for all users of your deployment, replace
+`"patreon": { "clientId": ... }"` with `"disablePatreon": true` in the public key of the METEOR_SETTINGS environment variable.
+
+Alternatively run `meteor run --settings exampleMeteorSettings.json` to start the app with the example settings that disable Patreon by default.
+
 Now, visiting [](http://localhost:3000/) should show you an empty instance of
 DiceCloud running.

app/.gitignore

@@ -2,6 +2,8 @@
 .meteor/meteorite
 .demeteorized
 .cache
+.vscode
+fileStorage
 settings.json
 public/components
 public/_imports.html

app/.meteor/packages

@@ -3,44 +3,34 @@
 # 'meteor add' and 'meteor remove' will edit this file for you,
 # but you can also edit it by hand.
 
-accounts-password@1.7.0
-random@1.2.0
-dburles:collection-helpers
-reactive-var@1.0.11
-underscore@1.0.10
-momentjs:moment
+zegenie:redis-oplog
+accounts-password@2.3.4
+random@1.2.1
+underscore@1.0.13
 dburles:mongo-collection-instances
-accounts-google@1.3.3
-email@2.0.0
-meteorhacks:subs-manager
-chuangbo:marked
-meteor-base@1.4.0
+accounts-google@1.4.0
+email@2.2.5
+meteor-base@1.5.1
 mobile-experience@1.1.0
-mongo@1.11.0
-session@1.2.0
-tracker@1.2.0
-logging@1.2.0
+mongo@1.16.6
+session@1.2.1
+tracker@1.3.2
+logging@1.3.2
 reload@1.3.1
-ejson@1.1.1
-check@1.3.1
-standard-minifier-js@2.6.0
+ejson@1.1.3
+check@1.3.2
+standard-minifier-js@2.8.1
 shell-server@0.5.0
-templates:array
-ecmascript@0.15.1
+ecmascript@0.16.7
 es5-shim@4.8.0
-reactive-dict@1.3.0
-percolate:synced-cron
-ongoworks:speakingurl
-service-configuration@1.0.11
-dynamic-import@0.6.0
-ddp-rate-limiter@1.0.9
-rate-limit@1.0.9
+service-configuration@1.3.1
+dynamic-import@0.7.3
+ddp-rate-limiter@1.2.0
+rate-limit@1.1.1
 mdg:validated-method
-akryum:vue-router2
-static-html
-aldeed:collection2@3.0.0
+static-html@1.3.2
+aldeed:collection2
 aldeed:schema-index
-zer0th:meteor-vuetify-loader
 accounts-patreon
 bozhao:link-accounts
 peerlibrary:reactive-publish
@@ -48,6 +38,16 @@ simple:rest
 simple:rest-method-mixin
 mikowals:batch-insert
 peerlibrary:subscription-data
+zer0th:meteor-vuetify-loader
+akryum:vue-component@0.15.2
+akryum:vue-router2
+percolate:migrations
+meteortesting:mocha
+ostrio:files
+simple:rest-bearer-token-parser
+simple:rest-json-error-handler
+littledata:synced-cron
+#mdg:meteor-apm-agent
+typescript@4.9.4
 seba:minifiers-autoprefixer
-akryum:vue-component
-akryum:vue-sass
+mixmax:smart-disconnect

app/.meteor/release

@@ -1 +1 @@
-METEOR@2.2
+METEOR@2.12

app/.meteor/versions

@@ -1,87 +1,85 @@
-accounts-base@1.9.0
-accounts-google@1.3.3
-accounts-oauth@1.2.0
-accounts-password@1.7.0
+accounts-base@2.2.8
+accounts-google@1.4.0
+accounts-oauth@1.4.2
+accounts-password@2.3.4
 accounts-patreon@0.1.0
 akryum:npm-check@0.1.2
 akryum:vue-component@0.15.2
 akryum:vue-component-dev-client@0.4.7
 akryum:vue-component-dev-server@0.1.4
 akryum:vue-router2@0.2.3
-akryum:vue-sass@0.1.2
-aldeed:collection2@3.3.0
+aldeed:collection2@3.5.0
 aldeed:schema-index@3.0.0
-allow-deny@1.1.0
-autoupdate@1.7.0
-babel-compiler@7.6.1
-babel-runtime@1.5.0
+allow-deny@1.1.1
+autoupdate@1.8.0
+babel-compiler@7.10.4
+babel-runtime@1.5.1
 base64@1.0.12
 binary-heap@1.0.11
-blaze-tools@1.1.1
+blaze-tools@1.1.3
 boilerplate-generator@1.7.1
-bozhao:link-accounts@2.3.2
+bozhao:link-accounts@2.6.1
 caching-compiler@1.2.2
-caching-html-compiler@1.2.0
-callback-hook@1.3.0
-check@1.3.1
-chuangbo:marked@0.3.5_1
+caching-html-compiler@1.2.1
+callback-hook@1.5.1
+check@1.3.2
 coffeescript@2.4.1
 coffeescript-compiler@2.4.1
-dburles:collection-helpers@1.1.0
-dburles:mongo-collection-instances@0.3.5
-ddp@1.4.0
-ddp-client@2.4.0
+dburles:mongo-collection-instances@0.3.6
+ddp@1.4.1
+ddp-client@2.6.1
 ddp-common@1.4.0
-ddp-rate-limiter@1.0.9
-ddp-server@2.3.2
-deps@1.0.12
-diff-sequence@1.1.1
-dynamic-import@0.6.0
-ecmascript@0.15.1
-ecmascript-runtime@0.7.0
-ecmascript-runtime-client@0.11.0
-ecmascript-runtime-server@0.10.0
-ejson@1.1.1
-email@2.0.0
+ddp-rate-limiter@1.2.0
+ddp-server@2.6.1
+diff-sequence@1.1.2
+dynamic-import@0.7.3
+ecmascript@0.16.7
+ecmascript-runtime@0.8.1
+ecmascript-runtime-client@0.12.1
+ecmascript-runtime-server@0.11.0
+ejson@1.1.3
+email@2.2.5
 es5-shim@4.8.0
-fetch@0.1.1
-geojson-utils@1.0.10
-google-oauth@1.3.0
+fetch@0.1.3
+geojson-utils@1.0.11
+google-oauth@1.4.3
 hot-code-push@1.0.4
-html-tools@1.1.1
-htmljs@1.1.0
-http@1.4.3
-id-map@1.1.0
+html-tools@1.1.3
+htmljs@1.1.1
+http@2.0.0
+id-map@1.1.1
 inter-process-messaging@0.1.1
-lai:collection-extensions@0.2.1_1
-launch-screen@1.2.1
-livedata@1.0.18
+lai:collection-extensions@0.3.0
+launch-screen@1.3.0
+littledata:synced-cron@1.5.1
 localstorage@1.2.0
-logging@1.2.0
-mdg:validated-method@1.2.0
-meteor@1.9.3
-meteor-base@1.4.0
-meteorhacks:subs-manager@1.6.4
-mikowals:batch-insert@1.2.0
-minifier-css@1.5.3
-minifier-js@2.6.0
-minimongo@1.6.2
+logging@1.3.2
+mdg:validated-method@1.3.0
+meteor@1.11.2
+meteor-base@1.5.1
+meteortesting:browser-tests@1.4.2
+meteortesting:mocha@2.1.0
+meteortesting:mocha-core@8.1.2
+mikowals:batch-insert@1.3.0
+minifier-css@1.6.4
+minifier-js@2.7.5
+minimongo@1.9.3
+mixmax:smart-disconnect@0.0.5
 mobile-experience@1.1.0
 mobile-status-bar@1.1.0
-modern-browsers@0.1.5
-modules@0.16.0
-modules-runtime@0.12.0
-momentjs:moment@2.29.1
-mongo@1.11.0
-mongo-decimal@0.1.2
+modern-browsers@0.1.9
+modules@0.19.0
+modules-runtime@0.13.1
+mongo@1.16.6
+mongo-decimal@0.1.3
 mongo-dev-server@1.1.0
-mongo-id@1.0.7
-npm-bcrypt@0.9.3
-npm-mongo@3.9.0
-oauth@1.3.2
-oauth2@1.3.0
-ongoworks:speakingurl@9.0.0
+mongo-id@1.0.8
+npm-mongo@4.16.0
+oauth@2.2.0
+oauth2@1.3.2
 ordered-dict@1.1.0
+ostrio:cookies@2.7.2
+ostrio:files@2.3.3
 patreon-oauth@0.1.0
 peerlibrary:assert@0.3.0
 peerlibrary:check-extension@0.7.0
@@ -89,41 +87,42 @@ peerlibrary:computed-field@0.10.0
 peerlibrary:data-lookup@0.3.0
 peerlibrary:extend-publish@0.6.0
 peerlibrary:fiber-utils@0.10.0
-peerlibrary:reactive-mongo@0.4.0
+peerlibrary:reactive-mongo@0.4.1
 peerlibrary:reactive-publish@0.10.0
 peerlibrary:server-autorun@0.8.0
 peerlibrary:subscription-data@0.8.0
-percolate:synced-cron@1.3.2
-promise@0.11.2
+percolate:migrations@1.1.0
+promise@0.12.2
 raix:eventemitter@1.0.0
-random@1.2.0
-rate-limit@1.0.9
-react-fast-refresh@0.1.0
-reactive-dict@1.3.0
-reactive-var@1.0.11
+random@1.2.1
+rate-limit@1.1.1
+react-fast-refresh@0.2.7
+reactive-dict@1.3.1
+reactive-var@1.0.12
 reload@1.3.1
 retry@1.1.0
-routepolicy@1.1.0
+routepolicy@1.1.1
 seba:minifiers-autoprefixer@2.0.1
-service-configuration@1.0.11
-session@1.2.0
+service-configuration@1.3.1
+session@1.2.1
 sha@1.0.9
 shell-server@0.5.0
-simple:json-routes@2.1.0
-simple:rest@1.1.1
-simple:rest-method-mixin@1.0.1
-socket-stream-client@0.3.1
-spacebars-compiler@1.2.1
-srp@1.1.0
-standard-minifier-js@2.6.0
-static-html@1.3.0
-templates:array@1.0.3
-templating-tools@1.2.0
-tmeasday:check-npm-versions@1.0.1
-tracker@1.2.0
-typescript@4.2.2
-underscore@1.0.10
-url@1.3.1
-webapp@1.10.1
-webapp-hashing@1.1.0
-zer0th:meteor-vuetify-loader@0.1.30
+simple:json-routes@2.3.1
+simple:rest@1.2.1
+simple:rest-bearer-token-parser@1.1.1
+simple:rest-json-error-handler@1.1.1
+simple:rest-method-mixin@1.1.0
+socket-stream-client@0.5.1
+spacebars-compiler@1.3.1
+standard-minifier-js@2.8.1
+static-html@1.3.2
+templating-tools@1.2.2
+tmeasday:check-npm-versions@1.0.2
+tracker@1.3.2
+typescript@4.9.4
+underscore@1.0.13
+url@1.3.2
+webapp@1.13.5
+webapp-hashing@1.1.1
+zegenie:redis-oplog@2.0.16
+zer0th:meteor-vuetify-loader@0.1.41

app/client/head.html

@@ -1,38 +1,39 @@
 <head>
-  <link href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900|Material+Icons" rel="stylesheet">
+  <link href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900" rel="stylesheet">
+  <link href="https://cdn.jsdelivr.net/npm/@mdi/font@5.x/css/materialdesignicons.min.css" rel="stylesheet">
   <meta name="viewport" content="width=device-width initial-scale=1.0, user-scalable=no">
-	<meta name="mobile-web-app-capable" content="yes">
-	<meta name="apple-mobile-web-app-capable" content="yes">
-	<link rel="apple-touch-icon" sizes="57x57" href="/apple-touch-icon-57x57.png?v=lk6WXp6Pmj">
-	<link rel="apple-touch-icon" sizes="60x60" href="/apple-touch-icon-60x60.png?v=lk6WXp6Pmj">
-	<link rel="apple-touch-icon" sizes="72x72" href="/apple-touch-icon-72x72.png?v=lk6WXp6Pmj">
-	<link rel="apple-touch-icon" sizes="76x76" href="/apple-touch-icon-76x76.png?v=lk6WXp6Pmj">
-	<link rel="apple-touch-icon" sizes="114x114" href="/apple-touch-icon-114x114.png?v=lk6WXp6Pmj">
-	<link rel="apple-touch-icon" sizes="120x120" href="/apple-touch-icon-120x120.png?v=lk6WXp6Pmj">
-	<link rel="apple-touch-icon" sizes="144x144" href="/apple-touch-icon-144x144.png?v=lk6WXp6Pmj">
-	<link rel="apple-touch-icon" sizes="152x152" href="/apple-touch-icon-152x152.png?v=lk6WXp6Pmj">
-	<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon-180x180.png?v=lk6WXp6Pmj">
-	<link rel="icon" type="image/png" href="/favicon-32x32.png?v=lk6WXp6Pmj" sizes="32x32">
-	<link rel="icon" type="image/png" href="/favicon-194x194.png?v=lk6WXp6Pmj" sizes="194x194">
-	<link rel="icon" type="image/png" href="/favicon-96x96.png?v=lk6WXp6Pmj" sizes="96x96">
-	<link rel="icon" type="image/png" href="/android-chrome-192x192.png?v=lk6WXp6Pmj" sizes="192x192">
-	<link rel="icon" type="image/png" href="/favicon-16x16.png?v=lk6WXp6Pmj" sizes="16x16">
-	<link rel="manifest" href="/manifest.json?v=lk6WXp6Pmj">
-	<link rel="shortcut icon" href="/favicon.ico?v=lk6WXp6Pmj">
-	<meta name="msapplication-TileColor" content="#b91d1d">
-	<meta name="msapplication-TileImage" content="/mstile-144x144.png?v=lk6WXp6Pmj">
-	<meta name="theme-color" content="#d12929">
+  <meta name="mobile-web-app-capable" content="yes">
+  <meta name="apple-mobile-web-app-capable" content="yes">
+  <link rel="apple-touch-icon" sizes="57x57" href="/apple-touch-icon-57x57.png?v=lk6WXp6Pmj">
+  <link rel="apple-touch-icon" sizes="60x60" href="/apple-touch-icon-60x60.png?v=lk6WXp6Pmj">
+  <link rel="apple-touch-icon" sizes="72x72" href="/apple-touch-icon-72x72.png?v=lk6WXp6Pmj">
+  <link rel="apple-touch-icon" sizes="76x76" href="/apple-touch-icon-76x76.png?v=lk6WXp6Pmj">
+  <link rel="apple-touch-icon" sizes="114x114" href="/apple-touch-icon-114x114.png?v=lk6WXp6Pmj">
+  <link rel="apple-touch-icon" sizes="120x120" href="/apple-touch-icon-120x120.png?v=lk6WXp6Pmj">
+  <link rel="apple-touch-icon" sizes="144x144" href="/apple-touch-icon-144x144.png?v=lk6WXp6Pmj">
+  <link rel="apple-touch-icon" sizes="152x152" href="/apple-touch-icon-152x152.png?v=lk6WXp6Pmj">
+  <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon-180x180.png?v=lk6WXp6Pmj">
+  <link rel="icon" type="image/png" href="/favicon-32x32.png?v=lk6WXp6Pmj" sizes="32x32">
+  <link rel="icon" type="image/png" href="/favicon-194x194.png?v=lk6WXp6Pmj" sizes="194x194">
+  <link rel="icon" type="image/png" href="/favicon-96x96.png?v=lk6WXp6Pmj" sizes="96x96">
+  <link rel="icon" type="image/png" href="/android-chrome-192x192.png?v=lk6WXp6Pmj" sizes="192x192">
+  <link rel="icon" type="image/png" href="/favicon-16x16.png?v=lk6WXp6Pmj" sizes="16x16">
+  <link rel="manifest" href="/manifest.json?v=lk6WXp6Pmj">
+  <link rel="shortcut icon" href="/favicon.ico?v=lk6WXp6Pmj">
+  <meta name="msapplication-TileColor" content="#b91d1d">
+  <meta name="msapplication-TileImage" content="/mstile-144x144.png?v=lk6WXp6Pmj">
+  <meta name="theme-color" content="#d12929">
 
-	<style type="text/css" media="print">
-		@page {
-			margin: 0mm;
-		}
-		html {
-			margin: 0px;
-		}
-		* {
-			-webkit-transition: none !important;
-			transition: none !important;
-		}
-	</style>
+  <style type="text/css" media="print">
+    @page {
+      margin: 0mm;
+    }
+    html {
+      margin: 0px;
+    }
+    * {
+      -webkit-transition: none !important;
+      transition: none !important;
+    }
+  </style>
 </head>

app/client/main.js

@@ -1,3 +1,7 @@
-import '/imports/ui/vueSetup.js';
-import '/imports/ui/styles/stylesIndex.js';
+import '/imports/api/simpleSchemaConfig.js';
+import '/imports/client/ui/vueSetup.js';
+import '/imports/client/ui/styles/stylesIndex.js';
 import '/imports/client/config.js';
+import '/imports/client/serviceWorker.js';
+
+import 'ngraph.graph';

app/exampleMeteorSettings.json

@@ -0,0 +1,6 @@
+{
+  "public": {
+    "environment": "production",
+    "disablePatreon": true
+  }
+}

app/imports/api/creature/Creatures.js

@@ -1,267 +0,0 @@
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import SimpleSchema from 'simpl-schema';
-import deathSaveSchema from '/imports/api/properties/subSchemas/DeathSavesSchema.js'
-import ColorSchema from '/imports/api/properties/subSchemas/ColorSchema.js';
-import SharingSchema from '/imports/api/sharing/SharingSchema.js';
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import {assertEditPermission} from '/imports/api/sharing/sharingPermissions.js';
-import { assertUserHasPaidBenefits } from '/imports/api/users/patreon/tiers.js';
-import defaultCharacterProperties from '/imports/api/creature/defaultCharacterProperties.js';
-import insertPropertyFromLibraryNode from '/imports/api/creature/creatureProperties/methods/insertPropertyFromLibraryNode.js';
-import '/imports/api/creature/removeCreature.js';
-import '/imports/api/creature/restCreature.js';
-
-//set up the collection for creatures
-let Creatures = new Mongo.Collection('creatures');
-
-let CreatureSettingsSchema = new SimpleSchema({
-	//slowed down by carrying too much?
-	useVariantEncumbrance: {
-		type: Boolean,
-		optional: true,
-	},
-	//hide spellcasting tab
-	hideSpellcasting: {
-		type: Boolean,
-		optional: true,
-	},
-	// Swap around the modifier and stat
-	swapStatAndModifier: {
-		type: Boolean,
-		optional: true,
-	},
-  // Hide all the unused stats
-  hideUnusedStats: {
-    type: Boolean,
-    optional: true,
-  },
-  // Show the tree tab
-  showTreeTab: {
-    type: Boolean,
-    optional: true,
-  },
-  // Hide the spells tab
-  hideSpellsTab: {
-    type: Boolean,
-    optional: true,
-  },
-  // How much each hitDice resets on a long rest
-  hitDiceResetMultiplier: {
-    type: Number,
-    optional: true,
-    min: 0,
-    max: 1,
-  },
-  discordWebhook: {
-    type: String,
-    optional: true,
-    max: 200,
-  },
-});
-
-let CreatureSchema = new SimpleSchema({
-	// Strings
-	name: {
-		type: String,
-		defaultValue: '',
-		optional: true,
-	},
-	alignment: {
-		type: String,
-		optional: true
-	},
-	gender: {
-		type: String,
-		optional: true
-	},
-	picture: {
-		type: String,
-		optional: true
-	},
-  avatarPicture: {
-    type: String,
-    optional: true,
-  },
-	// Mechanics
-	deathSave: {
-		type: deathSaveSchema,
-		defaultValue: {},
-	},
-  // Stats that are computed and denormalised outside of recomputation
-  denormalizedStats: {
-    type: Object,
-    defaultValue: {},
-  },
-  // Sum of all XP gained by this character
-	'denormalizedStats.xp': {
-		type: SimpleSchema.Integer,
-		defaultValue: 0,
-	},
-  // Sum of all levels granted by milestone XP
-  'denormalizedStats.milestoneLevels': {
-    type: SimpleSchema.Integer,
-    defaultValue: 0,
-  },
-  // Inventory
-	'denormalizedStats.weightTotal': {
-		type: Number,
-		defaultValue: 0,
-	},
-  'denormalizedStats.weightEquipment': {
-		type: Number,
-		defaultValue: 0,
-	},
-  'denormalizedStats.weightCarried': {
-		type: Number,
-		defaultValue: 0,
-	},
-  'denormalizedStats.valueTotal': {
-		type: Number,
-		defaultValue: 0,
-	},
-  'denormalizedStats.valueEquipment': {
-		type: Number,
-		defaultValue: 0,
-	},
-  'denormalizedStats.valueCarried': {
-		type: Number,
-		defaultValue: 0,
-	},
-  'denormalizedStats.itemsAttuned': {
-		type: Number,
-		defaultValue: 0,
-	},
-  // Version of computation engine that was last used to compute this creature
-  computeVersion: {
-		type: String,
-    optional: true,
-	},
-	type: {
-		type: String,
-		defaultValue: 'pc',
-		allowedValues: ['pc', 'npc', 'monster'],
-	},
-  damageMultipliers: {
-    type: Object,
-		blackbox: true,
-		defaultValue: {}
-  },
-	variables: {
-		type: Object,
-		blackbox: true,
-		defaultValue: {}
-	},
-
-  // Tabletop
-  tabletop: {
-    type: String,
-    regEx: SimpleSchema.RegEx.id,
-    optional: true,
-  },
-  initiativeRoll: {
-    type: SimpleSchema.Integer,
-    optional: true,
-  },
-
-	// Settings
-	settings: {
-		type: CreatureSettingsSchema,
-		defaultValue: {},
-	},
-});
-
-CreatureSchema.extend(ColorSchema);
-CreatureSchema.extend(SharingSchema);
-
-Creatures.attachSchema(CreatureSchema);
-
-const insertCreature = new ValidatedMethod({
-
-  name: 'creatures.insertCreature',
-
-  validate: null,
-
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-
-  run() {
-    if (!this.userId) {
-      throw new Meteor.Error('Creatures.methods.insert.denied',
-      'You need to be logged in to insert a creature');
-    }
-    assertUserHasPaidBenefits(this.userId);
-
-		// Create the creature document
-    let creatureId = Creatures.insert({
-			owner: this.userId,
-		});
-
-    // Insert the default properties
-    // Not batchInsert because we want the properties cleaned by the schema
-    let baseId;
-    defaultCharacterProperties(creatureId).forEach(prop => {
-      let id = CreatureProperties.insert(prop);
-      if (prop.name === 'Ruleset'){
-        baseId = id;
-      }
-    });
-
-    if (Meteor.isServer){
-      // Insert the 5e ruleset as the default base
-      insertPropertyFromLibraryNode.call({
-        nodeId: 'iHbhfcg3AL5isSWbw',
-        parentRef: {id: baseId, collection: 'creatureProperties'},
-        order: 0.5,
-      });
-    }
-
-		this.unblock();
-		return creatureId;
-  },
-});
-
-const updateCreature = new ValidatedMethod({
-  name: 'creatures.update',
-  validate({_id, path}){
-		if (!_id) return false;
-		// Allowed fields
-		let allowedFields = [
-      'name',
-      'alignment',
-      'gender',
-      'picture',
-      'avatarPicture',
-      'color',
-      'settings',
-    ];
-		if (!allowedFields.includes(path[0])){
-			throw new Meteor.Error('Creatures.methods.update.denied',
-      'This field can\'t be updated using this method');
-		}
-  },
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-  run({_id, path, value}) {
-		let creature = Creatures.findOne(_id);
-    assertEditPermission(creature, this.userId);
-    if (value === undefined || value === null){
-      Creatures.update(_id, {
-        $unset: {[path.join('.')]: 1},
-      });
-    } else {
-      Creatures.update(_id, {
-        $set: {[path.join('.')]: value},
-      });
-    }
-  },
-});
-
-export default Creatures;
-export { CreatureSchema, insertCreature, updateCreature };

app/imports/api/creature/Parties.js

@@ -1,28 +0,0 @@
-import SimpleSchema from 'simpl-schema';
-
-let Parties = new Mongo.Collection('parties');
-
-let partySchema = new SimpleSchema({
-	name: {
-		type: String,
-		defaultValue: 'New Party',
-		trim: false,
-		optional: true,
-	},
-	creatures: {
-		type: Array,
-		defaultValue: [],
-	},
-	'creatures.$': {
-		type: String,
-		regEx: SimpleSchema.RegEx.Id,
-	},
-	owner: {
-		type: String,
-		regEx: SimpleSchema.RegEx.Id,
-	},
-});
-
-Parties.attachSchema(partySchema);
-
-export default Parties;

app/imports/api/creature/actions/Actions.js

@@ -0,0 +1,27 @@
+import SimpleSchema from 'simpl-schema';
+
+// Actions are creature actions that have been partially executed and not yet resolved
+// They require some user input to progress
+let Actions = new Mongo.Collection('actions');
+
+let CreaturePropertySchema = new SimpleSchema({
+  _id: {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+  // Which creature is taking the action
+  _creatureId: {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+  // The user who began taking the action
+  user: {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+  // The property that is about to be applied
+  property: {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+});

app/imports/api/creature/actions/applyAction.js

@@ -1,13 +0,0 @@
-import spendResources from '/imports/api/creature/actions/spendResources.js'
-import embedInlineCalculations from '/imports/api/creature/computation/afterComputation/embedInlineCalculations.js';
-
-export default function applyAction({prop, log}){
-  let content = { name: prop.name };
-  if (prop.summary){
-    content.value = embedInlineCalculations(
-      prop.summary, prop.summaryCalculations
-    );
-  }
-  log.content.push(content);
-  spendResources({prop, log});
-}

app/imports/api/creature/actions/applyAdjustment.js

@@ -1,55 +0,0 @@
-import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
-import damagePropertiesByName from '/imports/api/creature/creatureProperties/methods/damagePropertiesByName.js';
-
-export default function applyAdjustment({
-  prop,
-  creature,
-  targets,
-  actionContext,
-  log
-}){
-  let damageTargets = prop.target === 'self' ? [creature] : targets;
-  let scope = {
-    ...creature.variables,
-    ...actionContext,
-  };
-  var {result, context} = evaluateString({
-    string: prop.amount,
-    scope,
-    fn: 'reduce'
-  });
-  context.errors.forEach(e => {
-    log.content.push({
-      name: 'Attribute damage error',
-      value: e.message || e.toString(),
-    });
-  });
-  if (damageTargets) {
-    damageTargets.forEach(target => {
-      if (prop.target === 'each'){
-        ({result} = evaluateString({
-          string: prop.amount,
-          scope,
-          fn: 'reduce'
-        }));
-      }
-      damagePropertiesByName.call({
-        creatureId: target._id,
-        variableName: prop.stat,
-        operation: prop.operation || 'increment',
-        value: result.value,
-      });
-      log.content.push({
-        name: 'Attribute damage',
-        value: `${prop.stat}${prop.operation === 'set' ? ' set to' : ''}` +
-        ` ${result.isNumber ? -result.value : result.toString()}`,
-      });
-    });
-  } else {
-    log.content.push({
-      name: 'Attribute damage',
-      value: `${prop.stat}${prop.operation === 'set' ? ' set to' : ''}` +
-      ` ${result.isNumber ? -result.value : result.toString()}`,
-    });
-  }
-}

app/imports/api/creature/actions/applyAttack.js

@@ -1,22 +0,0 @@
-import roll from '/imports/parser/roll.js';
-
-export default function applyAttack({
-  prop,
-  log,
-  actionContext,
-  creature,
-}){
-  let value = roll(1, 20)[0];
-  actionContext.attackRoll = {value};
-  let criticalHitTarget = creature.variables.criticalHitTarget &&
-    creature.variables.criticalHitTarget.currentValue || 20;
-  let criticalHit = value >= criticalHitTarget;
-  if (criticalHit) actionContext.criticalHit = {value: true};
-  let result = value + prop.rollBonusResult;
-  actionContext.toHit = {value: result};
-
-  log.content.push({
-    name: criticalHit ? 'Critical Hit!' : 'To Hit',
-    value: `1d20 [${value}] + ${prop.rollBonusResult} = ` + result,
-  });
-}

app/imports/api/creature/actions/applyBuff.js

@@ -1,61 +0,0 @@
-import {
-	setLineageOfDocs,
-	renewDocIds
-} from '/imports/api/parenting/parenting.js';
-import {setDocToLastOrder} from '/imports/api/parenting/order.js';
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-
-export default function applyBuff({
-  prop,
-  children,
-  creature,
-  targets = [],
-  //actionContext,
-}){
-  let buffTargets = prop.target === 'self' ? [creature] : targets;
-
-  //let scope = {
-  //  ...creature.variables,
-  //  ...actionContext,
-  //};
-
-  // TODO
-  // If the target is not self, walk through all decendants and replace
-  // variables in calculations with their values from the creature scope
-  // If the target is self, replace all the target.x references with just x
-
-  // Then copy the decendants of the buff to the targets
-  prop.applied = true;
-  let propList = [prop];
-  function addChildrenToPropList(children){
-    children.forEach(child => {
-      propList.push(child.node);
-      addChildrenToPropList(child.children);
-    });
-  }
-  addChildrenToPropList(children);
-  let oldParent = {
-    id: prop.parent.id,
-    collection: prop.parent.collection,
-  };
-  buffTargets.forEach(target => {
-    copyNodeListToTarget(propList, target, oldParent);
-  });
-}
-
-function copyNodeListToTarget(propList, target, oldParent){
-  let ancestry = [{collection: 'creatures', id: target._id}];
-  setLineageOfDocs({
-    docArray: propList,
-    newAncestry: ancestry,
-    oldParent,
-  });
-  renewDocIds({
-    docArray: propList,
-  });
-  setDocToLastOrder({
-    collection: CreatureProperties,
-    doc: propList[0],
-  });
-  CreatureProperties.batchInsert(propList);
-}

app/imports/api/creature/actions/applyDamage.js

@@ -1,115 +0,0 @@
-import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
-import dealDamage from '/imports/api/creature/creatureProperties/methods/dealDamage.js';
-import {insertCreatureLog} from '/imports/api/creature/log/CreatureLogs.js';
-import { CompilationContext } from '/imports/parser/parser.js';
-
-export default function applyDamage({
-  prop,
-  creature,
-  targets,
-  actionContext,
-  log,
-}){
-  let damageTargets = prop.target === 'self' ? [creature] : targets;
-  let scope = {
-    ...creature.variables,
-    ...actionContext,
-  };
-  // Add the target's variables to the scope
-  if (targets.length === 1){
-    scope.target = targets[0].variables;
-  }
-  // Determine if the hit is critical
-  let criticalHit = !!(
-    actionContext.criticalHit &&
-    actionContext.criticalHit.value &&
-    prop.damageType !== 'healing' // Can't critically heal
-  );
-  // Double the damage rolls if the hit is critical
-  let context = new CompilationContext({
-    doubleRolls: criticalHit,
-  });
-
-  // Compute the roll the first time, logging any errors
-  var {result} = evaluateString({
-    string: prop.amount,
-    scope,
-    fn: 'reduce',
-    context
-  });
-
-  // If the result is an error bail out now
-  if (result.constructor.name === 'ErrorNode'){
-    log.content.push({
-      name: 'Damage error',
-      value: result.toString(),
-    });
-    return;
-  }
-
-  // Memoise the damage suffix for the log
-  let suffix = (criticalHit ? ' critical ' : ' ') +
-    prop.damageType +
-    (prop.damageType !== ' healing ' ? ' damage ': '');
-
-  if (damageTargets && damageTargets.length) {
-    // Iterate through all the targets
-    damageTargets.forEach(target => {
-      let name = prop.damageType === 'healing' ? 'Healing' : 'Damage';
-
-      // Reroll the damage if needed
-      if (prop.target === 'each'){
-        ({result, context} = evaluateString({
-          string: prop.amount,
-          scope,
-          fn: 'reduce'
-        }));
-      }
-      // If the result is an error or not a number bail out now
-      if (result.constructor.name === 'ErrorNode' || !result.isNumber){
-        log.content.push({
-          name: 'Damage error',
-          value: result.toString(),
-        });
-        return;
-      }
-
-      // Deal the damage to the target
-      let damageDealt = dealDamage.call({
-        creatureId: target._id,
-        damageType: prop.damageType,
-        amount: result.value,
-      });
-
-      // Log the damage done
-      if (target._id === creature._id){
-        // Target is same as self, log damage as such
-        log.content.push({
-          name,
-          value: damageDealt + suffix + ' to self',
-        });
-      } else {
-        log.content.push({
-          name,
-          value: 'Dealt ' + damageDealt + suffix + ` ${target.name && ' to '}${target.name}`,
-        });
-        // Log the damage received on that creature's log as well
-        insertCreatureLog.call({
-          log: {
-            creatureId: target._id,
-            content: [{
-              name,
-              value: 'Recieved ' + damageDealt + suffix,
-            }],
-          }
-        });
-      }
-    });
-  } else {
-    // There are no targets, just log the result
-    log.content.push({
-      name: prop.damageType === 'healing' ? 'Healing' : 'Damage',
-      value: result.toString() + suffix,
-    });
-  }
-}

app/imports/api/creature/actions/applyProperties.js

@@ -1,81 +0,0 @@
-import applyAction from '/imports/api/creature/actions/applyAction.js';
-import applyAdjustment from '/imports/api/creature/actions/applyAdjustment.js';
-import applyAttack from '/imports/api/creature/actions/applyAttack.js';
-import applyBuff from '/imports/api/creature/actions/applyBuff.js';
-import applyDamage from '/imports/api/creature/actions/applyDamage.js';
-import applyRoll from '/imports/api/creature/actions/applyRoll.js';
-import applyToggle from '/imports/api/creature/actions/applyToggle.js';
-import applySave from '/imports/api/creature/actions/applySave.js';
-
-function applyProperty(options){
-  let prop = options.prop;
-  if (prop.type === 'buff'){
-    // ignore only applied buffs, don't apply them again
-    if (prop.applied === true){
-      return false;
-    }
-  // Only ignore toggles if they wont be computed
-  } else if (prop.type === 'toggle') {
-    if (prop.disabled) return false;
-    if (prop.enabled) return true;
-    if (!prop.condition) return false;
-  // Ignore inactive props of other types
-  } else if (prop.deactivatedBySelf === true){
-    return false;
-  }
-  switch (prop.type){
-    case 'action':
-    case 'spell':
-      applyAction(options);
-      break;
-    case 'attack':
-      applyAction(options);
-      applyAttack(options);
-      break;
-    case 'damage':
-      applyDamage(options);
-      break;
-    case 'adjustment':
-      applyAdjustment(options);
-      break;
-    case 'buff':
-      applyBuff(options);
-      return false;
-    case 'toggle':
-      return applyToggle(options);
-    case 'roll':
-      applyRoll(options);
-      break;
-    case 'savingThrow':
-      return applySave(options);
-  }
-  return true;
-}
-
-function applyPropertyAndWalkChildren({prop, children, targets, ...options}){
-  let shouldKeepWalking = applyProperty({ prop, children, targets, ...options });
-  if (shouldKeepWalking){
-    applyProperties({ forest: children, targets, ...options,});
-  }
-}
-
-export default function applyProperties({ forest, targets, ...options}){
-  forest.forEach(node => {
-    let prop = node.node;
-    let children = node.children;
-    if (shouldSplit(prop) && targets.length){
-      targets.forEach(target => {
-        let targets = [target]
-        applyPropertyAndWalkChildren({ targets, prop, children, ...options});
-      });
-    } else {
-      applyPropertyAndWalkChildren({prop, children, targets, ...options});
-    }
-  });
-}
-
-function shouldSplit(prop){
-  if (prop.target === 'each'){
-    return true;
-  }
-}

app/imports/api/creature/actions/applyRoll.js

@@ -1,25 +0,0 @@
-import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
-
-export default function applyRoll({
-  prop,
-  creature,
-  actionContext,
-  log,
-}){
-  let scope = {
-    ...creature.variables,
-    ...actionContext,
-  };
-  var {result} = evaluateString({
-    string: prop.roll,
-    scope,
-    fn: 'reduce'
-  });
-  if (result.isNumber){
-    actionContext[prop.variableName] = result.value;
-  }
-  log.content.push({
-    name: prop.name,
-    value: prop.variableName + ' = ' + prop.roll + ' = ' + result.toString(),
-  });
-}

app/imports/api/creature/actions/applySave.js

@@ -1,76 +0,0 @@
-import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
-import CreaturesProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import roll from '/imports/parser/roll.js';
-
-export default function applySave({
-  prop,
-  creature,
-  actionContext,
-  log,
-}){
-  let scope = {
-    ...creature.variables,
-    ...actionContext,
-  };
-  try {
-    // Calculate the DC
-    var {result} = evaluateString({
-      string: prop.dc,
-      scope,
-      fn: 'reduce'
-    });
-    let dc = result.value;
-    log.content.push({
-      name: prop.name,
-      value: ' DC ' + result.toString(),
-    });
-    if (prop.target === 'self'){
-      let save = CreaturesProperties.findOne({
-        'ancestors.id': creature._id,
-        type: 'skill',
-        skillType: 'save',
-        variableName: prop.stat,
-        removed: {$ne: true},
-        inactive: {$ne: true},
-      });
-      if (!save){
-        log.content.push({
-          name: 'Saving throw error',
-          value: 'No saving throw found: ' + prop.stat,
-        });
-        return;
-      }
-      let value, values, resultPrefix;
-      if (save.advantage === 1){
-        values = roll(2, 20).sort().reverse();
-        value = values[0];
-        resultPrefix = `Advantage: 1d20 [${values[0]},~~${values[1]}~~] + ${save.value} = `
-      } else if (save.advantage === -1){
-        values = roll(2, 20).sort();
-        value = values[0];
-        resultPrefix = `Disadvantage: 1d20 [${values[0]},~~${values[1]}~~] + ${save.value} = `
-      } else {
-        values = roll(1, 20);
-        value = values[0];
-        resultPrefix = `1d20 [${value}] + ${save.value} = `
-      }
-      actionContext.savingThrowRoll = {value};
-      let result = value + save.value;
-      actionContext.savingThrow = {value: result};
-      let saveSuccess = result >= dc;
-      log.content.push({
-        name: 'Save',
-        value: resultPrefix + result + (saveSuccess ? 'Passed' : 'Failed')
-      });
-      return !saveSuccess;
-    } else {
-      // TODO
-      return true;
-    }
-  } catch (e){
-    log.content.push({
-      name: 'Save error',
-      value: e.toString(),
-    });
-  }
-}

app/imports/api/creature/actions/applyToggle.js

@@ -1,33 +0,0 @@
-import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
-
-export default function applyToggle({
-  prop,
-  creature,
-  actionContext,
-  log,
-}){
-  let scope = {
-    ...creature.variables,
-    ...actionContext,
-  };
-  if (Number.isFinite(+prop.condition)){
-    return !!+prop.condition;
-  }
-  var {result} = evaluateString({
-    string: prop.condition,
-    scope,
-    fn: 'reduce'
-  });
-  if (result.constructor.name === 'ErrorNode') {
-    log.content.push({
-      name: 'Toggle error',
-      value: result.toString(),
-    });
-    return false;
-  }
-  log.content.push({
-    name: prop.name || 'Toggle',
-    value: prop.condition + ' = ' + result.toString(),
-  });
-  return !!result.value;
-}

app/imports/api/creature/actions/castSpellWithSlot.js

@@ -1,79 +0,0 @@
-import SimpleSchema from 'simpl-schema';
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
-import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-import { doActionWork } from '/imports/api/creature/actions/doAction.js';
-import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-
-const castSpellWithSlot = new ValidatedMethod({
-  name: 'creatureProperties.castSpellWithSlot',
-  validate: new SimpleSchema({
-    spellId: SimpleSchema.RegEx.Id,
-    slotId: {
-      type: String,
-      regEx: SimpleSchema.RegEx.Id,
-      optional: true,
-    },
-    targetId: {
-      type: String,
-      regEx: SimpleSchema.RegEx.Id,
-      optional: true,
-    },
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 10,
-    timeInterval: 5000,
-  },
-  run({spellId, slotId, targetId}) {
-    let spell = CreatureProperties.findOne(spellId);
-		// Check permissions
-    let creature = getRootCreatureAncestor(spell);
-    assertEditPermission(creature, this.userId);
-    let target = undefined;
-    if (targetId) {
-      target = Creatures.findOne(targetId);
-      assertEditPermission(target, this.userId);
-    }
-    let slotLevel = spell.level || 0;
-    if (slotLevel !== 0){
-      let slot = CreatureProperties.findOne(slotId);
-      if (!slot){
-        throw new Meteor.Error('No slot',
-          'Slot not found to cast spell');
-      }
-      if (!slot.currentValue){
-        throw new Meteor.Error('No slot',
-          'Slot depleted');
-      }
-      if (!(slot.spellSlotLevelValue >= spell.level)){
-        throw new Meteor.Error('Slot too small',
-          'Slot is not large enough to cast spell');
-      }
-      slotLevel = slot.spellSlotLevelValue;
-      damagePropertyWork({
-        property: slot,
-        operation: 'increment',
-        value: 1,
-      });
-    }
-		doActionWork({
-      action: spell,
-      context: {slotLevel},
-      creature,
-      targets: target ? [target] : [],
-      method: this,
-    });
-    // Note this only recomputes the top-level creature, not the nearest one
-		recomputeCreatureByDoc(creature);
-    if (target){
-      recomputeCreatureByDoc(target);
-    }
-  },
-});
-
-export default castSpellWithSlot;

app/imports/api/creature/actions/doAction.js

@@ -1,94 +0,0 @@
-import SimpleSchema from 'simpl-schema';
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import { CreatureLogSchema, insertCreatureLogWork } from '/imports/api/creature/log/CreatureLogs.js';
-import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-import { nodesToTree } from '/imports/api/parenting/parenting.js';
-import applyProperties from '/imports/api/creature/actions/applyProperties.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
-
-const doAction = new ValidatedMethod({
-  name: 'creatureProperties.doAction',
-  validate: new SimpleSchema({
-    actionId: SimpleSchema.RegEx.Id,
-    targetIds: {
-      type: Array,
-      defaultValue: [],
-      maxCount: 10,
-      optional: true,
-    },
-    'targetIds.$': {
-      type: String,
-      regEx: SimpleSchema.RegEx.Id,
-    },
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 10,
-    timeInterval: 5000,
-  },
-  run({actionId, targetIds = []}) {
-    let action = CreatureProperties.findOne(actionId);
-		// Check permissions
-    let creature = getRootCreatureAncestor(action);
-    assertEditPermission(creature, this.userId);
-    let targets = [];
-    targetIds.forEach(targetId => {
-      let target = Creatures.findOne(targetId);
-      assertEditPermission(target, this.userId);
-      targets.push(target);
-    });
-		doActionWork({action, creature, targets, method: this});
-
-    // The acting creature might have used ammo
-    recomputeInventory(creature._id);
-
-    // The action might add properties which need to be activated
-    recomputeInactiveProperties(creature._id);
-
-    // recompute creatures
-		recomputeCreatureByDoc(creature);
-    targets.forEach(target => {
-      recomputeInactiveProperties(target._id);
-      recomputeCreatureByDoc(target);
-    });
-  },
-});
-
-export function doActionWork({
-  action,
-  creature,
-  targets,
-  context = {},
-  method
-}){
-  // Create the log
-  let log = CreatureLogSchema.clean({
-    creatureId: creature._id,
-    creatureName: creature.name,
-  });
-
-  let decendantForest = nodesToTree({
-    collection: CreatureProperties,
-    ancestorId: action._id,
-  });
-  let startingForest = [{
-    node: action,
-    children: decendantForest,
-  }];
-  applyProperties({
-    forest: startingForest,
-    actionContext: context,
-    creature,
-    targets,
-    log,
-  });
-  insertCreatureLogWork({log, creature, method});
-}
-
-export default doAction;

app/imports/api/creature/actions/doCheck.js

@@ -1,56 +0,0 @@
-import SimpleSchema from 'simpl-schema';
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import Creatures from '/imports/api/creature/Creatures.js';
-import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import roll from '/imports/parser/roll.js';
-
-const doCheck = new ValidatedMethod({
-  name: 'creature.doCheck',
-  validate: new SimpleSchema({
-    creatureId: {
-      type: String,
-      regEx: SimpleSchema.RegEx.Id,
-      optional: true,
-    },
-    attributeName: {
-      type: String,
-      optional: true,
-    },
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 10,
-    timeInterval: 5000,
-  },
-  run({creatureId, attributeName}) {
-    let creature = Creatures.findOne(creatureId);
-    assertEditPermission(creature, this.userId);
-    let bonus = getAttributeValue({creature, attributeName})
-		return doCheckWork({bonus});
-  },
-});
-
-function getAttributeValue({creature, attributeName}){
-  let att = creature.variables[attributeName];
-  if (!att) throw new Meteor.Error('No such attribute',
-    `This creature does not have a ${attributeName} property`);
-  let bonus = att.attributeType === 'ability'? att.modifier : att.value;
-  return bonus || 0;
-}
-
-export function doCheckWork({bonus, advantage = 0}){
-  let rolls = roll(2,20);
-  let chosenRoll;
-  if (advantage === 1){
-    chosenRoll = Math.max.apply(rolls);
-  } else if (advantage === -1){
-    chosenRoll = Math.min.apply(rolls);
-  } else {
-    chosenRoll = rolls[0];
-  }
-  let result = chosenRoll + bonus;
-  return {rolls, bonus, chosenRoll, result};
-}
-
-export default doCheck;

app/imports/api/creature/actions/spendResources.js

@@ -1,93 +0,0 @@
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import { adjustQuantityWork } from '/imports/api/creature/creatureProperties/methods/adjustQuantity.js';
-import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
-
-export default function spendResources({prop, log}){
-  // Check Uses
-  if (prop.usesUsed >= prop.usesResult){
-    throw new Meteor.Error('Insufficient Uses',
-      'This prop has no uses left');
-  }
-  // Resources
-  if (prop.insufficientResources){
-    throw new Meteor.Error('Insufficient Resources',
-      'This creature doesn\'t have sufficient resources to perform this prop');
-  }
-  // Items
-  let itemQuantityAdjustments = [];
-  let spendLog = [];
-  let gainLog = [];
-  prop.resources.itemsConsumed.forEach(itemConsumed => {
-    if (!itemConsumed.itemId){
-      throw new Meteor.Error('Ammo not selected',
-        'No ammo was selected for this prop');
-    }
-    let item = CreatureProperties.findOne(itemConsumed.itemId);
-    if (!item || item.ancestors[0].id !== prop.ancestors[0].id){
-      throw new Meteor.Error('Ammo not found',
-        'The prop\'s ammo was not found on the creature');
-    }
-    if (!item.equipped){
-      throw new Meteor.Error('Ammo not equipped',
-        'The selected ammo is not equipped');
-    }
-    if (!itemConsumed.quantity) return;
-    itemQuantityAdjustments.push({
-      property: item,
-      operation: 'increment',
-      value: itemConsumed.quantity,
-    });
-    let logName = item.name;
-    if (itemConsumed.quantity > 1 || itemConsumed.quantity < -1){
-      logName = item.plural || logName;
-    }
-    if (itemConsumed.quantity > 0){
-      spendLog.push(logName + ': ' + itemConsumed.quantity);
-    } else if (itemConsumed.quantity < 0){
-      gainLog.push(logName + ': ' + -itemConsumed.quantity);
-    }
-  });
-  // No more errors should be thrown after this line
-  // Now that we have confirmed that there are no errors, do actual work
-  //Items
-  itemQuantityAdjustments.forEach(adjustQuantityWork);
-
-  // Use uses
-  if (prop.usesResult){
-    CreatureProperties.update(prop._id, {
-      $inc: {usesUsed: 1}
-    }, {
-      selector: prop
-    });
-    log.content.push({
-      name: 'Uses left',
-      value: prop.usesResult - (prop.usesUsed || 0) - 1,
-    });
-  }
-
-  // Damage stats
-  prop.resources.attributesConsumed.forEach(attConsumed => {
-    if (!attConsumed.quantity) return;
-    let stat = CreatureProperties.findOne(attConsumed.statId);
-    damagePropertyWork({
-      property: stat,
-      operation: 'increment',
-      value: attConsumed.quantity,
-    });
-    if (attConsumed.quantity > 0){
-      spendLog.push(stat.name + ': ' + attConsumed.quantity);
-    } else if (attConsumed.quantity < 0){
-      gainLog.push(stat.name + ': ' + -attConsumed.quantity);
-    }
-  });
-
-  // Log all the spending
-  if (gainLog.length) log.content.push({
-    name: 'Gained',
-    value: gainLog.join('\n'),
-  });
-  if (spendLog.length) log.content.push({
-    name: 'Spent',
-    value: spendLog.join('\n'),
-  });
-}

app/imports/api/creature/archive/ArchiveCreatureFiles.js

@@ -0,0 +1,58 @@
+
+import SimpleSchema from 'simpl-schema';
+import { incrementFileStorageUsed } from '/imports/api/users/methods/updateFileStorageUsed.js';
+import { CreaturePropertySchema } from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { CreatureSchema } from '/imports/api/creature/creatures/Creatures.js';
+let createS3FilesCollection;
+if (Meteor.isServer) {
+  createS3FilesCollection = require('/imports/api/files/server/s3FileStorage.js').createS3FilesCollection
+} else {
+  createS3FilesCollection = require('/imports/api/files/client/s3FileStorage.js').createS3FilesCollection
+}
+
+const ArchiveCreatureFiles = createS3FilesCollection({
+  collectionName: 'archiveCreatureFiles',
+  storagePath: Meteor.isDevelopment ? '../../../../../fileStorage/archiveCreatures' : 'assets/app/archiveCreatures',
+  onBeforeUpload(file) {
+    // Allow upload files under 10MB, and only in json format
+    if (file.size > 10485760) {
+      return 'Please upload with size equal or less than 10MB';
+    }
+    if (!/json/i.test(file.extension)) {
+      return 'Please upload only a JSON file';
+    }
+    return true;
+  },
+  onAfterUpload(file) {
+    if (Meteor.isServer) incrementFileStorageUsed(file.userId, file.size);
+  }
+});
+
+let archiveSchema = new SimpleSchema({
+  meta: {
+    type: Object,
+    blackbox: true,
+  },
+  creature: CreatureSchema,
+  properties: {
+    type: Array,
+  },
+  'properties.$': CreaturePropertySchema,
+  experiences: {
+    type: Array,
+  },
+  'experiences.$': {
+    type: Object,
+    blackbox: true,
+  },
+  logs: {
+    type: Array,
+  },
+  'logs.$': {
+    type: Object,
+    blackbox: true,
+  },
+});
+
+export default ArchiveCreatureFiles;
+export { archiveSchema };

app/imports/api/creature/archive/methods/archiveCreatureToFile.js

@@ -0,0 +1,78 @@
+import SCHEMA_VERSION from '/imports/constants/SCHEMA_VERSION.js';
+import SimpleSchema from 'simpl-schema';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import { assertOwnership } from '/imports/api/creature/creatures/creaturePermissions.js';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import CreatureLogs from '/imports/api/creature/log/CreatureLogs.js';
+import Experiences from '/imports/api/creature/experience/Experiences.js';
+import { removeCreatureWork } from '/imports/api/creature/creatures/methods/removeCreature.js';
+import ArchiveCreatureFiles from '/imports/api/creature/archive/ArchiveCreatureFiles.js';
+
+export function getArchiveObj(creatureId){
+  // Build the archive document
+  const creature = Creatures.findOne(creatureId);
+  const properties = CreatureProperties.find({'ancestors.id': creatureId}).fetch();
+  const experiences = Experiences.find({creatureId}).fetch();
+  const logs = CreatureLogs.find({creatureId}).fetch();
+  let archiveCreature = {
+    meta: {
+      type: 'DiceCloud V2 Creature Archive',
+      schemaVersion: SCHEMA_VERSION,
+      archiveDate: new Date(),
+    },
+    creature,
+    properties,
+    experiences,
+    logs,
+  };
+
+  return archiveCreature;
+}
+
+export function archiveCreature(creatureId){
+  const archive = getArchiveObj(creatureId);
+  const buffer = Buffer.from(JSON.stringify(archive, null, 2));
+  ArchiveCreatureFiles.write(buffer, {
+    fileName: `${archive.creature.name || archive.creature._id}.json`,
+    type: 'application/json',
+    userId: archive.creature.owner,
+    meta: {
+      schemaVersion: SCHEMA_VERSION,
+      creatureId: archive.creature._id,
+      creatureName: archive.creature.name,
+    },
+  }, (error) => {
+    if (error){
+      throw error;
+    } else {
+      removeCreatureWork(creatureId);
+    }
+  }, true);
+}
+
+const archiveCreatureToFile = new ValidatedMethod({
+  name: 'Creatures.methods.archiveCreatureToFile',
+  validate: new SimpleSchema({
+    'creatureId': {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 10,
+    timeInterval: 5000,
+  },
+  async run({creatureId}) {
+    assertOwnership(creatureId, this.userId);
+    if (Meteor.isServer){
+      archiveCreature(creatureId, this.userId);
+    } else {
+      removeCreatureWork(creatureId);
+    }
+  },
+});
+
+export default archiveCreatureToFile;

app/imports/api/creature/archive/methods/index.js

@@ -0,0 +1,3 @@
+import '/imports/api/creature/archive/methods/archiveCreatureToFile.js';
+import '/imports/api/creature/archive/methods/restoreCreatureFromFile.js';
+import '/imports/api/creature/archive/methods/removeArchiveCreature.js';

app/imports/api/creature/archive/methods/removeArchiveCreature.js

@@ -0,0 +1,40 @@
+import SimpleSchema from 'simpl-schema';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import ArchiveCreatureFiles from '/imports/api/creature/archive/ArchiveCreatureFiles.js';
+import { incrementFileStorageUsed } from '/imports/api/users/methods/updateFileStorageUsed.js';
+
+const removeArchiveCreature = new ValidatedMethod({
+  name: 'ArchiveCreatureFiles.methods.removeArchiveCreature',
+  validate: new SimpleSchema({
+    'fileId': {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  async run({ fileId }) {
+    // fetch the file
+    const file = ArchiveCreatureFiles.findOne({ _id: fileId }).get();
+    if (!file) {
+      throw new Meteor.Error('File not found',
+        'The requested creature archive does not exist');
+    }
+    // Assert ownership
+    const userId = file?.userId;
+    if (!userId || userId !== this.userId) {
+      throw new Meteor.Error('Permission denied',
+        'You can only restore creatures you own');
+    }
+    //Remove the archive once the restore succeeded
+    ArchiveCreatureFiles.remove({ _id: fileId });
+    // Update the user's file storage limits
+    incrementFileStorageUsed(userId, -file.size);
+  },
+});
+
+export default removeArchiveCreature;

app/imports/api/creature/archive/methods/restoreCreatureFromFile.js

@@ -0,0 +1,104 @@
+import SCHEMA_VERSION from '/imports/constants/SCHEMA_VERSION.js';
+import SimpleSchema from 'simpl-schema';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import CreatureLogs from '/imports/api/creature/log/CreatureLogs.js';
+import Experiences from '/imports/api/creature/experience/Experiences.js';
+import { removeCreatureWork } from '/imports/api/creature/creatures/methods/removeCreature.js';
+import ArchiveCreatureFiles from '/imports/api/creature/archive/ArchiveCreatureFiles.js';
+import assertHasCharactersSlots from '/imports/api/creature/creatures/methods/assertHasCharacterSlots.js';
+import { incrementFileStorageUsed } from '/imports/api/users/methods/updateFileStorageUsed.js';
+import verifyArchiveSafety from '/imports/api/creature/archive/methods/verifyArchiveSafety.js';
+
+let migrateArchive;
+if (Meteor.isServer) {
+  migrateArchive = require('/imports/migrations/archive/migrateArchive.js').default;
+}
+
+function restoreCreature(archive, userId) {
+  if (SCHEMA_VERSION < archive.meta.schemaVersion) {
+    throw new Meteor.Error('Incompatible',
+      'The archive file is from a newer version. Update required to read.')
+  }
+
+  // Migrate and verify the archive meets the current schema
+  migrateArchive(archive);
+
+  // Asset that the archive is safe
+  verifyArchiveSafety(archive);
+
+  // Don't upload creatures twice
+  const existingCreature = Creatures.findOne(archive.creature._id, {
+    fields: { _id: 1 }
+  });
+  if (existingCreature) throw new Meteor.Error('Already exists',
+    'The creature you are trying to restore already exists.')
+
+  // Ensure the user owns the restored creature
+  archive.creature.owner = userId;
+
+  // Insert the creature sub documents
+  // They still have their original _id's
+  Creatures.insert(archive.creature);
+  try {
+    // Add all the properties
+    if (archive.properties && archive.properties.length) {
+      CreatureProperties.batchInsert(archive.properties);
+    }
+    if (archive.experiences && archive.experiences.length) {
+      Experiences.batchInsert(archive.experiences);
+    }
+    if (archive.logs && archive.logs.length) {
+      CreatureLogs.batchInsert(archive.logs);
+    }
+  } catch (e) {
+    // If the above fails, delete the inserted creature
+    removeCreatureWork(archive.creature._id);
+    throw e;
+  }
+}
+
+const restoreCreaturefromFile = new ValidatedMethod({
+  name: 'Creatures.methods.restoreCreaturefromFile',
+  validate: new SimpleSchema({
+    'fileId': {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 10,
+    timeInterval: 5000,
+  },
+  async run({ fileId }) {
+    // fetch the file
+    const file = ArchiveCreatureFiles.findOne({ _id: fileId }).get();
+    if (!file) {
+      throw new Meteor.Error('File not found',
+        'The requested creature archive does not exist');
+    }
+    // Assert ownership
+    const userId = file?.userId;
+    if (!userId || userId !== this.userId) {
+      throw new Meteor.Error('Permission denied',
+        'You can only restore creatures you own');
+    }
+
+    assertHasCharactersSlots(this.userId);
+
+    if (Meteor.isServer) {
+      // Read the file data
+      const archive = await ArchiveCreatureFiles.readJSONFile(file);
+      restoreCreature(archive, this.userId);
+    }
+    //Remove the archive once the restore succeeded
+    ArchiveCreatureFiles.remove({ _id: fileId });
+    // Update the user's file storage limits
+    incrementFileStorageUsed(userId, -file.size);
+  },
+});
+
+export default restoreCreaturefromFile;

app/imports/api/creature/archive/methods/verifyArchiveSafety.js

@@ -0,0 +1,28 @@
+import { slice } from 'lodash';
+import PER_CREATURE_LOG_LIMIT from '/imports/api/creature/log/CreatureLogs.js';
+
+export default function verifyArchiveSafety({ meta, creature, properties, experiences, logs }){
+  const creatureId = creature._id;
+
+  // Check lengths of arrays
+  if (logs.length > PER_CREATURE_LOG_LIMIT) {
+    logs = slice(logs, 0, PER_CREATURE_LOG_LIMIT);
+  }
+
+  // Check that everything belongs to the right creature
+  logs.forEach(log => {
+    if (log.creatureId !== creatureId) {
+      throw new Meteor.Error('Malicious log', 'Log contains an entry for the wrong creature');
+    }
+  });
+  experiences.forEach(experience => {
+    if (experience.creatureId !== creatureId) {
+      throw new Meteor.Error('Malicious experience', 'Experiences contains an entry for the wrong creature');
+    }
+  });
+  properties.forEach(prop => {
+    if (prop.ancestors[0].id !== creatureId) {
+      throw new Meteor.Error('Malicious prop', 'Properties contains an entry for the wrong creature');
+    }
+  });
+}

app/imports/api/creature/computation/afterComputation/embedInlineCalculations.js

@@ -1,11 +0,0 @@
-import INLINE_CALCULATION_REGEX from '/imports/constants/INLINE_CALCULTION_REGEX.js';
-
-export default function embedInlineCalculations(string, calculations){
-  if (!string) return '';
-  if (!calculations) return string;
-  let index = 0;
-  return string.replace(INLINE_CALCULATION_REGEX, substring => {
-    let comp = calculations && calculations[index++];
-    return (comp && 'result' in comp) ? comp.result : substring;
-  });
-}

app/imports/api/creature/computation/afterComputation/evaluateString.js

@@ -1,67 +0,0 @@
-import { parse, CompilationContext } from '/imports/parser/parser.js';
-import ConstantNode from '/imports/parser/parseTree/ConstantNode.js';
-import SymbolNode from '/imports/parser/parseTree/SymbolNode.js';
-import ErrorNode from '/imports/parser/parseTree/ErrorNode.js';
-
-//TODO replace constants with their parsed node
-
-export default function evaluateString({string, scope, fn = 'compile', context}){
-  if (!context){
-    context = new CompilationContext({});
-  }
-  if (!string){
-    context.storeError('No string provided');
-    return {result: {value: string}, context};
-  }
-
-  if (!scope) context.storeError('No scope provided');
-
-  // Parse the string using mathjs
-  let node;
-  try {
-    node = parse(string);
-  } catch (e) {
-    context.storeError(e);
-    return {result: {value: string}, context};
-  }
-  node = replaceConstants({calc: node, context, scope});
-  let result = node[fn](scope, context);
-  return {result, context};
-}
-
-// Replace constants in the calc with the right ParseNodes
-function replaceConstants({calc, context, scope}){
-  let constFailed = [];
-  calc = calc.replaceNodes(node => {
-    if (!(node instanceof SymbolNode)) return;
-    let constant = scope[node.name];
-    // replace constants that aren't overridden by stats or disabled by a toggle
-    if (constant && constant.type === 'constant'){
-      // Fail if the constant has errors
-      if (constant.errors && constant.errors.length){
-        constFailed.push(node.name);
-        return;
-      }
-      let parsedConstantNode;
-      try {
-        parsedConstantNode = parse(constant.calculation);
-      } catch(e){
-        constFailed.push(node.name);
-        return;
-      }
-      if (!parsedConstantNode) constFailed.push(node.name);
-      return parsedConstantNode;
-    }
-  });
-  constFailed.forEach(name => {
-    context.storeError({
-      type: 'error',
-      message: `${name} is a constant property with parsing errors`
-    });
-  });
-  let failed = !!constFailed.length;
-  if (failed){
-    calc = new ErrorNode({error: 'Failed to replace constants'});
-  }
-  return calc;
-}

app/imports/api/creature/computation/engine/ComputationMemo.js

@@ -1,289 +0,0 @@
-import { includes, cloneDeep } from 'lodash';
-import findAncestorByType from '/imports/api/creature/computation/engine/findAncestorByType.js';
-
-// The computation memo is an in-memory data structure used only during the
-// computation process
-export default class ComputationMemo {
-  constructor(props, creature){
-    this.statsByVariableName = {};
-    this.constantsByVariableName = {};
-    this.constantsById = {};
-    this.extraStatsByVariableName = {};
-    this.statsById = {};
-    this.originalPropsById = {};
-    this.propsById = {};
-    this.skillsByAbility = {};
-    this.unassignedEffects = [];
-    this.classLevelsById = {};
-    this.classes = {};
-    this.togglesById = {};
-    this.toggleIds = new Set();
-    // Equipped items that might be used as ammo
-    this.equipmentById = {};
-    // Properties that have calculations, but don't impact other properties
-    this.endStepPropsById = {};
-    // First note all the ids of all the toggles
-    props.forEach((prop) => {
-      if (
-        prop.type === 'toggle'
-      ) {
-        this.toggleIds.add(prop._id);
-      }
-    });
-    props.filter((prop) => {
-      if (
-        prop.type === 'toggle'
-      ) {
-        this.addToggle(prop);
-      } else {
-        return true;
-      }
-    }).filter((prop) => {
-      if (
-        prop.type === 'attribute' ||
-        prop.type === 'skill'
-      ) {
-        // Add all the stats
-        this.addStat(prop);
-      } else if (
-        prop.type === 'item'
-      ) {
-        this.addEquipment(prop);
-      } else {
-        return true;
-      }
-    }).forEach((prop) => {
-      // Now add everything else
-      if (prop.type === 'effect'){
-        this.addEffect(prop);
-      } else if (prop.type === 'proficiency') {
-        this.addProficiency(prop);
-      } else if (prop.type === 'classLevel'){
-        this.addClassLevel(prop);
-      } else if (prop.type === 'constant'){
-        this.addConstant(prop);
-      } else {
-        this.addEndStepProp(prop);
-      }
-    });
-    for (let name in creature.denormalizedStats){
-      if (!this.statsByVariableName[name]){
-        this.statsByVariableName[name] = {
-          variableName: name,
-          value: creature.denormalizedStats[name],
-          computationDetails: propDetailsByType.denormalizedStat(),
-        }
-      }
-    }
-  }
-  addConstant(prop){
-    prop = this.registerProperty(prop);
-    this.constantsById[prop._id] = prop;
-  }
-  registerProperty(prop){
-    this.originalPropsById[prop._id] = cloneDeep(prop);
-    this.propsById[prop._id] = prop;
-    prop.dependencies = [];
-    prop.computationDetails = propDetails(prop);
-    prop.ancestors.forEach(ancestor => {
-      if (this.toggleIds.has(ancestor.id)){
-        prop.computationDetails.toggleAncestors.push(ancestor.id);
-      }
-    });
-    return prop;
-  }
-  addToggle(prop){
-    prop = this.registerProperty(prop);
-    this.togglesById[prop._id] = prop;
-  }
-  addClassLevel(prop){
-    prop = this.registerProperty(prop);
-    this.classLevelsById[prop._id] = prop;
-  }
-  addStat(prop){
-    let variableName = prop.variableName;
-    if (!variableName) return;
-    let existingStat = this.statsByVariableName[variableName];
-    prop = this.registerProperty(prop);
-    if (existingStat){
-      existingStat.computationDetails.idsOfSameName.push(prop._id);
-    } else {
-      this.statsById[prop._id] = prop;
-      this.statsByVariableName[variableName] = prop;
-      if (
-        prop.type === 'skill' &&
-        isSkillCheck(prop) &&
-        prop.ability
-      ){
-        this.addSkillToAbility(prop, prop.ability)
-      }
-    }
-  }
-  addSkillToAbility(prop, ability){
-    if (!this.skillsByAbility[ability]){
-      this.skillsByAbility[ability] = [];
-    }
-    this.skillsByAbility[ability].push(prop);
-  }
-  addEffect(prop){
-    prop = this.registerProperty(prop);
-    let targets = this.getEffectTargets(prop);
-    targets.forEach(target => {
-      if (target.computationDetails && target.computationDetails.effects){
-        target.computationDetails.effects.push(prop);
-      }
-    });
-    if (!targets.size){
-      this.unassignedEffects.push(prop);
-    }
-  }
-  getEffectTargets(prop){
-    let targets = new Set();
-    if (!prop.stats) return targets;
-    prop.stats.forEach((statName) => {
-      let target;
-      if (statName[0] === '#'){
-        target = findAncestorByType({
-          type: statName.slice(1),
-          prop,
-          memo: this
-        });
-      } else {
-        target = this.statsByVariableName[statName];
-      }
-      if (!target) return;
-      targets.add(target);
-      if (isSkillOperation(prop) && isAbility(target)){
-        let extras = this.skillsByAbility[statName] || [];
-        extras.forEach(ex =>{
-          // Only pass on ability effects to skills and checks
-          if (ex.skillType === 'skill' || ex.skillType === 'check'){
-            targets.add(ex)
-          }
-        });
-      }
-    });
-    return targets;
-  }
-  addProficiency(prop){
-    prop = this.registerProperty(prop);
-    let targets = this.getProficiencyTargets(prop);
-    targets.forEach(target => {
-      if(target.computationDetails.proficiencies){
-        target.computationDetails.proficiencies.push(prop);
-      }
-    });
-  }
-  getProficiencyTargets(prop){
-    let targets = new Set();
-    if (!prop.stats) return targets;
-    prop.stats.forEach(statName => {
-      let target = this.statsByVariableName[statName];
-      if (!target) return;
-      targets.add(target);
-      if (isAbility(target)) {
-        let extras = this.skillsByAbility[statName] || [];
-        extras.forEach(ex =>{
-          // Only pass on ability proficiencies to skills and checks
-          if (ex.skillType === 'skill' || ex.skillType === 'check'){
-            targets.add(ex)
-          }
-        });
-      }
-    });
-    return targets;
-  }
-  addEquipment(prop){
-    prop = this.registerProperty(prop);
-    this.equipmentById[prop._id] = prop;
-  }
-  addEndStepProp(prop){
-    prop = this.registerProperty(prop);
-    this.endStepPropsById[prop._id] = prop;
-  }
-}
-
-function isAbility(prop){
-  return prop.type === 'attribute' &&
-  prop.attributeType === 'ability'
-}
-
-function isSkillCheck(prop){
-  return includes(['skill', 'check', 'save', 'utility'], prop.skillType);
-}
-
-const skillOperations = [
-  'advantage',
-  'disadvantage',
-  'passiveAdd',
-  'fail',
-  'conditional',
-  'rollBonus',
-];
-
-function isSkillOperation(prop){
-  return skillOperations.includes(prop.operation);
-}
-
-function propDetails(prop){
-  return propDetailsByType[prop.type] && propDetailsByType[prop.type]() ||
-    propDetailsByType.default();
-}
-
-const propDetailsByType = {
-  default(){
-    return {
-      toggleAncestors: [],
-    };
-  },
-  toggle(){
-    return {
-      computed: false,
-      busyComputing: false,
-      toggleAncestors: [],
-    };
-  },
-  attribute(){
-    return {
-      computed: false,
-      busyComputing: false,
-      effects: [],
-      proficiencies: [],
-      toggleAncestors: [],
-      idsOfSameName: [],
-    };
-  },
-  skill(){
-    return {
-      computed: false,
-      busyComputing: false,
-      effects: [],
-      proficiencies: [],
-      toggleAncestors: [],
-      idsOfSameName: [],
-    };
-  },
-  effect(){
-    return {
-      computed: false,
-      busyComputing: false,
-      toggleAncestors: [],
-    };
-  },
-  classLevel(){
-    return {
-      computed: true,
-      toggleAncestors: [],
-    };
-  },
-  proficiency(){
-    return {
-      toggleAncestors: [],
-    };
-  },
-  denormalizedStat(){
-    return {
-      toggleAncestors: [],
-    };
-  }
-}

app/imports/api/creature/computation/engine/EffectAggregator.js

@@ -1,72 +0,0 @@
-export default class EffectAggregator{
-  constructor(){
-    this.base = 0;
-    this.add = 0;
-    this.mul = 1;
-    this.min = Number.NEGATIVE_INFINITY;
-    this.max = Number.POSITIVE_INFINITY;
-    this.advantage = 0;
-    this.disadvantage = 0;
-    this.passiveAdd = undefined;
-    this.fail = 0;
-    this.set = undefined;
-    this.conditional = [];
-    this.rollBonus = [];
-    this.hasNoEffects = true;
-  }
-  addEffect(effect){
-    let result = effect.result;
-    if (this.hasNoEffects) this.hasNoEffects = false;
-    switch(effect.operation){
-      case 'base':
-        // Take the largest base value
-        this.base = result > this.base ? result : this.base;
-        break;
-      case 'add':
-        // Add all adds together
-        this.add += result;
-        break;
-      case 'mul':
-        // Multiply the muls together
-        this.mul *= result;
-        break;
-      case 'min':
-        // Take the largest min value
-        this.min = result > this.min ? result : this.min;
-        break;
-      case 'max':
-        // Take the smallest max value
-        this.max = result < this.max ? result : this.max;
-        break;
-      case 'set':
-        // Take the highest set value
-        this.set = this.set === undefined || result > this.set ? result : this.set;
-        break;
-      case 'advantage':
-        // Sum number of advantages
-        this.advantage++;
-        break;
-      case 'disadvantage':
-        // Sum number of disadvantages
-        this.disadvantage++;
-        break;
-      case 'passiveAdd':
-        // Add all passive adds together
-        if (this.passiveAdd === undefined) this.passiveAdd = 0;
-        this.passiveAdd += result;
-        break;
-      case 'fail':
-        // Sum number of fails
-        this.fail++;
-        break;
-      case 'conditional':
-        // Store array of conditionals
-        this.conditional.push(result);
-        break;
-      case 'rollBonus':
-        // Store array of roll bonuses
-        this.rollBonus.push(result);
-        break;
-    }
-  }
-}

app/imports/api/creature/computation/engine/applyToggles.js

@@ -1,25 +0,0 @@
-import computeToggle from '/imports/api/creature/computation/engine/computeToggle.js';
-import { union } from 'lodash';
-
-export default function applyToggles(prop, memo){
-  // If it used to be inactive delete those fields
-  if (prop.inactive) prop.inactive = undefined;
-  if (prop.deactivatedByAncestor) prop.deactivatedByAncestor = undefined;
-  if (prop.deactivatedByToggle) prop.deactivatedByToggle = undefined;
-  // Iterate through the toggle ancestors from oldest to nearest
-  prop.computationDetails.toggleAncestors.forEach(toggleId => {
-    let toggle = memo.togglesById[toggleId];
-    computeToggle(toggle, memo);
-    prop.dependencies = union(
-      prop.dependencies,
-      [toggle._id],
-      toggle.dependencies,
-    );
-    // Deactivate if the toggle is false
-    if (!toggle.toggleResult){
-      prop.inactive = true;
-      prop.deactivatedByAncestor = true;
-      prop.deactivatedByToggle = true;
-    }
-  });
-}

app/imports/api/creature/computation/engine/combineStat.js

@@ -1,186 +0,0 @@
-import computeStat from '/imports/api/creature/computation/engine/computeStat.js';
-import computeProficiency from '/imports/api/creature/computation/engine/computeProficiency.js';
-import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
-import { union } from 'lodash';
-
-export default function combineStat(stat, aggregator, memo){
-  if (stat.type === 'attribute'){
-    combineAttribute(stat, aggregator, memo);
-  } else if (stat.type === 'skill'){
-    combineSkill(stat, aggregator, memo);
-  } else if (stat.type === 'damageMultiplier'){
-    combineDamageMultiplier(stat, memo);
-  }
-}
-
-function getAggregatorResult(stat, aggregator){
-  let base = Math.max(aggregator.base, stat.baseValue || 0);
-  let result = (base + aggregator.add) * aggregator.mul;
-  if (result < aggregator.min) {
-    result = aggregator.min;
-  }
-  if (result > aggregator.max) {
-    result = aggregator.max;
-  }
-  if (aggregator.set !== undefined) {
-    result = aggregator.set;
-  }
-  if (!stat.decimal && Number.isFinite(result)){
-    result = Math.floor(result);
-  }
-  return result;
-}
-
-function combineAttribute(stat, aggregator, memo){
-  stat.value = getAggregatorResult(stat, aggregator);
-  if (stat.attributeType === 'spellSlot'){
-    let {
-      result,
-      context,
-      dependencies
-    } = evaluateCalculation({
-      string: stat.spellSlotLevelCalculation,
-      memo,
-      prop: stat,
-    });
-    stat.spellSlotLevelValue = result.value;
-    stat.spellSlotLevelErrors = context.errors;
-    stat.dependencies = union(stat.dependencies, dependencies);
-  }
-  stat.currentValue = stat.value - (stat.damage || 0);
-  // Ability scores get modifiers
-  if (stat.attributeType === 'ability') {
-    stat.modifier = Math.floor((stat.currentValue - 10) / 2);
-  } else {
-    stat.modifier = undefined;
-  }
-  // Hit dice get constitution modifiers
-  stat.constitutionMod = undefined;
-  if (stat.attributeType === 'hitDice') {
-    let conStat = memo.statsByVariableName['constitution'];
-    if (conStat && 'modifier' in conStat){
-      stat.constitutionMod = conStat.modifier;
-      stat.dependencies = union(
-        stat.dependencies,
-        [conStat._id],
-        conStat.dependencies,
-      );
-    }
-  }
-  // Stats that have no effects can be hidden based on a sheet setting
-  stat.hide = aggregator.hasNoEffects &&
-    stat.baseValue === undefined ||
-    undefined
-}
-
-function combineSkill(stat, aggregator, memo){
-  // Skills are based on some ability Modifier
-  let ability = stat.ability && memo.statsByVariableName[stat.ability]
-  if (stat.ability && ability){
-    computeStat(ability, memo);
-    stat.abilityMod = ability.modifier;
-    stat.dependencies = union(
-      stat.dependencies,
-      [ability._id],
-      ability.dependencies,
-    );
-  } else {
-    stat.abilityMod = 0;
-  }
-  // Combine all the child proficiencies
-  stat.proficiency = 0;
-  for (let i in stat.computationDetails.proficiencies){
-    let prof = stat.computationDetails.proficiencies[i];
-    computeProficiency(prof, memo);
-    if (
-      !prof.deactivatedByToggle &&
-      prof.value > stat.proficiency
-    ){
-      stat.proficiency = prof.value;
-      stat.dependencies = union(
-        stat.dependencies,
-        [prof._id],
-        prof.dependencies,
-      );
-    }
-  }
-  // Get the character's proficiency bonus to apply
-  let profBonusStat = memo.statsByVariableName['proficiencyBonus'];
-  let profBonus = profBonusStat && profBonusStat.value;
-
-  if (profBonusStat){
-    stat.dependencies = union(
-      stat.dependencies,
-      [profBonusStat._id],
-      profBonusStat.dependencies,
-    );
-  }
-
-  if (typeof profBonus !== 'number' && memo.statsByVariableName['level']){
-    let levelProp = memo.statsByVariableName['level'];
-    let level = levelProp.value;
-    profBonus = Math.ceil(level / 4) + 1;
-    if (levelProp._id){
-      stat.dependencies = union(stat.dependencies, [levelProp._id]);
-    }
-    if (levelProp.dependencies){
-      stat.dependencies = union(stat.dependencies, levelProp.dependencies);
-    }
-  }
-
-  // Multiply the proficiency bonus by the actual proficiency
-  if(stat.proficiency === 0.49){
-    // Round down proficiency bonus in the special case
-    profBonus = Math.floor(profBonus * 0.5);
-  } else {
-    profBonus = Math.ceil(profBonus * stat.proficiency);
-  }
-
-  // Combine everything to get the final result
-  let result = (aggregator.base + stat.abilityMod + profBonus + aggregator.add) * aggregator.mul;
-  if (result < aggregator.min) result = aggregator.min;
-  if (result > aggregator.max) result = aggregator.max;
-  if (aggregator.set !== undefined) {
-    result = aggregator.set;
-  }
-  if (Number.isFinite(result)){
-    result = Math.floor(result);
-  }
-  stat.value = result;
-  // Advantage/disadvantage
-  if (aggregator.advantage && !aggregator.disadvantage){
-    stat.advantage = 1;
-  } else if (aggregator.disadvantage && !aggregator.advantage){
-    stat.advantage = -1;
-  } else {
-    stat.advantage = 0;
-  }
-  // Passive bonus
-  stat.passiveBonus = aggregator.passiveAdd;
-  // conditional benefits
-  stat.conditionalBenefits = aggregator.conditional;
-  // Roll bonuses
-  stat.rollBonus = aggregator.rollBonus;
-  // Forced to fail
-  stat.fail = aggregator.fail;
-  // Rollbonus
-  stat.rollBonuses = aggregator.rollBonus;
-  // Hide
-  stat.hide = aggregator.hasNoEffects &&
-    stat.baseValue === undefined &&
-    stat.proficiency == 0 ||
-    undefined;
-}
-
-function combineDamageMultiplier(stat){
-  if (stat.immunityCount) return 0;
-  let result;
-  if (stat.ressistanceCount && !stat.vulnerabilityCount){
-    result = 0.5;
-  }  else if (!stat.ressistanceCount && stat.vulnerabilityCount){
-    result = 2;
-  } else {
-    result = 1;
-  }
-  stat.value = result;
-}

app/imports/api/creature/computation/engine/computeConstant.js

@@ -1,12 +0,0 @@
-import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
-
-export default function computeConstant(constant, memo){
-  // Apply any toggles
-  applyToggles(constant, memo);
-  if (constant.deactivatedByToggle) return;
-  if (
-    !memo.constantsByVariableName[constant.variableName]
-  ){
-    memo.constantsByVariableName[constant.variableName] = constant
-  }
-}

app/imports/api/creature/computation/engine/computeEffect.js

@@ -1,55 +0,0 @@
-import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
-import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
-import { union } from 'lodash';
-
-export default function computeEffect(effect, memo){
-  if (effect.computationDetails.computed) return;
-  if (effect.computationDetails.busyComputing){
-    // Trying to compute this effect again while it is already computing.
-    // We must be in a dependency loop.
-    effect.computationDetails.computed = true;
-    effect.result = NaN;
-    effect.computationDetails.busyComputing = false;
-    effect.computationDetails.error = 'dependencyLoop';
-    if (Meteor.isClient) console.warn('dependencyLoop', effect);
-    return;
-  }
-  // Before doing any work, mark this effect as busy
-  effect.computationDetails.busyComputing = true;
-
-  // Apply any toggles
-  applyToggles(effect, memo);
-
-  // Determine result of effect calculation
-  delete effect.errors;
-  if (!effect.calculation){
-    if(effect.operation === 'add' || effect.operation === 'base'){
-      effect.result = 0;
-    } else {
-      delete effect.result
-    }
-  } else if (Number.isFinite(+effect.calculation)){
-    effect.result = +effect.calculation;
-  } else if(effect.operation === 'conditional' || effect.operation === 'rollBonus'){
-    effect.result = effect.calculation;
-  } else if(_.contains(['advantage', 'disadvantage', 'fail'], effect.operation)){
-    effect.result = 1;
-  } else {
-    let {
-      result,
-      context,
-      dependencies,
-    } = evaluateCalculation({
-      string: effect.calculation,
-      prop: effect,
-      memo
-    });
-    effect.result = result.value;
-    effect.dependencies = union(effect.dependencies, dependencies);
-    if (context.errors.length){
-      effect.errors = context.errors;
-    }
-  }
-  effect.computationDetails.computed = true;
-  effect.computationDetails.busyComputing = false;
-}

app/imports/api/creature/computation/engine/computeEndStepProperty.js

@@ -1,129 +0,0 @@
-import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
-import ConstantNode from '/imports/parser/parseTree/ConstantNode.js';
-import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
-import { union } from 'lodash';
-
-export default function computeEndStepProperty(prop, memo){
-  applyToggles(prop, memo);
-
-  switch (prop.type){
-    case 'action':
-    case 'spell':
-      computeAction(prop, memo);
-      break;
-    case 'adjustment':
-    case 'damage':
-      computePropertyField(prop, memo, 'amount', 'compile');
-      break;
-    case 'attack':
-      computeAction(prop, memo);
-      computePropertyField(prop, memo, 'rollBonus');
-      break;
-    case 'savingThrow':
-      computePropertyField(prop, memo, 'dc');
-      break;
-    case 'spellList':
-      computePropertyField(prop, memo, 'maxPrepared');
-      computePropertyField(prop, memo, 'attackRollBonus');
-      computePropertyField(prop, memo, 'dc');
-      break;
-    case 'propertySlot':
-      computePropertyField(prop, memo, 'quantityExpected');
-      computePropertyField(prop, memo, 'slotCondition');
-      break;
-    case 'roll':
-      computePropertyField(prop, memo, 'roll', 'compile');
-      break;
-  }
-}
-
-function computeAction(prop, memo){
-  // Uses
-  let {
-    result,
-    context,
-    dependencies,
-  } = evaluateCalculation({ string: prop.uses, prop, memo});
-  prop.usesResult = result.value;
-  prop.dependencies = union(prop.dependencies, dependencies);
-  if (context.errors.length){
-    prop.usesErrors = context.errors;
-  } else {
-    delete prop.usesErrors;
-  }
-  prop.insufficientResources = undefined;
-  if (prop.usesUsed >= prop.usesResult){
-    prop.insufficientResources = true;
-  }
-  if (!prop.resources) return;
-  // Attributes consumed
-  prop.resources.attributesConsumed.forEach((attConsumed, i) => {
-    if (attConsumed.variableName){
-      let stat = memo.statsByVariableName[attConsumed.variableName];
-      prop.resources.attributesConsumed[i].statId = stat && stat._id;
-      prop.resources.attributesConsumed[i].statName = stat && stat.name;
-      let available = stat && stat.currentValue || 0;
-      prop.resources.attributesConsumed[i].available = available;
-      if (available < attConsumed.quantity){
-        prop.insufficientResources = true;
-      }
-      if (stat){
-        prop.dependencies = union(
-          prop.dependencies,
-          [stat._id],
-          stat.dependencies
-        );
-      }
-    }
-  });
-  // Items consumed
-  prop.resources.itemsConsumed.forEach((itemConsumed, i) => {
-    let item = itemConsumed.itemId ?
-      memo.equipmentById[itemConsumed.itemId] :
-      undefined;
-    let available = item ? item.quantity : 0;
-    prop.resources.itemsConsumed[i].available = available;
-    if (!item || available < itemConsumed.quantity){
-      prop.insufficientResources = true;
-    }
-    if (item){
-      prop.resources.itemsConsumed[i].itemId = item._id;
-      let name = item.name;
-      if (item.quantity !== 1 && item.plural){
-        name = item.plural;
-      }
-      if (name) prop.resources.itemsConsumed[i].itemName = name;
-      if (item.icon) prop.resources.itemsConsumed[i].itemIcon = item.icon;
-      if (item.color) prop.resources.itemsConsumed[i].itemColor = item.color;
-      prop.dependencies = union(
-        prop.dependencies,
-        [item._id],
-        item.dependencies
-      );
-    } else {
-      delete prop.resources.itemsConsumed[i].itemId;
-      delete prop.resources.itemsConsumed[i].itemName;
-      delete prop.resources.itemsConsumed[i].itemIcon;
-      delete prop.resources.itemsConsumed[i].itemColor;
-    }
-  });
-}
-
-function computePropertyField(prop, memo, fieldName, fn){
-  let {
-    result,
-    context,
-    dependencies,
-  } = evaluateCalculation({string: prop[fieldName], prop, memo, fn});
-  if (result instanceof ConstantNode){
-    prop[`${fieldName}Result`] = result.value;
-  } else {
-    prop[`${fieldName}Result`] = result.toString();
-  }
-  prop.dependencies = union(prop.dependencies, dependencies);
-  if (context.errors.length){
-    prop[`${fieldName}Errors`] = context.errors;
-  } else {
-    delete prop[`${fieldName}Errors`];
-  }
-}

app/imports/api/creature/computation/engine/computeInlineCalculations.js

@@ -1,40 +0,0 @@
-import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
-import INLINE_CALCULATION_REGEX from '/imports/constants/INLINE_CALCULTION_REGEX.js';
-import ErrorNode from '/imports/parser/parseTree/ErrorNode.js';
-import { union } from 'lodash';
-
-export default function computeInlineCalculations(prop, memo){
-  if (prop.summary){
-    computeInlineCalcsForField(prop, memo, 'summary');
-  }
-  if (prop.description){
-    computeInlineCalcsForField(prop, memo, 'description');
-  }
-}
-
-function computeInlineCalcsForField(prop, memo, field){
-  let string = prop[field];
-  let inlineComputations = [];
-  let matches = string.matchAll(INLINE_CALCULATION_REGEX);
-  for (let match of matches){
-    let calculation = match[1];
-    let {
-      result,
-      context,
-      dependencies,
-    } = evaluateCalculation({string: calculation, prop, memo, fn: 'compile'});
-    if (result instanceof ErrorNode){
-      result = '`Calculation Error`';
-    }
-    let computation = {
-      calculation,
-      result: result && result.toString(),
-    };
-    if (context.errors.length){
-      computation.errors = context.errors;
-    }
-    inlineComputations.push(computation);
-    prop.dependencies = union(prop.dependencies, dependencies);
-  }
-  prop[`${field}Calculations`] = inlineComputations;
-}

app/imports/api/creature/computation/engine/computeLevels.js

@@ -1,66 +0,0 @@
-import { forOwn, has, union } from 'lodash';
-import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
-
-export default function computeLevels(memo){
-  computeClassLevels(memo);
-  computeTotalLevel(memo);
-}
-
-function computeClassLevels(memo){
-  forOwn(memo.classLevelsById, classLevel => {
-    applyToggles(classLevel, memo);
-    //  class levels are mutually dependent
-    classLevel.dependencies = union(
-      classLevel.dependencies,
-      Object.keys(memo.classLevelsById)
-    );
-    if (classLevel.deactivatedByToggle) return;
-    let name = classLevel.variableName;
-    let stat = memo.statsByVariableName[name];
-    if (!stat){
-      memo.statsByVariableName[name] = classLevel;
-      memo.classes[name] = classLevel;
-    } else if (!has(stat, 'level')){
-      // Stat is overriden by an attribute
-      return;
-    } else if (stat.level < classLevel.level) {
-      memo.statsByVariableName[name] = classLevel;
-      memo.classes[name] = classLevel;
-    }
-  });
-}
-
-function computeTotalLevel(memo){
-  let currentLevel = memo.statsByVariableName['level'];
-  if (!currentLevel || currentLevel.deactivatedByToggle){
-    currentLevel = {
-      value: 0,
-      dependencies: [],
-      computationDetails: {
-        builtIn: true,
-        computed: true,
-      }
-    };
-    memo.statsByVariableName['level'] = currentLevel;
-  }
-  // bail out if overriden by an attribute
-  if (!currentLevel.computationDetails.builtIn) return;
-  let level = 0;
-  for (let name in memo.classes){
-    let cls = memo.classes[name];
-    level += cls.level || 0;
-    if (cls._id){
-      currentLevel.dependencies = union(
-        currentLevel.dependencies,
-        [cls._id]
-      )
-    }
-    if (cls.dependencies){
-      currentLevel.dependencies = union(
-        currentLevel.dependencies,
-        cls.dependencies,
-      )
-    }
-  }
-  currentLevel.value = level;
-}

app/imports/api/creature/computation/engine/computeMemo.js

@@ -1,37 +0,0 @@
-import { each, forOwn } from 'lodash';
-import computeLevels from '/imports/api/creature/computation/engine/computeLevels.js';
-import computeStat from '/imports/api/creature/computation/engine/computeStat.js';
-import computeEffect from '/imports/api/creature/computation/engine/computeEffect.js';
-import computeToggle from '/imports/api/creature/computation/engine/computeToggle.js';
-import computeEndStepProperty from '/imports/api/creature/computation/engine/computeEndStepProperty.js';
-import computeInlineCalculations from '/imports/api/creature/computation/engine/computeInlineCalculations.js';
-import computeConstant from '/imports/api/creature/computation/engine/computeConstant.js';
-
-export default function computeMemo(memo){
-  // Compute level
-  computeLevels(memo);
-  // Compute all constants that could be used
-  forOwn(memo.constantsById, constant => {
-    computeConstant (constant, memo);
-  });
-  // Compute all stats, even if they are overriden
-  forOwn(memo.statsById, stat => {
-    computeStat (stat, memo);
-  });
-  // Compute effects which didn't end up targeting a stat
-  each(memo.unassignedEffects, effect => {
-    computeEffect(effect, memo);
-  });
-  // Compute toggles which didn't already get computed by dependencies
-  forOwn(memo.togglesById, toggle => {
-    computeToggle(toggle, memo);
-  });
-  // Compute end step properties
-  forOwn(memo.endStepPropsById, prop => {
-    computeEndStepProperty(prop, memo);
-  });
-  // Compute inline calculations
-  forOwn(memo.propsById, prop => {
-    computeInlineCalculations(prop, memo);
-  });
-}

app/imports/api/creature/computation/engine/computeProficiency.js

@@ -1,23 +0,0 @@
-import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
-
-export default function computeEffect(proficiency, memo){
-  if (proficiency.computationDetails.computed) return;
-  if (proficiency.computationDetails.busyComputing){
-    // Trying to compute this proficiency again while it is already computing.
-    // We must be in a dependency loop.
-    proficiency.computationDetails.computed = true;
-    proficiency.result = NaN;
-    proficiency.computationDetails.busyComputing = false;
-    proficiency.computationDetails.error = 'dependencyLoop';
-    if (Meteor.isClient) console.warn('dependencyLoop', proficiency);
-    return;
-  }
-  // Before doing any work, mark this proficiency as busy
-  proficiency.computationDetails.busyComputing = true;
-
-  // Apply any toggles
-  applyToggles(proficiency, memo);
-
-  proficiency.computationDetails.computed = true;
-  proficiency.computationDetails.busyComputing = false;
-}

app/imports/api/creature/computation/engine/computeStat.js

@@ -1,154 +0,0 @@
-import combineStat from '/imports/api/creature/computation/engine/combineStat.js';
-import computeEffect from '/imports/api/creature/computation/engine/computeEffect.js';
-import EffectAggregator from '/imports/api/creature/computation/engine/EffectAggregator.js';
-import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
-import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
-import { each, union, without } from 'lodash';
-
-export default function computeStat(stat, memo){
-  // If the stat is already computed, skip it
-  if (stat.computationDetails.computed) return;
-  if (stat.computationDetails.busyComputing){
-    // Trying to compute this stat again while it is already computing.
-    // We must be in a dependency loop.
-    stat.computationDetails.computed = true;
-    stat.value = NaN;
-    stat.computationDetails.busyComputing = false;
-    stat.computationDetails.error = 'dependencyLoop';
-    if (Meteor.isClient) console.warn('dependencyLoop', stat);
-    return;
-  }
-  // Before doing any work, mark this stat as busy
-  stat.computationDetails.busyComputing = true;
-
-  let effects = stat.computationDetails.effects || [];
-  let proficiencies = stat.computationDetails.proficiencies || [];
-
-  // Get references to all the stats that share the variable name
-  let sameNameStats
-
-  if (stat.computationDetails.idsOfSameName){
-    sameNameStats = stat.computationDetails.idsOfSameName.map(
-      id => memo.propsById[id]
-    );
-  } else {
-    sameNameStats = [];
-  }
-
-  let allStats = [stat, ...sameNameStats];
-
-  // Decide which stat is the last active stat
-  // The last active stat is considered the cannonical stat
-  let lastActiveStat;
-  allStats.forEach(candidateStat => {
-    applyToggles(candidateStat, memo);
-    if (!candidateStat.inactive) lastActiveStat = candidateStat;
-    candidateStat.overridden = undefined;
-  });
-  if (!lastActiveStat){
-    delete memo.statsByVariableName[stat.variableName];
-    return;
-  }
-  // Make sure the active stat has all the effects and proficiencies
-  lastActiveStat.computationDetails.effects = effects;
-  lastActiveStat.computationDetails.proficiencies = proficiencies;
-
-  // Update the memo's stat with the chosen stat
-  memo.statsByVariableName[stat.variableName] = lastActiveStat;
-
-  // Recreate list of the non-cannonical stats
-  sameNameStats = without(allStats, lastActiveStat);
-
-  sameNameStats.forEach(statInstance => {
-    // Mark the non-cannonical stats as overridden
-    statInstance.overridden = true;
-
-    // Apply the cannonical damage
-    statInstance.damage = lastActiveStat.damage;
-  });
-
-  let baseDependencies = [];
-  allStats.forEach(statInstance => {
-    // Add this stat and its deps to the dependencies
-    baseDependencies = union(
-      baseDependencies,
-      [statInstance._id],
-      statInstance.dependencies,
-    );
-
-    // Apply all the base proficiencies
-    if (statInstance.baseProficiency && !statInstance.inactive){
-      proficiencies.push({
-        value: statInstance.baseProficiency,
-        stats: [statInstance.variableName],
-        type: 'proficiency',
-        dependencies: statInstance.overridden ?
-          union(statInstance.dependencies, [statInstance._id]) :
-          [],
-        computationDetails: {
-          computed: true,
-        }
-      });
-    }
-
-    // Compute each active stat's baseValue calculation and apply it
-    if (!statInstance.inactive) {
-      let {
-        result,
-        context,
-        dependencies
-      } = evaluateCalculation({
-        string: statInstance.baseValueCalculation,
-        prop: statInstance,
-        memo
-      });
-      statInstance.baseValue = +result.value;
-      statInstance.dependencies = union(statInstance.dependencies, dependencies);
-      if (context.errors.length){
-        statInstance.baseValueErrors = context.errors;
-      }
-      // Apply all the base values
-      effects.push({
-        operation: 'base',
-        calculation: statInstance.baseValueCalculation,
-        result: statInstance.baseValue,
-        stats: [statInstance.variableName],
-        dependencies: statInstance.overridden ?
-          union(statInstance.dependencies, [statInstance._id]) :
-          [],
-        computationDetails: {
-          computed: true,
-        },
-      });
-    }
-  });
-
-  // Compute and aggregate all the effects
-  let aggregator = new EffectAggregator();
-  let effectDeps = [];
-  each(effects, (effect) => {
-    // Compute
-    computeEffect(effect, memo);
-    if (effect.deactivatedByToggle) return;
-
-    // dependencies
-    if (effect._id) effectDeps = union(effectDeps, [effect._id]);
-    effectDeps = union(effectDeps, effect.dependencies);
-
-    // Add computed effect to aggregator
-    aggregator.addEffect(effect);
-  });
-
-  // Combine the effects into the stats
-  allStats.forEach(statInstance => {
-    // Conglomerate all the effects to compute the final stat values
-    combineStat(statInstance, aggregator, memo);
-    // Mark the stats as computed
-    statInstance.computationDetails.computed = true;
-    statInstance.computationDetails.busyComputing = false;
-    // Only the active stat instance depeneds on the effects
-    if (!statInstance.overridden){
-      statInstance.dependencies = union(statInstance.dependencies, effectDeps);
-    }
-  });
-}

app/imports/api/creature/computation/engine/computeToggle.js

@@ -1,55 +0,0 @@
-import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
-import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
-import { union } from 'lodash';
-
-export default function computeToggle(toggle, memo){
-  if (toggle.computationDetails.computed) return;
-  if (toggle.computationDetails.busyComputing){
-    // Trying to compute this effect again while it is already computing.
-    // We must be in a dependency loop.
-    toggle.computationDetails.computed = true;
-    toggle.result = false;
-    toggle.computationDetails.busyComputing = false;
-    toggle.computationDetails.error = 'dependencyLoop';
-    if (Meteor.isClient) console.warn('dependencyLoop', toggle);
-    return;
-  }
-  // Before doing any work, mark this toggle as busy
-  toggle.computationDetails.busyComputing = true;
-
-  // Apply any parent toggles
-  applyToggles(toggle, memo);
-
-  // Do work
-  delete toggle.errors;
-  if (toggle.enabled){
-    toggle.toggleResult = true;
-  } else if (toggle.disabled){
-    toggle.toggleResult = false;
-  } else if (!toggle.condition){
-    toggle.toggleResult = false;
-  } else if (Number.isFinite(+toggle.condition)){
-    toggle.toggleResult = !!+toggle.condition;
-  } else {
-    let {
-      result,
-      context,
-      dependencies,
-    } = evaluateCalculation({string: toggle.condition, prop: toggle, memo});
-    toggle.toggleResult = !!result.value;
-    toggle.dependencies = union(
-      toggle.dependencies,
-      dependencies,
-    );
-    if (context.errors.length){
-      toggle.errors = context.errors;
-    }
-  }
-  if (!toggle.toggleResult){
-    toggle.inactive = true;
-    toggle.deactivatedBySelf = true;
-    toggle.deactivatedByToggle = true;
-  }
-  toggle.computationDetails.computed = true;
-  toggle.computationDetails.busyComputing = false;
-}

app/imports/api/creature/computation/engine/evaluateCalculation.js

@@ -1,137 +0,0 @@
-import computeStat from '/imports/api/creature/computation/engine/computeStat.js';
-import { prettifyParseError, parse, CompilationContext } from '/imports/parser/parser.js';
-import SymbolNode from '/imports/parser/parseTree/SymbolNode.js';
-import AccessorNode from '/imports/parser/parseTree/AccessorNode.js';
-import ConstantNode from '/imports/parser/parseTree/ConstantNode.js';
-import ErrorNode from '/imports/parser/parseTree/ErrorNode.js';
-import findAncestorByType from '/imports/api/creature/computation/engine/findAncestorByType.js';
-import { union } from 'lodash';
-
-/* Convert a calculation into a constant output and errors*/
-export default function evaluateCalculation({
-  string,
-  prop,
-  memo,
-  fn = 'reduce',
-}){
-  let dependencies = [];
-  let context = new CompilationContext();
-  if (!string) return {
-    result: new ConstantNode({value: string, type: 'string'}),
-    context,
-    dependencies,
-  };
-  if (typeof string !== 'string'){
-    string = string.toString();
-  }
-  // Parse the string
-  let calc;
-  try {
-    calc = parse(string);
-  } catch (e) {
-    let error = prettifyParseError(e);
-    return {
-      result: new ErrorNode({context, error}),
-      context,
-      dependencies,
-    };
-  }
-
-  // Replace constants with their parsed constant
-  let replaceResults = replaceConstants({
-    calc, memo, prop, dependencies, context
-  });
-  dependencies = replaceResults.dependencies;
-  calc = replaceResults.calc;
-  if (replaceResults.failed){
-    return {
-      result: new ConstantNode({value: string, type: 'string'}),
-      context,
-      dependencies,
-    };
-  }
-
-  // Ensure all symbol nodes are defined and computed
-  dependencies = computeSymbols({calc, memo, prop, dependencies})
-
-  // Evaluate
-  let result = calc[fn](memo.statsByVariableName, context);
-  return {result, context, dependencies};
-}
-
-// Replace constants in the calc with the right ParseNodes
-function replaceConstants({calc, memo, prop, dependencies, context}){
-  let constFailed = [];
-  calc = calc.replaceNodes(node => {
-    if (!(node instanceof SymbolNode)) return;
-    let stat, constant;
-    if (node.name[0] !== '#'){
-      stat = memo.statsByVariableName[node.name]
-      constant = memo.constantsByVariableName[node.name];
-    } else if (node.name === '#constant'){
-      constant = findAncestorByType({type: 'constant', prop, memo});
-    }
-    // replace constants that aren't overridden by stats or disabled by a toggle
-    if (constant && !constant.deactivatedByToggle && !stat){
-      dependencies = union(dependencies, [
-        constant._id,
-        ...constant.dependencies
-      ]);
-      // Fail if the constant has errors
-      if (constant.errors && constant.errors.length){
-        constFailed.push(node.name);
-        return;
-      }
-      let parsedConstantNode;
-      try {
-        parsedConstantNode = parse(constant.calculation);
-      } catch(e){
-        constFailed.push(node.name);
-        return;
-      }
-      if (!parsedConstantNode) constFailed.push(node.name);
-      return parsedConstantNode;
-    }
-  });
-  constFailed.forEach(name => {
-    context.storeError({
-      type: 'error',
-      message: `${name} is a constant property with parsing errors`
-    });
-  });
-  let failed = !!constFailed.length;
-  if (failed){
-    calc = new ErrorNode({error: 'Failed to replace constants'});
-  }
-  return { failed, dependencies, calc };
-}
-
-  // Ensure all symbol nodes are defined and computed
-function computeSymbols({calc, memo, prop, dependencies}){
-  calc.traverse(node => {
-    if (node instanceof SymbolNode || node instanceof AccessorNode){
-      let stat;
-      // References up the tree start with #
-      if (node.name[0] === '#'){
-        stat = findAncestorByType({type: node.name.slice(1), prop, memo});
-        memo.statsByVariableName[node.name] = stat;
-      } else {
-        stat = memo.statsByVariableName[node.name];
-      }
-      if (stat && stat.computationDetails && !stat.computationDetails.computed){
-        computeStat(stat, memo);
-      }
-      if (stat){
-        if (stat.dependencies){
-          dependencies = union(dependencies, [
-            stat._id || node.name,
-            ...stat.dependencies
-          ]);
-        } else {
-          dependencies = union(dependencies, [stat._id || node.name]);
-        }
-      }
-    }
-  });
-  return dependencies;
-}

app/imports/api/creature/computation/engine/getComputationProperties.js

@@ -1,24 +0,0 @@
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-
-export default function getComputationProperties(creatureId){
-  // Find all the relevant properties
-  return CreatureProperties.find({
-    'ancestors.id': creatureId,
-    removed: {$ne: true},
-    $or: [
-      // All active properties
-      {inactive: {$ne: true}},
-      // Unless they were deactivated because of a toggle
-      {deactivatedByToggle: true},
-    ]
-  }, {
-    // Filter out fields never used by calculations
-    fields: {
-      icon: 0,
-    },
-    // Obey tree order
-    sort: {
-      order: 1,
-    }
-  }).fetch();
-}

app/imports/api/creature/computation/engine/getDependentProperties.js

@@ -1,51 +0,0 @@
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import { union } from 'lodash';
-
-export default function getDependentProperties({
-  creatureId,
-  propertyIds,
-  propertiesDependedAponIds,
- }){
-  // find ids of all dependant toggles that have conditions, even if inactive
-  let toggleIds = CreatureProperties.find({
-    'ancestors.id': creatureId,
-    type: 'toggle',
-    removed: {$ne: true},
-    condition: { $exists: true },
-    dependencies: {$in: propertyIds},
-  }, {
-    fields: {_id: 1},
-  }).map(t => t._id);
-  // Find all the dependant properties
-  let props = CreatureProperties.find({
-    'ancestors.id': creatureId,
-    removed: {$ne: true},
-    dependencies: {$in: propertyIds},
-    $or: [
-      // All active properties
-      {inactive: {$ne: true}},
-      // All active and inactive toggles with conditions
-      // Same as {$in: toggleIds}, but should be slightly faster
-      {type: 'toggle', condition: { $exists: true }},
-      // All decendents of the above toggles
-      {'ancestors.id': {$in: toggleIds}},
-    ]
-  }, { fields: {_id: 1, dependencies: 1} }).fetch();
-  // Add all the properties that changing props depend on, but haven't yet been
-  // included to make an array of every property we need
-  let allConnectedPropIds = [...propertyIds, ...propertiesDependedAponIds];
-  props.forEach(prop => {
-    allConnectedPropIds = union(
-      allConnectedPropIds,
-      prop.dependencies,
-      [prop._id]);
-  });
-  // Add on all the properties and the objects they depend apon
-  return CreatureProperties.find({
-    _id: {$in: allConnectedPropIds}
-  }, {
-    // Ignore fields not used in computations
-    fields: {icon: 0},
-    sort: {order: 1},
-  }).fetch();
-}

app/imports/api/creature/computation/engine/writeCreatureVariables.js

@@ -1,59 +0,0 @@
-import { pick, forOwn } from 'lodash';
-import Creatures from '/imports/api/creature/Creatures.js';
-import VERSION from '/imports/constants/VERSION.js';
-
-export default function writeCreatureVariables(memo, creatureId, fullRecompute = true) {
-  const fields = [
-    'ability',
-    'abilityMod',
-    'advantage',
-    'attributeType',
-    'baseProficiency',
-    'baseValue',
-    'calculation',
-    'conditionalBenefits',
-    'currentValue',
-    'damage',
-    'decimal',
-    'fail',
-    'level',
-    'modifier',
-    'name',
-    'passiveBonus',
-    'proficiency',
-    'reset',
-    'resetMultiplier',
-    'rollBonuses',
-    'skillType',
-    'spellSlotLevelValue',
-    'type',
-    'value',
-  ];
-
-  if (fullRecompute){
-    memo.creatureVariables = {};
-    forOwn(memo.statsByVariableName, (stat, variableName) => {
-      // Don't save context variables
-      if (variableName[0] === '#') return;
-      let condensedStat = pick(stat, fields);
-      memo.creatureVariables[variableName] = condensedStat;
-    });
-    forOwn(memo.constantsByVariableName, (stat, variableName) => {
-      let condensedStat = pick(stat, fields);
-      if (!memo.creatureVariables[variableName]){
-        memo.creatureVariables[variableName] = condensedStat;
-      }
-    });
-    Creatures.update(creatureId, {$set: {
-      variables: memo.creatureVariables,
-      computeVersion: VERSION,
-    }});
-  } else {
-    let $set = {};
-    forOwn(memo.statsByVariableName, (stat, variableName) => {
-      let condensedStat = pick(stat, fields);
-      $set[`variables.${variableName}`] = condensedStat;
-    });
-    Creatures.update(creatureId, {$set});
-  }
-}

app/imports/api/creature/computation/methods/recomputeCreature.js

@@ -1,120 +0,0 @@
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import SimpleSchema from 'simpl-schema';
-import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import ComputationMemo from '/imports/api/creature/computation/engine/ComputationMemo.js';
-import getComputationProperties from '/imports/api/creature/computation/engine/getComputationProperties.js';
-import computeMemo from '/imports/api/creature/computation/engine/computeMemo.js';
-import writeAlteredProperties from '/imports/api/creature/computation/engine/writeAlteredProperties.js';
-import writeCreatureVariables from '/imports/api/creature/computation/engine/writeCreatureVariables.js';
-import { recomputeDamageMultipliersById } from '/imports/api/creature/denormalise/recomputeDamageMultipliers.js';
-import recomputeSlotFullness from '/imports/api/creature/denormalise/recomputeSlotFullness.js';
-import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import getDependentProperties from '/imports/api/creature/computation/engine/getDependentProperties.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
-
-export const recomputeCreature = new ValidatedMethod({
-
-  name: 'creatures.recomputeCreature',
-
-  validate: new SimpleSchema({
-    charId: { type: String }
-  }).validator(),
-
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-
-  run({charId}) {
-    let creature = Creatures.findOne(charId);
-    // Permission
-    assertEditPermission(creature, this.userId);
-    // Work, call this direcly if you are already in a method that has checked
-    // for permission to edit a given character
-    recomputeCreatureById(charId);
-  },
-
-});
-
-export function recomputeCreatureById(creatureId){
-  let creature = Creatures.findOne(creatureId);
-  recomputeCreatureByDoc(creature);
-}
-
-/**
- * This function is the heart of DiceCloud. It recomputes a creature's stats,
- * distilling down effects and proficiencies into the final stats that make up
- * a creature.
- *
- * Essentially this is a depth first tree traversal algorithm that computes
- * stats' dependencies before computing stats themselves, while detecting
- * dependency loops.
- *
- * At the moment it makes no effort to limit recomputation to just what was
- * changed.
- *
- * Attempting to implement dependency management to limit recomputation to just
- * change affected stats should only happen as a last resort, when this function
- * can no longer be performed more efficiently, and server resources can not be
- * expanded to meet demand.
- *
- * A brief overview:
- * - Fetch the stats of the creature and add them to
- *   an object for quick lookup
- * - Fetch the effects and proficiencies which apply to each stat and store them with the stat
- * - Fetch the class levels and store them as well
- * - Mark each stat and effect as uncomputed
- * - Iterate over each stat in order and compute it
- *   - If the stat is already computed, skip it
- *   - If the stat is busy being computed, we are in a dependency loop, make it NaN and mark computed
- *   - Mark the stat as busy computing
- *   - Iterate over each effect which applies to the attribute
- *     - If the effect is not computed compute it
- *       - If the effect relies on another attribute, get its computed value
- *       - Recurse if that attribute is uncomputed
- *     - apply the effect to the attribute
- *   - Conglomerate all the effects to compute the final stat values
- *   - Mark the stat as computed
- * - Write the computed results back to the database
- */
-export function recomputeCreatureByDoc(creature){
-  const creatureId = creature._id;
-  let props = getComputationProperties(creatureId);
-  let computationMemo = new ComputationMemo(props, creature);
-  computeMemo(computationMemo);
-  writeAlteredProperties(computationMemo);
-  writeCreatureVariables(computationMemo, creatureId);
-  recomputeDamageMultipliersById(creatureId);
-  recomputeSlotFullness(creatureId);
-  return computationMemo;
-}
-
-export function recomputePropertyDependencies(property){
-  let creature = getRootCreatureAncestor(property);
-  recomputeCreatureByDependencies({
-    creature,
-    propertyIds: [property._id],
-    propertiesDependedAponIds: property.dependencies,
-  });
-}
-
-export function recomputeCreatureByDependencies({
-  creature,
-  propertyIds,
-  propertiesDependedAponIds
-}){
-  let props = getDependentProperties({
-    creatureId: creature._id,
-    propertyIds,
-    propertiesDependedAponIds,
-  });
-  let computationMemo = new ComputationMemo(props, creature);
-  computeMemo(computationMemo);
-  writeAlteredProperties(computationMemo);
-  writeCreatureVariables(computationMemo, creature._id, false)
-  recomputeInactiveProperties(creature._id);
-  return computationMemo;
-}

app/imports/api/creature/creatureComputation.test.js

@@ -1,97 +0,0 @@
-import {computeCreature} from "./recomputeCreature.js";
-import assert from "assert";
-
-const makeEffect = function(operation, value){
-  let effect = {computed: false, result: 0, operation}
-  if (_.isFinite(value)){
-    effect.value = +value;
-  } else {
-    effect.calculation = value;
-  }
-  return effect;
-}
-
-describe('computeCreature', function () {
-  it('computes an aritrary creature', function () {
-    let char = {
-      atts: {
-        attribute1: {
-          computed: false,
-          busyComputing: false,
-          type: "attribute",
-          attributeType: "ability",
-          result: 0,
-          mod: 0, // The resulting modifier if this is an ability
-          base: 0,
-          add: 0,
-          mul: 1,
-          min: Number.NEGATIVE_INFINITY,
-          max: Number.POSITIVE_INFINITY,
-          effects: [
-            makeEffect("base", 10),
-            makeEffect("add", 5),
-            makeEffect("mul", 2),
-          ],
-        },
-        attribute2: {
-          computed: false,
-          busyComputing: false,
-          type: "attribute",
-          result: 0,
-          mod: 0, // The resulting modifier if this is an ability
-          base: 0,
-          add: 0,
-          mul: 1,
-          min: Number.NEGATIVE_INFINITY,
-          max: Number.POSITIVE_INFINITY,
-          effects: [
-            makeEffect("base", "attribute1"),
-            makeEffect("max", 2),
-          ],
-        },
-      },
-      skills: {
-        skill1: {
-          computed: false,
-          busyComputing: false,
-          type: "skill",
-          ability: "attribute1",
-          result: 0,
-          proficiency: 0,
-          add: 0,
-          mul: 1,
-          min: Number.NEGATIVE_INFINITY,
-          max: Number.POSITIVE_INFINITY,
-          advantage: 0,
-          disadvantage: 0,
-          passiveAdd: 0,
-          fail: 0,
-          conditional: 0,
-          effects: [],
-          proficiencies: [],
-        },
-      },
-      dms: {
-        dm1: {
-          computed: false,
-          busyComputing: false,
-          type: "damageMultiplier",
-          result: 0,
-          immunityCount: 0,
-          ressistanceCount: 0,
-          vulnerabilityCount: 0,
-          effects: [],
-        }
-      },
-      classes: {
-        Barbarian: {
-          level: 5,
-        },
-      },
-      level: 5,
-    };
-    char = computeCreature(char);
-    console.log(char);
-    assert(true);
-  });
-});

app/imports/api/creature/creatureFolders/CreatureFolders.js

@@ -0,0 +1,39 @@
+import SimpleSchema from 'simpl-schema';
+import STORAGE_LIMITS from '/imports/constants/STORAGE_LIMITS.js';
+
+let CreatureFolders = new Mongo.Collection('creatureFolders');
+
+let creatureFolderSchema = new SimpleSchema({
+  name: {
+    type: String,
+    trim: false,
+    optional: true,
+    max: STORAGE_LIMITS.name,
+  },
+  creatures: {
+    type: Array,
+    defaultValue: [],
+  },
+  'creatures.$': {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+  owner: {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+    index: 1,
+  },
+  archived: {
+    type: Boolean,
+    optional: true,
+  },
+  order: {
+    type: Number,
+    defaultValue: 0,
+  },
+});
+
+CreatureFolders.attachSchema(creatureFolderSchema);
+
+import '/imports/api/creature/creatureFolders/methods.js/index.js';
+export default CreatureFolders;

app/imports/api/creature/creatureFolders/methods.js/index.js

@@ -0,0 +1,4 @@
+import '/imports/api/creature/creatureFolders/methods.js/insertCreatureFolder.js';
+import '/imports/api/creature/creatureFolders/methods.js/updateCreatureFolderName.js';
+import '/imports/api/creature/creatureFolders/methods.js/removeCreatureFolder.js';
+import '/imports/api/creature/creatureFolders/methods.js/moveCreatureToFolder.js';

app/imports/api/creature/creatureFolders/methods.js/insertCreatureFolder.js

@@ -0,0 +1,46 @@
+import CreatureFolders from '/imports/api/creature/creatureFolders/CreatureFolders.js';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+
+const insertCreatureFolder = new ValidatedMethod({
+  name: 'creatureFolders.methods.insert',
+  validate: null,
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run() {
+    // Ensure logged in
+    let userId = this.userId;
+    if (!userId) {
+      throw new Meteor.Error('creatureFolders.methods.insert.denied',
+      'You need to be logged in to insert a folder');
+    }
+    // Limit folders to 50 per user
+    let existingFolders = CreatureFolders.find({
+      owner: userId
+    }, {
+      fields: {order: 1},
+      sort: {order :-1}
+    });
+    if (existingFolders.count() >= 50){
+      throw new Meteor.Error('creatureFolders.methods.insert.denied',
+      'You can not have more than 50 folders');
+    }
+    // Make the new folder the last in the order
+    let order = 0;
+    let lastFolder = existingFolders.fetch()[0];
+    if (lastFolder){
+      order = (lastFolder.order || 0) + 1;
+    }
+    // Insert
+    return CreatureFolders.insert({
+      name: 'Folder',
+      owner: userId,
+      order,
+    });
+  },
+});
+
+export default insertCreatureFolder;

app/imports/api/creature/creatureFolders/methods.js/moveCreatureToFolder.js

@@ -0,0 +1,45 @@
+import CreatureFolders from '/imports/api/creature/creatureFolders/CreatureFolders.js';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+
+const moveCreatureToFolder = new ValidatedMethod({
+  name: 'creatureFolders.methods.moveCreatureToFolder',
+  validate: null,
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({creatureId, folderId}) {
+    // Ensure logged in
+    let userId = this.userId;
+    if (!userId) {
+      throw new Meteor.Error('creatureFolders.methods.updateName.denied',
+      'You need to be logged in to remove a folder');
+    }
+    // Check that this folder is owned by the user
+    if (folderId){
+      let existingFolder = CreatureFolders.findOne(folderId);
+      if (existingFolder.owner !== userId){
+        throw new Meteor.Error('creatureFolders.methods.updateName.denied',
+        'This folder does not belong to you');
+      }
+    }
+    // Remove from other folders
+    CreatureFolders.update({
+      owner: userId
+    }, {
+      $pull: {creatures: creatureId},
+    }, {
+      multi: true,
+    });
+    if (folderId){
+      // Add to this folder
+      CreatureFolders.update(folderId, {
+        $addToSet: {creatures: creatureId},
+      });
+    }
+  },
+});
+
+export default moveCreatureToFolder;

app/imports/api/creature/creatureFolders/methods.js/removeCreatureFolder.js

@@ -0,0 +1,31 @@
+import CreatureFolders from '/imports/api/creature/creatureFolders/CreatureFolders.js';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+
+const removeCreatureFolder = new ValidatedMethod({
+  name: 'creatureFolders.methods.remove',
+  validate: null,
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({_id}) {
+    // Ensure logged in
+    let userId = this.userId;
+    if (!userId) {
+      throw new Meteor.Error('creatureFolders.methods.updateName.denied',
+      'You need to be logged in to remove a folder');
+    }
+    // Check that this folder is owned by the user
+    let existingFolder = CreatureFolders.findOne(_id);
+    if (existingFolder.owner !== userId){
+      throw new Meteor.Error('creatureFolders.methods.updateName.denied',
+      'This folder does not belong to you');
+    }
+    // Remove
+    return CreatureFolders.remove(_id);
+  },
+});
+
+export default removeCreatureFolder;

app/imports/api/creature/creatureFolders/methods.js/reorderCreatureFolder.js

@@ -0,0 +1,43 @@
+import CreatureFolders from '/imports/api/creature/creatureFolders/CreatureFolders.js';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+
+const reorderCreatureFolder = new ValidatedMethod({
+  name: 'creatureFolders.methods.reorder',
+  validate: null,
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({_id, order}) {
+    // Ensure logged in
+    let userId = this.userId;
+    if (!userId) {
+      throw new Meteor.Error('creatureFolders.methods.reorder.denied',
+      'You need to be logged in to reorder a folder');
+    }
+    // Check that this folder is owned by the user
+    let existingFolder = CreatureFolders.findOne(_id);
+    if (existingFolder.owner !== userId){
+      throw new Meteor.Error('creatureFolders.methods.reorder.denied',
+      'This folder does not belong to you');
+    }
+    // First give it the new order, it should end in 0.5 putting it between two other docs
+    CreatureFolders.update(_id, {$set: {order}});
+    this.unblock();
+    // Reorder all the folders with integer numbers in this new order
+    CreatureFolders.find({
+      owner: userId
+    }, {
+      fields: {order: 1,},
+      sort: {order: -1}
+    }).forEach((folder, index) => {
+      if (folder.order !== index){
+        CreatureFolders.update(_id, {$set: {order: index}})
+      }
+    });
+  },
+});
+
+export default reorderCreatureFolder;

app/imports/api/creature/creatureFolders/methods.js/updateCreatureFolderName.js

@@ -0,0 +1,31 @@
+import CreatureFolders from '/imports/api/creature/creatureFolders/CreatureFolders.js';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+
+const updateCreatureFolderName = new ValidatedMethod({
+  name: 'creatureFolders.methods.updateName',
+  validate: null,
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({_id, name}) {
+    // Ensure logged in
+    let userId = this.userId;
+    if (!userId) {
+      throw new Meteor.Error('creatureFolders.methods.updateName.denied',
+      'You need to be logged in to update a folder');
+    }
+    // Check that this folder is owned by the user
+    let existingFolder = CreatureFolders.findOne(_id);
+    if (existingFolder.owner !== userId){
+      throw new Meteor.Error('creatureFolders.methods.updateName.denied',
+      'This folder does not belong to you');
+    }
+    // Update
+    return CreatureFolders.update(_id, {$set: {name}});
+  },
+});
+
+export default updateCreatureFolderName;

app/imports/api/creature/creatureProperties/CreatureProperties.js

@@ -5,35 +5,63 @@ import ChildSchema from '/imports/api/parenting/ChildSchema.js';
 import SoftRemovableSchema from '/imports/api/parenting/SoftRemovableSchema.js';
 import propertySchemasIndex from '/imports/api/properties/computedPropertySchemasIndex.js';
 import { storedIconsSchema } from '/imports/api/icons/Icons.js';
+import STORAGE_LIMITS from '/imports/constants/STORAGE_LIMITS.js';
 
 let CreatureProperties = new Mongo.Collection('creatureProperties');
 
 let CreaturePropertySchema = new SimpleSchema({
-	type: {
+  _id: {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+  _migrationError: {
+    type: String,
+    optional: true,
+  },
+  type: {
     type: String,
     allowedValues: Object.keys(propertySchemasIndex),
   },
-	tags: {
-		type: Array,
-		defaultValue: [],
-	},
-	'tags.$': {
-		type: String,
-	},
-	disabled: {
-		type: Boolean,
-		optional: true,
-	},
+  tags: {
+    type: Array,
+    defaultValue: [],
+    maxCount: STORAGE_LIMITS.tagCount,
+  },
+  'tags.$': {
+    type: String,
+    max: STORAGE_LIMITS.tagLength,
+  },
+  disabled: {
+    type: Boolean,
+    optional: true,
+  },
   icon: {
     type: storedIconsSchema,
     optional: true,
+    max: STORAGE_LIMITS.icon,
   },
+  // Reference to the library node that this property was copied from
+  libraryNodeId: {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+    optional: true,
+  },
+  // Fill more than one quantity in a slot, like feats and ability score
+  // improvements, filtered out of UI if there isn't space in quantityExpected
+  slotQuantityFilled: {
+    type: SimpleSchema.Integer,
+    optional: true, // Undefined implies 1
+  },
+});
+
+const DenormalisedOnlyCreaturePropertySchema = new SimpleSchema({
   // Denormalised flag if this property is inactive on the sheet for any reason
   // Including being disabled, or a decendent of a disabled property
   inactive: {
     type: Boolean,
     optional: true,
     index: 1,
+    removeBeforeCompute: true,
   },
   // Denormalised flag if this property was made inactive by an inactive
   // ancestor. True if this property has an inactive ancestor even if this
@@ -42,6 +70,7 @@ let CreaturePropertySchema = new SimpleSchema({
     type: Boolean,
     optional: true,
     index: 1,
+    removeBeforeCompute: true,
   },
   // Denormalised flag if this property was made inactive because of its own
   // state
@@ -49,6 +78,7 @@ let CreaturePropertySchema = new SimpleSchema({
     type: Boolean,
     optional: true,
     index: 1,
+    removeBeforeCompute: true,
   },
   // Denormalised flag if this property was made inactive because of a toggle
   // calculation. Either an ancestor toggle calculation or its own.
@@ -56,35 +86,39 @@ let CreaturePropertySchema = new SimpleSchema({
     type: Boolean,
     optional: true,
     index: 1,
+    removeBeforeCompute: true,
   },
-  // Denormalised list of all properties or creatures this property depends on
-  dependencies: {
-    type: Array,
-    defaultValue: [],
-    index: 1,
-  },
-  'dependencies.$': {
+  deactivatingToggleId: {
     type: String,
+    regEx: SimpleSchema.RegEx.Id,
+    optional: true,
+    removeBeforeCompute: true,
+  },
+  // When this is true on any property, the creature needs to be recomputed
+  dirty: {
+    type: Boolean,
+    // Default to true because new properties cause a recomputation
+    defaultValue: true,
+    optional: true,
   },
 });
 
-for (let key in propertySchemasIndex){
-	let schema = new SimpleSchema({});
-	schema.extend(propertySchemasIndex[key]);
-	schema.extend(CreaturePropertySchema);
-  schema.extend(ColorSchema);
-	schema.extend(ChildSchema);
-	schema.extend(SoftRemovableSchema);
-	CreatureProperties.attachSchema(schema, {
-		selector: {type: key}
-	});
-}
+CreaturePropertySchema.extend(DenormalisedOnlyCreaturePropertySchema);
 
-import '/imports/api/creature/creatureProperties/methods/index.js';
-import '/imports/api/creature/actions/doAction.js';
-import '/imports/api/creature/actions/castSpellWithSlot.js';
+for (let key in propertySchemasIndex) {
+  let schema = new SimpleSchema({});
+  schema.extend(propertySchemasIndex[key]);
+  schema.extend(CreaturePropertySchema);
+  schema.extend(ColorSchema);
+  schema.extend(ChildSchema);
+  schema.extend(SoftRemovableSchema);
+  CreatureProperties.attachSchema(schema, {
+    selector: { type: key }
+  });
+}
 
 export default CreatureProperties;
 export {
-	CreaturePropertySchema,
+  DenormalisedOnlyCreaturePropertySchema,
+  CreaturePropertySchema,
 };

app/imports/api/creature/creatureProperties/getRootCreatureAncestor.js

@@ -1,4 +1,4 @@
-import Creatures from '/imports/api/creature/Creatures.js';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
 
 export default function getRootCreatureAncestor(property){
   return Creatures.findOne(property.ancestors[0].id);

app/imports/api/creature/creatureProperties/methods/adjustQuantity.js

@@ -4,8 +4,6 @@ import SimpleSchema from 'simpl-schema';
 import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 
 const adjustQuantity = new ValidatedMethod({
   name: 'creatureProperties.adjustQuantity',
@@ -22,44 +20,40 @@ const adjustQuantity = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({_id, operation, value}) {
+  run({ _id, operation, value }) {
     // Permissions
-		let property = CreatureProperties.findOne(_id);
+    let property = CreatureProperties.findOne(_id);
     let rootCreature = getRootCreatureAncestor(property);
-		assertEditPermission(rootCreature, this.userId);
+    assertEditPermission(rootCreature, this.userId);
 
     // Do work
-    adjustQuantityWork({property, operation, value});
-
-    // Changing quantity does not change dependencies, but recomputing the
-    // inventory changes many deps at once, so recompute fully
-    recomputeCreatureByDoc(rootCreature);
-    recomputeInventory(rootCreature._id);
+    adjustQuantityWork({ property, operation, value });
   },
 });
 
-export function adjustQuantityWork({property, operation, value}){
+export function adjustQuantityWork({ property, operation, value }) {
   // Check if property has quantity
   let schema = CreatureProperties.simpleSchema(property);
-  if (!schema.allowsKey('quantity')){
+  if (!schema.allowsKey('quantity')) {
     throw new Meteor.Error(
       'Adjust quantity failed',
       `Property of type "${property.type}" doesn't have a quantity`
     );
   }
-  if (operation === 'set'){
+  if (operation === 'set') {
     CreatureProperties.update(property._id, {
-      $set: {quantity: value}
+      $set: { quantity: value, dirty: true }
     }, {
       selector: property
     });
-  } else if (operation === 'increment'){
+  } else if (operation === 'increment') {
     // value here is 'damage'
     value = -value;
     let currentQuantity = property.quantity;
     if (currentQuantity + value < 0) value = -currentQuantity;
     CreatureProperties.update(property._id, {
-      $inc: {quantity: value}
+      $inc: { quantity: value },
+      $set: { dirty: true }
     }, {
       selector: property
     });

app/imports/api/creature/creatureProperties/methods/copyPropertyToLibrary.js

@@ -0,0 +1,189 @@
+import SimpleSchema from 'simpl-schema';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import LibraryNodes from '/imports/api/library/LibraryNodes.js';
+import { RefSchema } from '/imports/api/parenting/ChildSchema.js';
+import {
+  assertEditPermission,
+  assertDocEditPermission,
+  assertCopyPermission
+} from '/imports/api/sharing/sharingPermissions.js';
+import {
+  setLineageOfDocs,
+  getAncestry,
+  renewDocIds
+} from '/imports/api/parenting/parenting.js';
+import { reorderDocs } from '/imports/api/parenting/order.js';
+import { setDocToLastOrder } from '/imports/api/parenting/order.js';
+import Libraries from '/imports/api/library/Libraries.js';
+const DUPLICATE_CHILDREN_LIMIT = 500;
+
+const copyPropertyToLibrary = new ValidatedMethod({
+  name: 'creatureProperties.copyPropertyToLibrary',
+  validate: new SimpleSchema({
+    propId: {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+    parentRef: {
+      type: RefSchema,
+    },
+    order: {
+      type: Number,
+      optional: true,
+    },
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 1,
+    timeInterval: 5000,
+  },
+  run({ propId, parentRef, order }) {
+    // get the new ancestry for the properties
+    let { parentDoc, ancestors } = getAncestry({ parentRef });
+
+    // Check permission to edit the destination
+    let rootLibrary;
+    if (parentRef.collection === 'libraries') {
+      rootLibrary = parentDoc;
+    } else if (parentRef.collection === 'libraryNodes') {
+      rootLibrary = Libraries.findOne(parentDoc.ancestors[0].id)
+    } else {
+      throw `${parentRef.collection} is not a valid parent collection`
+    }
+    assertEditPermission(rootLibrary, this.userId);
+
+    const insertedRootNode = insertNodeFromProperty(propId, ancestors, order, this);
+
+    // Tree structure changed by inserts, reorder the tree
+    reorderDocs({
+      collection: LibraryNodes,
+      ancestorId: rootLibrary._id,
+    });
+
+    // Return the docId of the inserted root property
+    return insertedRootNode?._id;
+  },
+});
+
+function insertNodeFromProperty(propId, ancestors, order, method) {
+  // Fetch the property and its descendants, provided they have not been
+  // removed
+  let prop = CreatureProperties.findOne({
+    _id: propId,
+    removed: { $ne: true },
+  });
+  if (!prop) {
+    if (Meteor.isClient) return;
+    else {
+      throw new Meteor.Error(
+        'Insert property from library failed',
+        `No property with id '${propId}' was found`
+      );
+    }
+  }
+
+  // Make sure we can edit this property
+  assertDocEditPermission(prop, method.userId);
+
+  let oldParent = prop.parent;
+  const propCursor = CreatureProperties.find({
+    'ancestors.id': propId,
+    removed: { $ne: true },
+  });
+
+  // Make sure there aren't too many descendants
+  if (propCursor.count() > DUPLICATE_CHILDREN_LIMIT) {
+    throw new Meteor.Error('Copy children limit',
+      `The property has over ${DUPLICATE_CHILDREN_LIMIT} descendants and cannot be copied`);
+  }
+
+  let props = propCursor.fetch();
+
+  // The root prop is first in the array of props
+  // It must get the first generated ID to prevent flickering
+  props = [prop, ...props];
+
+  // If the docs came from a library, that library must consent to this user copying their
+  // properties
+  assertSourceLibraryCopyPermission(props, method);
+
+  // re-map all the ancestors
+  setLineageOfDocs({
+    docArray: props,
+    newAncestry: ancestors,
+    oldParent,
+  });
+
+  // Give the docs new IDs without breaking internal references
+  renewDocIds({
+    docArray: props,
+    collectionMap: { 'creatureProperties': 'libraryNodes' }
+  });
+
+  // Order the root node
+  if (order === undefined) {
+    setDocToLastOrder({
+      collection: LibraryNodes,
+      doc: prop,
+    });
+  } else {
+    prop.order = order;
+  }
+
+  // Insert the props as library nodes
+  LibraryNodes.batchInsert(props);
+  return prop;
+}
+
+/**
+ * 
+ * @param {[Property]} props The properties to check
+ * @param {String} userId The userId trying to copy these properties to a library
+ * Checks that every property can be copied out of the library that originated it by this user
+ */
+function assertSourceLibraryCopyPermission(props, method) {
+  // Skip on the client
+  if (method.isSimulation) return;
+
+  // Get all the library node ids that are sources for these properties
+  const libraryNodeIds = [];
+  props.forEach(prop => {
+    if (prop.libraryNodeId) libraryNodeIds.push(prop.libraryNodeId);
+  });
+  if (!libraryNodeIds.length) return;
+
+  // Get the actual library Ids that each of these source nodes came from
+  const sourceLibIds = new Set();
+  LibraryNodes.find({
+    _id: { $in: libraryNodeIds }
+  }, {
+    fields: { ancestors: 1 }
+  }).forEach(node => {
+    sourceLibIds.add(node.ancestors?.[0]?.id);
+  });
+
+  // Assert copy permission on each of those libraries
+  Libraries.find({
+    _id: { $in: Array.from(sourceLibIds) }
+  }, {
+    fields: {
+      name: 1,
+      owner: 1,
+      readers: 1,
+      writers: 1,
+      public: 1,
+      readersCanCopy: 1,
+    }
+  }).forEach(lib => {
+    try {
+      assertCopyPermission(lib, method.userId);
+    } catch (e) {
+      throw new Meteor.Error('Copy permission denied',
+        `One of the properties you are copying comes from ${lib.name}, which you do not have permission to copy from`);
+    }
+  });
+}
+
+export default copyPropertyToLibrary;

app/imports/api/creature/creatureProperties/methods/damagePropertiesByName.js

@@ -1,57 +0,0 @@
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import SimpleSchema from 'simpl-schema';
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
-import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
-import { recomputePropertyDependencies } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-
-const damagePropertiesByName = new ValidatedMethod({
-  name: 'CreatureProperties.damagePropertiesByName',
-  validate: new SimpleSchema({
-    creatureId: SimpleSchema.RegEx.Id,
-    variableName: {
-      type: String,
-    },
-    operation: {
-      type: String,
-      allowedValues: ['set', 'increment']
-    },
-    value: Number,
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 20,
-    timeInterval: 5000,
-  },
-  run({creatureId, variableName, operation, value}) {
-		// Check permissions
-    let creature = Creatures.findOne(creatureId, {
-      fields: {
-        damageMultipliers: 1,
-        owner: 1,
-        readers: 1,
-        writers: 1,
-      },
-    });
-    assertEditPermission(creature, this.userId);
-    let lastProperty;
-    CreatureProperties.find({
-      'ancestors.id': creatureId,
-      variableName,
-      removed: {$ne: false},
-      inactive: {$ne: true},
-    }).forEach(property => {
-      // Check if property can take damage
-      let schema = CreatureProperties.simpleSchema(property);
-      if (!schema.allowsKey('damage')) return;
-      // Damage the property
-      damagePropertyWork({property, operation, value});
-      lastProperty = property;
-    });
-    if (lastProperty) recomputePropertyDependencies(lastProperty);
-  }
-});
-
-export default damagePropertiesByName;

app/imports/api/creature/creatureProperties/methods/damageProperty.js

@@ -2,9 +2,9 @@ import { ValidatedMethod } from 'meteor/mdg:validated-method';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import SimpleSchema from 'simpl-schema';
 import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
-import { recomputePropertyDependencies } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import { applyTriggers } from '/imports/api/engine/actions/applyTriggers.js';
+import ActionContext from '/imports/api/engine/actions/ActionContext.js';
 
 const damageProperty = new ValidatedMethod({
   name: 'creatureProperties.damage',
@@ -21,58 +21,119 @@ const damageProperty = new ValidatedMethod({
     numRequests: 20,
     timeInterval: 5000,
   },
-  run({_id, operation, value}) {
-    // Check permissions
-		let property = CreatureProperties.findOne(_id);
-    if (!property) throw new Meteor.Error(
+  run({ _id, operation, value }) {
+
+    // Get action context
+    let prop = CreatureProperties.findOne(_id);
+    if (!prop) throw new Meteor.Error(
       'Damage property failed', 'Property doesn\'t exist'
     );
-    let rootCreature = getRootCreatureAncestor(property);
-    assertEditPermission(rootCreature, this.userId);
-		// Check if property can take damage
-		let schema = CreatureProperties.simpleSchema(property);
-		if (!schema.allowsKey('damage')){
-			throw new Meteor.Error(
-				'Damage property failed',
-				`Property of type "${property.type}" can't be damaged`
-			);
-		}
-		let result = damagePropertyWork({property, operation, value});
-    // Dependencies can't be changed through damage, only recompute deps
-    recomputePropertyDependencies(property);
+    const creatureId = prop.ancestors[0].id;
+    const actionContext = new ActionContext(creatureId, [creatureId], this);
+
+    // Check permissions
+    assertEditPermission(actionContext.creature, this.userId);
+
+    // Check if property can take damage
+    let schema = CreatureProperties.simpleSchema(prop);
+    if (!schema.allowsKey('damage')) {
+      throw new Meteor.Error(
+        'Damage property failed',
+        `Property of type "${prop.type}" can't be damaged`
+      );
+    }
+
+    // Replace the prop by its actionContext counterpart if possible
+    if (prop.variableName) {
+      const actionContextProp = actionContext.scope[prop.variableName];
+      if (actionContextProp?._id === prop._id) {
+        prop = actionContextProp;
+      }
+    }
+
+    const result = damagePropertyWork({ prop, operation, value, actionContext });
+
+    // Insert the log
+    actionContext.writeLog();
     return result;
   },
 });
 
-export function damagePropertyWork({property, operation, value}){
-  if (operation === 'set'){
-    let currentValue = property.value;
+export function damagePropertyWork({ prop, operation, value, actionContext, logFunction }) {
+
+  // Save the value to the scope before applying the before triggers
+  if (operation === 'increment') {
+    if (value >= 0) {
+      actionContext.scope['~damage'] = { value };
+    } else {
+      actionContext.scope['~healing'] = { value: -value };
+    }
+  } else {
+    actionContext.scope['~set'] = { value };
+  }
+
+  applyTriggers(actionContext.triggers?.damageProperty?.before, prop, actionContext);
+
+  // fetch the value from the scope after the before triggers, in case they changed them
+  if (operation === 'increment') {
+    if (value >= 0) {
+      value = actionContext.scope['~damage']?.value;
+    } else {
+      value = -actionContext.scope['~healing']?.value;
+    }
+  } else {
+    value = actionContext.scope['~set']?.value;
+  }
+
+  let damage, newValue, increment;
+  if (operation === 'set') {
+    const total = prop.total || 0;
     // Set represents what we want the value to be after damage
     // So we need the actual damage to get to that value
-    let damage = currentValue - value;
+    damage = total - value;
     // Damage can't exceed total value
-    if (damage > currentValue) damage = currentValue;
+    if (damage > total && !prop.ignoreLowerLimit) damage = total;
     // Damage must be positive
-    if (damage < 0) damage = 0;
-    CreatureProperties.update(property._id, {
-      $set: {damage}
+    if (damage < 0 && !prop.ignoreUpperLimit) damage = 0;
+    newValue = prop.total - damage;
+    // Write the results
+    CreatureProperties.update(prop._id, {
+      $set: { damage, value: newValue, dirty: true }
     }, {
-      selector: property
+      selector: prop
     });
-    return currentValue - damage;
-  } else if (operation === 'increment'){
-    let currentValue = property.value - (property.damage || 0);
-    let currentDamage = property.damage;
-    let increment = value;
+    // Also write it straight to the prop so that it is updated in the actionContext
+    prop.damage = damage;
+    prop.value = newValue;
+    logFunction?.(newValue);
+  } else if (operation === 'increment') {
+    let currentValue = prop.value || 0;
+    let currentDamage = prop.damage || 0;
+    increment = value;
     // Can't increase damage above the remaining value
-    if (increment > currentValue) increment = currentValue;
+    if (increment > currentValue && !prop.ignoreLowerLimit) increment = currentValue;
     // Can't decrease damage below zero
-    if (-increment > currentDamage) increment = -currentDamage;
-    CreatureProperties.update(property._id, {
-      $inc: {damage: increment}
+    if (-increment > currentDamage && !prop.ignoreUpperLimit) increment = -currentDamage;
+    damage = currentDamage + increment;
+    newValue = prop.total - damage;
+    // Write the results
+    CreatureProperties.update(prop._id, {
+      $inc: { damage: increment, value: -increment },
+      $set: { dirty: true },
     }, {
-      selector: property
+      selector: prop
     });
+    // Also write it straight to the prop so that it is updated in the actionContext
+    prop.damage += increment;
+    prop.value -= increment;
+    logFunction?.(increment);
+  }
+
+  applyTriggers(actionContext.triggers?.damageProperty?.after, prop, actionContext);
+
+  if (operation === 'set') {
+    return damage;
+  } else if (operation === 'increment') {
     return increment;
   }
 }

app/imports/api/creature/creatureProperties/methods/dealDamage.js

@@ -1,73 +0,0 @@
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import SimpleSchema from 'simpl-schema';
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
-import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
-import { recomputeCreatureByDependencies } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-
-const dealDamage = new ValidatedMethod({
-  name: 'creatureProperties.dealDamage',
-  validate: new SimpleSchema({
-    creatureId: SimpleSchema.RegEx.Id,
-    damageType: {
-      type: String,
-    },
-    amount: Number,
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 20,
-    timeInterval: 5000,
-  },
-  run({creatureId, damageType, amount}) {
-    // permissions
-    let creature = Creatures.findOne(creatureId, {
-      fields: {
-        damageMultipliers: 1,
-        owner: 1,
-        readers: 1,
-        writers: 1,
-      },
-    });
-    assertEditPermission(creature, this.userId);
-
-    // Get all the health bars and do damage to them
-    let healthBars = CreatureProperties.find({
-      'ancestors.id': creatureId,
-      type: 'attribute',
-      attributeType:'healthBar',
-      removed: {$ne: true},
-      inactive: {$ne: true},
-    }, {
-      sort: {order: -1},
-    });
-    let multiplier = creature.damageMultipliers[damageType];
-    if (multiplier === undefined) multiplier = 1;
-    let totalDamage = Math.floor(amount * multiplier);
-    let damageLeft = totalDamage;
-    if (damageType === 'healing') damageLeft = -totalDamage;
-    let propertyIds = [];
-    let propertiesDependedAponIds = [];
-    healthBars.forEach(healthBar => {
-      if (damageLeft === 0) return;
-      let damageAdded = damagePropertyWork({
-        property: healthBar,
-        operation: 'increment',
-        value: damageLeft,
-      });
-      damageLeft -= damageAdded;
-      propertyIds.push(healthBar._id);
-      propertiesDependedAponIds.push(...healthBar.dependencies);
-    });
-    recomputeCreatureByDependencies({
-      creature,
-      propertyIds,
-      propertiesDependedAponIds,
-    });
-    return totalDamage;
-  },
-});
-
-export default dealDamage;

app/imports/api/creature/creatureProperties/methods/duplicateProperty.js

@@ -5,17 +5,14 @@ import CreatureProperties from '/imports/api/creature/creatureProperties/Creatur
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
 import {
-	setLineageOfDocs,
-	renewDocIds
+  setLineageOfDocs,
+  renewDocIds
 } from '/imports/api/parenting/parenting.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
 import { reorderDocs } from '/imports/api/parenting/order.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 var snackbar;
-if (Meteor.isClient){
+if (Meteor.isClient) {
   snackbar = require(
-    '/imports/ui/components/snackbars/SnackbarQueue.js'
+    '/imports/client/ui/components/snackbars/SnackbarQueue.js'
   ).snackbar
 }
 
@@ -34,7 +31,7 @@ const duplicateProperty = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({_id}) {
+  run({ _id }) {
     let property = CreatureProperties.findOne(_id);
     let creature = getRootCreatureAncestor(property);
 
@@ -45,19 +42,24 @@ const duplicateProperty = new ValidatedMethod({
     let propertyId = randomSrc.id();
     property._id = propertyId;
 
+    // Change the variableName so it isn't immediately overridden
+    if (property.variableName) {
+      property.variableName += 'Copy'
+    }
+
     // Get all the descendants
     let nodes = CreatureProperties.find({
-			'ancestors.id': _id,
-			removed: {$ne: true},
-		}, {
+      'ancestors.id': _id,
+      removed: { $ne: true },
+    }, {
       limit: DUPLICATE_CHILDREN_LIMIT + 1,
-      sort: {order: 1},
+      sort: { order: 1 },
     }).fetch();
 
     // Alert the user if the limit was hit
-    if (nodes.length > DUPLICATE_CHILDREN_LIMIT){
+    if (nodes.length > DUPLICATE_CHILDREN_LIMIT) {
       nodes.pop();
-      if (Meteor.isClient){
+      if (Meteor.isClient) {
         snackbar({
           text: `Only the first ${DUPLICATE_CHILDREN_LIMIT} children were duplicated`,
         });
@@ -66,22 +68,25 @@ const duplicateProperty = new ValidatedMethod({
 
     // re-map all the ancestors
     setLineageOfDocs({
-			docArray: nodes,
-			newAncestry : [
+      docArray: nodes,
+      newAncestry: [
         ...property.ancestors,
-        {id: propertyId, collection: 'creatureProperties'}
+        { id: propertyId, collection: 'creatureProperties' }
       ],
-			oldParent : {id: _id, collection: 'creatureProperties'},
-		});
+      oldParent: { id: _id, collection: 'creatureProperties' },
+    });
 
     // Give the docs new IDs without breaking internal references
-    renewDocIds({docArray: nodes});
+    renewDocIds({ docArray: nodes });
 
     // Order the root node
     property.order += 0.5;
 
+    // Mark the sheet as needing recompute
+    property.dirty = true;
+
     // Insert the properties
-		CreatureProperties.batchInsert([property, ...nodes]);
+    CreatureProperties.batchInsert([property, ...nodes]);
 
     // Tree structure changed by inserts, reorder the tree
     reorderDocs({
@@ -89,15 +94,6 @@ const duplicateProperty = new ValidatedMethod({
       ancestorId: property.ancestors[0].id,
     });
 
-    // Inserting the active status of the property needs to be denormalised
-    recomputeInactiveProperties(creature._id);
-
-    // Recompute the inventory
-    recomputeInventory(creature._id);
-
-    // Inserting a creature property invalidates dependencies: full recompute
-    recomputeCreatureByDoc(creature);
-
     return propertyId;
   },
 });

app/imports/api/creature/creatureProperties/methods/equipItem.js

@@ -4,17 +4,14 @@ import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import { organizeDoc } from '/imports/api/parenting/organizeMethods.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 import BUILT_IN_TAGS from '/imports/constants/BUILT_IN_TAGS.js';
 import getParentRefByTag from '/imports/api/creature/creatureProperties/methods/getParentRefByTag.js';
 
 // Equipping or unequipping an item will also change its parent
 const equipItem = new ValidatedMethod({
   name: 'creatureProperties.equip',
-  validate({_id, equipped}){
-		if (!_id) throw new Meteor.Error('No _id', '_id is required');
+  validate({ _id, equipped }) {
+    if (!_id) throw new Meteor.Error('No _id', '_id is required');
     if (equipped !== true && equipped !== false) {
       throw new Meteor.Error('No equipped', 'equipped is required to be true or false');
     }
@@ -24,20 +21,20 @@ const equipItem = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({_id, equipped}) {
+  run({ _id, equipped }) {
     let item = CreatureProperties.findOne(_id);
     if (item.type !== 'item') throw new Meteor.Error('wrong type',
-    'Equip and unequip can only be performed on items');
+      'Equip and unequip can only be performed on items');
     let creature = getRootCreatureAncestor(item);
     assertEditPermission(creature, this.userId);
     CreatureProperties.update(_id, {
-      $set: {equipped},
+      $set: { equipped, dirty: true },
     }, {
-			selector: {type: 'item'},
-		});
+      selector: { type: 'item' },
+    });
     let tag = equipped ? BUILT_IN_TAGS.equipment : BUILT_IN_TAGS.carried;
     let parentRef = getParentRefByTag(creature._id, tag);
-    if (!parentRef) parentRef = {id: creature._id, collection: 'creatures'};
+    if (!parentRef) parentRef = { id: creature._id, collection: 'creatures' };
 
     organizeDoc.call({
       docRef: {
@@ -48,10 +45,6 @@ const equipItem = new ValidatedMethod({
       order: Number.MAX_SAFE_INTEGER,
       skipRecompute: true,
     });
-
-    recomputeInactiveProperties(creature._id);
-    recomputeInventory(creature._id);
-    recomputeCreatureByDoc(creature);
   },
 });
 

app/imports/api/creature/creatureProperties/methods/flipToggle.js

@@ -0,0 +1,47 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+
+const flipToggle = new ValidatedMethod({
+  name: 'creatureProperties.flipToggle',
+  validate({ _id }) {
+    if (!_id) throw new Meteor.Error('No _id', '_id is required');
+  },
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({ _id }) {
+    // Permission
+    let property = CreatureProperties.findOne(_id, {
+      fields: { type: 1, ancestors: 1, enabled: 1, disabled: 1 }
+    });
+    if (property.type !== 'toggle') {
+      throw new Meteor.Error('wrong property',
+        'This method can only be applied to toggles');
+    }
+    if (!property.enabled && !property.disabled) {
+      throw new Meteor.Error('Computed toggle',
+        'Can\'t flip a toggle that is computed')
+    }
+    let rootCreature = getRootCreatureAncestor(property);
+    assertEditPermission(rootCreature, this.userId);
+
+    // Invert the current value, disabled is the canonical store of value
+    const currentValue = !property.disabled;
+    CreatureProperties.update(_id, {
+      $set: {
+        enabled: !currentValue,
+        disabled: currentValue,
+        dirty: true,
+      }
+    }, {
+      selector: { type: 'toggle' },
+    });
+  },
+});
+
+export default flipToggle;

app/imports/api/creature/creatureProperties/methods/getSlotFillFilter.js

@@ -0,0 +1,64 @@
+export default function getSlotFillFilter({ slot, libraryIds }) {
+
+  if (!slot) throw 'Slot is required for getSlotFillFilter';
+  if (!libraryIds) throw 'LibraryIds is required for getSlotFillFilter';
+
+  let filter = {
+    fillSlots: true,
+    removed: { $ne: true },
+    $and: []
+  };
+  filter['ancestors.id'] = { $in: libraryIds };
+  if (slot.slotType) {
+    filter.$and.push({
+      $or: [{
+        type: slot.slotType
+      }, {
+        slotFillerType: slot.slotType,
+      }]
+    });
+  } else if (slot.type === 'class') {
+    filter.$and.push({
+      $or: [{
+        type: 'classLevel',
+      }, {
+        slotFillerType: 'classLevel',
+      }]
+    });
+    if (slot.variableName) {
+      filter.variableName = slot.variableName;
+    }
+
+    // Only search for levels the class needs
+    if (slot.missingLevels && slot.missingLevels.length) {
+      filter.level = { $in: slot.missingLevels };
+    } else {
+      filter.level = { $gt: slot.level || 0 };
+    }
+  }
+  let tagsOr = [];
+  let tagsNin = [];
+  if (slot.slotTags && slot.slotTags.length) {
+    tagsOr.push({ libraryTags: { $all: slot.slotTags } });
+  }
+  if (slot.extraTags && slot.extraTags.length) {
+    slot.extraTags.forEach(extra => {
+      if (!extra.tags || !extra.tags.length) return;
+      if (extra.operation === 'OR') {
+        tagsOr.push({ libraryTags: { $all: extra.tags } });
+      } else if (extra.operation === 'NOT') {
+        tagsNin.push(...extra.tags);
+      }
+    });
+  }
+  if (tagsOr.length) {
+    filter.$or = tagsOr;
+  }
+  if (tagsNin.length) {
+    filter.$and.push({ libraryTags: { $nin: tagsNin } });
+  }
+  if (!filter.$and.length) {
+    delete filter.$and;
+  }
+  return filter;
+}

app/imports/api/creature/creatureProperties/methods/getSlotFillFilter.test.js

@@ -0,0 +1,85 @@
+import { assert } from 'chai';
+import getSlotFillFilter from '/imports/api/creature/creatureProperties/methods/getSlotFillFilter.js';
+
+describe('Slot fill filter', function () {
+
+  it('Gives error if arguments aren\'t provided', function () {
+    assert.throws(
+      () => getSlotFillFilter(undefined),
+      null, null, 'Passing undefined should give an error'
+    );
+    assert.throws(
+      () => getSlotFillFilter({
+        slot: { slotTags: ['tag1'] },
+      }),
+      null, null, 'Passing no libraryIds should give an error'
+    );
+    assert.throws(
+      () => getSlotFillFilter({
+        libraryIds: ['libraryId1'],
+      }),
+      null, null, 'Passing no slot should give an error'
+    );
+  });
+
+  it('filters using basic slot tags', function () {
+    const filter = getSlotFillFilter({
+      slot: {
+        slotTags: ['tag1', 'tag2']
+      },
+      libraryIds: ['libraryId1', 'libraryId2'],
+    });
+    assert.deepStrictEqual(filter, {
+      $or: [{
+        libraryTags: { $all: ['tag1', 'tag2'] }
+      }],
+      'ancestors.id': { $in: ['libraryId1', 'libraryId2'] },
+      removed: { $ne: true },
+      fillSlots: true,
+    });
+  });
+
+  it('filters using slot type', function () {
+    const filter = getSlotFillFilter({
+      slot: {
+        slotTags: ['tag1', 'tag2'],
+        slotType: 'feature',
+      },
+      libraryIds: ['libraryId1', 'libraryId2']
+    });
+    assert.deepStrictEqual(filter.$and, [{
+      $or: [{
+        type: 'feature'
+      }, {
+        slotFillerType: 'feature',
+      }],
+    }]);
+  });
+
+  it('filters using extra tags', function () {
+    const filter = getSlotFillFilter({
+      slot: {
+        slotTags: ['tag1', 'tag2'],
+        extraTags: [
+          { operation: 'OR', tags: ['tag3', 'tag4'] },
+          { operation: 'NOT', tags: ['tag5', 'tag6'] },
+          { operation: 'NOT', tags: ['tag7', 'tag8'] },
+        ],
+      },
+      libraryIds: ['libraryId1', 'libraryId2'],
+    });
+    assert.deepStrictEqual(filter, {
+      $or: [
+        { libraryTags: { $all: ['tag1', 'tag2'] } },
+        { libraryTags: { $all: ['tag3', 'tag4'] } },
+      ],
+      $and: [
+        { libraryTags: { $nin: ['tag5', 'tag6', 'tag7', 'tag8'] } },
+      ],
+      'ancestors.id': { $in: ['libraryId1', 'libraryId2'] },
+      removed: { $ne: true },
+      fillSlots: true,
+    });
+  });
+
+});

app/imports/api/creature/creatureProperties/methods/index.js

@@ -1,7 +1,6 @@
 import '/imports/api/creature/creatureProperties/methods/adjustQuantity.js';
-import '/imports/api/creature/creatureProperties/methods/damagePropertiesByName.js';
+import '/imports/api/creature/creatureProperties/methods/copyPropertyToLibrary.js';
 import '/imports/api/creature/creatureProperties/methods/damageProperty.js';
-import '/imports/api/creature/creatureProperties/methods/dealDamage.js';
 import '/imports/api/creature/creatureProperties/methods/duplicateProperty.js';
 import '/imports/api/creature/creatureProperties/methods/equipItem.js';
 import '/imports/api/creature/creatureProperties/methods/insertProperty.js';
@@ -12,3 +11,4 @@ import '/imports/api/creature/creatureProperties/methods/restoreProperty.js';
 import '/imports/api/creature/creatureProperties/methods/selectAmmoItem.js';
 import '/imports/api/creature/creatureProperties/methods/softRemoveProperty.js';
 import '/imports/api/creature/creatureProperties/methods/updateCreatureProperty.js';
+import '/imports/api/creature/creatureProperties/methods/flipToggle.js';

app/imports/api/creature/creatureProperties/methods/insertProperty.js

@@ -5,9 +5,6 @@ import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/ge
 import SimpleSchema from 'simpl-schema';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import { reorderDocs } from '/imports/api/parenting/order.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 import { getAncestry } from '/imports/api/parenting/parenting.js';
 import getParentRefByTag from '/imports/api/creature/creatureProperties/methods/getParentRefByTag.js';
 import { RefSchema } from '/imports/api/parenting/ChildSchema.js';
@@ -15,7 +12,7 @@ import { getHighestOrder } from '/imports/api/parenting/order.js';
 
 const insertProperty = new ValidatedMethod({
   name: 'creatureProperties.insert',
-	validate: new SimpleSchema({
+  validate: new SimpleSchema({
     creatureProperty: {
       type: Object,
       blackbox: true,
@@ -27,25 +24,25 @@ const insertProperty = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({creatureProperty, parentRef}) {
+  run({ creatureProperty, parentRef }) {
     // get the new ancestry for the properties
-		let {parentDoc, ancestors} = getAncestry({parentRef});
+    let { parentDoc, ancestors } = getAncestry({ parentRef });
 
-		// Check permission to edit
+    // Check permission to edit
     let rootCreature;
-		if (parentRef.collection === 'creatures'){
+    if (parentRef.collection === 'creatures') {
       rootCreature = parentDoc;
-		} else if (parentRef.collection === 'creatureProperties'){
+    } else if (parentRef.collection === 'creatureProperties') {
       rootCreature = getRootCreatureAncestor(parentDoc);
-		} else {
-			throw `${parentRef.collection} is not a valid parent collection`
-		}
+    } else {
+      throw `${parentRef.collection} is not a valid parent collection`
+    }
     assertEditPermission(rootCreature, this.userId);
 
     creatureProperty.parent = parentRef;
     creatureProperty.ancestors = ancestors;
 
-		return insertPropertyWork({
+    return insertPropertyWork({
       property: creatureProperty,
       creature: rootCreature,
     });
@@ -78,31 +75,31 @@ const insertPropertyAsChildOfTag = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({creatureProperty, creatureId, tag, tagDefaultName}) {
+  run({ creatureProperty, creatureId, tag, tagDefaultName }) {
     let parentRef = getParentRefByTag(creatureId, tag);
 
-    if (!parentRef){
+    if (!parentRef) {
       // Use the creature as the parent and mark that we need to insert the folder first later
       var insertFolderFirst = true;
-      parentRef = {id: creatureId, collection: 'creatures'};
+      parentRef = { id: creatureId, collection: 'creatures' };
     }
 
     // get the new ancestry for the properties
-		let {parentDoc, ancestors} = getAncestry({parentRef});
+    let { parentDoc, ancestors } = getAncestry({ parentRef });
 
     // Check permission to edit
     let rootCreature;
-		if (parentRef.collection === 'creatures'){
+    if (parentRef.collection === 'creatures') {
       rootCreature = parentDoc;
-		} else if (parentRef.collection === 'creatureProperties'){
+    } else if (parentRef.collection === 'creatureProperties') {
       rootCreature = getRootCreatureAncestor(parentDoc);
-		} else {
-			throw `${parentRef.collection} is not a valid parent collection`
-		}
+    } else {
+      throw `${parentRef.collection} is not a valid parent collection`
+    }
     assertEditPermission(rootCreature, this.userId);
 
     // Add the folder first if we need to
-    if (insertFolderFirst){
+    if (insertFolderFirst) {
       let order = getHighestOrder({
         collection: CreatureProperties,
         ancestorId: parentRef.id,
@@ -116,7 +113,7 @@ const insertPropertyAsChildOfTag = new ValidatedMethod({
         order,
       });
       // Make the folder our new parent
-      let newParentRef = {id, collection: 'creatureProperties'};
+      let newParentRef = { id, collection: 'creatureProperties' };
       ancestors = [parentRef, newParentRef];
       parentRef = newParentRef;
       creatureProperty.order = order + 1;
@@ -125,30 +122,22 @@ const insertPropertyAsChildOfTag = new ValidatedMethod({
     creatureProperty.parent = parentRef;
     creatureProperty.ancestors = ancestors;
 
-		return insertPropertyWork({
+    return insertPropertyWork({
       property: creatureProperty,
       creature: rootCreature,
     });
   },
 });
 
-export function insertPropertyWork({property, creature}){
+export function insertPropertyWork({ property, creature }) {
   delete property._id;
+  property.dirty = true;
   let _id = CreatureProperties.insert(property);
   // Tree structure changed by insert, reorder the tree
   reorderDocs({
     collection: CreatureProperties,
     ancestorId: creature._id,
   });
-  // Inserting the active status of the property needs to be denormalised
-  recomputeInactiveProperties(creature._id);
-
-  // Recompute the inventory if it has changed
-  if (property.type === 'item' || property.type === 'container'){
-    recomputeInventory(creature._id);
-  }
-  // Inserting a creature property invalidates dependencies: full recompute
-  recomputeCreatureByDoc(creature);
   return _id;
 }
 

app/imports/api/creature/creatureProperties/methods/insertPropertyFromLibraryNode.js

@@ -5,102 +5,66 @@ import CreatureProperties from '/imports/api/creature/creatureProperties/Creatur
 import LibraryNodes from '/imports/api/library/LibraryNodes.js';
 import { RefSchema } from '/imports/api/parenting/ChildSchema.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import {
-	setLineageOfDocs,
-	getAncestry,
-	renewDocIds
+  setLineageOfDocs,
+  getAncestry,
+  renewDocIds
 } from '/imports/api/parenting/parenting.js';
 import { reorderDocs } from '/imports/api/parenting/order.js';
 import { setDocToLastOrder } from '/imports/api/parenting/order.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 import fetchDocByRef from '/imports/api/parenting/fetchDocByRef.js';
 
 const insertPropertyFromLibraryNode = new ValidatedMethod({
-	name: 'creatureProperties.insertPropertyFromLibraryNode',
-	validate: new SimpleSchema({
-		nodeId: {
-			type: String,
-			regEx: SimpleSchema.RegEx.Id,
-		},
-		parentRef: {
-			type: RefSchema,
-		},
+  name: 'creatureProperties.insertPropertyFromLibraryNode',
+  validate: new SimpleSchema({
+    nodeIds: {
+      type: Array,
+      max: 20,
+    },
+    'nodeIds.$': {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+    parentRef: {
+      type: RefSchema,
+    },
     order: {
       type: Number,
       optional: true,
     },
-	}).validator(),
+  }).validator(),
   mixins: [RateLimiterMixin],
   rateLimit: {
     numRequests: 5,
     timeInterval: 5000,
   },
-	run({nodeId, parentRef, order}) {
-		// get the new ancestry for the properties
-		let {parentDoc, ancestors} = getAncestry({parentRef});
+  run({ nodeIds, parentRef, order }) {
+    // get the new ancestry for the properties
+    let { parentDoc, ancestors } = getAncestry({ parentRef });
 
-		// Check permission to edit
+    // Check permission to edit
     let rootCreature;
-		if (parentRef.collection === 'creatures'){
+    if (parentRef.collection === 'creatures') {
       rootCreature = parentDoc;
-		} else if (parentRef.collection === 'creatureProperties'){
+    } else if (parentRef.collection === 'creatureProperties') {
       rootCreature = getRootCreatureAncestor(parentDoc);
-		} else {
-			throw `${parentRef.collection} is not a valid parent collection`
-		}
+    } else {
+      throw `${parentRef.collection} is not a valid parent collection`
+    }
     assertEditPermission(rootCreature, this.userId);
 
-		// Fetch the library node and its decendents, provided they have not been
-		// removed
-    // TODO: Check permission to read the library this node is in
-		let node = LibraryNodes.findOne({
-			_id: nodeId,
-			removed: {$ne: true},
-		});
-		if (!node) throw `Node not found for nodeId: ${nodeId}`;
-		let oldParent = node.parent;
-		let nodes = LibraryNodes.find({
-			'ancestors.id': nodeId,
-			removed: {$ne: true},
-		}).fetch();
+    // {libraryId: hasViewPermission}
+    //let libraryPermissionMemoir = {};
+    let node;
+    nodeIds.forEach(nodeId => {
+      // TODO: Check library view permission for each node before starting
+      node = insertPropertyFromNode(nodeId, ancestors, order);
+      // Increment order, slightly, to keep the nodes inserted in the given id order
+      order += 0.001;
+    });
 
-    // Convert all references into actual nodes
-    nodes = reifyNodeReferences(nodes);
-
-    // The root node is first in the array of nodes
-    // It must get the first generated ID to prevent flickering
-		nodes = [node, ...nodes];
-
-		// re-map all the ancestors
-		setLineageOfDocs({
-			docArray: nodes,
-			newAncestry: ancestors,
-			oldParent,
-		});
-
-		// Give the docs new IDs without breaking internal references
-		renewDocIds({
-			docArray: nodes,
-			collectionMap: {'libraryNodes': 'creatureProperties'}
-		});
-
-		// Order the root node
-    if (order === undefined){
-      setDocToLastOrder({
-        collection: CreatureProperties,
-        doc: node,
-      });
-    } else {
-      node.order = order;
-    }
-
-		// Insert the creature properties
-    CreatureProperties.batchInsert(nodes);
-
-    // get the root inserted doc
+    // get one of the root inserted docs
     let rootId = node._id;
 
     // Tree structure changed by inserts, reorder the tree
@@ -108,43 +72,105 @@ const insertPropertyFromLibraryNode = new ValidatedMethod({
       collection: CreatureProperties,
       ancestorId: rootCreature._id,
     });
-
-    // The library properties need to denormalise which of them are inactive
-    recomputeInactiveProperties(rootId);
-    // Some of the library properties may be items or containers
-    recomputeInventory(rootCreature._id);
-		// Inserting a creature property invalidates dependencies: full recompute
-    recomputeCreatureByDoc(rootCreature);
-		// Return the docId of the last property, the inserted root property
-		return rootId;
-	},
+    // Return the docId of the last property, the inserted root property
+    return rootId;
+  },
 });
 
+function insertPropertyFromNode(nodeId, ancestors, order) {
+  // Fetch the library node and its decendents, provided they have not been
+  // removed
+  // TODO: Check permission to read the library this node is in
+  let node = LibraryNodes.findOne({
+    _id: nodeId,
+    removed: { $ne: true },
+  });
+  if (!node) {
+    if (Meteor.isClient) return;
+    else {
+      throw new Meteor.Error(
+        'Insert property from library failed',
+        `No library document with id '${nodeId}' was found`
+      );
+    }
+  }
+  let oldParent = node.parent;
+  let nodes = LibraryNodes.find({
+    'ancestors.id': nodeId,
+    removed: { $ne: true },
+  }).fetch();
+
+
+  // The root node is first in the array of nodes
+  // It must get the first generated ID to prevent flickering
+  nodes = [node, ...nodes];
+
+  // Convert all references into actual nodes
+  nodes = reifyNodeReferences(nodes);
+
+  // set libraryNodeIds
+  storeLibraryNodeReferences(nodes);
+
+  // re-map all the ancestors
+  setLineageOfDocs({
+    docArray: nodes,
+    newAncestry: ancestors,
+    oldParent,
+  });
+
+  // Give the docs new IDs without breaking internal references
+  renewDocIds({
+    docArray: nodes,
+    collectionMap: { 'libraryNodes': 'creatureProperties' }
+  });
+
+  // Order the root node
+  if (order === undefined) {
+    setDocToLastOrder({
+      collection: CreatureProperties,
+      doc: node,
+    });
+  } else {
+    node.order = order;
+  }
+
+  // Mark all nodes as dirty
+  dirtyNodes(nodes);
+
+  // Insert the creature properties
+  CreatureProperties.batchInsert(nodes);
+  return node;
+}
+
+function storeLibraryNodeReferences(nodes) {
+  nodes.forEach(node => {
+    if (node.libraryNodeId) return;
+    node.libraryNodeId = node._id;
+  });
+}
+
+function dirtyNodes(nodes) {
+  nodes.forEach(node => {
+    node.dirty = true;
+  });
+}
+
 // Covert node references into actual nodes
 // TODO: check permissions for each library a reference node references
-function reifyNodeReferences(nodes, visitedRefs = new Set(), depth = 0){
+function reifyNodeReferences(nodes, visitedRefs = new Set(), depth = 0) {
   depth += 1;
   // New nodes added this function
   let newNodes = [];
 
   // Filter out the reference nodes we replace
   let resultingNodes = nodes.filter(node => {
-
-    // We have already visited this ref and replaced it
-    if (visitedRefs.has(node._id)) return false;
-
-    // Already replaced an ancestor node
-    for (let i; i < node.ancestors.length; i++){
-      if (visitedRefs.has(node.ancestors[i].id)) return false;
-    }
-
     // This isn't a reference node, continue as normal
     if (node.type !== 'reference') return true;
 
     // We have gone too deep, keep the reference node as an error
-    if (depth > 10){
+    if (depth >= 10) {
       if (Meteor.isClient) console.warn('Reference depth limit exceeded');
-      node.cache = {error: 'Reference depth limit exceeded'};
+      node.cache = { error: 'Reference depth limit exceeded' };
       return true;
     }
 
@@ -154,17 +180,17 @@ function reifyNodeReferences(nodes, visitedRefs = new Set(), depth = 0){
       referencedNode.order = node.order;
       // We are definitely replacing this node, so add it to the list
       visitedRefs.add(node._id);
-    } catch (e){
-      node.cache = {error: e.reason || e.message || e.toString()};
+    } catch (e) {
+      node.cache = { error: e.reason || e.message || e.toString() };
       return true;
     }
 
     // Get all the descendants of the referenced node
     let descendents = LibraryNodes.find({
       'ancestors.id': referencedNode._id,
-      removed: {$ne: true},
+      removed: { $ne: true },
     }, {
-      sort: {order: 1},
+      sort: { order: 1 },
     }).fetch();
 
     // We are adding the referenced node and its descendants
@@ -172,29 +198,37 @@ function reifyNodeReferences(nodes, visitedRefs = new Set(), depth = 0){
 
     // re-map all the ancestors to parent the new sub-tree into our existing
     // node tree
-		setLineageOfDocs({
-			docArray: addedNodes,
-			newAncestry: node.ancestors,
-			oldParent: referencedNode.parent,
-		});
-
-    // Remove all the looped references and descendents from the new nodes
-    // We can't rely on the reify recursion to do this, since the IDs are
-    // getting renewed before it is called
-    addedNodes = addedNodes.filter(node => {
-      // Exclude removed referenced
-      if (visitedRefs.has(node._id)) return false;
-
-      // Exclude descendants of removed references
-      for (let i; i < node.ancestors.length; i++){
-        if (visitedRefs.has(node.ancestors[i].id)) return false;
-      }
-      return true;
+    setLineageOfDocs({
+      docArray: addedNodes,
+      newAncestry: node.ancestors,
+      oldParent: referencedNode.parent,
     });
 
+    // Filter all the looped references
+    addedNodes = addedNodes.filter(addedNode => {
+      // Add all non-reference nodes
+      if (addedNode.type !== 'reference') {
+        return true;
+      }
+      // If this exact reference has already been resolved before, filter it out
+      if (visitedRefs.has(addedNode._id)) {
+        return false;
+      } else {
+        // Otherwise mark it as visited, and keep it
+        visitedRefs.add(addedNode._id);
+        return true;
+      }
+    });
+
+    // Before renewing Ids make sure the library node reference is stored
+    storeLibraryNodeReferences(addedNodes);
+
     // Give the new referenced sub-tree new ids
+    // The referenced node must get the id of the ref node so that the
+    // descendants of the ref node keep their ancestry intact
     renewDocIds({
       docArray: addedNodes,
+      idMap: { [referencedNode._id]: node._id },
     });
 
     // Reify the subtree as well with recursion

app/imports/api/creature/creatureProperties/methods/pullFromProperty.js

@@ -3,34 +3,30 @@ import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 
 const pullFromProperty = new ValidatedMethod({
-	name: 'creatureProperties.pull',
-	validate: null,
+  name: 'creatureProperties.pull',
+  validate: null,
   mixins: [RateLimiterMixin],
   rateLimit: {
     numRequests: 5,
     timeInterval: 5000,
   },
-	run({_id, path, itemId}){
+  run({ _id, path, itemId }) {
     // Permissions
-		let property = CreatureProperties.findOne(_id);
+    let property = CreatureProperties.findOne(_id);
     let rootCreature = getRootCreatureAncestor(property);
     assertEditPermission(rootCreature, this.userId);
 
     // Do work
-		CreatureProperties.update(_id, {
-			$pull: {[path.join('.')]: {_id: itemId}},
-		}, {
-			selector: {type: property.type},
-			getAutoValues: false,
-		});
-
-    // TODO figure out if this method can change deps or not
-    recomputeCreatureByDoc(rootCreature);
-    // recomputePropertyDependencies(property);
-	}
+    CreatureProperties.update(_id, {
+      $pull: { [path.join('.')]: { _id: itemId } },
+      $set: { dirty: true }
+    }, {
+      selector: { type: property.type },
+      getAutoValues: false,
+    });
+  }
 });
 
 export default pullFromProperty;

app/imports/api/creature/creatureProperties/methods/pushToProperty.js

@@ -3,33 +3,47 @@ import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import { get } from 'lodash';
 
 const pushToProperty = new ValidatedMethod({
-	name: 'creatureProperties.push',
-	validate: null,
+  name: 'creatureProperties.push',
+  validate: null,
   mixins: [RateLimiterMixin],
   rateLimit: {
     numRequests: 5,
     timeInterval: 5000,
   },
-	run({_id, path, value}){
+  run({ _id, path, value }) {
     // Permissions
-		let property = CreatureProperties.findOne(_id);
+    let property = CreatureProperties.findOne(_id);
     let rootCreature = getRootCreatureAncestor(property);
     assertEditPermission(rootCreature, this.userId);
 
-    // Do work
-		CreatureProperties.update(_id, {
-			$push: {[path.join('.')]: value},
-		}, {
-			selector: {type: property.type},
-		});
+    let joinedPath = path.join('.');
 
-    // TODO figure out if this method can change deps or not
-    recomputeCreatureByDoc(rootCreature);
-    // recomputePropertyDependencies(property);
-	}
+    // Respect maxCount
+    let schema = CreatureProperties.simpleSchema(property);
+    let maxCount = schema.get(joinedPath, 'maxCount');
+
+    if (Number.isFinite(maxCount)) {
+      let array = get(property, path);
+      let currentCount = array ? array.length : 0;
+      if (currentCount >= maxCount) {
+        throw new Meteor.Error(
+          'Array is full',
+          `Cannot have more than ${maxCount} values`
+        );
+      }
+    }
+
+    // Do work
+    CreatureProperties.update(_id, {
+      $push: { [joinedPath]: value },
+      $set: { dirty: true },
+    }, {
+      selector: { type: property.type },
+    });
+  }
 });
 
 export default pushToProperty;

app/imports/api/creature/creatureProperties/methods/restoreProperty.js

@@ -5,36 +5,32 @@ import CreatureProperties from '/imports/api/creature/creatureProperties/Creatur
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import { restore } from '/imports/api/parenting/softRemove.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 
 const restoreProperty = new ValidatedMethod({
-	name: 'creatureProperties.restore',
-	validate: new SimpleSchema({
-		_id: SimpleSchema.RegEx.Id
-	}).validator(),
+  name: 'creatureProperties.restore',
+  validate: new SimpleSchema({
+    _id: SimpleSchema.RegEx.Id
+  }).validator(),
   mixins: [RateLimiterMixin],
   rateLimit: {
     numRequests: 5,
     timeInterval: 5000,
   },
-	run({_id}){
+  run({ _id }) {
     // Permissions
-		let property = CreatureProperties.findOne(_id);
+    let property = CreatureProperties.findOne(_id);
     let rootCreature = getRootCreatureAncestor(property);
     assertEditPermission(rootCreature, this.userId);
 
     // Do work
-    restore({_id, collection: CreatureProperties});
-
-    // Items and containers might be restored
-    recomputeInventory(rootCreature._id);
-    // Parents active status may have changed while it was deleted
-    recomputeInactiveProperties(rootCreature._id);
-    // Changes dependency tree by restoring children
-    recomputeCreatureByDoc(rootCreature);
-	}
+    restore({
+      _id,
+      collection: CreatureProperties,
+      extraUpdates: {
+        $set: { dirty: true }
+      },
+    });
+  }
 });
 
 export default restoreProperty;

app/imports/api/creature/creatureProperties/methods/selectAmmoItem.js

@@ -4,7 +4,6 @@ import SimpleSchema from 'simpl-schema';
 import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 
 const selectAmmoItem = new ValidatedMethod({
   name: 'creatureProperties.selectAmmoItem',
@@ -18,34 +17,29 @@ const selectAmmoItem = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({actionId, itemId, itemConsumedIndex}) {
+  run({ actionId, itemId, itemConsumedIndex }) {
     // Permissions
-		let action = CreatureProperties.findOne(actionId);
+    let action = CreatureProperties.findOne(actionId);
     let rootCreature = getRootCreatureAncestor(action);
-		assertEditPermission(rootCreature, this.userId);
+    assertEditPermission(rootCreature, this.userId);
 
     // Check that this index has a document to edit
     let itemConsumed = action.resources.itemsConsumed[itemConsumedIndex];
-    if (!itemConsumed){
+    if (!itemConsumed) {
       throw new Meteor.Error('Resouce not found',
         'Could not set ammo, because the ammo document was not found');
     }
     let itemToLink = CreatureProperties.findOne(itemId);
-    if (!itemToLink){
+    if (!itemToLink) {
       throw new Meteor.Error('Item not found',
         'Could not set ammo: the item was not found');
     }
     let path = `resources.itemsConsumed.${itemConsumedIndex}.itemId`;
     CreatureProperties.update(actionId, {
-      $set: {[path]: itemId}
+      $set: { [path]: itemId, dirty: true }
     }, {
       selector: action,
     });
-
-    // Changing the linked item does change the dependency tree
-    // TODO: We can predict exactly which deps will be affected instead of
-    //       recomputing the entire creature
-    recomputeCreatureByDoc(rootCreature);
   },
 });
 

app/imports/api/creature/creatureProperties/methods/softRemoveProperty.js

@@ -5,33 +5,26 @@ import CreatureProperties from '/imports/api/creature/creatureProperties/Creatur
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import { softRemove } from '/imports/api/parenting/softRemove.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 
 const softRemoveProperty = new ValidatedMethod({
-	name: 'creatureProperties.softRemove',
-	validate: new SimpleSchema({
-		_id: SimpleSchema.RegEx.Id
-	}).validator(),
+  name: 'creatureProperties.softRemove',
+  validate: new SimpleSchema({
+    _id: SimpleSchema.RegEx.Id
+  }).validator(),
   mixins: [RateLimiterMixin],
   rateLimit: {
     numRequests: 5,
     timeInterval: 5000,
   },
-	run({_id}){
+  run({ _id }) {
     // Permissions
-		let property = CreatureProperties.findOne(_id);
+    let property = CreatureProperties.findOne(_id);
     let rootCreature = getRootCreatureAncestor(property);
     assertEditPermission(rootCreature, this.userId);
 
     // Do work
-		softRemove({_id, collection: CreatureProperties});
-
-    // Potentially changes items and containers
-    recomputeInventory(rootCreature._id);
-    // Changes dependency tree by removing children
-    recomputeCreatureByDoc(rootCreature);
-	}
+    softRemove({ _id, collection: CreatureProperties });
+  }
 });
 
 export default softRemoveProperty;

app/imports/api/creature/creatureProperties/methods/updateCreatureProperty.js

@@ -3,34 +3,31 @@ import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
-import { recomputeCreatureById } from '/imports/api/creature/computation/methods/recomputeCreature.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
-import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 
 const updateCreatureProperty = new ValidatedMethod({
   name: 'creatureProperties.update',
-  validate({_id, path}){
-		if (!_id) throw new Meteor.Error('No _id', '_id is required');
-		// We cannot change these fields with a simple update
-		switch (path[0]){
-			case 'type':
+  validate({ _id, path }) {
+    if (!_id) throw new Meteor.Error('No _id', '_id is required');
+    // We cannot change these fields with a simple update
+    switch (path[0]) {
+      case 'type':
       case 'order':
       case 'parent':
       case 'ancestors':
-			case 'damage':
-				throw new Meteor.Error('Permission denied',
-				'This property can\'t be updated directly');
-		}
+      case 'damage':
+        throw new Meteor.Error('Permission denied',
+          'This property can\'t be updated directly');
+    }
   },
   mixins: [RateLimiterMixin],
   rateLimit: {
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({_id, path, value}) {
+  run({ _id, path, value }) {
     // Permission
     let property = CreatureProperties.findOne(_id, {
-      fields: {type: 1, ancestors: 1}
+      fields: { type: 1, ancestors: 1 }
     });
     let rootCreature = getRootCreatureAncestor(property);
     assertEditPermission(rootCreature, this.userId);
@@ -38,29 +35,14 @@ const updateCreatureProperty = new ValidatedMethod({
     let pathString = path.join('.');
     let modifier;
     // unset empty values
-    if (value === null || value === undefined){
-      modifier = {$unset: {[pathString]: 1}};
+    if (value === null || value === undefined) {
+      modifier = { $unset: { [pathString]: 1 }, $set: { dirty: true } };
     } else {
-      modifier = {$set: {[pathString]: value}};
+      modifier = { $set: { [pathString]: value, dirty: true } };
     }
-		CreatureProperties.update(_id, modifier, {
-			selector: {type: property.type},
-		});
-
-    // Some updates might cause other properties to become inactive
-    if ([
-      'applied', 'equipped', 'prepared', 'alwaysPrepared', 'disabled'
-    ].includes(path[0])){
-      recomputeInactiveProperties(rootCreature._id);
-    }
-
-    if (property.type === 'item' || property.type === 'container'){
-      // Potentially changes items and containers
-      recomputeInventory(rootCreature._id);
-    }
-    // Updating a property is likely to change dependencies, do a full recompute
-    // denormalised stats might change, so fetch the creature again
-    recomputeCreatureById(rootCreature._id);
+    CreatureProperties.update(_id, modifier, {
+      selector: { type: property.type },
+    });
   },
 });
 

app/imports/api/creature/creatureProperties/recomputeCreaturesByProperty.js

@@ -1,12 +1,12 @@
-import { recomputeCreatureById } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import computeCreature from '/imports/api/engine/computeCreature.js';
 
 /**
  * Recomputes all ancestor creatures of this property
  */
 export default function recomputeCreaturesByProperty(property){
-	for (let ref of property.ancestors){
-		if (ref.collection === 'creatures') {
-			recomputeCreatureById.call(ref.id);
-		}
-	}
+  for (let ref of property.ancestors){
+    if (ref.collection === 'creatures') {
+      computeCreature.call(ref.id);
+    }
+  }
 }

app/imports/api/creature/creatures/CreatureVariables.js

@@ -0,0 +1,21 @@
+//set up the collection for creature variables
+let CreatureVariables = new Mongo.Collection('creatureVariables');
+
+// Unique index on _creatureId
+if (Meteor.isServer) {
+  CreatureVariables._ensureIndex({ _creatureId: 1 }, { unique: true })
+}
+
+/** No schema because the structure isn't known until compute time
+ * Expect documents to looke like:
+ * {
+ *   _id: "nE8Ngd6K4L4jSxLY2",
+ *   _creatureId: "nE8Ngd6K4L4jSxLY2", // indexed reference to the creature
+ *   explicitlyDefinedVariableName: {...some creatureProperty}
+ *   implicitVariableName: {value: 10},
+ *   undefinedVariableName: {},
+ * }
+ * Where top level fields that don't start with `_` are variables on the sheet
+**/
+
+export default CreatureVariables;

app/imports/api/creature/creatures/Creatures.js

@@ -0,0 +1,198 @@
+import SimpleSchema from 'simpl-schema';
+import deathSaveSchema from '/imports/api/properties/subSchemas/DeathSavesSchema.js'
+import ColorSchema from '/imports/api/properties/subSchemas/ColorSchema.js';
+import SharingSchema from '/imports/api/sharing/SharingSchema.js';
+import STORAGE_LIMITS from '/imports/constants/STORAGE_LIMITS.js';
+
+//set up the collection for creatures
+let Creatures = new Mongo.Collection('creatures');
+
+let CreatureSettingsSchema = new SimpleSchema({
+  //slowed down by carrying too much?
+  useVariantEncumbrance: {
+    type: Boolean,
+    optional: true,
+  },
+  //hide spellcasting tab
+  hideSpellcasting: {
+    type: Boolean,
+    optional: true,
+  },
+  //hide rest buttons
+  hideRestButtons: {
+    type: Boolean,
+    optional: true,
+  },
+  // Swap around the modifier and stat
+  swapStatAndModifier: {
+    type: Boolean,
+    optional: true,
+  },
+  // Hide all the unused stats
+  hideUnusedStats: {
+    type: Boolean,
+    optional: true,
+  },
+  // Show the tree tab
+  showTreeTab: {
+    type: Boolean,
+    optional: true,
+  },
+  // Hide the spells tab
+  hideSpellsTab: {
+    type: Boolean,
+    optional: true,
+  },
+  // Hide calculation errors
+  hideCalculationErrors: {
+    type: Boolean,
+    optional: true,
+  },
+  // How much each hitDice resets on a long rest
+  hitDiceResetMultiplier: {
+    type: Number,
+    optional: true,
+    min: 0,
+    max: 1,
+  },
+  discordWebhook: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.url,
+  },
+});
+
+let CreatureSchema = new SimpleSchema({
+  // Strings
+  name: {
+    type: String,
+    defaultValue: '',
+    optional: true,
+    max: STORAGE_LIMITS.name,
+  },
+  alignment: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.name,
+  },
+  gender: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.name,
+  },
+  picture: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.url,
+  },
+  avatarPicture: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.url,
+  },
+
+  // Libraries
+  allowedLibraries: {
+    type: Array,
+    optional: true,
+    maxCount: 100,
+  },
+  'allowedLibraries.$': {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+  allowedLibraryCollections: {
+    type: Array,
+    optional: true,
+    maxCount: 100,
+  },
+  'allowedLibraryCollections.$': {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+
+  // Mechanics
+  deathSave: {
+    type: deathSaveSchema,
+    defaultValue: {},
+  },
+  // Stats that are computed and denormalised outside of recomputation
+  denormalizedStats: {
+    type: Object,
+    defaultValue: {},
+  },
+  // Sum of all XP gained by this character
+  'denormalizedStats.xp': {
+    type: SimpleSchema.Integer,
+    defaultValue: 0,
+  },
+  // Sum of all levels granted by milestone XP
+  'denormalizedStats.milestoneLevels': {
+    type: SimpleSchema.Integer,
+    defaultValue: 0,
+  },
+  // Does the character need a recompute?
+  dirty: {
+    type: Boolean,
+    optional: true,
+  },
+  // Version of computation engine that was last used to compute this creature
+  computeVersion: {
+    type: String,
+    optional: true,
+  },
+  type: {
+    type: String,
+    defaultValue: 'pc',
+    allowedValues: ['pc', 'npc', 'monster'],
+  },
+  damageMultipliers: {
+    type: Object,
+    blackbox: true,
+    defaultValue: {}
+  },
+  computeErrors: {
+    type: Array,
+    optional: true,
+  },
+  'computeErrors.$': {
+    type: Object,
+  },
+  'computeErrors.$.type': {
+    type: String,
+  },
+  'computeErrors.$.details': {
+    type: Object,
+    blackbox: true,
+    optional: true,
+  },
+
+  // Tabletop
+  tabletop: {
+    type: String,
+    regEx: SimpleSchema.RegEx.id,
+    optional: true,
+  },
+  initiativeRoll: {
+    type: SimpleSchema.Integer,
+    optional: true,
+  },
+
+  // Settings
+  settings: {
+    type: CreatureSettingsSchema,
+    defaultValue: {},
+  },
+});
+
+CreatureSchema.extend(ColorSchema);
+CreatureSchema.extend(SharingSchema);
+
+Creatures.attachSchema(CreatureSchema);
+
+
+
+export default Creatures;
+export { CreatureSchema };
+
+import '/imports/api/engine/actions/doAction.js';

app/imports/api/creature/creatures/creaturePermissions.js

@@ -1,4 +1,4 @@
-import Creatures from '/imports/api/creature/Creatures.js';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
 import {
   assertEditPermission as editPermission,
   assertViewPermission as viewPermission,

app/imports/api/creature/creatures/defaultCharacterProperties.js

@@ -10,10 +10,10 @@ export default function defaultCharacterProperties(creatureId){
     {
       type: 'propertySlot',
       name: 'Ruleset',
-      description: 'Choose a starting point for your character, this will define the basic setup of your character sheet. Without a base, your sheet will be empty.',
+      description: {text: 'Choose a starting point for your character, this will define the basic setup of your character sheet. Without a base ruleset, your sheet will be empty.'},
       slotTags: ['base'],
       tags: [],
-      quantityExpected: 1,
+      quantityExpected: {calculation: '1'},
       hideWhenFull: true,
       spaceLeft: 1,
       totalFilled: 0,

app/imports/api/creature/creatures/getCreatureUrlName.js

@@ -0,0 +1,5 @@
+import getSlug from 'speakingurl';
+
+export default function getCreatureUrlName({name}){
+  return getSlug(name, {maintainCase: true}) || '-';
+}

app/imports/api/creature/creatures/methods/assertHasCharacterSlots.js

@@ -0,0 +1,22 @@
+import { getUserTier } from '/imports/api/users/patreon/tiers.js';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
+
+export default function assertHasCharactersSlots(userId) {
+  if (characterSlotsRemaining(userId) <= 0) {
+    throw new Meteor.Error('characterSlotLimit',
+      'No character slots left')
+  }
+}
+
+export function characterSlotsRemaining(userId) {
+  let tier = getUserTier(userId);
+  const currentCharacterCount = Creatures.find({
+    owner: userId,
+  }, {
+    fields: { _id: 1 },
+  }).count();
+  if (tier.characterSlots === -1) {
+    return Number.POSITIVE_INFINITY;
+  }
+  return tier.characterSlots - currentCharacterCount;
+}

app/imports/api/creature/creatures/methods/changeAllowedLibraries.js

@@ -0,0 +1,90 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import SimpleSchema from 'simpl-schema';
+import simpleSchemaMixin from '/imports/api/creature/mixins/simpleSchemaMixin.js';
+
+const changeAllowedLibraries = new ValidatedMethod({
+  name: 'creatures.changeAllowedLibraries',
+  mixins: [RateLimiterMixin, simpleSchemaMixin],
+  schema: new SimpleSchema({
+    _id: {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+    allowedLibraries: {
+      type: Array,
+      optional: true,
+      maxCount: 100,
+    },
+    'allowedLibraries.$': {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+    allowedLibraryCollections: {
+      type: Array,
+      optional: true,
+      maxCount: 100,
+    },
+    'allowedLibraryCollections.$': {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+  }),
+  rateLimit: {
+    numRequests: 10,
+    timeInterval: 5000,
+  },
+  run({ _id, allowedLibraries, allowedLibraryCollections }) {
+    let creature = Creatures.findOne(_id);
+    assertEditPermission(creature, this.userId);
+    let $set;
+    if (allowedLibraries) {
+      $set = { allowedLibraries }
+    }
+    if (allowedLibraryCollections) {
+      if (!$set) $set = {};
+      $set.allowedLibraryCollections = allowedLibraryCollections;
+    }
+    if (!$set) return;
+    Creatures.update(_id, { $set });
+  },
+});
+
+const toggleAllUserLibraries = new ValidatedMethod({
+  name: 'creatures.removeLibraryLimits',
+  mixins: [RateLimiterMixin, simpleSchemaMixin],
+  schema: new SimpleSchema({
+    _id: {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+    value: {
+      type: Boolean,
+    },
+  }),
+  rateLimit: {
+    numRequests: 10,
+    timeInterval: 5000,
+  },
+  run({ _id, value }) {
+    if (value) {
+      Creatures.update(_id, {
+        $unset: {
+          allowedLibraryCollections: 1,
+          allowedLibraries: 1,
+        },
+      });
+    } else {
+      Creatures.update(_id, {
+        $set: {
+          allowedLibraryCollections: [],
+          allowedLibraries: [],
+        },
+      });
+    }
+  },
+});
+
+export { changeAllowedLibraries, toggleAllUserLibraries };

app/imports/api/creature/creatures/methods/index.js

@@ -0,0 +1,5 @@
+import '/imports/api/creature/creatures/methods/insertCreature.js';
+import '/imports/api/creature/creatures/methods/removeCreature.js';
+import '/imports/api/creature/creatures/methods/restCreature.js';
+import '/imports/api/creature/creatures/methods/updateCreature.js';
+import '/imports/api/creature/creatures/methods/changeAllowedLibraries.js';

app/imports/api/creature/creatures/methods/insertCreature.js

@@ -0,0 +1,104 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import simpleSchemaMixin from '/imports/api/creature/mixins/simpleSchemaMixin.js';
+import Creatures, { CreatureSchema } from '/imports/api/creature/creatures/Creatures.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import defaultCharacterProperties from '/imports/api/creature/creatures/defaultCharacterProperties.js';
+import insertPropertyFromLibraryNode from '/imports/api/creature/creatureProperties/methods/insertPropertyFromLibraryNode.js';
+import assertHasCharactersSlots from '/imports/api/creature/creatures/methods/assertHasCharacterSlots.js';
+import getSlotFillFilter from '/imports/api/creature/creatureProperties/methods/getSlotFillFilter.js';
+import getCreatureLibraryIds from '/imports/api/library/getCreatureLibraryIds.js';
+import LibraryNodes from '/imports/api/library/LibraryNodes.js';
+import { insertExperienceForCreature } from '/imports/api/creature/experience/Experiences.js';
+import SimpleSchema from 'simpl-schema';
+
+const insertCreature = new ValidatedMethod({
+  name: 'creatures.insertCreature',
+  mixins: [RateLimiterMixin, simpleSchemaMixin],
+  schema: CreatureSchema.pick(
+    'name',
+    'gender',
+    'alignment',
+    'allowedLibraries',
+    'allowedLibraryCollections',
+  ).extend({
+    'startingLevel': {
+      type: SimpleSchema.Integer,
+      min: 0,
+    },
+  }),
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+
+  run({ name, gender, alignment, startingLevel,
+    allowedLibraries, allowedLibraryCollections }) {
+    const userId = this.userId
+    if (!userId) {
+      throw new Meteor.Error('Creatures.methods.insert.denied',
+        'You need to be logged in to insert a creature');
+    }
+
+    assertHasCharactersSlots(userId);
+
+    // Create the creature document
+    let creatureId = Creatures.insert({
+      owner: userId,
+      name,
+      gender,
+      alignment,
+      allowedLibraries,
+      allowedLibraryCollections,
+    });
+
+    // Insert experience to get character to starting level
+    if (startingLevel) {
+      insertExperienceForCreature({
+        experience: {
+          name: 'Starting level',
+          levels: startingLevel,
+          creatureId
+        },
+        creatureId,
+        userId,
+      });
+    }
+
+    // Insert the default properties
+    // Not batchInsert because we want the properties cleaned by the schema
+    let baseId, rulesetSlot;
+    defaultCharacterProperties(creatureId).forEach(prop => {
+      let id = CreatureProperties.insert(prop);
+      if (prop.name === 'Ruleset') {
+        baseId = id;
+        rulesetSlot = prop;
+      }
+    });
+
+    // If the user only has a single ruleset subscribed, use it by default
+    if (Meteor.isServer) {
+      insertDefaultRuleset(creatureId, baseId, userId, rulesetSlot);
+    }
+
+    return creatureId;
+  },
+});
+
+// If the user only has a single ruleset subscribed, insert it by default
+function insertDefaultRuleset(creatureId, baseId, userId, slot) {
+  const libraryIds = getCreatureLibraryIds(creatureId, userId);
+  const filter = getSlotFillFilter({ slot, libraryIds });
+  const fillCursor = LibraryNodes.find(filter, { fields: { _id: 1 } });
+  const numRulesets = fillCursor.count();
+  if (numRulesets === 1) {
+    const ruleset = fillCursor.fetch()[0]
+    insertPropertyFromLibraryNode.call({
+      nodeIds: [ruleset._id],
+      parentRef: { id: baseId, collection: 'creatureProperties' },
+      order: 0.5,
+    });
+  }
+}
+
+export default insertCreature;

app/imports/api/creature/creatures/methods/removeCreature.js

@@ -1,13 +1,15 @@
 import SimpleSchema from 'simpl-schema';
 import { ValidatedMethod } from 'meteor/mdg:validated-method';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import { assertOwnership } from '/imports/api/creature/creaturePermissions.js';
-import Creatures from '/imports/api/creature/Creatures.js';
+import { assertOwnership } from '/imports/api/creature/creatures/creaturePermissions.js';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
+import CreatureVariables from '/imports/api/creature/creatures/CreatureVariables.js';
 import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import CreatureLogs from '/imports/api/creature/log/CreatureLogs.js';
 import Experiences from '/imports/api/creature/experience/Experiences.js';
 
 function removeRelatedDocuments(creatureId){
+  CreatureVariables.remove({_creatureId: creatureId});
   CreatureProperties.remove({'ancestors.id': creatureId});
   CreatureLogs.remove({creatureId});
   Experiences.remove({creatureId});

app/imports/api/creature/creatures/methods/restCreature.js

@@ -0,0 +1,170 @@
+import SimpleSchema from 'simpl-schema';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { assertEditPermission } from '/imports/api/creature/creatures/creaturePermissions.js';
+import { union } from 'lodash';
+import ActionContext from '/imports/api/engine/actions/ActionContext.js';
+import { applyTriggers } from '/imports/api/engine/actions/applyTriggers.js';
+import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
+
+const restCreature = new ValidatedMethod({
+  name: 'creature.methods.rest',
+  validate: new SimpleSchema({
+    creatureId: {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    },
+    restType: {
+      type: String,
+      allowedValues: ['shortRest', 'longRest'],
+    },
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({ creatureId, restType }) {
+    // Get action context
+    const actionContext = new ActionContext(creatureId, [creatureId], this);
+    // Check permissions
+    assertEditPermission(actionContext.creature, this.userId);
+
+    // Join, sort, and apply before triggers
+    const beforeTriggers = union(
+      actionContext.triggers.anyRest?.before, actionContext.triggers[restType]?.before
+    ).sort((a, b) => a.order - b.order);
+    applyTriggers(beforeTriggers, null, actionContext);
+
+    // Rest
+    actionContext.addLog({
+      name: restType === 'shortRest' ? 'Short rest' : 'Long rest',
+    });
+    doRestWork(restType, actionContext);
+
+    // Join, sort, and apply after triggers
+    const afterTriggers = union(
+      actionContext.triggers.anyRest?.after, actionContext.triggers[restType]?.after
+    ).sort((a, b) => a.order - b.order);
+    applyTriggers(afterTriggers, null, actionContext);
+
+    // Insert log
+    actionContext.writeLog();
+  },
+});
+
+function doRestWork(restType, actionContext) {
+  const creatureId = actionContext.creature._id;
+  // Long rests reset short rest properties as well
+  let resetFilter;
+  if (restType === 'shortRest') {
+    resetFilter = 'shortRest'
+  } else {
+    resetFilter = { $in: ['shortRest', 'longRest'] }
+  }
+  resetProperties(creatureId, resetFilter, actionContext);
+
+  // Reset half hit dice on a long rest, starting with the highest dice
+  if (restType === 'longRest') {
+    resetHitDice(creatureId, actionContext);
+  }
+}
+
+export function resetProperties(creatureId, resetFilter, actionContext) {
+  // Only apply to active properties
+  const filter = {
+    'ancestors.id': creatureId,
+    reset: resetFilter,
+    removed: { $ne: true },
+    inactive: { $ne: true },
+  };
+  // update all attribute's damage
+  const attributeFilter = {
+    ...filter,
+    type: 'attribute',
+    damage: { $nin: [0, undefined] },
+  }
+  CreatureProperties.find(attributeFilter).forEach(prop => {
+    damagePropertyWork({
+      prop,
+      operation: 'increment',
+      value: -prop.damage ?? 0,
+      actionContext,
+      logFunction(increment) {
+        actionContext.addLog({
+          name: prop.name,
+          value: increment < 0 ? `Restored ${-increment}` : `Removed ${-increment}`
+        });
+      }
+    });
+  });
+  // Update all action-like properties' usesUsed
+  const actionFilter = {
+    ...filter,
+    type: {
+      $in: ['action', 'spell']
+    },
+    usesUsed: { $nin: [0, undefined] },
+  };
+  CreatureProperties.find(actionFilter, {
+    fields: { name: 1, usesUsed: 1 }
+  }).forEach(prop => {
+    actionContext.addLog({
+      name: prop.name,
+      value: prop.usesUsed >= 0 ? `Restored ${prop.usesUsed} uses` : `Removed ${-prop.usesUsed} uses`
+    });
+  });
+  CreatureProperties.update(actionFilter, {
+    $set: {
+      usesUsed: 0,
+      dirty: true,
+    }
+  }, {
+    selector: { type: 'action' },
+    multi: true,
+  });
+}
+
+function resetHitDice(creatureId, actionContext) {
+  let hitDice = CreatureProperties.find({
+    'ancestors.id': creatureId,
+    type: 'attribute',
+    attributeType: 'hitDice',
+    removed: { $ne: true },
+    inactive: { $ne: true },
+  }).fetch();
+  // Use a collator to do sorting in natural order
+  let collator = new Intl.Collator('en', {
+    numeric: true, sensitivity: 'base'
+  });
+  // Get the hit dice in decending order of hitDiceSize
+  let compare = (a, b) => collator.compare(b.hitDiceSize, a.hitDiceSize)
+  hitDice.sort(compare);
+  // Get the total number of hit dice that can be recovered this rest
+  let totalHd = hitDice.reduce((sum, hd) => sum + (hd.total || 0), 0);
+  let resetMultiplier = actionContext.creature.settings.hitDiceResetMultiplier || 0.5;
+  let recoverableHd = Math.max(Math.floor(totalHd * resetMultiplier), 1);
+  // recover each hit dice in turn until the recoverable amount is used up
+  let amountToRecover;
+  hitDice.forEach(hd => {
+    if (!recoverableHd) return;
+    amountToRecover = Math.min(recoverableHd, hd.damage ?? 0);
+    if (!amountToRecover) return;
+    recoverableHd -= amountToRecover;
+    damagePropertyWork({
+      prop: hd,
+      operation: 'increment',
+      value: -amountToRecover,
+      actionContext,
+      logFunction(increment) {
+        actionContext.addLog({
+          name: hd.name,
+          value: increment < 0 ? `Restored ${-increment} hit dice` : `Removed ${increment} hit dice`
+        });
+      }
+    });
+  });
+}
+
+export default restCreature;

app/imports/api/creature/creatures/methods/updateCreature.js

@@ -0,0 +1,45 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+
+const updateCreature = new ValidatedMethod({
+  name: 'creatures.update',
+  validate({ _id, path }) {
+    if (!_id) return false;
+    // Allowed fields
+    let allowedFields = [
+      'name',
+      'alignment',
+      'gender',
+      'picture',
+      'avatarPicture',
+      'color',
+      'settings',
+    ];
+    if (!allowedFields.includes(path[0])) {
+      throw new Meteor.Error('Creatures.methods.update.denied',
+        'This field can\'t be updated using this method');
+    }
+  },
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({ _id, path, value }) {
+    let creature = Creatures.findOne(_id);
+    assertEditPermission(creature, this.userId);
+    if (value === undefined || value === null) {
+      Creatures.update(_id, {
+        $unset: { [path.join('.')]: 1 },
+      });
+    } else {
+      Creatures.update(_id, {
+        $set: { [path.join('.')]: value },
+      });
+    }
+  },
+});
+
+export default updateCreature;

app/imports/api/creature/denormalise/recomputeDamageMultipliers.js

@@ -1,78 +0,0 @@
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import SimpleSchema from 'simpl-schema';
-import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-
-export const recomputeDamageMultipliers = new ValidatedMethod({
-
-  name: 'creatures.recomputeDamageMultipliers',
-
-  validate: new SimpleSchema({
-    creatureId: { type: String }
-  }).validator(),
-
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-
-  run({creatureId}) {
-    // Permission
-    assertEditPermission(creatureId, this.userId);
-    // Work, call this direcly if you are already in a method that has checked
-    // for permission to edit a given character
-    recomputeDamageMultipliersById(creatureId);
-  },
-
-});
-
-export function recomputeDamageMultipliersById(creatureId){
-  if (!creatureId) throw 'Creature ID is required';
-  let props = CreatureProperties.find({
-    'ancestors.id': creatureId,
-    type: 'damageMultiplier',
-    removed: {$ne: true},
-    inactive: {$ne: true},
-  }, {
-    sort: {order: 1}
-  });
-
-  // Count of how many weakness, resistances and immunities each damage type has
-  let multipliersByName = {};
-  props.forEach(dm => {
-    dm.damageTypes.forEach(damageType => {
-      if (!multipliersByName[damageType]){
-        multipliersByName[damageType] = {
-          weaknesses: 0,
-          resistances: 0,
-          immunities: 0,
-        };
-      }
-      if (dm.value === 0){
-        multipliersByName[damageType].immunities++;
-      } else if (dm.value === 0.5){
-        multipliersByName[damageType].resistances++;
-      } else if (dm.value === 2){
-        multipliersByName[damageType].weaknesses++;
-      }
-    });
-  });
-  // Make an Object with keys of all the damage types that have a resulting
-  // immunity, weakness, or resistance
-  let damageMultipliers = {};
-  for (let damageType in multipliersByName){
-    let multiplier = multipliersByName[damageType];
-    if (multiplier.immunities){
-      damageMultipliers[damageType] = 0;
-    } else if (multiplier.resistances && !multiplier.weaknesses){
-      damageMultipliers[damageType] = 0.5;
-    } else if (multiplier.weaknesses && !multiplier.resistances){
-      damageMultipliers[damageType] = 2;
-    }
-  }
-  // Store the Object on the creature document
-  Creatures.update(creatureId, {$set: {damageMultipliers}});
-}

app/imports/api/creature/denormalise/recomputeInactiveProperties.js

@@ -1,75 +0,0 @@
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-
-export default function recomputeInactiveProperties(ancestorId){
-  let disabledFilter = {
-    'ancestors.id': ancestorId,
-    $or: [
-      {disabled: true}, // Everything can be disabled
-      {type: 'buff', applied: false}, // Buffs can be applied
-      {type: 'item', equipped: {$ne: true}},
-      {type: 'spell', prepared: {$ne: true}, alwaysPrepared: {$ne: true}},
-    ],
-  };
-  let disabledIds = CreatureProperties.find(disabledFilter, {
-    fields: {_id: 1},
-  }).map(prop => prop._id);
-
-  // Deactivate relevant properties
-  // Inactive properties
-  CreatureProperties.update({
-    'ancestors.id': ancestorId,
-    '_id': {$in: disabledIds},
-    $or: [
-      {inactive: {$ne: true}},
-      {deactivatedBySelf: {$ne: true}},
-      {deactivatedByAncestor: true},
-    ],
-  }, {
-    $set: {
-      inactive: true,
-      deactivatedBySelf: true,
-    },
-    $unset: {deactivatedByAncestor: 1},
-  }, {
-    multi: true,
-    selector: {type: 'any'},
-  });
-  // Decendants of inactive properties
-  CreatureProperties.update({
-    'ancestors.id': {$eq: ancestorId, $in: disabledIds},
-    $or: [
-      {inactive: {$ne: true}},
-      {deactivatedByAncestor: {$ne: true}},
-    ],
-  }, {
-    $set: {
-      inactive: true,
-      deactivatedByAncestor: true,
-    },
-  }, {
-    multi: true,
-    selector: {type: 'any'},
-  });
-
-  // Remove inactive from all the properties that are inactive but shouldn't be
-  CreatureProperties.update({
-    'ancestors.id': {$eq: ancestorId, $nin: disabledIds},
-    '_id': {$nin: disabledIds},
-    // if it was a toggle responsible, we leave it alone
-    deactivatedByToggle: {$ne: true},
-    $or: [
-      {inactive: true},
-      {deactivatedByAncestor: true},
-      {deactivatedBySelf: true}
-    ],
-  }, {
-    $unset: {
-      inactive: 1,
-      deactivatedByAncestor: 1,
-      deactivatedBySelf: 1,
-    },
-  }, {
-    multi: true,
-    selector: {type: 'any'},
-  });
-}

app/imports/api/creature/denormalise/recomputeInventory.js

@@ -1,111 +0,0 @@
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import { nodesToTree } from '/imports/api/parenting/parenting.js';
-
-export default function recomputeInventory(creatureId){
-  let inventoryForest = nodesToTree({
-    collection: CreatureProperties,
-    ancestorId: creatureId,
-    filter: {
-      type: {$in: ['container', 'item']},
-    },
-    deactivatedByAncestor: {$ne: true},
-  });
-  let containersToWrite = [];
-  let data =  getChildrenInventoryData(inventoryForest, containersToWrite);
-  containersToWrite.forEach(container => {
-    CreatureProperties.update(container._id, {$set: {
-      contentsWeight: container.contentsWeight,
-      contentsValue: container.contentsValue,
-    }}, {selector: {type: 'container'}});
-  });
-  Creatures.update(creatureId, {$set: {
-    'denormalizedStats.weightTotal': data.weightTotal,
-    'denormalizedStats.weightEquipment': data.weightEquipment,
-    'denormalizedStats.weightCarried': data.weightCarried,
-    'denormalizedStats.valueTotal': data.valueTotal,
-    'denormalizedStats.valueEquipment': data.valueEquipment,
-    'denormalizedStats.valueCarried': data.valueCarried,
-    'denormalizedStats.itemsAttuned': data.itemsAttuned,
-  }});
-  return data;
-}
-
-function getChildrenInventoryData(forest, containersToWrite){
-  let data = {
-    weightTotal: 0,
-    weightEquipment: 0,
-    weightCarried: 0,
-    valueTotal: 0,
-    valueEquipment: 0,
-    valueCarried: 0,
-    itemsAttuned: 0,
-  }
-  forest.forEach(tree => {
-    let treeData = getInventoryData(tree, containersToWrite);
-    for (let key in data){
-      data[key] += treeData[key] || 0;
-    }
-  });
-  return data;
-}
-
-function getInventoryData(tree, containersToWrite){
-  let data = {
-    weightTotal: 0,
-    weightEquipment: 0,
-    weightCarried: 0,
-    valueTotal: 0,
-    valueEquipment: 0,
-    valueCarried: 0,
-    itemsAttuned: 0,
-  }
-  let childData = getChildrenInventoryData(tree.children, containersToWrite);
-  let node = tree.node;
-  if (node.type === 'container'){
-    data.weightTotal += node.weight || 0;
-    data.valueTotal += node.value || 0;
-    data.weightCarried += node.weight || 0;
-    data.valueCarried += node.value || 0;
-    storeContentsData(node, childData, containersToWrite);
-  } else if (node.type === 'item'){
-    data.weightTotal += (node.weight * node.quantity) || 0;
-    data.valueTotal += (node.value * node.quantity) || 0;
-    data.weightCarried += (node.weight * node.quantity) || 0;
-    data.valueCarried += (node.value * node.quantity) || 0;
-    if (node.equipped){
-      data.weightEquipment += (node.weight * node.quantity) || 0;
-      data.valueEquipment += (node.value * node.quantity) || 0;
-    }
-    if (node.attuned){
-      data.itemsAttuned += 1;
-    }
-  }
-  for (let key in data){
-    data[key] += childData[key];
-  }
-  if (node.contentsWeightless){
-    data.weightCarried = node.weight;
-  }
-  if (node.carried === false){
-    data.weightCarried = 0;
-    data.valueCarried = 0;
-  }
-  return data
-}
-
-function storeContentsData(node, childData, containersToWrite){
-  let newContentsWeight = childData.weightCarried
-  if (node.contentsWeight !== newContentsWeight){
-    node.contentsWeight = newContentsWeight;
-    node.contentsWeightChanged = true;
-  }
-  let newContentsValue = childData.valueCarried;
-  if (node.contentsValue !== newContentsValue){
-    node.contentsValue = newContentsValue;
-    node.contentsValueChanged = true;
-  }
-  if (node.contentsWeightChanged || node.contentsValueChanged){
-    containersToWrite.push(node);
-  }
-}

app/imports/api/creature/denormalise/recomputeSlotFullness.js

@@ -1,43 +0,0 @@
-import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
-// n + 1 database queries + n potential updates for n slots. Could be sped up.
-export default function recomputeSlotFullness(ancestorId){
-  CreatureProperties.find({
-    'ancestors.id': ancestorId,
-    type: 'propertySlot',
-  }).forEach(slot => {
-    let children = CreatureProperties.find({
-      'parent.id': slot._id,
-      removed: {$ne: true},
-    }, {
-      fields: {
-        slotQuantityFilled: 1,
-        type: 1
-      }
-    }).fetch();
-    let totalFilled = 0;
-    children.forEach(child => {
-      if (child.type === 'slotFiller'){
-        totalFilled += child.slotQuantityFilled;
-      } else {
-        totalFilled++;
-      }
-    });
-    let spaceLeft;
-    let expected = slot.quantityExpectedResult;
-    if (typeof expected !== 'number'){
-      expected = 1;
-    }
-    if (expected === 0){
-      spaceLeft = null;
-    } else {
-      spaceLeft = expected - totalFilled;
-    }
-    if (slot.totalFilled !== totalFilled || slot.spaceLeft !== spaceLeft){
-      CreatureProperties.update(slot._id, {
-        $set: {totalFilled, spaceLeft},
-      }, {
-        selector: {type: 'propertySlot'}
-      });
-    }
-  });
-}

app/imports/api/creature/experience/Experiences.js

@@ -1,24 +1,24 @@
 import SimpleSchema from 'simpl-schema';
 import { ValidatedMethod } from 'meteor/mdg:validated-method';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import { getUserTier } from '/imports/api/users/patreon/tiers.js';
-import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import { recomputeCreatureById } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import { assertEditPermission } from '/imports/api/creature/creatures/creaturePermissions.js';
+import Creatures from '/imports/api/creature/creatures/Creatures.js';
+import STORAGE_LIMITS from '/imports/constants/STORAGE_LIMITS.js';
 
 let Experiences = new Mongo.Collection('experiences');
 
 let ExperienceSchema = new SimpleSchema({
-	name: {
-		type: String,
-		optional: true,
-	},
-	// The amount of XP this experience gives
-	xp: {
-		type: SimpleSchema.Integer,
-		optional: true,
+  name: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.name,
+  },
+  // The amount of XP this experience gives
+  xp: {
+    type: SimpleSchema.Integer,
+    optional: true,
     min: 0,
-	},
+  },
   // Setting levels instead of value grants whole levels
   levels: {
     type: SimpleSchema.Integer,
@@ -26,17 +26,17 @@ let ExperienceSchema = new SimpleSchema({
     min: 0,
     index: 1,
   },
-	// The real-world date that it occured, usually sorted by date
-	date: {
-		type: Date,
-		autoValue: function() {
-			// If the date isn't set, set it to now
-			if (!this.isSet) {
-				return new Date();
-			}
-		},
+  // The real-world date that it occured, usually sorted by date
+  date: {
+    type: Date,
+    autoValue: function () {
+      // If the date isn't set, set it to now
+      if (!this.isSet) {
+        return new Date();
+      }
+    },
     index: 1,
-	},
+  },
   creatureId: {
     type: String,
     regEx: SimpleSchema.RegEx.Id,
@@ -46,21 +46,21 @@ let ExperienceSchema = new SimpleSchema({
 
 Experiences.attachSchema(ExperienceSchema);
 
-const insertExperienceForCreature = function({experience, creatureId, userId}){
-  assertEditPermission(creatureId, userId);
-  if (experience.xp){
-    Creatures.update(creatureId, {$inc: {
-      'denormalizedStats.xp': experience.xp
-    }});
+const insertExperienceForCreature = function ({ experience, creatureId }) {
+  if (experience.xp) {
+    Creatures.update(creatureId, {
+      $inc: { 'denormalizedStats.xp': experience.xp },
+      $set: { dirty: true },
+    });
   }
   if (experience.levels) {
-    Creatures.update(creatureId, {$inc: {
-      'denormalizedStats.milestoneLevels': experience.levels
-    }});
+    Creatures.update(creatureId, {
+      $inc: { 'denormalizedStats.milestoneLevels': experience.levels },
+      $set: { dirty: true },
+    });
   }
   experience.creatureId = creatureId;
   let id = Experiences.insert(experience);
-  recomputeCreatureById(creatureId);
   return id;
 };
 
@@ -84,20 +84,16 @@ const insertExperience = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({experience, creatureIds}) {
+  run({ experience, creatureIds }) {
     let userId = this.userId;
     if (!userId) {
       throw new Meteor.Error('Experiences.methods.insert.denied',
-      'You need to be logged in to insert an experience');
-    }
-    let tier = getUserTier(this.userId);
-    if (!tier.paidBenefits){
-      throw new Meteor.Error('Experiences.methods.insert.denied',
-      `The ${tier.name} tier does not allow you to grant experience`);
+        'You need to be logged in to insert an experience');
     }
     let insertedIds = [];
     creatureIds.forEach(creatureId => {
-      let id = insertExperienceForCreature({experience, creatureId, userId});
+      assertEditPermission(creatureId, userId);
+      let id = insertExperienceForCreature({ experience, creatureId, userId });
       insertedIds.push(id);
     });
     return insertedIds;
@@ -117,34 +113,30 @@ const removeExperience = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({experienceId}) {
+  run({ experienceId }) {
     let userId = this.userId;
     if (!userId) {
       throw new Meteor.Error('Experiences.methods.remove.denied',
-      'You need to be logged in to remove an experience');
-    }
-    let tier = getUserTier(this.userId);
-    if (!tier.paidBenefits){
-      throw new Meteor.Error('Experiences.methods.remove.denied',
-      `The ${tier.name} tier does not allow you to remove  an experience`);
+        'You need to be logged in to remove an experience');
     }
     let experience = Experiences.findOne(experienceId);
     if (!experience) return;
     let creatureId = experience.creatureId
     assertEditPermission(creatureId, userId);
-    if (experience.xp){
-      Creatures.update(creatureId, {$inc: {
-        'denormalizedStats.xp': -experience.xp
-      }});
+    if (experience.xp) {
+      Creatures.update(creatureId, {
+        $inc: { 'denormalizedStats.xp': -experience.xp },
+        $set: { dirty: true },
+      });
     }
     if (experience.levels) {
-      Creatures.update(creatureId, {$inc: {
-        'denormalizedStats.milestoneLevels': -experience.levels
-      }});
+      Creatures.update(creatureId, {
+        $inc: { 'denormalizedStats.milestoneLevels': -experience.levels },
+        $set: { dirty: true },
+      });
     }
     experience.creatureId = creatureId;
     let numRemoved = Experiences.remove(experienceId);
-    recomputeCreatureById(creatureId);
     return numRemoved;
   },
 });
@@ -162,16 +154,11 @@ const recomputeExperiences = new ValidatedMethod({
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({creatureId}) {
+  run({ creatureId }) {
     let userId = this.userId;
     if (!userId) {
       throw new Meteor.Error('Experiences.methods.recompute.denied',
-      'You need to be logged in to recompute a creature\'s experiences');
-    }
-    let tier = getUserTier(this.userId);
-    if (!tier.paidBenefits){
-      throw new Meteor.Error('Experiences.methods.recompute.denied',
-      `The ${tier.name} tier does not allow you to recompute a creature's experiences`);
+        'You need to be logged in to recompute a creature\'s experiences');
     }
     assertEditPermission(creatureId, userId);
 
@@ -180,18 +167,20 @@ const recomputeExperiences = new ValidatedMethod({
     Experiences.find({
       creatureId
     }, {
-      fields: {xp: 1, levels: 1}
+      fields: { xp: 1, levels: 1 }
     }).forEach(experience => {
       xp += experience.xp || 0;
       milestoneLevels += experience.levels || 0;
     });
-    Creatures.update(creatureId, {$set: {
-      'denormalizedStats.xp': xp,
-      'denormalizedStats.milestoneLevels': milestoneLevels
-    }});
-    recomputeCreatureById(creatureId);
+    Creatures.update(creatureId, {
+      $set: {
+        'denormalizedStats.xp': xp,
+        'denormalizedStats.milestoneLevels': milestoneLevels,
+        dirty: true,
+      }
+    });
   },
 });
 
 export default Experiences;
-export { ExperienceSchema, insertExperience, removeExperience, recomputeExperiences };
+export { ExperienceSchema, insertExperience, insertExperienceForCreature, removeExperience, recomputeExperiences };

app/imports/api/creature/journal/JournalEntry.js

@@ -1,37 +1,43 @@
 import SimpleSchema from 'simpl-schema';
+import STORAGE_LIMITS from '/imports/constants/STORAGE_LIMITS.js';
 
 let ExperienceSchema = new SimpleSchema({
-	title: {
-		type: String,
-		optional: true,
-	},
-	// Potentially long description of the event
-	description: {
-		type: String,
-		optional: true,
-	},
-	// The real-world date that it occured
-	date: {
-		type: Date,
-		autoValue: function() {
-			// If the date isn't set, set it to now
-			if (!this.isSet) {
-				return new Date();
-			}
-		},
-	},
-	// The date in-world of this event
-	worldDate: {
-		type: String,
-		optional: true,
-	},
+  title: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.name,
+  },
+  // Potentially long description of the event
+  description: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.description,
+  },
+  // The real-world date that it occured
+  date: {
+    type: Date,
+    autoValue: function () {
+      // If the date isn't set, set it to now
+      if (!this.isSet) {
+        return new Date();
+      }
+    },
+  },
+  // The date in-world of this event
+  worldDate: {
+    type: String,
+    optional: true,
+    max: STORAGE_LIMITS.name,
+  },
   // Tags to better find this entry later
   tags: {
     type: Array,
     defaultValue: [],
+    maxCount: STORAGE_LIMITS.tagCount,
   },
   'tags.$': {
     type: String,
+    max: STORAGE_LIMITS.tagLength,
   },
   // ID of the journal this entry belongs to
   journalId: {