Fixed attributes not hiding when redundant

This commit is contained in:
Stefan Zermatten
2021-07-12 17:03:32 +02:00
parent 8eaad3600f
commit 039b7046b2

View File

@@ -102,24 +102,31 @@ export default function computeStat(stat, memo){
prop: statInstance,
memo
});
statInstance.baseValue = +result.value;
result.value = +result.value;
if (!isNaN(result.value)){
statInstance.baseValue = result.value;
} else {
statInstance.baseValue = undefined;
}
statInstance.dependencies = union(statInstance.dependencies, dependencies);
if (context.errors.length){
statInstance.baseValueErrors = context.errors;
}
// Apply all the base values
effects.push({
operation: 'base',
calculation: statInstance.baseValueCalculation,
result: statInstance.baseValue,
stats: [statInstance.variableName],
dependencies: statInstance.overridden ?
if (Number.isFinite(statInstance.baseValue)){
effects.push({
operation: 'base',
calculation: statInstance.baseValueCalculation,
result: statInstance.baseValue,
stats: [statInstance.variableName],
dependencies: statInstance.overridden ?
union(statInstance.dependencies, [statInstance._id]) :
[],
computationDetails: {
computed: true,
},
});
computationDetails: {
computed: true,
},
});
}
}
});