Fixed: buffs

app/.meteor/packages

@@ -53,3 +53,4 @@ peerlibrary:reactive-publish
 simple:rest
 simple:rest-method-mixin
 mikowals:batch-insert
+peerlibrary:subscription-data

app/.meteor/versions

@@ -95,11 +95,15 @@ ongoworks:speakingurl@9.0.0
 ordered-dict@1.1.0
 patreon-oauth@0.1.0
 peerlibrary:assert@0.3.0
+peerlibrary:check-extension@0.7.0
+peerlibrary:computed-field@0.10.0
+peerlibrary:data-lookup@0.3.0
 peerlibrary:extend-publish@0.6.0
 peerlibrary:fiber-utils@0.10.0
 peerlibrary:reactive-mongo@0.4.0
 peerlibrary:reactive-publish@0.10.0
 peerlibrary:server-autorun@0.8.0
+peerlibrary:subscription-data@0.8.0
 percolate:migrations@0.9.8
 percolate:synced-cron@1.3.2
 promise@0.11.2

app/client/main.js

@@ -1,3 +1,3 @@
 import '/imports/ui/vueSetup.js';
 import '/imports/ui/styles/stylesIndex.js';
-import '/imports/ui/styles/stylesIndex.js';
+import '/imports/client/config.js';

app/imports/api/creature/CreatureProperties.js

@@ -1,598 +0,0 @@
-import { Meteor } from 'meteor/meteor';
-import { Mongo } from 'meteor/mongo';
-import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import SimpleSchema from 'simpl-schema';
-import ColorSchema from '/imports/api/properties/subSchemas/ColorSchema.js';
-import ChildSchema, { RefSchema } from '/imports/api/parenting/ChildSchema.js';
-import { recomputeCreature } from '/imports/api/creature/computation/recomputeCreature.js';
-import LibraryNodes from '/imports/api/library/LibraryNodes.js';
-import Creatures from '/imports/api/creature/Creatures.js';
-import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
-import { softRemove, restore } from '/imports/api/parenting/softRemove.js';
-import SoftRemovableSchema from '/imports/api/parenting/SoftRemovableSchema.js';
-import propertySchemasIndex from '/imports/api/properties/computedPropertySchemasIndex.js';
-import {
-	setLineageOfDocs,
-	getAncestry,
-	renewDocIds
-} from '/imports/api/parenting/parenting.js';
-import {setDocToLastOrder} from '/imports/api/parenting/order.js';
-import { storedIconsSchema } from '/imports/api/icons/Icons.js';
-import { reorderDocs } from '/imports/api/parenting/order.js';
-
-import '/imports/api/creature/actions/doAction.js';
-import '/imports/api/creature/creatureProperties/manageEquipment.js';
-
-let CreatureProperties = new Mongo.Collection('creatureProperties');
-
-let CreaturePropertySchema = new SimpleSchema({
-	type: {
-    type: String,
-    allowedValues: Object.keys(propertySchemasIndex),
-  },
-	tags: {
-		type: Array,
-		defaultValue: [],
-	},
-	'tags.$': {
-		type: String,
-	},
-	disabled: {
-		type: Boolean,
-		optional: true,
-	},
-  icon: {
-    type: storedIconsSchema,
-    optional: true,
-  },
-  // Denormalised flag if this property is inactive on the sheet for any reason
-  // Including being disabled, or a decendent of a disabled property
-  inactive: {
-    type: Boolean,
-    optional: true,
-    index: 1,
-  },
-  // Denormalised flag if this property was made inactive by an inactive
-  // ancestor. True if this property has an inactive ancestor even if this
-  // property is itself inactive
-  deactivatedByAncestor: {
-    type: Boolean,
-    optional: true,
-    index: 1,
-  },
-});
-
-for (let key in propertySchemasIndex){
-	let schema = new SimpleSchema({});
-	schema.extend(propertySchemasIndex[key]);
-	schema.extend(CreaturePropertySchema);
-  schema.extend(ColorSchema);
-	schema.extend(ChildSchema);
-	schema.extend(SoftRemovableSchema);
-	CreatureProperties.attachSchema(schema, {
-		selector: {type: key}
-	});
-}
-
-export function getCreature(property){
-  if (!property) throw new Meteor.Error('No property provided');
-  let creature = Creatures.findOne(property.ancestors[0].id);
-  if (!creature) throw new Meteor.Error('Creature does not exist');
-  return creature;
-}
-
-function assertPropertyEditPermission(property, userId){
-  let creature = getCreature(property);
-  return assertEditPermission(creature, userId);
-}
-
-function recomputeCreatures(property){
-	for (let ref of property.ancestors){
-		if (ref.collection === 'creatures') {
-      reorderDocs({collection: CreatureProperties, ancestorId: ref.id});
-			recomputeCreature.call({charId: ref.id});
-		}
-	}
-}
-
-const insertProperty = new ValidatedMethod({
-  name: 'creatureProperties.insert',
-	validate: null,
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-  run({creatureProperty}) {
-    delete creatureProperty._id;
-    assertPropertyEditPermission(creatureProperty, this.userId);
-		let _id = CreatureProperties.insert(creatureProperty);
-		let property = CreatureProperties.findOne(_id);
-		recomputeCreatures(property);
-  },
-});
-
-const duplicateProperty = new ValidatedMethod({
-  name: 'creatureProperties.duplicate',
-  validate: new SimpleSchema({
-    _id: {
-      type: String,
-      regEx: SimpleSchema.RegEx.Id,
-    }
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-  run({_id}) {
-    let creatureProperty = CreatureProperties.findOne(_id);
-    assertPropertyEditPermission(creatureProperty, this.userId);
-    delete creatureProperty._id;
-		CreatureProperties.insert(creatureProperty);
-    recomputeCreatures(creatureProperty);
-  },
-});
-
-const insertPropertyFromLibraryNode = new ValidatedMethod({
-	name: 'creatureProperties.insertPropertyFromLibraryNode',
-	validate: new SimpleSchema({
-		nodeId: {
-			type: String,
-			regEx: SimpleSchema.RegEx.Id,
-		},
-		parentRef: {
-			type: RefSchema,
-		},
-	}).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-	run({nodeId, parentRef}) {
-		// get the new ancestry for the properties
-		let {parentDoc, ancestors} = getAncestry({parentRef});
-
-		// Check permission to edit
-		if (parentRef.collection === 'creatures'){
-			assertEditPermission(parentDoc, this.userId);
-		} else if (parentRef.collection === 'creatureProperties'){
-			assertPropertyEditPermission(parentDoc, this.userId);
-		} else {
-			throw `${parentRef.collection} is not a valid parent collection`
-		}
-
-		// Fetch the library node and its decendents, provided they have not been
-		// removed
-		let node = LibraryNodes.findOne({
-			_id: nodeId,
-			removed: {$ne: true},
-		});
-		if (!node) throw `Node not found for nodeId: ${nodeId}`;
-		let oldParent = node.parent;
-		let nodes = LibraryNodes.find({
-			'ancestors.id': nodeId,
-			removed: {$ne: true},
-		}).fetch();
-    // The root node is last in the array of nodes
-		nodes.push(node);
-
-		// re-map all the ancestors
-		setLineageOfDocs({
-			docArray: nodes,
-			newAncestry: ancestors,
-			oldParent,
-		});
-
-		// Give the docs new IDs without breaking internal references
-		renewDocIds({
-			docArray: nodes,
-			collectionMap: {'libraryNodes': 'creatureProperties'}
-		});
-
-		// Order the root node
-		setDocToLastOrder({
-			collection: CreatureProperties,
-			doc: node,
-		});
-
-		// Insert the creature properties
-    let insertedDocIds = CreatureProperties.batchInsert(nodes);
-
-    // get the root inserted doc
-    let rootId = insertedDocIds[insertedDocIds.length - 1];
-
-		// Recompute the creatures doc was attached to
-		recomputeCreatures(node);
-
-		// Return the docId of the last property, the inserted root property
-		return rootId;
-	},
-})
-
-const updateProperty = new ValidatedMethod({
-  name: 'creatureProperties.update',
-  validate({_id, path}){
-		if (!_id) throw new Meteor.Error('No _id', '_id is required');
-		// We cannot change these fields with a simple update
-		switch (path[0]){
-			case 'type':
-      case 'order':
-      case 'parent':
-      case 'ancestors':
-			case 'damage':
-				throw new Meteor.Error('Permission denied',
-				'This property can\'t be updated directly');
-		}
-  },
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-  run({_id, path, value}) {
-    let property = CreatureProperties.findOne(_id);
-    assertPropertyEditPermission(property, this.userId);
-    let pathString = path.join('.');
-    let modifier;
-    // unset empty values
-    if (value === null || value === undefined){
-      modifier = {$unset: {[pathString]: 1}};
-    } else {
-      modifier = {$set: {[pathString]: value}};
-    }
-		CreatureProperties.update(_id, modifier, {
-			selector: {type: property.type},
-		});
-		recomputeCreatures(property);
-  },
-});
-
-export function damagePropertyWork({property, operation, value}){
-  if (operation === 'set'){
-    let currentValue = property.value;
-    // Set represents what we want the value to be after damage
-    // So we need the actual damage to get to that value
-    let damage = currentValue - value;
-    // Damage can't exceed total value
-    if (damage > currentValue) damage = currentValue;
-    // Damage must be positive
-    if (damage < 0) damage = 0;
-    CreatureProperties.update(property._id, {
-      $set: {damage}
-    }, {
-      selector: property
-    });
-    return currentValue - damage;
-  } else if (operation === 'increment'){
-    let currentValue = property.value - (property.damage || 0);
-    let currentDamage = property.damage;
-    let increment = value;
-    // Can't increase damage above the remaining value
-    if (increment > currentValue) increment = currentValue;
-    // Can't decrease damage below zero
-    if (-increment > currentDamage) increment = -currentDamage;
-    CreatureProperties.update(property._id, {
-      $inc: {damage: increment}
-    }, {
-      selector: property
-    });
-    return increment;
-  }
-}
-
-const damagePropertiesByName = new ValidatedMethod({
-  name: 'CreatureProperties.damagePropertiesByName',
-  validate: new SimpleSchema({
-    creatureId: SimpleSchema.RegEx.Id,
-    variableName: {
-      type: String,
-    },
-    operation: {
-      type: String,
-      allowedValues: ['set', 'increment']
-    },
-    value: Number,
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 20,
-    timeInterval: 5000,
-  },
-  run({creatureId, variableName, operation, value}) {
-		// Check permissions
-    let creature = Creatures.findOne(creatureId, {
-      fields: {
-        damageMultipliers: 1,
-        owner: 1,
-        readers: 1,
-        writers: 1,
-      },
-    });
-    assertEditPermission(creature, this.userId);
-    CreatureProperties.find({
-      'ancestors.id': creatureId,
-      variableName,
-      removed: {$ne: false},
-      inactive: {$ne: true},
-    }).forEach(property => {
-      // Check if property can take damage
-      let schema = CreatureProperties.simpleSchema(property);
-      if (!schema.allowsKey('damage')) return;
-      // Damage the property
-      damagePropertyWork({property: property, operation, value})
-    });
-    recomputeCreature.call({charId: creatureId});
-  }
-})
-
-const damageProperty = new ValidatedMethod({
-  name: 'creatureProperties.damage',
-  validate: new SimpleSchema({
-    _id: SimpleSchema.RegEx.Id,
-    operation: {
-      type: String,
-      allowedValues: ['set', 'increment']
-    },
-    value: Number,
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 20,
-    timeInterval: 5000,
-  },
-  run({_id, operation, value}) {
-		let currentProperty = CreatureProperties.findOne(_id);
-		// Check permissions
-		assertPropertyEditPermission(currentProperty, this.userId);
-		// Check if property can take damage
-		let schema = CreatureProperties.simpleSchema(currentProperty);
-		if (!schema.allowsKey('damage')){
-			throw new Meteor.Error(
-				'Damage property failed',
-				`Property of type "${currentProperty.type}" can't be damaged`
-			);
-		}
-		damagePropertyWork({property: currentProperty, operation, value})
-		recomputeCreatures(currentProperty);
-  },
-});
-
-const dealDamage = new ValidatedMethod({
-  name: 'creatureProperties.dealDamage',
-  validate: new SimpleSchema({
-    creatureId: SimpleSchema.RegEx.Id,
-    damageType: {
-      type: String,
-    },
-    amount: Number,
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 20,
-    timeInterval: 5000,
-  },
-  run({creatureId, damageType, amount}) {
-    let creature = Creatures.findOne(creatureId, {
-      fields: {
-        damageMultipliers: 1,
-        owner: 1,
-        readers: 1,
-        writers: 1,
-      },
-    });
-		// Check permissions
-    assertEditPermission(creature, this.userId);
-    let healthBars = CreatureProperties.find({
-      'ancestors.id': creatureId,
-      type: 'attribute',
-      attributeType:'healthBar',
-      removed: {$ne: true},
-      inactive: {$ne: true},
-    }, {
-      sort: {order: -1},
-    });
-    let multiplier = creature.damageMultipliers[damageType];
-    if (multiplier === undefined) multiplier = 1;
-    let totalDamage = Math.floor(amount * multiplier);
-    let damageLeft = totalDamage;
-    if (damageType === 'healing') damageLeft = -totalDamage;
-    healthBars.forEach(healthBar => {
-      if (damageLeft === 0) return;
-      let damageAdded = damagePropertyWork({
-        property: healthBar,
-        operation: 'increment',
-        value: damageLeft,
-      });
-      damageLeft -= damageAdded;
-    });
-    recomputeCreature.call({charId: creatureId});
-    return totalDamage;
-  },
-});
-
-export function adjustQuantityWork({property, operation, value}){
-  // Check if property has quantity
-  let schema = CreatureProperties.simpleSchema(property);
-  if (!schema.allowsKey('quantity')){
-    throw new Meteor.Error(
-      'Adjust quantity failed',
-      `Property of type "${property.type}" doesn't have a quantity`
-    );
-  }
-  if (operation === 'set'){
-    CreatureProperties.update(property._id, {
-      $set: {quantity: value}
-    }, {
-      selector: property
-    });
-  } else if (operation === 'increment'){
-    // value here is 'damage'
-    value = -value;
-    let currentQuantity = property.quantity;
-    if (currentQuantity + value < 0) value = -currentQuantity;
-    CreatureProperties.update(property._id, {
-      $inc: {quantity: value}
-    }, {
-      selector: property
-    });
-  }
-}
-
-const adjustQuantity = new ValidatedMethod({
-  name: 'creatureProperties.adjustQuantity',
-  validate: new SimpleSchema({
-    _id: SimpleSchema.RegEx.Id,
-    operation: {
-      type: String,
-      allowedValues: ['set', 'increment']
-    },
-    value: Number,
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-  run({_id, operation, value}) {
-		let currentProperty = CreatureProperties.findOne(_id);
-		// Check permissions
-		assertPropertyEditPermission(currentProperty, this.userId);
-    adjustQuantityWork({property: currentProperty, operation, value});
-    recomputeCreatures(currentProperty);
-  },
-});
-
-const selectAmmoItem = new ValidatedMethod({
-  name: 'creatureProperties.selectAmmoItem',
-  validate: new SimpleSchema({
-    actionId: SimpleSchema.RegEx.Id,
-    itemId: SimpleSchema.RegEx.Id,
-    itemConsumedIndex: Number,
-  }).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-  run({actionId, itemId, itemConsumedIndex}) {
-		let action = CreatureProperties.findOne(actionId);
-		// Check permissions
-		assertPropertyEditPermission(action, this.userId);
-    // Check that this index has a document to edit
-    let itemConsumed = action.resources.itemsConsumed[itemConsumedIndex];
-    if (!itemConsumed){
-      throw new Meteor.Error('Resouce not found',
-        'Could not set ammo, because the ammo document was not found');
-    }
-    let itemToLink = CreatureProperties.findOne(itemId);
-    if (!itemToLink){
-      throw new Meteor.Error('Item not found',
-        'Could not set ammo: the item was not found');
-    }
-    let path = `resources.itemsConsumed.${itemConsumedIndex}.itemId`;
-    CreatureProperties.update(actionId, {
-      $set: {[path]: itemId}
-    }, {
-      selector: action,
-    });
-    recomputeCreatures(action);
-  },
-});
-
-const pushToProperty = new ValidatedMethod({
-	name: 'creatureProperties.push',
-	validate: null,
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-	run({_id, path, value}){
-		let property = CreatureProperties.findOne(_id);
-    assertPropertyEditPermission(property, this.userId);
-		CreatureProperties.update(_id, {
-			$push: {[path.join('.')]: value},
-		}, {
-			selector: {type: property.type},
-		});
-		recomputeCreatures(property);
-	}
-});
-
-const pullFromProperty = new ValidatedMethod({
-	name: 'creatureProperties.pull',
-	validate: null,
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-	run({_id, path, itemId}){
-		let property = CreatureProperties.findOne(_id);
-    assertPropertyEditPermission(property, this.userId);
-		CreatureProperties.update(_id, {
-			$pull: {[path.join('.')]: {_id: itemId}},
-		}, {
-			selector: {type: property.type},
-			getAutoValues: false,
-		});
-		recomputeCreatures(property);
-	}
-});
-
-const softRemoveProperty = new ValidatedMethod({
-	name: 'creatureProperties.softRemove',
-	validate: new SimpleSchema({
-		_id: SimpleSchema.RegEx.Id
-	}).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-	run({_id}){
-		let property = CreatureProperties.findOne(_id);
-    assertPropertyEditPermission(property, this.userId);
-		softRemove({_id, collection: CreatureProperties});
-		recomputeCreatures(property);
-	}
-});
-
-const restoreProperty = new ValidatedMethod({
-	name: 'creatureProperties.restore',
-	validate: new SimpleSchema({
-		_id: SimpleSchema.RegEx.Id
-	}).validator(),
-  mixins: [RateLimiterMixin],
-  rateLimit: {
-    numRequests: 5,
-    timeInterval: 5000,
-  },
-	run({_id}){
-		let property = CreatureProperties.findOne(_id);
-    assertPropertyEditPermission(property, this.userId);
-		restore({_id, collection: CreatureProperties});
-		recomputeCreatures(property);
-	}
-});
-
-export default CreatureProperties;
-export {
-	CreaturePropertySchema,
-	insertProperty,
-  duplicateProperty,
-	insertPropertyFromLibraryNode,
-	updateProperty,
-  dealDamage,
-  damagePropertiesByName,
-	damageProperty,
-  adjustQuantity,
-  selectAmmoItem,
-	pushToProperty,
-	pullFromProperty,
-  softRemoveProperty,
-	restoreProperty,
-};

app/imports/api/creature/Creatures.js

@@ -4,6 +4,7 @@ import SimpleSchema from 'simpl-schema';
 import deathSaveSchema from '/imports/api/properties/subSchemas/DeathSavesSchema.js'
 import ColorSchema from '/imports/api/properties/subSchemas/ColorSchema.js';
 import SharingSchema from '/imports/api/sharing/SharingSchema.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import {assertEditPermission} from '/imports/api/sharing/sharingPermissions.js';
 import { assertUserHasPaidBenefits } from '/imports/api/users/patreon/tiers.js';
 
@@ -91,8 +92,32 @@ let CreatureSchema = new SimpleSchema({
     type: SimpleSchema.Integer,
     defaultValue: 0,
   },
-  // Sum of all weights of items and containers that are carried
-	'denormalizedStats.weightCarried': {
+  // Inventory
+	'denormalizedStats.weightTotal': {
+		type: Number,
+		defaultValue: 0,
+	},
+  'denormalizedStats.weightEquipment': {
+		type: Number,
+		defaultValue: 0,
+	},
+  'denormalizedStats.weightCarried': {
+		type: Number,
+		defaultValue: 0,
+	},
+  'denormalizedStats.valueTotal': {
+		type: Number,
+		defaultValue: 0,
+	},
+  'denormalizedStats.valueEquipment': {
+		type: Number,
+		defaultValue: 0,
+	},
+  'denormalizedStats.valueCarried': {
+		type: Number,
+		defaultValue: 0,
+	},
+  'denormalizedStats.itemsAttuned': {
 		type: Number,
 		defaultValue: 0,
 	},
@@ -160,11 +185,25 @@ const insertCreature = new ValidatedMethod({
     assertUserHasPaidBenefits(this.userId);
 
 		// Create the creature document
-    let charId = Creatures.insert({
+    let creatureId = Creatures.insert({
 			owner: this.userId,
 		});
+    CreatureProperties.insert({
+      slotTags: ['base'],
+      quantityExpected: 1,
+      type: 'propertySlot',
+      name: 'Base',
+      description: 'Choose a starting point for your character, this will define the basic setup of your character sheet. Without a base, your sheet will be empty.',
+      hideWhenFull: true,
+      parent: {collection: 'creatures', id: creatureId},
+      ancestors: [{collection: 'creatures', id: creatureId}],
+      order: 0,
+      tags: [],
+      spaceLeft: 1,
+      totalFilled: 0,
+    });
 		this.unblock();
-		return charId;
+		return creatureId;
   },
 
 });

app/imports/api/creature/actions/applyAction.js

@@ -1,11 +1,13 @@
 import spendResources from '/imports/api/creature/actions/spendResources.js'
-import {insertCreatureLog} from '/imports/api/creature/log/CreatureLogs.js';
+import embedInlineCalculations from '/imports/api/creature/computation/afterComputation/embedInlineCalculations.js';
 
-export default function applyAction({prop, creature}){
-  spendResources(prop);
-  insertCreatureLog.call({
-    log: {
-      text: prop.name,
-      creatureId: creature._id},
-  });
+export default function applyAction({prop, log}){
+  let content = { name: prop.name };
+  if (prop.summary){
+    content.description = embedInlineCalculations(
+      prop.summary, prop.summaryCalculations
+    );
+  }
+  log.content.push(content);
+  spendResources({prop, log});
 }

app/imports/api/creature/actions/applyAdjustment.js

@@ -1,12 +1,12 @@
 import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
-import {insertCreatureLog} from '/imports/api/creature/log/CreatureLogs.js';
-import { damagePropertiesByName } from '/imports/api/creature/CreatureProperties.js';
+import damagePropertiesByName from '/imports/api/creature/creatureProperties/methods/damagePropertiesByName.js';
 
 export default function applyAdjustment({
   prop,
   creature,
   targets,
-  actionContext
+  actionContext,
+  log
 }){
   let damageTargets = prop.target === 'self' ? [creature] : targets;
   let scope = {
@@ -16,16 +16,16 @@ export default function applyAdjustment({
   try {
     var {result, errors} = evaluateString(prop.amount, scope, 'reduce');
     if (typeof result !== 'number') {
-      return insertCreatureLog.call({ log: {
-        text: errors.join(', ') || 'Something went wrong',
-        creatureId: creature._id,
-      }});
+      log.content.push({
+        name: 'Attribute damage',
+        error: errors.join(', ') || 'Something went wrong',
+      });
     }
   } catch (e){
-    return insertCreatureLog.call({ log: {
-      text: e.toString(),
-      creatureId: creature._id,
-    }});
+    log.content.push({
+      name: 'Attribute damage',
+      error: e.toString(),
+    });
   }
   if (damageTargets) {
     damageTargets.forEach(target => {
@@ -38,19 +38,17 @@ export default function applyAdjustment({
         operation: prop.operation || 'increment',
         value: result
       });
-      insertCreatureLog.call({
-        log: {
-          text: `${prop.stat} ${prop.operation === 'set' ? 'set to' : ''} ${-result}`,
-          creatureId: target._id,
-        }
+      log.content.push({
+        name: 'Attribute damage',
+        resultPrefix: `${prop.stat} ${prop.operation === 'set' ? 'set to' : ''}`,
+        result: `${-result}`,
       });
     });
   } else {
-    insertCreatureLog.call({
-      log: {
-        text: `${prop.stat} ${prop.operation === 'set' ? 'set to' : ''} ${-result}`,
-        creatureId: creature._id,
-      }
+    log.content.push({
+      name: 'Attribute damage',
+      resultPrefix: `${prop.stat} ${prop.operation === 'set' ? 'set to' : ''}`,
+      result: `${-result}`,
     });
   }
 }

app/imports/api/creature/actions/applyAttack.js

@@ -1,18 +1,23 @@
 import roll from '/imports/parser/roll.js';
-import {insertCreatureLog} from '/imports/api/creature/log/CreatureLogs.js';
 
 export default function applyAttack({
   prop,
-  //children,
+  log,
+  actionContext,
   creature,
-  //targets,
-  //actionContext
 }){
-  let result = roll(1, 20)[0] + prop.rollBonusResult;
-  insertCreatureLog.call({
-    log: {
-      text: `${prop.name} attack. ${result} to hit`,
-      creatureId: creature._id,
-    }
+  let value = roll(1, 20)[0];
+  actionContext.attackRoll = {value};
+  let criticalHitTarget = creature.variables.criticalHitTarget &&
+    creature.variables.criticalHitTarget.currentValue || 20;
+  let criticalHit = value >= criticalHitTarget;
+  if (criticalHit) actionContext.criticalHit = {value: true};
+  let result = value + prop.rollBonusResult;
+  actionContext.toHit = {value: result};
+
+  log.content.push({
+    name: criticalHit ? 'Critical Hit!' : 'To Hit',
+    resultPrefix: `1d20 [${value}] + ${prop.rollBonusResult} = `,
+    result,
   });
 }

app/imports/api/creature/actions/applyBuff.js

@@ -3,7 +3,8 @@ import {
 	renewDocIds
 } from '/imports/api/parenting/parenting.js';
 import {setDocToLastOrder} from '/imports/api/parenting/order.js';
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 
 export default function applyBuff({
   prop,
@@ -57,5 +58,10 @@ function copyNodeListToTarget(propList, target, oldParent){
     collection: CreatureProperties,
     doc: propList[0],
   });
-  CreatureProperties.batchInsert(propList);
+
+  CreatureProperties.batchInsert(propList, () => {
+    // This insert is racing the main recompute, recmpute again after it's
+    // certainly finished
+    recomputeCreatureByDoc(target);
+  });
 }

app/imports/api/creature/actions/applyDamage.js

@@ -1,34 +1,50 @@
 import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
+import dealDamage from '/imports/api/creature/creatureProperties/methods/dealDamage.js';
 import {insertCreatureLog} from '/imports/api/creature/log/CreatureLogs.js';
-import { dealDamage } from '/imports/api/creature/CreatureProperties.js';
+import { CompilationContext } from '/imports/parser/parser.js';
 
 export default function applyDamage({
   prop,
   creature,
   targets,
-  actionContext
+  actionContext,
+  log,
 }){
   let damageTargets = prop.target === 'self' ? [creature] : targets;
   let scope = {
     ...creature.variables,
     ...actionContext,
   };
+  if (targets.length === 1){
+    scope.target = targets[0].variables;
+  }
+  let criticalHit = !!(
+    actionContext.criticalHit &&
+    actionContext.criticalHit.value &&
+    prop.damageType !== 'healing' // Can't critically heal
+  );
+  let context = new CompilationContext({
+    doubleRolls: criticalHit,
+  });
   try {
-    var {result, errors} = evaluateString(prop.amount, scope, 'reduce');
+    var {result, errors} = evaluateString(prop.amount, scope, 'reduce', context);
     if (typeof result !== 'number') {
-      return insertCreatureLog.call({ log: {
-        text: errors.join(', '),
-        creatureId: creature._id,
-      }});
+      log.content.push({
+        error: errors.join(', '),
+      });
     }
   } catch (e){
-    return insertCreatureLog.call({ log: {
-      text: e.toString(),
-      creatureId: creature._id,
-    }});
+    log.content.push({
+      error: e.toString(),
+    });
   }
-  if (damageTargets) {
+  let suffix = (criticalHit ? ' critical ' : '') +
+    prop.damageType +
+    (prop.damageType !== 'healing' ? ' damage': '');
+
+  if (damageTargets && damageTargets.length) {
     damageTargets.forEach(target => {
+      let name = prop.damageType === 'healing' ? 'Healing' : 'Damage';
       if (prop.target === 'each'){
         result = evaluateString(prop.amount, scope, 'reduce');
       }
@@ -37,27 +53,37 @@ export default function applyDamage({
         damageType: prop.damageType,
         amount: result,
       });
-      insertCreatureLog.call({
-        log: {
-          text: `Recieved ${damageDealt} ${prop.damageType}${prop.damageType !== 'healing'? ' damage': ''}`,
-          creatureId: target._id,
-        }
-      });
-      if (target._id !== creature._id){
+      if (target._id === creature._id){
+        log.content.push({
+          name,
+          result: damageDealt,
+          details: suffix + 'to self',
+        });
+      } else {
+        log.content.push({
+          name,
+          resultPrefix: 'Dealt ',
+          result: damageDealt,
+          details: suffix + `${target.name && ' to '}${target.name}`,
+        });
         insertCreatureLog.call({
           log: {
-            text: `Dealt ${damageDealt} ${prop.damageType}${prop.damageType !== 'healing'? ' damage': ''}`,
-            creatureId: creature._id,
+            content: [{
+              name,
+              resultPrefix: 'Recieved ',
+              result: damageDealt,
+              details: suffix,
+            }],
+            creatureId: target._id,
           }
         });
       }
     });
   } else {
-    insertCreatureLog.call({
-      log: {
-        text: `${result} ${prop.damageType}${prop.damageType !== 'healing'? ' damage': ''}`,
-        creatureId: creature._id,
-      }
+    log.content.push({
+      name: prop.damageType === 'healing' ? 'Healing' : 'Damage',
+      result,
+      details: suffix,
     });
   }
 }

app/imports/api/creature/actions/applyProperties.js

@@ -1,67 +1,81 @@
 import applyAction from '/imports/api/creature/actions/applyAction.js';
 import applyAdjustment from '/imports/api/creature/actions/applyAdjustment.js';
 import applyAttack from '/imports/api/creature/actions/applyAttack.js';
-import applyDamage from '/imports/api/creature/actions/applyDamage.js';
 import applyBuff from '/imports/api/creature/actions/applyBuff.js';
+import applyDamage from '/imports/api/creature/actions/applyDamage.js';
+import applyRoll from '/imports/api/creature/actions/applyRoll.js';
+import applyToggle from '/imports/api/creature/actions/applyToggle.js';
+import applySave from '/imports/api/creature/actions/applySave.js';
 
 function applyProperty(options){
   let prop = options.prop;
-  if (
-    prop.disabled === true || // ignore disabled props
-    prop.equipped === false || // ignore unequipped items
-    prop.toggleResult === false || // ignore untoggled toggles
-    prop.applied === true // ignore buffs that are already applied
-  ){
+  if (prop.type === 'buff'){
+    // ignore only applied buffs
+    if (prop.applied === true){
+      return false;
+    }
+  // Only ignore toggles if they wont be computed
+  } else if (prop.type === 'toggle') {
+    if (prop.disabled) return false;
+    if (prop.enabled) return true;
+    if (!prop.condition) return false;
+  // Ignore inactive props of other types
+  } else if (prop.deactivatedBySelf === true){
     return false;
   }
   switch (prop.type){
     case 'action':
     case 'spell':
       applyAction(options);
-      return true;
+      break;
     case 'attack':
       applyAction(options);
       applyAttack(options);
-      return true;
+      break;
     case 'damage':
       applyDamage(options);
-      return true;
+      break;
     case 'adjustment':
       applyAdjustment(options);
-      return true;
+      break;
     case 'buff':
       applyBuff(options);
-      return false;
+      break;
+    case 'toggle':
+      return applyToggle(options);
     case 'roll':
-      // applyRoll(options);
-      return true;
+      applyRoll(options);
+      break;
     case 'savingThrow':
-      // applySavingThrow(options);
-      return false;
+      return applySave(options);
+  }
+  return true;
+}
+
+function applyPropertyAndWalkChildren({prop, children, targets, ...options}){
+  let shouldKeepWalking = applyProperty({ prop, children, targets, ...options });
+  if (shouldKeepWalking){
+    applyProperties({ forest: children, targets, ...options,});
   }
 }
 
-export default function applyProperties({
-  forest,
-  creature,
-  targets,
-  actionContext
-}){
-  forest.forEach(child => {
-    let walkChildren = applyProperty({
-      prop: child.node,
-      children: child.children,
-      creature,
-      targets,
-      actionContext
-    });
-    if (walkChildren){
-      applyProperties({
-        forest: child.children,
-        creature,
-        targets,
-        actionContext
+export default function applyProperties({ forest, targets, ...options}){
+  forest.forEach(node => {
+    let prop = node.node;
+    let children = node.children;
+    if (shouldSplit(prop) && targets.length){
+      targets.forEach(target => {
+        let targets = [target]
+        applyPropertyAndWalkChildren({ targets, prop, children, ...options});
       });
+    } else {
+      applyPropertyAndWalkChildren({prop, children, targets, ...options});
     }
   });
 }
+
+function shouldSplit(prop){
+  if (prop.target === 'each'){
+    return true;
+  }
+}

app/imports/api/creature/actions/applyRoll.js

@@ -0,0 +1,32 @@
+import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
+
+export default function applyRoll({
+  prop,
+  creature,
+  actionContext,
+  log,
+}){
+  let scope = {
+    ...creature.variables,
+    ...actionContext,
+  };
+  try {
+    var {result, errors} = evaluateString(prop.roll, scope, 'reduce');
+    actionContext[prop.variableName] = result;
+    log.content.push({
+      name: prop.name,
+      resultPrefix: prop.variableName + ' = ' + prop.roll + ' = ',
+      result,
+    });
+    if (errors.length) {
+      log.content.push({
+        error: errors.join(', '),
+      });
+    }
+
+  } catch (e){
+    log.content.push({
+      error: e.toString(),
+    });
+  }
+}

app/imports/api/creature/actions/applySave.js

@@ -0,0 +1,79 @@
+import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
+import CreaturesProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import roll from '/imports/parser/roll.js';
+
+export default function applySave({
+  prop,
+  creature,
+  actionContext,
+  log,
+}){
+  let scope = {
+    ...creature.variables,
+    ...actionContext,
+  };
+  try {
+    // Calculate the DC
+    var {result, errors} = evaluateString(prop.dc, scope, 'reduce');
+    let dc = result;
+    log.content.push({
+      name: prop.name,
+      resultPrefix: ' DC ',
+      result,
+    });
+    if (errors.length) {
+      log.content.push({
+        error: errors.join(', '),
+      });
+      return false;
+    }
+    if (prop.target === 'self'){
+      let save = CreaturesProperties.findOne({
+        'ancestors.id': creature._id,
+        type: 'skill',
+        skillType: 'save',
+        variableName: prop.stat,
+        removed: {$ne: true},
+        inactive: {$ne: true},
+      });
+      if (!save){
+        log.content.push({
+          error: 'No saving throw found: ' + prop.stat,
+        });
+        return;
+      }
+      let value, values, resultPrefix;
+      if (save.advantage === 1){
+        values = roll(2, 20).sort().reverse();
+        value = values[0];
+        resultPrefix = `Advantage: 1d20 [${values[0]},~~${values[1]}~~] + ${save.value} = `
+      } else if (save.advantage === -1){
+        values = roll(2, 20).sort();
+        value = values[0];
+        resultPrefix = `Disadvantage: 1d20 [${values[0]},~~${values[1]}~~] + ${save.value} = `
+      } else {
+        values = roll(1, 20);
+        value = values[0];
+        resultPrefix = `1d20 [${value}] + ${save.value} = `
+      }
+      actionContext.savingThrowRoll = {value};
+      let result = value + save.value;
+      actionContext.savingThrow = {value: result};
+      let saveSuccess = result >= dc;
+      log.content.push({
+        name: 'Save',
+        resultPrefix,
+        result,
+        details: saveSuccess ? 'Passed' : 'Failed'
+      });
+      return !saveSuccess;
+    } else {
+      // TODO
+      return true;
+    }
+  } catch (e){
+    log.content.push({
+      error: e.toString(),
+    });
+  }
+}

app/imports/api/creature/actions/applyToggle.js

@@ -0,0 +1,35 @@
+import evaluateString from '/imports/api/creature/computation/afterComputation/evaluateString.js';
+
+export default function applyToggle({
+  prop,
+  creature,
+  actionContext,
+  log,
+}){
+  let scope = {
+    ...creature.variables,
+    ...actionContext,
+  };
+  if (Number.isFinite(+prop.condition)){
+    return !!+prop.condition;
+  }
+  try {
+    var {result, errors} = evaluateString(prop.condition, scope, 'reduce');
+    if (typeof result !== 'number' && typeof result !== 'boolean') {
+      log.content.push({
+        error: errors.join(', '),
+      });
+      return false;
+    }
+    log.content.push({
+      name: prop.name,
+      resultPrefix: prop.condition + ' = ',
+      result,
+    });
+    return !!result;
+  } catch (e){
+    log.content.push({
+      error: e.toString(),
+    });
+  }
+}

app/imports/api/creature/actions/castSpellWithSlot.js

@@ -0,0 +1,79 @@
+import SimpleSchema from 'simpl-schema';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import Creatures from '/imports/api/creature/Creatures.js';
+import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
+import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import { doActionWork } from '/imports/api/creature/actions/doAction.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+
+const castSpellWithSlot = new ValidatedMethod({
+  name: 'creatureProperties.castSpellWithSlot',
+  validate: new SimpleSchema({
+    spellId: SimpleSchema.RegEx.Id,
+    slotId: {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+      optional: true,
+    },
+    targetId: {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+      optional: true,
+    },
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 10,
+    timeInterval: 5000,
+  },
+  run({spellId, slotId, targetId}) {
+    let spell = CreatureProperties.findOne(spellId);
+		// Check permissions
+    let creature = getRootCreatureAncestor(spell);
+    assertEditPermission(creature, this.userId);
+    let target = undefined;
+    if (targetId) {
+      target = Creatures.findOne(targetId);
+      assertEditPermission(target, this.userId);
+    }
+    let slotLevel = spell.level || 0;
+    if (slotLevel !== 0){
+      let slot = CreatureProperties.findOne(slotId);
+      if (!slot){
+        throw new Meteor.Error('No slot',
+          'Slot not found to cast spell');
+      }
+      if (!slot.currentValue){
+        throw new Meteor.Error('No slot',
+          'Slot depleted');
+      }
+      if (!(slot.spellSlotLevelValue >= spell.level)){
+        throw new Meteor.Error('Slot too small',
+          'Slot is not large enough to cast spell');
+      }
+      slotLevel = slot.spellSlotLevelValue;
+      damagePropertyWork({
+        property: slot,
+        operation: 'increment',
+        value: 1,
+      });
+    }
+		doActionWork({
+      action: spell,
+      context: {slotLevel},
+      creature,
+      target,
+      method: this,
+    });
+    // Note this only recomputes the top-level creature, not the nearest one
+		recomputeCreatureByDoc(creature);
+    if (target){
+      recomputeCreatureByDoc(target);
+    }
+  },
+});
+
+export default castSpellWithSlot;

app/imports/api/creature/actions/doAction.js

@@ -1,20 +1,29 @@
 import SimpleSchema from 'simpl-schema';
 import { ValidatedMethod } from 'meteor/mdg:validated-method';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
-import CreatureProperties, { getCreature } from '/imports/api/creature/CreatureProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import Creatures from '/imports/api/creature/Creatures.js';
+import { CreatureLogSchema, insertCreatureLogWork } from '/imports/api/creature/log/CreatureLogs.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
 import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import { recomputeCreatureByDoc } from '/imports/api/creature/computation/recomputeCreature.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 import { nodesToTree } from '/imports/api/parenting/parenting.js';
 import applyProperties from '/imports/api/creature/actions/applyProperties.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 
 const doAction = new ValidatedMethod({
   name: 'creatureProperties.doAction',
   validate: new SimpleSchema({
     actionId: SimpleSchema.RegEx.Id,
-    targetId: {
+    targetIds: {
+      type: Array,
+      defaultValue: [],
+      maxCount: 10,
+      optional: true,
+    },
+    'targetIds.$': {
       type: String,
       regEx: SimpleSchema.RegEx.Id,
-      optional: true,
     },
   }).validator(),
   mixins: [RateLimiterMixin],
@@ -22,27 +31,42 @@ const doAction = new ValidatedMethod({
     numRequests: 10,
     timeInterval: 5000,
   },
-  run({actionId, targetId}) {
+  run({actionId, targetIds = []}) {
     let action = CreatureProperties.findOne(actionId);
 		// Check permissions
-    let creature = getCreature(action);
+    let creature = getRootCreatureAncestor(action);
     assertEditPermission(creature, this.userId);
-    let target = undefined;
-    if (targetId) {
-      target = getCreature(targetId);
+    let targets = [];
+    targetIds.forEach(targetId => {
+      let target = Creatures.findOne(targetId);
       assertEditPermission(target, this.userId);
-    }
-		doActionWork({action, creature, target});
-    // Note this only recomputes the top-level creature, not the nearest one
+      targets.push(target);
+    });
+		doActionWork({action, creature, targets, method: this});
+
+    // The acting creature might have used ammo
+    recomputeInventory(creature._id);
+    // recompute creatures
 		recomputeCreatureByDoc(creature);
-    if (target){
+    targets.forEach(target => {
       recomputeCreatureByDoc(target);
-    }
+    });
   },
 });
 
-function doActionWork({action, creature, target}){
-  let actionContext = {};
+export function doActionWork({
+  action,
+  creature,
+  targets,
+  context = {},
+  method
+}){
+  // Create the log
+  let log = CreatureLogSchema.clean({
+    creatureId: creature._id,
+    creatureName: creature.name,
+  });
+
   let decendantForest = nodesToTree({
     collection: CreatureProperties,
     ancestorId: action._id,
@@ -53,10 +77,12 @@ function doActionWork({action, creature, target}){
   }];
   applyProperties({
     forest: startingForest,
+    actionContext: context,
     creature,
-    target,
-    actionContext
+    targets,
+    log,
   });
+  insertCreatureLogWork({log, creature, method});
 }
 
 export default doAction;

app/imports/api/creature/actions/spendResources.js

@@ -1,27 +1,31 @@
-import CreatureProperties, { damagePropertyWork, adjustQuantityWork } from '/imports/api/creature/CreatureProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { adjustQuantityWork } from '/imports/api/creature/creatureProperties/methods/adjustQuantity.js';
+import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
 
-export default function spendResources(action){
+export default function spendResources({prop, log}){
   // Check Uses
-  if (action.usesUsed >= action.usesResult){
+  if (prop.usesUsed >= prop.usesResult){
     throw new Meteor.Error('Insufficient Uses',
-      'This action has no uses left');
+      'This prop has no uses left');
   }
   // Resources
-  if (action.insufficientResources){
+  if (prop.insufficientResources){
     throw new Meteor.Error('Insufficient Resources',
-      'This creature doesn\'t have sufficient resources to perform this action');
+      'This creature doesn\'t have sufficient resources to perform this prop');
   }
   // Items
   let itemQuantityAdjustments = [];
-  action.resources.itemsConsumed.forEach(itemConsumed => {
+  let spendLog = [];
+  let gainLog = [];
+  prop.resources.itemsConsumed.forEach(itemConsumed => {
     if (!itemConsumed.itemId){
       throw new Meteor.Error('Ammo not selected',
-        'No ammo was selected for this action');
+        'No ammo was selected for this prop');
     }
     let item = CreatureProperties.findOne(itemConsumed.itemId);
-    if (!item || item.ancestors[0].id !== action.ancestors[0].id){
+    if (!item || item.ancestors[0].id !== prop.ancestors[0].id){
       throw new Meteor.Error('Ammo not found',
-        'The action\'s ammo was not found on the creature');
+        'The prop\'s ammo was not found on the creature');
     }
     if (!item.equipped){
       throw new Meteor.Error('Ammo not equipped',
@@ -33,19 +37,36 @@ export default function spendResources(action){
       operation: 'increment',
       value: itemConsumed.quantity,
     });
+    let logName = item.name;
+    if (itemConsumed.quantity > 1 || itemConsumed.quantity < -1){
+      logName = item.plural || logName;
+    }
+    if (itemConsumed.quantity > 0){
+      spendLog.push(logName + ': ' + itemConsumed.quantity);
+    } else if (itemConsumed.quantity < 0){
+      gainLog.push(logName + ': ' + -itemConsumed.quantity);
+    }
   });
   // No more errors should be thrown after this line
   // Now that we have confirmed that there are no errors, do actual work
   //Items
   itemQuantityAdjustments.forEach(adjustQuantityWork);
+  
   // Use uses
-  CreatureProperties.update(action._id, {
-    $inc: {usesUsed: 1}
-  }, {
-    selector: action
-  });
+  if (prop.usesResult){
+    CreatureProperties.update(prop._id, {
+      $inc: {usesUsed: 1}
+    }, {
+      selector: prop
+    });
+    log.content.push({
+      name: 'Uses left',
+      result: prop.usesResult - prop.usesUsed - 1,
+    });
+  }
+
   // Damage stats
-  action.resources.attributesConsumed.forEach(attConsumed => {
+  prop.resources.attributesConsumed.forEach(attConsumed => {
     if (!attConsumed.quantity) return;
     let stat = CreatureProperties.findOne(attConsumed.statId);
     damagePropertyWork({
@@ -53,5 +74,20 @@ export default function spendResources(action){
       operation: 'increment',
       value: attConsumed.quantity,
     });
+    if (attConsumed.quantity > 0){
+      spendLog.push(stat.name + ': ' + attConsumed.quantity);
+    } else if (attConsumed.quantity < 0){
+      gainLog.push(stat.name + ': ' + -attConsumed.quantity);
+    }
+  });
+
+  // Log all the spending
+  if (gainLog.length) log.content.push({
+    name: 'Gained',
+    description: gainLog.join('\n'),
+  });
+  if (spendLog.length) log.content.push({
+    name: 'Spent',
+    description: spendLog.join('\n'),
   });
 }

app/imports/api/creature/computation/afterComputation/embedInlineCalculations.js

@@ -0,0 +1,11 @@
+import INLINE_CALCULATION_REGEX from '/imports/constants/INLINE_CALCULTION_REGEX.js';
+
+export default function embedInlineCalculations(string, calculations){
+  if (!string) return '';
+  if (!calculations) return string;
+  let index = 0;
+  return string.replace(INLINE_CALCULATION_REGEX, substring => {
+    let comp = calculations && calculations[index++];
+    return (comp && 'result' in comp) ? comp.result : substring;
+  });
+}

app/imports/api/creature/computation/afterComputation/evaluateString.js

@@ -1,7 +1,7 @@
 import { parse, CompilationContext } from '/imports/parser/parser.js';
 import ConstantNode from '/imports/parser/parseTree/ConstantNode.js';
 
-export default function evaluateString(string, scope, fn = 'compile'){
+export default function evaluateString(string, scope, fn = 'compile', context){
   let errors = [];
   if (!string){
     errors.push('No string provided');
@@ -18,8 +18,9 @@ export default function evaluateString(string, scope, fn = 'compile'){
     errors.push(e);
     return {result: string, errors};
   }
-
-  let context = new CompilationContext();
+  if (!context){
+    context = new CompilationContext({});
+  }
   let result = node[fn](scope, context);
   if (result instanceof ConstantNode){
     return {result: result.value, errors: context.errors}

app/imports/api/creature/computation/afterComputation/evalutateStringWithEmbeddedCalculations.js

@@ -2,6 +2,8 @@ import evaluateString from '/imports/api/creature/computation/afterComputation/e
 
 // Strings can have computations in bracers like so: {computation}
 export default function evalutateStringWithEmbeddedCalculations(string, scope){
+  console.warn('evalutateStringWithEmbeddedCalculations should be replaced with ' +
+  'fetching the result from the compuations on the property doc');
 	if (!string) return string;
   // Compute everything inside bracers
 	return string.replace(/\{([^{}]*)\}/g, function(match, p1){

app/imports/api/creature/computation/engine/ComputationMemo.js

@@ -1,10 +1,12 @@
 import { includes, cloneDeep } from 'lodash';
+import findAncestorByType from '/imports/api/creature/computation/engine/findAncestorByType.js';
 
 // The computation memo is an in-memory data structure used only during the
 // computation process
 export default class ComputationMemo {
   constructor(props, creature){
     this.statsByVariableName = {};
+    this.constantsByVariableName = {};
     this.extraStatsByVariableName = {};
     this.statsById = {};
     this.originalPropsById = {};
@@ -50,13 +52,15 @@ export default class ComputationMemo {
         return true;
       }
     }).forEach((prop) => {
-      // Now add all effects and proficiencies
+      // Now add everything else
       if (prop.type === 'effect'){
         this.addEffect(prop);
       } else if (prop.type === 'proficiency') {
         this.addProficiency(prop);
       } else if (prop.type === 'classLevel'){
         this.addClassLevel(prop);
+      } else if (prop.type === 'constant'){
+        this.addConstant(prop);
       } else {
         this.addEndStepProp(prop);
       }
@@ -71,9 +75,18 @@ export default class ComputationMemo {
       }
     }
   }
+  addConstant(prop){
+    prop = this.registerProperty(prop);
+    if (
+      !this.constantsByVariableName[prop.variableName]
+    ){
+      this.constantsByVariableName[prop.variableName] = prop
+    }
+  }
   registerProperty(prop){
     this.originalPropsById[prop._id] = cloneDeep(prop);
     this.propsById[prop._id] = prop;
+    prop.dependencies = [];
     prop.computationDetails = propDetails(prop);
     prop.ancestors.forEach(ancestor => {
       if (this.toggleIds.has(ancestor.id)){
@@ -104,6 +117,7 @@ export default class ComputationMemo {
           stats: [variableName],
           computationDetails: propDetailsByType.effect(),
           statBase: true,
+          dependencies: [],
         });
       }
       if (prop.baseProficiency){
@@ -113,6 +127,7 @@ export default class ComputationMemo {
           computationDetails: propDetailsByType.proficiency(),
           type: 'proficiency',
           statBase: true,
+          dependencies: [],
         });
       }
     } else {
@@ -138,7 +153,7 @@ export default class ComputationMemo {
     prop = this.registerProperty(prop);
     let targets = this.getEffectTargets(prop);
     targets.forEach(target => {
-      if (target.computationDetails.effects){
+      if (target.computationDetails && target.computationDetails.effects){
         target.computationDetails.effects.push(prop);
       }
     });
@@ -150,7 +165,16 @@ export default class ComputationMemo {
     let targets = new Set();
     if (!prop.stats) return targets;
     prop.stats.forEach((statName) => {
-      let target = this.statsByVariableName[statName];
+      let target;
+      if (statName[0] === '#'){
+        target = findAncestorByType({
+          type: statName.slice(1),
+          prop,
+          memo: this
+        });
+      } else {
+        target = this.statsByVariableName[statName];
+      }
       if (!target) return;
       targets.add(target);
       if (isSkillOperation(prop) && isAbility(target)){

app/imports/api/creature/computation/engine/EffectAggregator.js

@@ -1,11 +1,24 @@
-import evaluateCalculation from '/imports/api/creature/computation/evaluateCalculation.js';
+import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
+import { union } from 'lodash';
 
 export default class EffectAggregator{
   constructor(stat, memo){
     delete this.baseValueErrors;
     if (stat.baseValueCalculation){
-      let {result, context} = evaluateCalculation(stat.baseValueCalculation, memo);
-      this.statBaseValue = result.value;
+      let {
+        result,
+        context,
+        dependencies
+      } = evaluateCalculation({
+        string: stat.baseValueCalculation,
+        prop: stat,
+        memo
+      });
+      this.statBaseValue = +result.value;
+      stat.dependencies = union(
+        stat.dependencies,
+        dependencies,
+      );
       if (context.errors.length){
         this.baseValueErrors = context.errors;
       }
@@ -19,7 +32,7 @@ export default class EffectAggregator{
     this.max = Number.POSITIVE_INFINITY;
     this.advantage = 0;
     this.disadvantage = 0;
-    this.passiveAdd = 0;
+    this.passiveAdd = undefined;
     this.fail = 0;
     this.set = undefined;
     this.conditional = [];
@@ -69,6 +82,7 @@ export default class EffectAggregator{
         break;
       case 'passiveAdd':
         // Add all passive adds together
+        if (this.passiveAdd === undefined) this.passiveAdd = 0;
         this.passiveAdd += result;
         break;
       case 'fail':

app/imports/api/creature/computation/engine/applyToggles.js

@@ -1,9 +1,15 @@
-import computeToggle from '/imports/api/creature/computation/computeToggle.js';
+import computeToggle from '/imports/api/creature/computation/engine/computeToggle.js';
+import { union } from 'lodash';
 
 export default function applyToggles(prop, memo){
   prop.computationDetails.toggleAncestors.forEach(toggleId => {
     let toggle = memo.togglesById[toggleId];
     computeToggle(toggle, memo);
+    prop.dependencies = union(
+      prop.dependencies,
+      [toggle._id],
+      toggle.dependencies,
+    );
     if (!toggle.toggleResult){
       prop.computationDetails.disabledByToggle = true;
     }

app/imports/api/creature/computation/engine/combineStat.js

@@ -1,6 +1,7 @@
-import computeStat from '/imports/api/creature/computation/computeStat.js';
-import applyToggles from '/imports/api/creature/computation/applyToggles.js';
-import evaluateCalculation from '/imports/api/creature/computation/evaluateCalculation.js';
+import computeStat from '/imports/api/creature/computation/engine/computeStat.js';
+import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
+import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
+import { union } from 'lodash';
 
 export default function combineStat(stat, aggregator, memo){
   if (stat.type === 'attribute'){
@@ -34,14 +35,40 @@ function combineAttribute(stat, aggregator, memo){
   stat.baseValue = aggregator.statBaseValue;
   stat.baseValueErrors = aggregator.baseValueErrors;
   if (stat.attributeType === 'spellSlot'){
-    let {result, context} = evaluateCalculation(stat.spellSlotLevelCalculation, memo);
+    let {
+      result,
+      context,
+      dependencies
+    } = evaluateCalculation({
+      string: stat.spellSlotLevelCalculation,
+      memo,
+      prop: stat,
+    });
     stat.spellSlotLevelValue = result.value;
     stat.spellSlotLevelErrors = context.errors;
+    stat.dependencies = union(stat.dependencies, dependencies);
   }
   stat.currentValue = stat.value - (stat.damage || 0);
+  // Ability scores get modifiers
   if (stat.attributeType === 'ability') {
     stat.modifier = Math.floor((stat.currentValue - 10) / 2);
+  } else {
+    stat.modifier = undefined;
   }
+  // Hit dice get constitution modifiers
+  stat.constitutionMod = undefined;
+  if (stat.attributeType === 'hitDice') {
+    let conStat = memo.statsByVariableName['constitution'];
+    if (conStat && 'modifier' in conStat){
+      stat.constitutionMod = conStat.modifier;
+      stat.dependencies = union(
+        stat.dependencies,
+        [conStat._id],
+        conStat.dependencies,
+      );
+    }
+  }
+  // Stats that have no effects can be hidden based on a sheet setting
   stat.hide = aggregator.hasNoEffects &&
     stat.baseValue === undefined ||
     undefined
@@ -49,12 +76,19 @@ function combineAttribute(stat, aggregator, memo){
 
 function combineSkill(stat, aggregator, memo){
   // Skills are based on some ability Modifier
-  let ability = memo.statsByVariableName[stat.ability]
+  let ability = stat.ability && memo.statsByVariableName[stat.ability]
   if (stat.ability && ability){
     if (!ability.computationDetails.computed){
       computeStat(ability, memo);
     }
     stat.abilityMod = ability.modifier;
+    stat.dependencies = union(
+      stat.dependencies,
+      [ability._id],
+      ability.dependencies,
+    );
+  } else {
+    stat.abilityMod = 0;
   }
   // Combine all the child proficiencies
   stat.proficiency = stat.baseProficiency || 0;
@@ -66,6 +100,11 @@ function combineSkill(stat, aggregator, memo){
       prof.value > stat.proficiency
     ){
       stat.proficiency = prof.value;
+      stat.dependencies = union(
+        stat.dependencies,
+        [prof._id],
+        prof.dependencies,
+      );
     }
   }
   // Get the character's proficiency bonus to apply
@@ -75,6 +114,18 @@ function combineSkill(stat, aggregator, memo){
   if (typeof profBonus !== 'number' && memo.statsByVariableName['level']){
     let level = memo.statsByVariableName['level'].value;
     profBonus = Math.ceil(level / 4) + 1;
+    if (level._id){
+      stat.dependencies = union(stat.dependencies, [level._id]);
+    }
+    if (level.dependencies){
+      stat.dependencies = union(stat.dependencies, level.dependencies);
+    }
+  } else {
+    stat.dependencies = union(
+      stat.dependencies,
+      [profBonusStat._id],
+      profBonusStat.dependencies,
+    );
   }
   // Multiply the proficiency bonus by the actual proficiency
   profBonus *= stat.proficiency;

app/imports/api/creature/computation/engine/computeEffect.js

@@ -1,5 +1,6 @@
-import evaluateCalculation from '/imports/api/creature/computation/evaluateCalculation.js';
-import applyToggles from '/imports/api/creature/computation/applyToggles.js';
+import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
+import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
+import { union } from 'lodash';
 
 export default function computeEffect(effect, memo){
   if (effect.computationDetails.computed) return;
@@ -34,8 +35,17 @@ export default function computeEffect(effect, memo){
   } else if(_.contains(['advantage', 'disadvantage', 'fail'], effect.operation)){
     effect.result = 1;
   } else {
-    let {result, context} = evaluateCalculation(effect.calculation, memo);
+    let {
+      result,
+      context,
+      dependencies,
+    } = evaluateCalculation({
+      string: effect.calculation,
+      prop: effect,
+      memo
+    });
     effect.result = result.value;
+    effect.dependencies = union(effect.dependencies, dependencies);
     if (context.errors.length){
       effect.errors = context.errors;
     }

app/imports/api/creature/computation/engine/computeEndStepProperty.js

@@ -1,4 +1,6 @@
-import evaluateCalculation from '/imports/api/creature/computation/evaluateCalculation.js';
+import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
+import ConstantNode from '/imports/parser/parseTree/ConstantNode.js';
+import { union } from 'lodash';
 
 export default function computeEndStepProperty(prop, memo){
   switch (prop.type){
@@ -6,25 +8,41 @@ export default function computeEndStepProperty(prop, memo){
     case 'spell':
       computeAction(prop, memo);
       break;
+    case 'adjustment':
+    case 'damage':
+      computePropertyField(prop, memo, 'amount', 'compile');
+      break;
     case 'attack':
       computeAction(prop, memo);
-      computeAttack(prop, memo);
+      computePropertyField(prop, memo, 'rollBonus');
       break;
     case 'savingThrow':
-      computeSavingThrow(prop, memo);
+      computePropertyField(prop, memo, 'dc');
       break;
     case 'spellList':
-      computeSpellList(prop, memo);
+      computePropertyField(prop, memo, 'maxPrepared');
+      computePropertyField(prop, memo, 'attackRollBonus');
+      computePropertyField(prop, memo, 'dc');
       break;
     case 'propertySlot':
-      computeSlot(prop, memo);
+      computePropertyField(prop, memo, 'quantityExpected');
+      computePropertyField(prop, memo, 'slotCondition');
+      break;
+    case 'roll':
+      computePropertyField(prop, memo, 'roll', 'compile');
+      break;
   }
 }
 
 function computeAction(prop, memo){
   // Uses
-  let {result, context} = evaluateCalculation(prop.uses, memo);
+  let {
+    result,
+    context,
+    dependencies,
+  } = evaluateCalculation({ string: prop.uses, prop, memo});
   prop.usesResult = result.value;
+  prop.dependencies = union(prop.dependencies, dependencies);
   if (context.errors.length){
     prop.usesErrors = context.errors;
   } else {
@@ -46,6 +64,13 @@ function computeAction(prop, memo){
       if (available < attConsumed.quantity){
         prop.insufficientResources = true;
       }
+      if (stat){
+        prop.dependencies = union(
+          prop.dependencies,
+          [stat._id],
+          stat.dependencies
+        );
+      }
     }
   });
   // Items consumed
@@ -64,31 +89,31 @@ function computeAction(prop, memo){
     if (!item || available < itemConsumed.quantity){
       prop.insufficientResources = true;
     }
+    if (item){
+      prop.dependencies = union(
+        prop.dependencies,
+        [item._id],
+        item.dependencies
+      );
+    }
   });
 }
 
 function computePropertyField(prop, memo, fieldName, fn){
-  let {result, context} = evaluateCalculation(prop[fieldName], memo, fn);
-  prop[`${fieldName}Result`] = result.value;
+  let {
+    result,
+    context,
+    dependencies,
+  } = evaluateCalculation({string: prop[fieldName], prop, memo, fn});
+  if (result instanceof ConstantNode){
+    prop[`${fieldName}Result`] = result.value;
+  } else {
+    prop[`${fieldName}Result`] = result.toString();
+  }
+  prop.dependencies = union(prop.dependencies, dependencies);
   if (context.errors.length){
     prop[`${fieldName}Errors`] = context.errors;
   } else {
     delete prop[`${fieldName}Errors`];
   }
 }
-
-function computeAttack(prop, memo){
-  computePropertyField(prop, memo, 'rollBonus');
-}
-
-function computeSavingThrow(prop, memo){
-  computePropertyField(prop, memo, 'dc');
-}
-
-function computeSpellList(prop, memo){
-  computePropertyField(prop, memo, 'maxPrepared');
-}
-
-function computeSlot(prop, memo){
-  computePropertyField(prop, memo, 'slotCondition');
-}

app/imports/api/creature/computation/engine/computeInlineCalculations.js

@@ -0,0 +1,40 @@
+import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
+import INLINE_CALCULATION_REGEX from '/imports/constants/INLINE_CALCULTION_REGEX.js';
+import ErrorNode from '/imports/parser/parseTree/ErrorNode.js';
+import { union } from 'lodash';
+
+export default function computeInlineCalculations(prop, memo){
+  if (prop.summary){
+    computeInlineCalcsForField(prop, memo, 'summary');
+  }
+  if (prop.description){
+    computeInlineCalcsForField(prop, memo, 'description');
+  }
+}
+
+function computeInlineCalcsForField(prop, memo, field){
+  let string = prop[field];
+  let inlineComputations = [];
+  let matches = string.matchAll(INLINE_CALCULATION_REGEX);
+  for (let match of matches){
+    let calculation = match[1];
+    let {
+      result,
+      context,
+      dependencies,
+    } = evaluateCalculation({string: calculation, prop, memo, fn: 'compile'});
+    if (result instanceof ErrorNode){
+      result = '`Calculation Error`';
+    }
+    let computation = {
+      calculation,
+      result: result && result.toString(),
+    };
+    if (context.errors.length){
+      computation.errors = context.errors;
+    }
+    inlineComputations.push(computation);
+    prop.dependencies = union(prop.dependencies, dependencies);
+  }
+  prop[`${field}Calculations`] = inlineComputations;
+}

app/imports/api/creature/computation/engine/computeLevels.js

@@ -1,4 +1,4 @@
-import { forOwn, has } from 'lodash';
+import { forOwn, has, union } from 'lodash';
 
 export default function computeLevels(memo){
   computeClassLevels(memo);
@@ -7,6 +7,11 @@ export default function computeLevels(memo){
 
 function computeClassLevels(memo){
   forOwn(memo.classLevelsById, classLevel => {
+    //  class levels are mutually dependent
+    classLevel.dependencies = union(
+      classLevel.dependencies,
+      Object.keys(memo.classLevelsById)
+    );
     let name = classLevel.variableName;
     let stat = memo.statsByVariableName[name];
     if (!stat){
@@ -27,6 +32,7 @@ function computeTotalLevel(memo){
   if (!currentLevel){
     currentLevel = {
       value: 0,
+      dependencies: [],
       computationDetails: {
         builtIn: true,
         computed: true,
@@ -38,7 +44,20 @@ function computeTotalLevel(memo){
   if (!currentLevel.computationDetails.builtIn) return;
   let level = 0;
   for (let name in memo.classes){
-    level += memo.classes[name].level || 0;
+    let cls = memo.classes[name];
+    level += cls.level || 0;
+    if (cls._id){
+      currentLevel.dependencies = union(
+        currentLevel.dependencies,
+        [cls._id]
+      )
+    }
+    if (cls.dependencies){
+      currentLevel.dependencies = union(
+        currentLevel.dependencies,
+        cls.dependencies,
+      )
+    }
   }
-  memo.statsByVariableName['level'].value = level;
+  currentLevel.value = level;
 }

app/imports/api/creature/computation/engine/computeMemo.js

@@ -1,9 +1,10 @@
 import { each, forOwn } from 'lodash';
-import computeLevels from '/imports/api/creature/computation/computeLevels.js';
-import computeStat from '/imports/api/creature/computation/computeStat.js';
-import computeEffect from '/imports/api/creature/computation/computeEffect.js';
-import computeToggle from '/imports/api/creature/computation/computeToggle.js';
-import computeEndStepProperty from '/imports/api/creature/computation/computeEndStepProperty.js';
+import computeLevels from '/imports/api/creature/computation/engine/computeLevels.js';
+import computeStat from '/imports/api/creature/computation/engine/computeStat.js';
+import computeEffect from '/imports/api/creature/computation/engine/computeEffect.js';
+import computeToggle from '/imports/api/creature/computation/engine/computeToggle.js';
+import computeEndStepProperty from '/imports/api/creature/computation/engine/computeEndStepProperty.js';
+import computeInlineCalculations from '/imports/api/creature/computation/engine/computeInlineCalculations.js';
 
 export default function computeMemo(memo){
   // Compute level
@@ -24,4 +25,8 @@ export default function computeMemo(memo){
   forOwn(memo.endStepPropsById, prop => {
     computeEndStepProperty(prop, memo);
   });
+  // Compute inline calculations
+  forOwn(memo.propsById, prop => {
+    computeInlineCalculations(prop, memo);
+  });
 }

app/imports/api/creature/computation/engine/computeStat.js

@@ -1,8 +1,8 @@
-import combineStat from '/imports/api/creature/computation/combineStat.js';
-import computeEffect from '/imports/api/creature/computation/computeEffect.js';
-import EffectAggregator from '/imports/api/creature/computation/EffectAggregator.js';
-import applyToggles from '/imports/api/creature/computation/applyToggles.js';
-import { each } from 'lodash';
+import combineStat from '/imports/api/creature/computation/engine/combineStat.js';
+import computeEffect from '/imports/api/creature/computation/engine/computeEffect.js';
+import EffectAggregator from '/imports/api/creature/computation/engine/EffectAggregator.js';
+import applyToggles from '/imports/api/creature/computation/engine/applyToggles.js';
+import { each, union } from 'lodash';
 
 export default function computeStat(stat, memo){
   // If the stat is already computed, skip it
@@ -27,6 +27,16 @@ export default function computeStat(stat, memo){
     let aggregator = new EffectAggregator(stat, memo)
     each(stat.computationDetails.effects, (effect) => {
       computeEffect(effect, memo);
+      if (effect._id){
+        stat.dependencies = union(
+          stat.dependencies,
+          [effect._id]
+        );
+      }
+      stat.dependencies = union(
+        stat.dependencies,
+        effect.dependencies
+      )
       if (!effect.computationDetails.disabledByToggle){
         aggregator.addEffect(effect);
       }

app/imports/api/creature/computation/engine/computeToggle.js

@@ -1,4 +1,5 @@
-import evaluateCalculation from '/imports/api/creature/computation/evaluateCalculation.js';
+import evaluateCalculation from '/imports/api/creature/computation/engine/evaluateCalculation.js';
+import { union } from 'lodash';
 
 export default function computeToggle(toggle, memo){
   if (toggle.computationDetails.computed) return;
@@ -26,8 +27,16 @@ export default function computeToggle(toggle, memo){
   } else if (Number.isFinite(+toggle.condition)){
     toggle.toggleResult = !!+toggle.condition;
   } else {
-    let {result, context} = evaluateCalculation(toggle.condition, memo);
+    let {
+      result,
+      context,
+      dependencies,
+    } = evaluateCalculation({string: toggle.condition, prop: toggle, memo});
     toggle.toggleResult = !!result.value;
+    toggle.dependencies = union(
+      toggle.dependencies,
+      dependencies,
+    );
     if (context.errors.length){
       toggle.errors = context.errors;
     }

app/imports/api/creature/computation/engine/evaluateCalculation.js

@@ -0,0 +1,137 @@
+import computeStat from '/imports/api/creature/computation/engine/computeStat.js';
+import { prettifyParseError, parse, CompilationContext } from '/imports/parser/parser.js';
+import SymbolNode from '/imports/parser/parseTree/SymbolNode.js';
+import AccessorNode from '/imports/parser/parseTree/AccessorNode.js';
+import ConstantNode from '/imports/parser/parseTree/ConstantNode.js';
+import ErrorNode from '/imports/parser/parseTree/ErrorNode.js';
+import findAncestorByType from '/imports/api/creature/computation/engine/findAncestorByType.js';
+import { union } from 'lodash';
+
+/* Convert a calculation into a constant output and errors*/
+export default function evaluateCalculation({
+  string,
+  prop,
+  memo,
+  fn = 'reduce',
+}){
+  let dependencies = [];
+  let context = new CompilationContext();
+  if (!string) return {
+    result: new ConstantNode({value: string, type: 'string'}),
+    context,
+    dependencies,
+  };
+  if (typeof string !== 'string'){
+    string = string.toString();
+  }
+  // Parse the string
+  let calc;
+  try {
+    calc = parse(string);
+  } catch (e) {
+    let error = prettifyParseError(e);
+    return {
+      result: new ErrorNode({context, error}),
+      context,
+      dependencies,
+    };
+  }
+
+  // Replace constants with their parsed constant
+  let replaceResults = replaceConstants({
+    calc, memo, prop, dependencies, context
+  });
+  dependencies = replaceResults.dependencies;
+  calc = replaceResults.calc;
+  if (replaceResults.failed){
+    return {
+      result: new ConstantNode({value: string, type: 'string'}),
+      context,
+      dependencies,
+    };
+  }
+
+  // Ensure all symbol nodes are defined and computed
+  dependencies = computeSymbols({calc, memo, prop, dependencies})
+
+  // Evaluate
+  let result = calc[fn](memo.statsByVariableName, context);
+  return {result, context, dependencies};
+}
+
+// Replace constants in the calc with the right ParseNodes
+function replaceConstants({calc, memo, prop, dependencies, context}){
+  let constFailed = [];
+  calc = calc.replaceNodes(node => {
+    if (!(node instanceof SymbolNode)) return;
+    let stat, constant;
+    if (node.name[0] !== '#'){
+      stat = memo.statsByVariableName[node.name]
+      constant = memo.constantsByVariableName[node.name];
+    } else if (node.name === '#constant'){
+      constant = findAncestorByType({type: 'constant', prop, memo});
+    }
+    // replace constants that aren't overridden by stats
+    if (constant && !stat){
+      dependencies = union(dependencies, [
+        constant._id,
+        ...constant.dependencies
+      ]);
+      // Fail if the constant has errors
+      if (constant.errors && constant.errors.length){
+        constFailed.push(node.name);
+        return;
+      }
+      let parsedConstantNode;
+      try {
+        parsedConstantNode = parse(constant.calculation);
+      } catch(e){
+        constFailed.push(node.name);
+        return;
+      }
+      if (!parsedConstantNode) constFailed.push(node.name);
+      return parsedConstantNode;
+    }
+  });
+  constFailed.forEach(name => {
+    context.storeError({
+      type: 'error',
+      message: `${name} is a constant property with parsing errors`
+    });
+  });
+  let failed = !!constFailed.length;
+  if (failed){
+    calc = new ErrorNode({error: 'Failed to replace constants'});
+  }
+  return { failed, dependencies, calc };
+}
+
+  // Ensure all symbol nodes are defined and computed
+function computeSymbols({calc, memo, prop, dependencies}){
+  calc.traverse(node => {
+    if (node instanceof SymbolNode || node instanceof AccessorNode){
+      let stat;
+      // References up the tree start with #
+      if (node.name[0] === '#'){
+        stat = findAncestorByType({type: node.name.slice(1), prop, memo});
+        memo.statsByVariableName[node.name] = stat;
+      } else {
+        stat = memo.statsByVariableName[node.name];
+      }
+      if (stat && stat.computationDetails && !stat.computationDetails.computed){
+        computeStat(stat, memo);
+      }
+      if (stat){
+        if (stat.dependencies){
+          dependencies = union(dependencies, [
+            stat._id || node.name,
+            ...stat.dependencies
+          ]);
+        } else {
+          dependencies = union(dependencies, [stat._id || node.name]);
+        }
+      }
+    }
+  });
+  return dependencies;
+}

app/imports/api/creature/computation/engine/findAncestorByType.js

@@ -0,0 +1,10 @@
+export default function findAncestorByType({type, prop, memo}){
+  if (!prop || !prop.ancestors) return;
+  let ancestor;
+  for (let i = prop.ancestors.length - 1; i >= 0; i--){
+    ancestor = memo.propsById[prop.ancestors[i].id];
+    if (ancestor && ancestor.type === type){
+      return ancestor;
+    }
+  }
+}

app/imports/api/creature/computation/engine/getComputationProperties.js

@@ -0,0 +1,35 @@
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+
+export default function getComputationProperties(creatureId){
+  // find ids of all toggles that have conditions, even if they are inactive
+  let toggleIds = CreatureProperties.find({
+    'ancestors.id': creatureId,
+    type: 'toggle',
+    removed: {$ne: true},
+    condition: { $exists: true },
+  }, {
+    fields: {_id: 1},
+  }).map(t => t._id);
+  // Find all the relevant properties
+  return CreatureProperties.find({
+    'ancestors.id': creatureId,
+    removed: {$ne: true},
+    $or: [
+      // All active properties
+      {inactive: {$ne: true}},
+      // All active and inactive toggles with conditions
+      // Same as {$in: toggleIds}, but should be slightly faster
+      {type: 'toggle', condition: { $exists: true }},
+      // All decendents of the above toggles
+      {'ancestors.id': {$in: toggleIds}},
+    ]
+  }, {
+    // Filter out fields never used by calculations
+    fields: {
+      icon: 0,
+    },
+    sort: {
+      order: 1,
+    }
+  }).fetch();
+}

app/imports/api/creature/computation/engine/getDependentProperties.js

@@ -0,0 +1,51 @@
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { union } from 'lodash';
+
+export default function getDependentProperties({
+  creatureId,
+  propertyIds,
+  propertiesDependedAponIds,
+ }){
+  // find ids of all dependant toggles that have conditions, even if inactive
+  let toggleIds = CreatureProperties.find({
+    'ancestors.id': creatureId,
+    type: 'toggle',
+    removed: {$ne: true},
+    condition: { $exists: true },
+    dependencies: {$in: propertyIds},
+  }, {
+    fields: {_id: 1},
+  }).map(t => t._id);
+  // Find all the dependant properties
+  let props = CreatureProperties.find({
+    'ancestors.id': creatureId,
+    removed: {$ne: true},
+    dependencies: {$in: propertyIds},
+    $or: [
+      // All active properties
+      {inactive: {$ne: true}},
+      // All active and inactive toggles with conditions
+      // Same as {$in: toggleIds}, but should be slightly faster
+      {type: 'toggle', condition: { $exists: true }},
+      // All decendents of the above toggles
+      {'ancestors.id': {$in: toggleIds}},
+    ]
+  }, { fields: {_id: 1, dependencies: 1} }).fetch();
+  // Add all the properties that changing props depend on, but haven't yet been
+  // included to make an array of every property we need
+  let allConnectedPropIds = [...propertyIds, ...propertiesDependedAponIds];
+  props.forEach(prop => {
+    allConnectedPropIds = union(
+      allConnectedPropIds,
+      prop.dependencies,
+      [prop._id]);
+  });
+  // Add on all the properties and the objects they depend apon
+  return CreatureProperties.find({
+    _id: {$in: allConnectedPropIds}
+  }, {
+    // Ignore fields not used in computations
+    fields: {icon: 0},
+    sort: {order: 1},
+  }).fetch();
+}

app/imports/api/creature/computation/engine/writeAlteredProperties.js

@@ -1,38 +1,13 @@
 import { Meteor } from 'meteor/meteor'
 import { isEqual, forOwn } from 'lodash';
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
-// Schemas
-// Calculated props
-import { ComputedOnlySkillSchema } from '/imports/api/properties/Skills.js';
-import { ComputedOnlyAttributeSchema } from '/imports/api/properties/Attributes.js';
-import { ComputedOnlyEffectSchema } from '/imports/api/properties/Effects.js';
-import { ComputedOnlyToggleSchema } from '/imports/api/properties/Toggles.js';
-// End step props
-import { ComputedOnlyActionSchema } from '/imports/api/properties/Actions.js';
-import { ComputedOnlyAttackSchema } from '/imports/api/properties/Attacks.js';
-import { ComputedOnlySavingThrowSchema } from '/imports/api/properties/SavingThrows.js';
-import { ComputedOnlySpellListSchema } from '/imports/api/properties/SpellLists.js';
-import { ComputedOnlySpellSchema } from '/imports/api/properties/Spells.js';
-import { ComputedOnlySlotSchema } from '/imports/api/properties/Slots.js';
-
-const schemasByType = {
-  'skill': ComputedOnlySkillSchema,
-  'attribute': ComputedOnlyAttributeSchema,
-  'effect': ComputedOnlyEffectSchema,
-  'toggle': ComputedOnlyToggleSchema,
-  'action': ComputedOnlyActionSchema,
-  'attack': ComputedOnlyAttackSchema,
-  'savingThrow': ComputedOnlySavingThrowSchema,
-  'spellList': ComputedOnlySpellListSchema,
-  'spell': ComputedOnlySpellSchema,
-  'propertySlot': ComputedOnlySlotSchema,
-};
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import propertySchemasIndex from '/imports/api/properties/computedOnlyPropertySchemasIndex.js';
 
 export default function writeAlteredProperties(memo){
   let bulkWriteOperations = [];
   // Loop through all properties on the memo
   forOwn(memo.propsById, changed => {
-    let schema = schemasByType[changed.type];
+    let schema = propertySchemasIndex[changed.type];
     if (!schema) return;
     let extraIds = changed.computationDetails.idsOfSameName;
     let ids;
@@ -44,13 +19,14 @@ export default function writeAlteredProperties(memo){
     ids.forEach(id => {
       let op = undefined;
       let original = memo.originalPropsById[id];
-      op = addChangedKeysToOp(op, schema.objectKeys(), original, changed);
+      let keys = ['dependencies', ...schema.objectKeys()];
+      op = addChangedKeysToOp(op, keys, original, changed);
       if (op){
         bulkWriteOperations.push(op);
       }
     });
   });
-  bulkWriteProperties(bulkWriteOperations);
+  writePropertiesSequentially(bulkWriteOperations);
 }
 
 function addChangedKeysToOp(op, keys, original, changed) {
@@ -101,8 +77,27 @@ function addUnsetOp(op, key){
   }
 }
 
+// We use this instead of bulkWriteProperties because it functions with latency
+// compensation without needing to roll back changes, which causes multiple
+// expensive redraws of the character sheet
+function writePropertiesSequentially(bulkWriteOps){
+  bulkWriteOps.forEach(op => {
+    let updateOneOrMany = op.updateOne || op.updateMany;
+    CreatureProperties.update(updateOneOrMany.filter, updateOneOrMany.update, {
+      // The bulk code is bypassing validation, so do the same here
+      // selector: {type: op.type} // include this if bypass is off
+      bypassCollection2: true,
+    });
+  });
+}
+
+// This is more efficient on the database, but significantly less efficient
+// in the UI because of incompatibility with latency compensation. If the
+// duplicate redraws can be fixed, this is a strictly better way of processing
+// writes
 function bulkWriteProperties(bulkWriteOps){
   if (!bulkWriteOps.length) return;
+  // bulkWrite is only available on the server
   if (Meteor.isServer){
     CreatureProperties.rawCollection().bulkWrite(
       bulkWriteOps,
@@ -115,15 +110,6 @@ function bulkWriteProperties(bulkWriteOps){
       }
     );
   } else {
-    bulkWriteOps.forEach(op => {
-      let updateOneOrMany = op.updateOne || op.updateMany;
-      CreatureProperties.update(updateOneOrMany.filter, updateOneOrMany.update, {
-        // The server code is bypassing collection 2 validation, so do the same
-        // on the client
-        // include this if bypass is off:
-        // selector: {type: op.type}
-        bypassCollection2: true,
-      });
-    });
+    writePropertiesSequentially(bulkWriteOps);
   }
 }

app/imports/api/creature/computation/engine/writeCreatureVariables.js

@@ -0,0 +1,49 @@
+import { pick, forOwn } from 'lodash';
+import Creatures from '/imports/api/creature/Creatures.js';
+import VERSION from '/imports/constants/VERSION.js';
+
+export default function writeCreatureVariables(memo, creatureId, fullRecompute = true) {
+  const fields = [
+    'name',
+    'attributeType',
+    'baseValue',
+    'spellSlotLevelValue',
+    'damage',
+    'decimal',
+    'reset',
+    'resetMultiplier',
+    'value',
+    'currentValue',
+    'modifier',
+    'ability',
+    'skillType',
+    'baseProficiency',
+    'abilityMod',
+    'advantage',
+    'passiveBonus',
+    'proficiency',
+    'conditionalBenefits',
+    'rollBonuses',
+    'fail',
+    'level',
+  ];
+
+  if (fullRecompute){
+    memo.creatureVariables = {};
+    forOwn(memo.statsByVariableName, (stat, variableName) => {
+      let condensedStat = pick(stat, fields);
+      memo.creatureVariables[variableName] = condensedStat;
+    });
+    Creatures.update(creatureId, {$set: {
+      variables: memo.creatureVariables,
+      computeVersion: VERSION,
+    }});
+  } else {
+    let $set = {};
+    forOwn(memo.statsByVariableName, (stat, variableName) => {
+      let condensedStat = pick(stat, fields);
+      $set[`variables.${variableName}`] = condensedStat;
+    });
+    Creatures.update(creatureId, {$set});
+  }
+}

app/imports/api/creature/computation/evaluateCalculation.js

@@ -1,41 +0,0 @@
-import computeStat from '/imports/api/creature/computation/computeStat.js';
-import { parse, CompilationContext } from '/imports/parser/parser.js';
-import SymbolNode from '/imports/parser/parseTree/SymbolNode.js';
-import AccessorNode from '/imports/parser/parseTree/AccessorNode.js';
-import ConstantNode from '/imports/parser/parseTree/ConstantNode.js';
-
-/* Convert a calculation into a constant output and errors*/
-export default function evaluateCalculation(string, memo, fn = 'reduce'){
-  if (!string) return {
-    context: {errors: []},
-    result: new ConstantNode({value: string, type: 'string'}),
-  };
-  let errors = [];
-  // Parse the string
-  let calc;
-  try {
-    calc = parse(string);
-  } catch (e) {
-    errors.push({
-      type: 'parsing',
-      message: e.message || e
-    });
-    return {
-      context: {errors},
-      result: new ConstantNode({value: string, type: 'string'}),
-    };
-  }
-  // Ensure all symbol nodes are defined and coputed
-  calc.traverse(node => {
-    if (node instanceof SymbolNode || node instanceof AccessorNode){
-      let stat = memo.statsByVariableName[node.name];
-      if (stat && !stat.computationDetails.computed){
-        computeStat(stat, memo);
-      }
-    }
-  });
-  // Evaluate
-  let context = new CompilationContext();
-  let result = calc[fn](memo.statsByVariableName, context);
-  return {result, context};
-}

app/imports/api/creature/computation/methods/recomputeCreature.js

@@ -2,15 +2,17 @@ import { ValidatedMethod } from 'meteor/mdg:validated-method';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import SimpleSchema from 'simpl-schema';
 import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import ComputationMemo from '/imports/api/creature/computation/ComputationMemo.js';
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
-import computeMemo from '/imports/api/creature/computation/computeMemo.js';
-import writeAlteredProperties from '/imports/api/creature/computation/writeAlteredProperties.js';
-import writeCreatureVariables from '/imports/api/creature/computation/writeCreatureVariables.js';
+import ComputationMemo from '/imports/api/creature/computation/engine/ComputationMemo.js';
+import getComputationProperties from '/imports/api/creature/computation/engine/getComputationProperties.js';
+import computeMemo from '/imports/api/creature/computation/engine/computeMemo.js';
+import writeAlteredProperties from '/imports/api/creature/computation/engine/writeAlteredProperties.js';
+import writeCreatureVariables from '/imports/api/creature/computation/engine/writeCreatureVariables.js';
 import { recomputeDamageMultipliersById } from '/imports/api/creature/denormalise/recomputeDamageMultipliers.js';
-import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
 import recomputeSlotFullness from '/imports/api/creature/denormalise/recomputeSlotFullness.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import getDependentProperties from '/imports/api/creature/computation/engine/getDependentProperties.js';
 import Creatures from '/imports/api/creature/Creatures.js';
+import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
 
 export const recomputeCreature = new ValidatedMethod({
 
@@ -37,23 +39,6 @@ export const recomputeCreature = new ValidatedMethod({
 
 });
 
-const calculationPropertyTypes = [
-  'attribute',
-  'skill',
-  'effect',
-  'proficiency',
-  'classLevel',
-  'toggle',
-  'item',
-  // End step types
-  'action',
-  'attack',
-  'savingThrow',
-  'spellList',
-  'spell',
-  'propertySlot',
-];
-
 export function recomputeCreatureById(creatureId){
   let creature = Creatures.findOne(creatureId);
   recomputeCreatureByDoc(creature);
@@ -97,42 +82,40 @@ export function recomputeCreatureById(creatureId){
  */
 export function recomputeCreatureByDoc(creature){
   const creatureId = creature._id;
-  // find all toggles that have conditions, even if they are inactive
-  let toggleIds = CreatureProperties.find({
-    'ancestors.id': creatureId,
-    type: 'toggle',
-    removed: {$ne: true},
-    condition: { $exists: true },
-  }, {
-    fields: {_id: 1},
-  }).map(t => t._id);
-  // Find all the active properties
-  let props = CreatureProperties.find({
-    'ancestors.id': creatureId,
-    removed: {$ne: true},
-    type: {$in: calculationPropertyTypes},
-    $or: [
-      {inactive: {$ne: true}},
-      // But also the inactive computed toggles and their decendants
-      {'ancestors.id': {$in: toggleIds}},
-      {_id: {$in: toggleIds}},
-    ]
-  }, {
-    fields: { // Filter out potentially large fields
-      icon: 0,
-      summary: 0,
-      description: 0,
-    },
-    sort: {
-      order: 1,
-    }
-  }).fetch();
+  let props = getComputationProperties(creatureId);
   let computationMemo = new ComputationMemo(props, creature);
-  recomputeInactiveProperties(creatureId);
   computeMemo(computationMemo);
   writeAlteredProperties(computationMemo);
   writeCreatureVariables(computationMemo, creatureId);
   recomputeDamageMultipliersById(creatureId);
   recomputeSlotFullness(creatureId);
+  recomputeInactiveProperties(creatureId);
+  return computationMemo;
+}
+
+export function recomputePropertyDependencies(property){
+  let creature = getRootCreatureAncestor(property);
+  recomputeCreatureByDependencies({
+    creature,
+    propertyIds: [property._id],
+    propertiesDependedAponIds: property.dependencies,
+  });
+}
+
+export function recomputeCreatureByDependencies({
+  creature,
+  propertyIds,
+  propertiesDependedAponIds
+}){
+  let props = getDependentProperties({
+    creatureId: creature._id,
+    propertyIds,
+    propertiesDependedAponIds,
+  });
+  let computationMemo = new ComputationMemo(props, creature);
+  computeMemo(computationMemo);
+  writeAlteredProperties(computationMemo);
+  writeCreatureVariables(computationMemo, creature._id, false)
+  recomputeInactiveProperties(creature._id);
   return computationMemo;
 }

app/imports/api/creature/computation/writeCreatureVariables.js

@@ -1,39 +0,0 @@
-import { pick, forOwn } from 'lodash';
-import Creatures from '/imports/api/creature/Creatures.js';
-import VERSION from '/imports/constants/VERSION.js';
-
-export default function writeCreatureVariables(memo, creatureId) {
-  const fields = [
-    'name',
-    'attributeType',
-    'baseValue',
-    'damage',
-    'decimal',
-    'reset',
-    'resetMultiplier',
-    'value',
-    'currentValue',
-    'modifier',
-    'ability',
-    'skillType',
-    'baseProficiency',
-    'abilityMod',
-    'advantage',
-    'passiveBonus',
-    'proficiency',
-    'conditionalBenefits',
-    'rollBonuses',
-    'fail',
-    'level',
-  ];
-
-  memo.creatureVariables = {};
-  forOwn(memo.statsByVariableName, (stat, variableName) => {
-    let condensedStat = pick(stat, fields);
-    memo.creatureVariables[variableName] = condensedStat;
-  });
-  Creatures.update(creatureId, {$set: {
-    variables: memo.creatureVariables,
-    computeVersion: VERSION,
-  }});
-}

app/imports/api/creature/creatureProperties/CreatureProperties.js

@@ -0,0 +1,84 @@
+import { Mongo } from 'meteor/mongo';
+import SimpleSchema from 'simpl-schema';
+import ColorSchema from '/imports/api/properties/subSchemas/ColorSchema.js';
+import ChildSchema from '/imports/api/parenting/ChildSchema.js';
+import SoftRemovableSchema from '/imports/api/parenting/SoftRemovableSchema.js';
+import propertySchemasIndex from '/imports/api/properties/computedPropertySchemasIndex.js';
+import { storedIconsSchema } from '/imports/api/icons/Icons.js';
+
+let CreatureProperties = new Mongo.Collection('creatureProperties');
+
+let CreaturePropertySchema = new SimpleSchema({
+	type: {
+    type: String,
+    allowedValues: Object.keys(propertySchemasIndex),
+  },
+	tags: {
+		type: Array,
+		defaultValue: [],
+	},
+	'tags.$': {
+		type: String,
+	},
+	disabled: {
+		type: Boolean,
+		optional: true,
+	},
+  icon: {
+    type: storedIconsSchema,
+    optional: true,
+  },
+  // Denormalised flag if this property is inactive on the sheet for any reason
+  // Including being disabled, or a decendent of a disabled property
+  inactive: {
+    type: Boolean,
+    optional: true,
+    index: 1,
+  },
+  // Denormalised flag if this property was made inactive by an inactive
+  // ancestor. True if this property has an inactive ancestor even if this
+  // property is itself inactive
+  deactivatedByAncestor: {
+    type: Boolean,
+    optional: true,
+    index: 1,
+  },
+  // Denormalised flag if this property was made inactive because of its own
+  // state
+  deactivatedBySelf: {
+    type: Boolean,
+    optional: true,
+    index: 1,
+  },
+  // Denormalised list of all properties or creatures this property depends on
+  dependencies: {
+    type: Array,
+    defaultValue: [],
+    index: 1,
+  },
+  'dependencies.$': {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+  },
+});
+
+for (let key in propertySchemasIndex){
+	let schema = new SimpleSchema({});
+	schema.extend(propertySchemasIndex[key]);
+	schema.extend(CreaturePropertySchema);
+  schema.extend(ColorSchema);
+	schema.extend(ChildSchema);
+	schema.extend(SoftRemovableSchema);
+	CreatureProperties.attachSchema(schema, {
+		selector: {type: key}
+	});
+}
+
+import '/imports/api/creature/creatureProperties/methods/index.js';
+import '/imports/api/creature/actions/doAction.js';
+import '/imports/api/creature/actions/castSpellWithSlot.js';
+
+export default CreatureProperties;
+export {
+	CreaturePropertySchema,
+};

app/imports/api/creature/creatureProperties/assertPropertyEditPermission.js

@@ -1,7 +0,0 @@
-import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
-import getClosestPropertyAncestorCreature from '/imports/api/creature/creatureProperties/getClosestPropertyAncestorCreature.js';
-
-export default function assertPropertyEditPermission(prop, userId){
-  let creature = getClosestPropertyAncestorCreature(prop);
-  assertEditPermission(creature, userId);
-}

app/imports/api/creature/creatureProperties/getClosestPropertyAncestorCreature.js

@@ -1,7 +0,0 @@
-import Creatures from '/imports/api/creature/Creatures.js';
-import getClosestPropertyAncestorCreatureId from '/imports/api/creature/creatureProperties/getClosestPropertyAncestorCreatureId.js';
-
-export default function getClosestPropertyAncestorCreature(prop){
-  let creatureId = getClosestPropertyAncestorCreatureId(prop);
-  return Creatures.findOne(creatureId);
-}

app/imports/api/creature/creatureProperties/getClosestPropertyAncestorCreatureId.js

@@ -1,13 +0,0 @@
-export default function getClosestPropertyAncestorCreatureId(prop){
-  if (!prop.ancestors) throw 'Property has no ancestors';
-  let creatureId;
-  // Find the last ancestor in the creature collection
-  for (let i = prop.ancestors.length - 1; i >= 0; i--){
-    if (prop.ancestors[i].collection === 'creatures'){
-      creatureId = prop.ancestors[i].id;
-      break;
-    }
-  }
-  if (!creatureId) throw 'This property has no creature ancestors';
-  return creatureId;
-}

app/imports/api/creature/creatureProperties/getRootCreatureAncestor.js

@@ -0,0 +1,5 @@
+import Creatures from '/imports/api/creature/Creatures.js';
+
+export default function getRootCreatureAncestor(property){
+  return Creatures.findOne(property.ancestors[0].id);
+}

app/imports/api/creature/creatureProperties/methods/adjustQuantity.js

@@ -0,0 +1,69 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import SimpleSchema from 'simpl-schema';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+
+const adjustQuantity = new ValidatedMethod({
+  name: 'creatureProperties.adjustQuantity',
+  validate: new SimpleSchema({
+    _id: SimpleSchema.RegEx.Id,
+    operation: {
+      type: String,
+      allowedValues: ['set', 'increment']
+    },
+    value: Number,
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({_id, operation, value}) {
+    // Permissions
+		let property = CreatureProperties.findOne(_id);
+    let rootCreature = getRootCreatureAncestor(property);
+		assertEditPermission(rootCreature, this.userId);
+
+    // Do work
+    adjustQuantityWork({property, operation, value});
+
+    // Changing quantity does not change dependencies, but recomputing the
+    // inventory changes many deps at once, so recompute fully
+    recomputeCreatureByDoc(rootCreature);
+    recomputeInventory(rootCreature._id);
+  },
+});
+
+export function adjustQuantityWork({property, operation, value}){
+  // Check if property has quantity
+  let schema = CreatureProperties.simpleSchema(property);
+  if (!schema.allowsKey('quantity')){
+    throw new Meteor.Error(
+      'Adjust quantity failed',
+      `Property of type "${property.type}" doesn't have a quantity`
+    );
+  }
+  if (operation === 'set'){
+    CreatureProperties.update(property._id, {
+      $set: {quantity: value}
+    }, {
+      selector: property
+    });
+  } else if (operation === 'increment'){
+    // value here is 'damage'
+    value = -value;
+    let currentQuantity = property.quantity;
+    if (currentQuantity + value < 0) value = -currentQuantity;
+    CreatureProperties.update(property._id, {
+      $inc: {quantity: value}
+    }, {
+      selector: property
+    });
+  }
+}
+
+export default adjustQuantity;

app/imports/api/creature/creatureProperties/methods/damagePropertiesByName.js

@@ -0,0 +1,57 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import SimpleSchema from 'simpl-schema';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import Creatures from '/imports/api/creature/Creatures.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
+import { recomputePropertyDependencies } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+
+const damagePropertiesByName = new ValidatedMethod({
+  name: 'CreatureProperties.damagePropertiesByName',
+  validate: new SimpleSchema({
+    creatureId: SimpleSchema.RegEx.Id,
+    variableName: {
+      type: String,
+    },
+    operation: {
+      type: String,
+      allowedValues: ['set', 'increment']
+    },
+    value: Number,
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 20,
+    timeInterval: 5000,
+  },
+  run({creatureId, variableName, operation, value}) {
+		// Check permissions
+    let creature = Creatures.findOne(creatureId, {
+      fields: {
+        damageMultipliers: 1,
+        owner: 1,
+        readers: 1,
+        writers: 1,
+      },
+    });
+    assertEditPermission(creature, this.userId);
+    let lastProperty;
+    CreatureProperties.find({
+      'ancestors.id': creatureId,
+      variableName,
+      removed: {$ne: false},
+      inactive: {$ne: true},
+    }).forEach(property => {
+      // Check if property can take damage
+      let schema = CreatureProperties.simpleSchema(property);
+      if (!schema.allowsKey('damage')) return;
+      // Damage the property
+      damagePropertyWork({property, operation, value});
+      lastProperty = property;
+    });
+    recomputePropertyDependencies(lastProperty);
+  }
+});
+
+export default damagePropertiesByName;

app/imports/api/creature/creatureProperties/methods/damageProperty.js

@@ -0,0 +1,76 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import SimpleSchema from 'simpl-schema';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import { recomputePropertyDependencies } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+
+const damageProperty = new ValidatedMethod({
+  name: 'creatureProperties.damage',
+  validate: new SimpleSchema({
+    _id: SimpleSchema.RegEx.Id,
+    operation: {
+      type: String,
+      allowedValues: ['set', 'increment']
+    },
+    value: Number,
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 20,
+    timeInterval: 5000,
+  },
+  run({_id, operation, value}) {
+    // Check permissions
+		let property = CreatureProperties.findOne(_id);
+    let rootCreature = getRootCreatureAncestor(property);
+    assertEditPermission(rootCreature, this.userId);
+		// Check if property can take damage
+		let schema = CreatureProperties.simpleSchema(property);
+		if (!schema.allowsKey('damage')){
+			throw new Meteor.Error(
+				'Damage property failed',
+				`Property of type "${property.type}" can't be damaged`
+			);
+		}
+		damagePropertyWork({property, operation, value});
+    // Dependencies can't be changed through damage, only recompute deps
+    recomputePropertyDependencies(property);
+  },
+});
+
+export function damagePropertyWork({property, operation, value}){
+  if (operation === 'set'){
+    let currentValue = property.value;
+    // Set represents what we want the value to be after damage
+    // So we need the actual damage to get to that value
+    let damage = currentValue - value;
+    // Damage can't exceed total value
+    if (damage > currentValue) damage = currentValue;
+    // Damage must be positive
+    if (damage < 0) damage = 0;
+    CreatureProperties.update(property._id, {
+      $set: {damage}
+    }, {
+      selector: property
+    });
+    return currentValue - damage;
+  } else if (operation === 'increment'){
+    let currentValue = property.value - (property.damage || 0);
+    let currentDamage = property.damage;
+    let increment = value;
+    // Can't increase damage above the remaining value
+    if (increment > currentValue) increment = currentValue;
+    // Can't decrease damage below zero
+    if (-increment > currentDamage) increment = -currentDamage;
+    CreatureProperties.update(property._id, {
+      $inc: {damage: increment}
+    }, {
+      selector: property
+    });
+    return increment;
+  }
+}
+
+export default damageProperty;

app/imports/api/creature/creatureProperties/methods/dealDamage.js

@@ -0,0 +1,73 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import SimpleSchema from 'simpl-schema';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import Creatures from '/imports/api/creature/Creatures.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import { damagePropertyWork } from '/imports/api/creature/creatureProperties/methods/damageProperty.js';
+import { recomputeCreatureByDependencies } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+
+const dealDamage = new ValidatedMethod({
+  name: 'creatureProperties.dealDamage',
+  validate: new SimpleSchema({
+    creatureId: SimpleSchema.RegEx.Id,
+    damageType: {
+      type: String,
+    },
+    amount: Number,
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 20,
+    timeInterval: 5000,
+  },
+  run({creatureId, damageType, amount}) {
+    // permissions
+    let creature = Creatures.findOne(creatureId, {
+      fields: {
+        damageMultipliers: 1,
+        owner: 1,
+        readers: 1,
+        writers: 1,
+      },
+    });
+    assertEditPermission(creature, this.userId);
+
+    // Get all the health bars and do damage to them
+    let healthBars = CreatureProperties.find({
+      'ancestors.id': creatureId,
+      type: 'attribute',
+      attributeType:'healthBar',
+      removed: {$ne: true},
+      inactive: {$ne: true},
+    }, {
+      sort: {order: -1},
+    });
+    let multiplier = creature.damageMultipliers[damageType];
+    if (multiplier === undefined) multiplier = 1;
+    let totalDamage = Math.floor(amount * multiplier);
+    let damageLeft = totalDamage;
+    if (damageType === 'healing') damageLeft = -totalDamage;
+    let propertyIds = [];
+    let propertiesDependedAponIds = [];
+    healthBars.forEach(healthBar => {
+      if (damageLeft === 0) return;
+      let damageAdded = damagePropertyWork({
+        property: healthBar,
+        operation: 'increment',
+        value: damageLeft,
+      });
+      damageLeft -= damageAdded;
+      propertyIds.push(healthBar._id);
+      propertiesDependedAponIds.push(...healthBar.dependencies);
+    });
+    recomputeCreatureByDependencies({
+      creature,
+      propertyIds,
+      propertiesDependedAponIds,
+    });
+    return totalDamage;
+  },
+});
+
+export default dealDamage;

app/imports/api/creature/creatureProperties/methods/duplicateProperty.js

@@ -0,0 +1,33 @@
+import SimpleSchema from 'simpl-schema';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import { insertPropertyWork } from '/imports/api/creature/creatureProperties/methods/insertProperty.js';
+
+const duplicateProperty = new ValidatedMethod({
+  name: 'creatureProperties.duplicate',
+  validate: new SimpleSchema({
+    _id: {
+      type: String,
+      regEx: SimpleSchema.RegEx.Id,
+    }
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({_id}) {
+    let creatureProperty = CreatureProperties.findOne(_id);
+    let rootCreature = getRootCreatureAncestor(creatureProperty);
+    assertEditPermission(rootCreature, this.userId);
+    insertPropertyWork({
+      property: creatureProperty,
+      creature: rootCreature,
+    });
+  },
+});
+
+export default duplicateProperty;

app/imports/api/creature/creatureProperties/methods/equipItem.js

@@ -1,12 +1,14 @@
 import { ValidatedMethod } from 'meteor/mdg:validated-method';
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import { organizeDoc } from '/imports/api/parenting/organizeMethods.js';
-import getClosestPropertyAncestorCreature from '/imports/api/creature/creatureProperties/getClosestPropertyAncestorCreature.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 import INVENTORY_TAGS from '/imports/constants/INVENTORY_TAGS.js';
 
-function getParentRefByTag(creatureId, tag){
+export function getParentRefByTag(creatureId, tag){
   let prop = CreatureProperties.findOne({
     'ancestors.id': creatureId,
     removed: {$ne: true},
@@ -40,7 +42,7 @@ const equipItem = new ValidatedMethod({
     let item = CreatureProperties.findOne(_id);
     if (item.type !== 'item') throw new Meteor.Error('wrong type',
     'Equip and unequip can only be performed on items');
-    let creature = getClosestPropertyAncestorCreature(item);
+    let creature = getRootCreatureAncestor(item);
     assertEditPermission(creature, this.userId);
     CreatureProperties.update(_id, {
       $set: {equipped},
@@ -49,7 +51,7 @@ const equipItem = new ValidatedMethod({
 		});
     let tag = equipped ? INVENTORY_TAGS.equipment : INVENTORY_TAGS.carried;
     let parentRef = getParentRefByTag(creature._id, tag);
-    // organizeDoc handles recompuation
+
     organizeDoc.call({
       docRef: {
         id: _id,
@@ -57,8 +59,12 @@ const equipItem = new ValidatedMethod({
       },
       parentRef,
       order: Number.MAX_SAFE_INTEGER,
+      skipRecompute: true,
     });
+
+    recomputeInventory(creature._id);
+    recomputeCreatureByDoc(creature);
   },
 });
 
-export { equipItem, getParentRefByTag }
+export default equipItem;

app/imports/api/creature/creatureProperties/methods/index.js

@@ -0,0 +1,14 @@
+import '//imports/api/creature/creatureProperties/methods/adjustQuantity.js';
+import '/imports/api/creature/creatureProperties/methods/damagePropertiesByName.js';
+import '/imports/api/creature/creatureProperties/methods/damageProperty.js';
+import '/imports/api/creature/creatureProperties/methods/dealDamage.js';
+import '/imports/api/creature/creatureProperties/methods/duplicateProperty.js';
+import '/imports/api/creature/creatureProperties/methods/equipItem.js';
+import '/imports/api/creature/creatureProperties/methods/insertProperty.js';
+import '/imports/api/creature/creatureProperties/methods/insertPropertyFromLibraryNode.js';
+import '/imports/api/creature/creatureProperties/methods/pullFromProperty.js';
+import '/imports/api/creature/creatureProperties/methods/pushToProperty.js';
+import '/imports/api/creature/creatureProperties/methods/restoreProperty.js';
+import '/imports/api/creature/creatureProperties/methods/selectAmmoItem.js';
+import '/imports/api/creature/creatureProperties/methods/softRemoveProperty.js';
+import '/imports/api/creature/creatureProperties/methods/updateCreatureProperty.js';

app/imports/api/creature/creatureProperties/methods/insertProperty.js

@@ -0,0 +1,49 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import { reorderDocs } from '/imports/api/parenting/order.js';
+import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
+
+const insertProperty = new ValidatedMethod({
+  name: 'creatureProperties.insert',
+	validate: null,
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({creatureProperty}) {
+    let rootCreature = getRootCreatureAncestor(creatureProperty);
+    assertEditPermission(rootCreature, this.userId);
+		return insertPropertyWork({
+      property: creatureProperty,
+      creature: rootCreature,
+    });
+  },
+});
+
+export function insertPropertyWork({property, creature}){
+  delete property._id;
+  let _id = CreatureProperties.insert(property);
+  // Tree structure changed by insert, reorder the tree
+  reorderDocs({
+    collection: CreatureProperties,
+    ancestorId: creature._id,
+  });
+  // Inserting the active status of the property needs to be denormalised
+  recomputeInactiveProperties(creature._id);
+
+  // Recompute the inventory if it has changed
+  if (property.type === 'item' || property.type === 'container'){
+    recomputeInventory(creature._id);
+  }
+  // Inserting a creature property invalidates dependencies: full recompute
+  recomputeCreatureByDoc(creature);
+  return _id;
+}
+
+export default insertProperty;

app/imports/api/creature/creatureProperties/methods/insertPropertyFromLibraryNode.js

@@ -0,0 +1,110 @@
+import SimpleSchema from 'simpl-schema';
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import LibraryNodes from '/imports/api/library/LibraryNodes.js';
+import { RefSchema } from '/imports/api/parenting/ChildSchema.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import {
+	setLineageOfDocs,
+	getAncestry,
+	renewDocIds
+} from '/imports/api/parenting/parenting.js';
+import { reorderDocs } from '/imports/api/parenting/order.js';
+import { setDocToLastOrder } from '/imports/api/parenting/order.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
+
+const insertPropertyFromLibraryNode = new ValidatedMethod({
+	name: 'creatureProperties.insertPropertyFromLibraryNode',
+	validate: new SimpleSchema({
+		nodeId: {
+			type: String,
+			regEx: SimpleSchema.RegEx.Id,
+		},
+		parentRef: {
+			type: RefSchema,
+		},
+	}).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+	run({nodeId, parentRef}) {
+		// get the new ancestry for the properties
+		let {parentDoc, ancestors} = getAncestry({parentRef});
+
+		// Check permission to edit
+    let rootCreature;
+		if (parentRef.collection === 'creatures'){
+      rootCreature = parentDoc;
+		} else if (parentRef.collection === 'creatureProperties'){
+      rootCreature = getRootCreatureAncestor(parentDoc);
+		} else {
+			throw `${parentRef.collection} is not a valid parent collection`
+		}
+    assertEditPermission(rootCreature, this.userId);
+
+		// Fetch the library node and its decendents, provided they have not been
+		// removed
+		let node = LibraryNodes.findOne({
+			_id: nodeId,
+			removed: {$ne: true},
+		});
+		if (!node) throw `Node not found for nodeId: ${nodeId}`;
+		let oldParent = node.parent;
+		let nodes = LibraryNodes.find({
+			'ancestors.id': nodeId,
+			removed: {$ne: true},
+		}).fetch();
+
+    // The root node is first in the array of nodes
+    // It must get the first generated ID to prevent flickering
+		nodes = [node, ...nodes];
+
+		// re-map all the ancestors
+		setLineageOfDocs({
+			docArray: nodes,
+			newAncestry: ancestors,
+			oldParent,
+		});
+
+		// Give the docs new IDs without breaking internal references
+		renewDocIds({
+			docArray: nodes,
+			collectionMap: {'libraryNodes': 'creatureProperties'}
+		});
+
+		// Order the root node
+		setDocToLastOrder({
+			collection: CreatureProperties,
+			doc: node,
+		});
+
+		// Insert the creature properties
+    CreatureProperties.batchInsert(nodes);
+
+    // get the root inserted doc
+    let rootId = node._id;
+
+    // Tree structure changed by inserts, reorder the tree
+    reorderDocs({
+      collection: CreatureProperties,
+      ancestorId: rootCreature._id,
+    });
+
+    // The library properties need to denormalise which of them are inactive
+    recomputeInactiveProperties(rootId);
+    // Some of the library properties may be items or containers
+    recomputeInventory(rootCreature._id);
+		// Inserting a creature property invalidates dependencies: full recompute
+    recomputeCreatureByDoc(rootCreature);
+		// Return the docId of the last property, the inserted root property
+		return rootId;
+	},
+});
+
+export default insertPropertyFromLibraryNode;

app/imports/api/creature/creatureProperties/methods/pullFromProperty.js

@@ -0,0 +1,36 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+
+const pullFromProperty = new ValidatedMethod({
+	name: 'creatureProperties.pull',
+	validate: null,
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+	run({_id, path, itemId}){
+    // Permissions
+		let property = CreatureProperties.findOne(_id);
+    let rootCreature = getRootCreatureAncestor(property);
+    assertEditPermission(rootCreature, this.userId);
+
+    // Do work
+		CreatureProperties.update(_id, {
+			$pull: {[path.join('.')]: {_id: itemId}},
+		}, {
+			selector: {type: property.type},
+			getAutoValues: false,
+		});
+
+    // TODO figure out if this method can change deps or not
+    recomputeCreatureByDoc(rootCreature);
+    // recomputePropertyDependencies(property);
+	}
+});
+
+export default pullFromProperty;

app/imports/api/creature/creatureProperties/methods/pushToProperty.js

@@ -0,0 +1,35 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+
+const pushToProperty = new ValidatedMethod({
+	name: 'creatureProperties.push',
+	validate: null,
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+	run({_id, path, value}){
+    // Permissions
+		let property = CreatureProperties.findOne(_id);
+    let rootCreature = getRootCreatureAncestor(property);
+    assertEditPermission(rootCreature, this.userId);
+
+    // Do work
+		CreatureProperties.update(_id, {
+			$push: {[path.join('.')]: value},
+		}, {
+			selector: {type: property.type},
+		});
+
+    // TODO figure out if this method can change deps or not
+    recomputeCreatureByDoc(rootCreature);
+    // recomputePropertyDependencies(property);
+	}
+});
+
+export default pushToProperty;

app/imports/api/creature/creatureProperties/methods/restoreProperty.js

@@ -0,0 +1,40 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import SimpleSchema from 'simpl-schema';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import { restore } from '/imports/api/parenting/softRemove.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
+
+const restoreProperty = new ValidatedMethod({
+	name: 'creatureProperties.restore',
+	validate: new SimpleSchema({
+		_id: SimpleSchema.RegEx.Id
+	}).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+	run({_id}){
+    // Permissions
+		let property = CreatureProperties.findOne(_id);
+    let rootCreature = getRootCreatureAncestor(property);
+    assertEditPermission(rootCreature, this.userId);
+
+    // Do work
+    restore({_id, collection: CreatureProperties});
+
+    // Items and containers might be restored
+    recomputeInventory(rootCreature._id);
+    // Parents active status may have changed while it was deleted
+    recomputeInactiveProperties(rootCreature._id);
+    // Changes dependency tree by restoring children
+    recomputeCreatureByDoc(rootCreature);
+	}
+});
+
+export default restoreProperty;

app/imports/api/creature/creatureProperties/methods/selectAmmoItem.js

@@ -0,0 +1,52 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import SimpleSchema from 'simpl-schema';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+
+const selectAmmoItem = new ValidatedMethod({
+  name: 'creatureProperties.selectAmmoItem',
+  validate: new SimpleSchema({
+    actionId: SimpleSchema.RegEx.Id,
+    itemId: SimpleSchema.RegEx.Id,
+    itemConsumedIndex: Number,
+  }).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({actionId, itemId, itemConsumedIndex}) {
+    // Permissions
+		let action = CreatureProperties.findOne(actionId);
+    let rootCreature = getRootCreatureAncestor(action);
+		assertEditPermission(rootCreature, this.userId);
+
+    // Check that this index has a document to edit
+    let itemConsumed = action.resources.itemsConsumed[itemConsumedIndex];
+    if (!itemConsumed){
+      throw new Meteor.Error('Resouce not found',
+        'Could not set ammo, because the ammo document was not found');
+    }
+    let itemToLink = CreatureProperties.findOne(itemId);
+    if (!itemToLink){
+      throw new Meteor.Error('Item not found',
+        'Could not set ammo: the item was not found');
+    }
+    let path = `resources.itemsConsumed.${itemConsumedIndex}.itemId`;
+    CreatureProperties.update(actionId, {
+      $set: {[path]: itemId}
+    }, {
+      selector: action,
+    });
+
+    // Changing the linked item does change the dependency tree
+    // TODO: We can predict exactly which deps will be affected instead of
+    //       recomputing the entire creature
+    recomputeCreatureByDoc(rootCreature);
+  },
+});
+
+export default selectAmmoItem;

app/imports/api/creature/creatureProperties/methods/softRemoveProperty.js

@@ -0,0 +1,37 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import SimpleSchema from 'simpl-schema';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import { softRemove } from '/imports/api/parenting/softRemove.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
+
+const softRemoveProperty = new ValidatedMethod({
+	name: 'creatureProperties.softRemove',
+	validate: new SimpleSchema({
+		_id: SimpleSchema.RegEx.Id
+	}).validator(),
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+	run({_id}){
+    // Permissions
+		let property = CreatureProperties.findOne(_id);
+    let rootCreature = getRootCreatureAncestor(property);
+    assertEditPermission(rootCreature, this.userId);
+
+    // Do work
+		softRemove({_id, collection: CreatureProperties});
+
+    // Potentially changes items and containers
+    recomputeInventory(rootCreature._id);
+    // Changes dependency tree by removing children
+    recomputeCreatureByDoc(rootCreature);
+	}
+});
+
+export default softRemoveProperty;

app/imports/api/creature/creatureProperties/methods/updateCreatureProperty.js

@@ -0,0 +1,66 @@
+import { ValidatedMethod } from 'meteor/mdg:validated-method';
+import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import { assertEditPermission } from '/imports/api/sharing/sharingPermissions.js';
+import getRootCreatureAncestor from '/imports/api/creature/creatureProperties/getRootCreatureAncestor.js';
+import { recomputeCreatureByDoc } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
+
+const updateCreatureProperty = new ValidatedMethod({
+  name: 'creatureProperties.update',
+  validate({_id, path}){
+		if (!_id) throw new Meteor.Error('No _id', '_id is required');
+		// We cannot change these fields with a simple update
+		switch (path[0]){
+			case 'type':
+      case 'order':
+      case 'parent':
+      case 'ancestors':
+			case 'damage':
+				throw new Meteor.Error('Permission denied',
+				'This property can\'t be updated directly');
+		}
+  },
+  mixins: [RateLimiterMixin],
+  rateLimit: {
+    numRequests: 5,
+    timeInterval: 5000,
+  },
+  run({_id, path, value}) {
+    // Permission
+    let property = CreatureProperties.findOne(_id, {
+      fields: {type: 1, ancestors: 1}
+    });
+    let rootCreature = getRootCreatureAncestor(property);
+    assertEditPermission(rootCreature, this.userId);
+
+    let pathString = path.join('.');
+    let modifier;
+    // unset empty values
+    if (value === null || value === undefined){
+      modifier = {$unset: {[pathString]: 1}};
+    } else {
+      modifier = {$set: {[pathString]: value}};
+    }
+		CreatureProperties.update(_id, modifier, {
+			selector: {type: property.type},
+		});
+
+    // Some updates might cause other properties to become inactive
+    if ([
+      'applied', 'equipped', 'prepared', 'alwaysPrepared', 'disabled'
+    ].includes(path[0])){
+      recomputeInactiveProperties(rootCreature._id);
+    }
+
+    if (property.type === 'item' || property.type === 'container'){
+      // Potentially changes items and containers
+      recomputeInventory(rootCreature._id);
+    }
+    // Updating a property is likely to change dependencies, do a full recompute
+    recomputeCreatureByDoc(rootCreature);
+  },
+});
+
+export default updateCreatureProperty;

app/imports/api/creature/creatureProperties/recomputeCreaturesByProperty.js

@@ -0,0 +1,12 @@
+import { recomputeCreatureById } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+
+/**
+ * Recomputes all ancestor creatures of this property
+ */
+export default function recomputeCreaturesByProperty(property){
+	for (let ref of property.ancestors){
+		if (ref.collection === 'creatures') {
+			recomputeCreatureById.call(ref.id);
+		}
+	}
+}

app/imports/api/creature/denormalise/recomputeDamageMultipliers.js

@@ -3,7 +3,7 @@ import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import SimpleSchema from 'simpl-schema';
 import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
 import Creatures from '/imports/api/creature/Creatures.js';
-import getActiveProperties from '/imports/api/creature/getActiveProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 
 export const recomputeDamageMultipliers = new ValidatedMethod({
 
@@ -31,9 +31,13 @@ export const recomputeDamageMultipliers = new ValidatedMethod({
 
 export function recomputeDamageMultipliersById(creatureId){
   if (!creatureId) throw 'Creature ID is required';
-  let props = getActiveProperties({
-    ancestorId: creatureId,
-    filter: {type: 'damageMultiplier'},
+  let props = CreatureProperties.find({
+    'ancestors.id': creatureId,
+    type: 'damageMultiplier',
+    removed: {$ne: true},
+    inactive: {$ne: true},
+  }, {
+    sort: {order: 1}
   });
 
   // Count of how many weakness, resistances and immunities each damage type has

app/imports/api/creature/denormalise/recomputeInactiveProperties.js

@@ -1,4 +1,4 @@
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 
 export default function recomputeInactiveProperties(ancestorId){
   let disabledFilter = {
@@ -20,9 +20,16 @@ export default function recomputeInactiveProperties(ancestorId){
   CreatureProperties.update({
     'ancestors.id': ancestorId,
     '_id': {$in: disabledIds},
-    $or: [{inactive: {$ne: true}}, {deactivatedByAncestor: true}],
+    $or: [
+      {inactive: {$ne: true}},
+      {deactivatedBySelf: {$ne: true}},
+      {deactivatedByAncestor: true},
+    ],
   }, {
-    $set: {inactive: true},
+    $set: {
+      inactive: true,
+      deactivatedBySelf: true,
+    },
     $unset: {deactivatedByAncestor: 1},
   }, {
     multi: true,
@@ -31,7 +38,10 @@ export default function recomputeInactiveProperties(ancestorId){
   // Decendants of inactive properties
   CreatureProperties.update({
     'ancestors.id': {$eq: ancestorId, $in: disabledIds},
-    $or: [{inactive: {$ne: true}}, {deactivatedByAncestor: {$ne: true}}],
+    $or: [
+      {inactive: {$ne: true}},
+      {deactivatedByAncestor: {$ne: true}},
+    ],
   }, {
     $set: {
       inactive: true,
@@ -46,7 +56,10 @@ export default function recomputeInactiveProperties(ancestorId){
   CreatureProperties.update({
     'ancestors.id': {$eq: ancestorId, $nin: disabledIds},
     '_id': {$nin: disabledIds},
-    $or: [{inactive: true}, {deactivatedByAncestor: true}],
+    $or: [
+      {inactive: true},
+      {deactivatedByAncestor: true},
+    ],
   }, {
     $unset: {
       inactive: 1,

app/imports/api/creature/denormalise/recomputeInventory.js

@@ -0,0 +1,111 @@
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
+import Creatures from '/imports/api/creature/Creatures.js';
+import { nodesToTree } from '/imports/api/parenting/parenting.js';
+
+export default function recomputeInventory(creatureId){
+  let inventoryForest = nodesToTree({
+    collection: CreatureProperties,
+    ancestorId: creatureId,
+    filter: {
+      type: {$in: ['container', 'item']},
+    },
+    deactivatedByAncestor: {$ne: true},
+  });
+  let containersToWrite = [];
+  let data =  getChildrenInventoryData(inventoryForest, containersToWrite);
+  containersToWrite.forEach(container => {
+    CreatureProperties.update(container._id, {$set: {
+      contentsWeight: container.contentsWeight,
+      contentsValue: container.contentsValue,
+    }}, {selector: {type: 'container'}});
+  });
+  Creatures.update(creatureId, {$set: {
+    'denormalizedStats.weightTotal': data.weightTotal,
+    'denormalizedStats.weightEquipment': data.weightEquipment,
+    'denormalizedStats.weightCarried': data.weightCarried,
+    'denormalizedStats.valueTotal': data.valueTotal,
+    'denormalizedStats.valueEquipment': data.valueEquipment,
+    'denormalizedStats.valueCarried': data.valueCarried,
+    'denormalizedStats.itemsAttuned': data.itemsAttuned,
+  }});
+  return data;
+}
+
+function getChildrenInventoryData(forest, containersToWrite){
+  let data = {
+    weightTotal: 0,
+    weightEquipment: 0,
+    weightCarried: 0,
+    valueTotal: 0,
+    valueEquipment: 0,
+    valueCarried: 0,
+    itemsAttuned: 0,
+  }
+  forest.forEach(tree => {
+    let treeData = getInventoryData(tree, containersToWrite);
+    for (let key in data){
+      data[key] += treeData[key] || 0;
+    }
+  });
+  return data;
+}
+
+function getInventoryData(tree, containersToWrite){
+  let data = {
+    weightTotal: 0,
+    weightEquipment: 0,
+    weightCarried: 0,
+    valueTotal: 0,
+    valueEquipment: 0,
+    valueCarried: 0,
+    itemsAttuned: 0,
+  }
+  let childData = getChildrenInventoryData(tree.children, containersToWrite);
+  let node = tree.node;
+  if (node.type === 'container'){
+    data.weightTotal += node.weight || 0;
+    data.valueTotal += node.value || 0;
+    data.weightCarried += node.weight || 0;
+    data.valueCarried += node.value || 0;
+    storeContentsData(node, childData, containersToWrite);
+  } else if (node.type === 'item'){
+    data.weightTotal += (node.weight * node.quantity) || 0;
+    data.valueTotal += (node.value * node.quantity) || 0;
+    data.weightCarried += (node.weight * node.quantity) || 0;
+    data.valueCarried += (node.value * node.quantity) || 0;
+    if (node.equipped){
+      data.weightEquipment += (node.weight * node.quantity) || 0;
+      data.valueEquipment += (node.value * node.quantity) || 0;
+    }
+    if (node.attuned){
+      data.itemsAttuned += 1;
+    }
+  }
+  for (let key in data){
+    data[key] += childData[key];
+  }
+  if (node.carried === false){
+    data.weightCarried = 0;
+    data.valueCarried = 0;
+  }
+  if (node.contentsWeightless){
+    data.weightCarried = node.weight;
+  }
+  return data
+}
+
+function storeContentsData(node, childData, containersToWrite){
+  let newContentsWeight = childData.weightCarried
+  if (node.contentsWeight !== newContentsWeight){
+    node.contentsWeight = newContentsWeight;
+    node.contentsWeightChanged = true;
+  }
+  let newContentsValue = childData.valueCarried;
+  if (node.contentsValue !== newContentsValue){
+    node.contentsValue = newContentsValue;
+    node.contentsValueChanged = true;
+  }
+  if (node.contentsWeightChanged || node.contentsValueChanged){
+    containersToWrite.push(node);
+  }
+}

app/imports/api/creature/denormalise/recomputeSlotFullness.js

@@ -1,4 +1,4 @@
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 // n + 1 database queries + n potential updates for n slots. Could be sped up.
 export default function recomputeSlotFullness(ancestorId){
   CreatureProperties.find({
@@ -23,10 +23,14 @@ export default function recomputeSlotFullness(ancestorId){
       }
     });
     let spaceLeft;
-    if (slot.quantityExpected === 0){
+    let expected = slot.quantityExpectedResult;
+    if (typeof expected !== 'number'){
+      expected = 1;
+    }
+    if (expected === 0){
       spaceLeft = null;
     } else {
-      spaceLeft = slot.quantityExpected - totalFilled;
+      spaceLeft = expected - totalFilled;
     }
     if (slot.totalFilled !== totalFilled || slot.spaceLeft !== spaceLeft){
       CreatureProperties.update(slot._id, {

app/imports/api/creature/experience/Experiences.js

@@ -4,7 +4,7 @@ import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import { getUserTier } from '/imports/api/users/patreon/tiers.js';
 import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
 import Creatures from '/imports/api/creature/Creatures.js';
-import { recomputeCreatureById } from '/imports/api/creature/computation/recomputeCreature.js';
+import { recomputeCreatureById } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 
 let Experiences = new Mongo.Collection('experiences');
 

app/imports/api/creature/getActiveProperties.js

@@ -1,86 +0,0 @@
-import Creatures from '/imports/api/creature/Creatures.js';
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
-
-export default function getActiveProperties({
-  ancestorId,
-  filter = {},
-  options = {sort: {order: 1}},
-  includeUntoggled = false,
-  includeUnprepared = false,
-  includeUnequipped = false,
-  excludeAncestors,
-}){
-  filter = getActivePropertyFilter({
-    ancestorId,
-    filter,
-    includeUntoggled,
-    includeUnprepared,
-    includeUnequipped,
-    excludeAncestors,
-  });
-  return CreatureProperties.find(filter, options).fetch();
-}
-
-export function getActivePropertyFilter({
-  ancestorId,
-  filter = {},
-  includeUntoggled = false,
-  includeUnprepared = false,
-  includeUnequipped = false,
-  excludeAncestors = [],
-}){
-  if (!ancestorId){
-    throw 'Ancestor Id is required to get active properties'
-  }
-  // First get ids of disabled properties, unequiped items, unapplied buffs
-  let disabledAncestorsFilter = {
-    'ancestors.id': ancestorId,
-    $or: [
-      {disabled: true}, // Everything can be disabled
-      {applied: false}, // Buffs can be applied
-    ],
-  };
-  if (!includeUnequipped){
-    disabledAncestorsFilter.$or.push({type: 'item', equipped: {$ne: true}});
-  }
-  if (!includeUntoggled){
-    disabledAncestorsFilter.$or.push({toggleResult: false});
-  }
-  if (!includeUnprepared){
-    disabledAncestorsFilter.$or.push({
-      type: 'spell',
-      prepared: {$ne: true},
-      alwaysPrepared: {$ne: true}
-    });
-  }
-  let disabledAncestorIds = CreatureProperties.find(disabledAncestorsFilter, {
-    fields: {_id: 1},
-  }).map(prop => prop._id);
-
-  // Then get the ids of creatures that are children of this creature
-  // to isolate their decendent properties
-  Creatures.find({
-    'ancestors.id': ancestorId,
-  }, {
-    fields: {_id: 1},
-  }).forEach(subCreature => {
-    disabledAncestorIds.push(subCreature._id);
-  });
-
-  // Get all the properties that are decendents of the ancestor of interest but
-  // aren't from the excluded decendents
-  if (filter['ancestors.id'] && Meteor.isClient){
-    console.warn('Filtering on ancestor id is ignored')
-  }
-  filter['ancestors.id'] = {
-    $eq: ancestorId,
-    $nin: disabledAncestorIds.concat(excludeAncestors),
-  };
-  // Get properties that aren't removed
-  filter.removed = {$ne: true};
-  // Don't include the disabled ancestors themselves either
-  filter._id = {
-    $nin: disabledAncestorIds,
-  }
-  return filter;
-}

app/imports/api/creature/log/CreatureLogs.js

@@ -1,9 +1,14 @@
 import SimpleSchema from 'simpl-schema';
 import Creatures from '/imports/api/creature/Creatures.js';
+import LogContentSchema from '/imports/api/creature/log/LogContentSchema.js';
 import { ValidatedMethod } from 'meteor/mdg:validated-method';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import {assertEditPermission} from '/imports/api/creature/creaturePermissions.js';
-import { parse, CompilationContext } from '/imports/parser/parser.js';
+import {
+  parse,
+  CompilationContext,
+  prettifyParseError
+} from '/imports/parser/parser.js';
 const PER_CREATURE_LOG_LIMIT = 100;
 
 if (Meteor.isServer){
@@ -13,13 +18,13 @@ if (Meteor.isServer){
 let CreatureLogs = new Mongo.Collection('creatureLogs');
 
 let CreatureLogSchema = new SimpleSchema({
-	text: {
-		type: String,
-	},
-  type: {
-    type: String,
-    allowedValues: ['roll', 'change', 'damage', 'info'],
-    defaultValue: 'info',
+  content: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 25,
+  },
+  'content.$': {
+    type: LogContentSchema,
   },
 	// The real-world date that it occured, usually sorted by date
 	date: {
@@ -37,6 +42,10 @@ let CreatureLogSchema = new SimpleSchema({
     regEx: SimpleSchema.RegEx.Id,
     index: 1,
   },
+  creatureName: {
+    type: String,
+    optional: true,
+  },
 });
 
 CreatureLogs.attachSchema(CreatureLogSchema);
@@ -56,11 +65,45 @@ function removeOldLogs(creatureId){
   });
 }
 
+function logToMessageData(log){
+  let embed = {
+    fields: [],
+  };
+  log.content.forEach(c => {
+    let field = {};
+    let descriptionField = {};
+    if (c.name) field.name = c.name;
+    let valueArray = [];
+    if (c.error) valueArray.push(`*${c.error}*`);
+    if (c.resultPrefix) valueArray.push(`${c.resultPrefix}`);
+    if (c.result) valueArray.push(`\`${c.result}\``);
+    if (c.details) valueArray.push(c.details);
+    if (valueArray.length) field.value = valueArray.join(' ');
+    if (c.description){
+      if (!field.value){
+        field.value = c.description;
+      } else {
+        descriptionField.value = c.description;
+      }
+    }
+    if (field.name || field.value){
+      if (!field.name) field.name = '\u200b';
+      if (!field.value) field.value = '\u200b';
+      embed.fields.push(field);
+    }
+    if (descriptionField.value){
+      descriptionField.name = '\u200b';
+      embed.fields.push(descriptionField);
+    }
+  });
+  return { embeds: [embed] };
+}
+
 function logWebhook({log, creature}){
   if (Meteor.isServer){
     sendWebhookAsCreature({
       creature,
-      content: log.text,
+      data: logToMessageData(log),
     });
   }
 }
@@ -73,7 +116,7 @@ const insertCreatureLog = new ValidatedMethod({
     timeInterval: 5000,
   },
 	validate: new SimpleSchema({
-		log: CreatureLogSchema.omit('type', 'date'),
+		log: CreatureLogSchema.omit('date'),
 	}).validator(),
   run({log}){
     const creatureId = log.creatureId;
@@ -87,21 +130,27 @@ const insertCreatureLog = new ValidatedMethod({
     }});
     assertEditPermission(creature, this.userId);
     // Build the new log
-    if (typeof log === 'string'){
-      log = {text: log};
-    }
-    log.date = new Date();
-    // Insert it
-    let id = CreatureLogs.insert(log);
-    if (Meteor.isServer){
-      this.unblock();
-      removeOldLogs(creatureId);
-      logWebhook({log, creature});
-    }
+    let id = insertCreatureLogWork({log, creature, method: this})
     return id;
   },
 });
 
+export function insertCreatureLogWork({log, creature, method}){
+  // Build the new log
+  if (typeof log === 'string'){
+    log = {text: log};
+  }
+  log.date = new Date();
+  // Insert it
+  let id = CreatureLogs.insert(log);
+  if (Meteor.isServer){
+    method.unblock();
+    removeOldLogs(creature._id);
+    logWebhook({log, creature});
+  }
+  return id;
+}
+
 
 function equalIgnoringWhitespace(a, b){
   if (typeof a !== 'string' || typeof b !== 'string') return a === b;
@@ -135,39 +184,45 @@ const logRoll = new ValidatedMethod({
       avatarPicture: 1,
     }});
     assertEditPermission(creature, this.userId);
-    let parsedResult = parse(roll);
-    let logText;
-    if (parsedResult === null) {
-      logText = 'Unexpected end of input';
+    let logContent = []
+    let parsedResult = undefined;
+    try {
+      parsedResult = parse(roll);
+    } catch (e){
+      let error = prettifyParseError(e);
+      logContent.push({error});
     }
-    else try {
-      logText = [];
+    if (parsedResult) try {
       let rollContext = new CompilationContext();
       let compiled = parsedResult.compile(creature.variables, rollContext);
       let compiledString = compiled.toString();
-      if (!equalIgnoringWhitespace(compiledString, roll)) logText.push(roll);
-      logText.push(compiledString);
+      if (!equalIgnoringWhitespace(compiledString, roll)) logContent.push({
+        details: roll
+      });
+      logContent.push({
+        details: compiledString
+      });
       let rolled = compiled.roll(creature.variables, rollContext);
       let rolledString = rolled.toString();
-      if (rolledString !== compiledString) logText.push(rolled.toString());
+      if (rolledString !== compiledString) logContent.push({
+        result: rolled.toString()
+      });
       let result = rolled.reduce(creature.variables, rollContext);
       let resultString = result.toString();
-      if (resultString !== rolledString) logText.push(resultString);
-      logText = logText.join('\n\n');
+      if (resultString !== rolledString) logContent.push({
+        result: resultString
+      });
     } catch (e){
-      logText = 'Calculation error';
+      logContent = [{error: 'Calculation error'}];
     }
     const log = {
-      text: logText,
+      content: logContent,
       creatureId,
       date: new Date(),
     };
-    let id = CreatureLogs.insert(log);
-    if (Meteor.isServer){
-      this.unblock();
-      removeOldLogs(creatureId);
-      logWebhook({log, creature});
-    }
+
+    let id = insertCreatureLogWork({log, creature, method: this});
+
     return id;
   },
 });

app/imports/api/creature/log/LogContentSchema.js

@@ -0,0 +1,58 @@
+import SimpleSchema from 'simpl-schema';
+import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
+import RollDetailsSchema from '/imports/api/properties/subSchemas/RollDetailsSchema.js';
+
+let LogContentSchema = new SimpleSchema({
+  name: {
+    type: String,
+    optional: true,
+  },
+  error: {
+    type: String,
+    optional: true,
+  },
+  resultPrefix: {
+    type: String,
+    optional: true,
+  },
+  result: {
+    type: String,
+    optional: true,
+  },
+  expandedResult: {
+    type: String,
+    optional: true,
+  },
+  details: {
+    type: String,
+    optional: true,
+  },
+  description: {
+    type: String,
+    optional: true,
+  },
+  context: {
+    type: Object,
+    optional: true,
+  },
+  'context.errors':{
+    type: Array,
+    defaultValue: [],
+  },
+  'context.errors.$': {
+    type: ErrorSchema,
+  },
+  'context.rolls': {
+    type: Array,
+    defaultValue: [],
+  },
+  'context.rolls.$': {
+    type: RollDetailsSchema,
+  },
+  'context.doubleRolls': {
+    type: Boolean,
+    optional: true,
+  },
+});
+
+export default LogContentSchema;

app/imports/api/creature/mixins/recomputeCreatureMixin.js

@@ -1,4 +1,4 @@
-import { recomputeCreatureById } from '/imports/api/creature/computation/recomputeCreature.js';
+import { recomputeCreatureById } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 
 export default function recomputeCreatureMixin(methodOptions){
   let runFunc = methodOptions.run;

app/imports/api/creature/removeCreature.js

@@ -3,7 +3,7 @@ import { ValidatedMethod } from 'meteor/mdg:validated-method';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import { assertOwnership } from '/imports/api/creature/creaturePermissions.js';
 import Creatures from '/imports/api/creature/Creatures.js';
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import CreatureLogs from '/imports/api/creature/log/CreatureLogs.js';
 import Experiences from '/imports/api/creature/experience/Experiences.js';
 

app/imports/api/creature/restCreature.js

@@ -2,10 +2,9 @@ import SimpleSchema from 'simpl-schema';
 import { ValidatedMethod } from 'meteor/mdg:validated-method';
 import { RateLimiterMixin } from 'ddp-rate-limiter-mixin';
 import Creatures from '/imports/api/creature/Creatures.js';
-import CreatureProperties from '/imports/api/creature/CreatureProperties.js';
-import getActiveProperties, { getActivePropertyFilter } from '/imports/api/creature/getActiveProperties.js';
+import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
-import { recomputeCreatureById } from '/imports/api/creature/computation/recomputeCreature.js';
+import { recomputeCreatureById } from '/imports/api/creature/computation/methods/recomputeCreature.js';
 
 const restCreature = new ValidatedMethod({
   name: 'creature.methods.longRest',
@@ -43,11 +42,12 @@ const restCreature = new ValidatedMethod({
       resetFilter = {$in: ['shortRest', 'longRest']}
     }
     // Only apply to active properties
-    let filter = getActivePropertyFilter({
-      filter: {reset: resetFilter},
-      ancestorId: creatureId,
-      includeUntoggled: true,
-    });
+    let filter = {
+      'ancestors.id': creatureId,
+      reset: resetFilter,
+      removed: {$ne: true},
+      inactive: {$ne: true},
+    };
     // update all attribute's damage
     filter.type = 'attribute';
     CreatureProperties.update(filter, {
@@ -70,15 +70,19 @@ const restCreature = new ValidatedMethod({
     });
     // Reset half hit dice on a long rest, starting with the highest dice
     if (restType === 'longRest'){
-      let hitDice = getActiveProperties({
-        ancestorId: creatureId,
-        filter: {type: 'attribute', attributeType: 'hitDice'},
-        options: {fields: {
+      let hitDice = CreatureProperties.find({
+        'ancestors.id': creatureId,
+        type: 'attribute',
+        attributeType: 'hitDice',
+        removed: {$ne: true},
+        inactive: {$ne: true},
+      }, {
+        fields: {
           hitDiceSize: 1,
           damage: 1,
           value: 1,
-        }},
-      });
+        }
+      }).fetch();
       // Use a collator to do sorting in natural order
       let collator = new Intl.Collator('en', {
         numeric: true, sensitivity: 'base'

app/imports/api/library/LibraryNodes.js

@@ -32,6 +32,14 @@ let LibraryNodeSchema = new SimpleSchema({
   }
 });
 
+// Set up server side search index
+if (Meteor.isServer) {
+  LibraryNodes._ensureIndex({
+    'name': 'text',
+		'tags': 'text',
+  });
+}
+
 for (let key in propertySchemasIndex){
 	let schema = new SimpleSchema({});
 	schema.extend(LibraryNodeSchema);

app/imports/api/parenting/organizeMethods.js

@@ -8,8 +8,9 @@ import { RefSchema } from '/imports/api/parenting/ChildSchema.js';
 import { assertDocEditPermission } from '/imports/api/sharing/sharingPermissions.js';
 import fetchDocByRef from '/imports/api/parenting/fetchDocByRef.js';
 import getCollectionByName from '/imports/api/parenting/getCollectionByName.js';
-import { recomputeCreatureById } from '/imports/api/creature/computation/recomputeCreature.js';
-
+import { recomputeCreatureById } from '/imports/api/creature/computation/methods/recomputeCreature.js';
+import recomputeInactiveProperties from '/imports/api/creature/denormalise/recomputeInactiveProperties.js';
+import recomputeInventory from '/imports/api/creature/denormalise/recomputeInventory.js';
 const organizeDoc = new ValidatedMethod({
   name: 'organize.organizeDoc',
   validate: new SimpleSchema({
@@ -19,13 +20,17 @@ const organizeDoc = new ValidatedMethod({
       type: Number,
       // Should end in 0.5 to place it reliably between two existing documents
     },
+    skipRecompute: {
+      type: Boolean,
+      optional: true,
+    },
   }).validator(),
   mixins: [RateLimiterMixin],
   rateLimit: {
     numRequests: 5,
     timeInterval: 5000,
   },
-  run({docRef, parentRef, order}) {
+  run({docRef, parentRef, order, skipRecompute}) {
     let doc = fetchDocByRef(docRef);
     let collection = getCollectionByName(docRef.collection);
     // The user must be able to edit both the doc and its parent to move it
@@ -51,11 +56,20 @@ const organizeDoc = new ValidatedMethod({
     // Figure out which creatures need to be recalculated after this move
     let docCreatures = getCreatureAncestors(doc);
     let parentCreatures = getCreatureAncestors(parent);
-    let creaturesToRecompute = union(docCreatures, parentCreatures);
-    // Recompute the creatures
-    creaturesToRecompute.forEach(id => {
-      recomputeCreatureById(id);
-    });
+    if (!skipRecompute){
+      let creaturesToRecompute = union(docCreatures, parentCreatures);
+      // Recompute the creatures
+      creaturesToRecompute.forEach(id => {
+        // The active status of some properties might change due to a change in
+        // ancestry
+        recomputeInactiveProperties(id);
+        if (doc.type === 'container' || doc.type === 'item'){
+          recomputeInventory(id);
+        }
+        // Some Dependencies depend on ancestry, so a full recompute is needed
+        recomputeCreatureById(id);
+      });
+    }
   },
 });
 

app/imports/api/parenting/parenting.js

@@ -120,13 +120,19 @@ export function setLineageOfDocs({docArray, oldParent, newAncestry}){
 export function renewDocIds({docArray, collectionMap}){
   // map of {oldId: newId}
   let idMap = {};
-  // Give new ids and map the changes
+
+  // Get a random generator that's consistent on client and server
+  let randomSrc = DDP.randomStream('renewDocIds');
+
+  // Give new ids and map the changes as {oldId: newId}
   docArray.forEach(doc => {
     let oldId = doc._id;
-    let newId = Random.id();
+    let newId = randomSrc.id();
     doc._id = newId;
     idMap[oldId] = newId;
   });
+
+  // Remap all references using the new IDs
   const remapReference = ref => {
     if (idMap[ref.id]){
       ref.id = idMap[ref.id];

app/imports/api/properties/Actions.js

@@ -1,7 +1,7 @@
 import SimpleSchema from 'simpl-schema';
 import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
+import InlineComputationSchema from '/imports/api/properties/subSchemas/InlineComputationSchema.js';
 import { storedIconsSchema } from '/imports/api/icons/Icons.js'
-
 /*
  * Actions are things a character can do
  * Any rolls that are children of actions will be rolled when taking the action
@@ -117,6 +117,20 @@ let ActionSchema = new SimpleSchema({
 });
 
 const ComputedOnlyActionSchema = new SimpleSchema({
+  summaryCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'summaryCalculations.$': InlineComputationSchema,
+
+  descriptionCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'descriptionCalculations.$': InlineComputationSchema,
+
   usesResult: {
     type: SimpleSchema.Integer,
     optional: true,

app/imports/api/properties/Adjustments.js

@@ -1,4 +1,5 @@
 import SimpleSchema from 'simpl-schema';
+import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
 
 const AdjustmentSchema = new SimpleSchema({
 	// The roll that determines how much to change the attribute
@@ -13,7 +14,7 @@ const AdjustmentSchema = new SimpleSchema({
 		type: String,
     defaultValue: 'every',
 		allowedValues: [
-      'self',   // the character who took the action
+      'self',   // the character who took the Adjustment
       'each',   // rolled once for `each` target
       'every',  // rolled once and applied to `every` target
     ],
@@ -30,4 +31,22 @@ const AdjustmentSchema = new SimpleSchema({
   },
 });
 
-export { AdjustmentSchema };
+const ComputedOnlyAdjustmentSchema = new SimpleSchema({
+  amountResult: {
+    type: SimpleSchema.Integer,
+    optional: true,
+  },
+  amountErrors: {
+    type: Array,
+    optional: true,
+  },
+  'amountErrors.$':{
+    type: ErrorSchema,
+  },
+});
+
+const ComputedAdjustmentSchema = new SimpleSchema()
+  .extend(AdjustmentSchema)
+  .extend(ComputedOnlyAdjustmentSchema);
+
+export { AdjustmentSchema, ComputedAdjustmentSchema, ComputedOnlyAdjustmentSchema };

app/imports/api/properties/Attributes.js

@@ -1,6 +1,7 @@
 import SimpleSchema from 'simpl-schema';
 import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
 import VARIABLE_NAME_REGEX from '/imports/constants/VARIABLE_NAME_REGEX.js';
+import InlineComputationSchema from '/imports/api/properties/subSchemas/InlineComputationSchema.js';
 
 /*
  * Attributes are numbered stats of a character
@@ -75,6 +76,12 @@ let AttributeSchema = new SimpleSchema({
 });
 
 let ComputedOnlyAttributeSchema = new SimpleSchema({
+  descriptionCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'descriptionCalculations.$': InlineComputationSchema,
   // The result of baseValueCalculation
   baseValue: {
     type: SimpleSchema.oneOf(Number, String, Boolean),
@@ -116,6 +123,11 @@ let ComputedOnlyAttributeSchema = new SimpleSchema({
 		type: SimpleSchema.Integer,
 		optional: true,
 	},
+  // The computed creature constitution modifier
+  constitutionMod: {
+    type: Number,
+		optional: true,
+  },
   // Should this attribute hide
   hide: {
     type: Boolean,

app/imports/api/properties/Buffs.js

@@ -1,4 +1,5 @@
 import SimpleSchema from 'simpl-schema';
+import InlineComputationSchema from '/imports/api/properties/subSchemas/InlineComputationSchema.js';
 
 let BuffSchema = new SimpleSchema({
 	name: {
@@ -29,12 +30,13 @@ let BuffSchema = new SimpleSchema({
 	},
 });
 
-let AppliedBuffSchema = new SimpleSchema({
-  applied: {
-    type: Boolean,
-    defaultValue: true,
-    index: 1,
+let ComputedOnlyBuffSchema = new SimpleSchema({
+  descriptionCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
   },
+  'descriptionCalculations.$': InlineComputationSchema,
 	durationSpent: {
 		type: Number,
 		optional: true,
@@ -54,6 +56,10 @@ let AppliedBuffSchema = new SimpleSchema({
 	'appliedBy.collection': {
 		type: String,
 	},
-}).extend(BuffSchema);
+})
 
-export { AppliedBuffSchema, BuffSchema };
+const ComputedBuffSchema = new SimpleSchema()
+  .extend(BuffSchema)
+  .extend(ComputedOnlyBuffSchema);
+
+export { BuffSchema, ComputedOnlyBuffSchema, ComputedBuffSchema };

app/imports/api/properties/ClassLevels.js

@@ -6,6 +6,7 @@ let ClassLevelSchema = new SimpleSchema({
 		type: String,
 		optional: true,
 	},
+  // Only used by slot filling dialog, not computed
   description: {
     type: String,
     optional: true,

app/imports/api/properties/Constants.js

@@ -0,0 +1,82 @@
+import SimpleSchema from 'simpl-schema';
+import VARIABLE_NAME_REGEX from '/imports/constants/VARIABLE_NAME_REGEX.js';
+import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
+import {
+  parse,
+  CompilationContext,
+  prettifyParseError,
+} from '/imports/parser/parser.js';
+import AccessorNode from '/imports/parser/parseTree/AccessorNode.js';
+import SymbolNode from '/imports/parser/parseTree/SymbolNode.js';
+/*
+ * Constants are primitive values that can be used elsewhere in computations
+ */
+let ConstantSchema = new SimpleSchema({
+  name: {
+		type: String,
+		optional: true,
+	},
+  // The technical, lowercase, single-word name used in formulae
+  variableName: {
+    type: String,
+		regEx: VARIABLE_NAME_REGEX,
+    min: 2,
+    defaultValue: 'newConstant',
+  },
+	// The input value to be parsed, must return a constant node or an array
+  // of constant nodes to be valid
+	calculation: {
+		type: String,
+		optional: true,
+	},
+  errors: {
+    type: Array,
+    autoValue(){
+      let calc = this.field('calculation');
+      if (!calc.isSet && this.isModifier) {
+        this.unset()
+        return;
+      }
+      let string = calc.value;
+      if (!string) return [];
+      // Evaluate the calculation with no scope
+      let {result, context} = parseString(string);
+      // Any existing errors will result in an early failure
+      if (context && context.errors.length) return context.errors;
+      // Ban variables in constants if necessary
+      result && result.traverse(node => {
+        if (node instanceof SymbolNode || node instanceof AccessorNode){
+          context.storeError({
+            type: 'error',
+            message: 'Variables can\'t be used to define a constant'
+          });
+        }
+      });
+      return context && context.errors || [];
+    }
+  },
+  'errors.$':{
+    type: ErrorSchema,
+  },
+});
+
+function parseString(string, fn = 'compile'){
+  let context = new CompilationContext();
+  if (!string){
+    return {result: string, context};
+  }
+
+  // Parse the string using mathjs
+  let node;
+  try {
+    node = parse(string);
+  } catch (e) {
+    let message = prettifyParseError(e);
+    context.storeError({type: 'error', message});
+    return {context};
+  }
+  let result = node[fn]({/*empty scope*/}, context);
+  return {result, context}
+}
+
+export { ConstantSchema };

app/imports/api/properties/Containers.js

@@ -1,4 +1,5 @@
 import SimpleSchema from 'simpl-schema';
+import InlineComputationSchema from '/imports/api/properties/subSchemas/InlineComputationSchema.js';
 
 let ContainerSchema = new SimpleSchema({
 	name: {
@@ -33,15 +34,25 @@ let ContainerSchema = new SimpleSchema({
 });
 
 const ComputedOnlyContainerSchema = new SimpleSchema({
+  descriptionCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'descriptionCalculations.$': InlineComputationSchema,
   // Weight of all the contents, zero if `contentsWeightless` is true
   contentsWeight:{
     type: Number,
     optional: true,
   },
+  contentsValue:{
+    type: Number,
+    optional: true,
+  },
 });
 
 const ComputedContainerSchema = new SimpleSchema()
 	.extend(ComputedOnlyContainerSchema)
 	.extend(ContainerSchema);
 
-export { ContainerSchema, ComputedContainerSchema };
+export { ContainerSchema, ComputedOnlyContainerSchema, ComputedContainerSchema };

app/imports/api/properties/Damages.js

@@ -1,5 +1,6 @@
 import SimpleSchema from 'simpl-schema';
 import DAMAGE_TYPES from '/imports/constants/DAMAGE_TYPES.js';
+import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
 
 const DamageSchema = new SimpleSchema({
 	// The roll that determines how much to damage the attribute
@@ -26,4 +27,22 @@ const DamageSchema = new SimpleSchema({
 	},
 });
 
-export { DamageSchema };
+const ComputedOnlyDamageSchema = new SimpleSchema({
+  amountResult: {
+    type: SimpleSchema.oneOf(String, SimpleSchema.Integer),
+    optional: true,
+  },
+  amountErrors: {
+    type: Array,
+    optional: true,
+  },
+  'amountErrors.$':{
+    type: ErrorSchema,
+  },
+});
+
+const ComputedDamageSchema = new SimpleSchema()
+  .extend(DamageSchema)
+  .extend(ComputedOnlyDamageSchema);
+
+export { DamageSchema, ComputedDamageSchema, ComputedOnlyDamageSchema };

app/imports/api/properties/Features.js

@@ -1,4 +1,5 @@
 import SimpleSchema from 'simpl-schema';
+import InlineComputationSchema from '/imports/api/properties/subSchemas/InlineComputationSchema.js';
 
 let FeatureSchema = new SimpleSchema({
 	name: {
@@ -14,4 +15,26 @@ let FeatureSchema = new SimpleSchema({
 	},
 });
 
-export { FeatureSchema }
+let ComputedOnlyFeatureSchema = new SimpleSchema({
+
+  summaryCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'summaryCalculations.$': InlineComputationSchema,
+
+  descriptionCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'descriptionCalculations.$': InlineComputationSchema,
+
+});
+
+const ComputedFeatureSchema = new SimpleSchema()
+  .extend(FeatureSchema)
+  .extend(ComputedOnlyFeatureSchema);
+
+export { FeatureSchema, ComputedFeatureSchema, ComputedOnlyFeatureSchema }

app/imports/api/properties/Items.js

@@ -1,4 +1,5 @@
 import SimpleSchema from 'simpl-schema';
+import InlineComputationSchema from '/imports/api/properties/subSchemas/InlineComputationSchema.js';
 
 const ItemSchema = new SimpleSchema({
 	name: {
@@ -33,7 +34,6 @@ const ItemSchema = new SimpleSchema({
     optional: true,
 	},
 	// If this item is equipped, it requires attunement
-	// Being equipped is `enabled === true`
 	requiresAttunement: {
 		type: Boolean,
 		optional: true,
@@ -54,4 +54,17 @@ const ItemSchema = new SimpleSchema({
 	},
 });
 
-export { ItemSchema };
+let ComputedOnlyItemSchema = new SimpleSchema({
+  descriptionCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'descriptionCalculations.$': InlineComputationSchema,
+});
+
+const ComputedItemSchema = new SimpleSchema()
+  .extend(ItemSchema)
+  .extend(ComputedOnlyItemSchema);
+
+export { ItemSchema, ComputedItemSchema, ComputedOnlyItemSchema };

app/imports/api/properties/Notes.js

@@ -1,14 +1,41 @@
 import SimpleSchema from 'simpl-schema';
+import InlineComputationSchema from '/imports/api/properties/subSchemas/InlineComputationSchema.js';
 
 let NoteSchema = new SimpleSchema({
 	name: {
 		type: String,
 		optional: true,
 	},
+  summary: {
+		type: String,
+		optional: true,
+	},
 	description: {
 		type: String,
 		optional: true,
 	},
 });
 
-export { NoteSchema };
+let ComputedOnlyNoteSchema = new SimpleSchema({
+
+  summaryCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'summaryCalculations.$': InlineComputationSchema,
+
+  descriptionCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'descriptionCalculations.$': InlineComputationSchema,
+
+});
+
+const ComputedNoteSchema = new SimpleSchema()
+  .extend(NoteSchema)
+  .extend(ComputedOnlyNoteSchema);
+
+export { NoteSchema, ComputedNoteSchema, ComputedOnlyNoteSchema, };

app/imports/api/properties/Rolls.js

@@ -1,4 +1,6 @@
 import SimpleSchema from 'simpl-schema';
+import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
+import VARIABLE_NAME_REGEX from '/imports/constants/VARIABLE_NAME_REGEX.js';
 
 /**
  * Rolls are children to actions or other rolls, they are triggered with 0 or
@@ -19,6 +21,17 @@ import SimpleSchema from 'simpl-schema';
  *  child rolls are applied
  */
 let RollSchema = new SimpleSchema({
+  name: {
+		type: String,
+    defaultValue: 'New Roll',
+	},
+  // The technical, lowercase, single-word name used in formulae
+  variableName: {
+    type: String,
+		regEx: VARIABLE_NAME_REGEX,
+    min: 2,
+    defaultValue: 'newRoll',
+  },
   // The roll, can be simplified, but only computed in context
   roll: {
     type: String,
@@ -35,4 +48,22 @@ let RollSchema = new SimpleSchema({
   },
 });
 
-export { RollSchema };
+let ComputedOnlyRollSchema = new SimpleSchema({
+  rollResult: {
+    type: SimpleSchema.Integer,
+    optional: true,
+  },
+  rollErrors: {
+    type: Array,
+    optional: true,
+  },
+  'rollErrors.$':{
+    type: ErrorSchema,
+  },
+});
+
+const ComputedRollSchema = new SimpleSchema()
+  .extend(RollSchema)
+  .extend(ComputedOnlyRollSchema);
+
+export { RollSchema, ComputedRollSchema, ComputedOnlyRollSchema };

app/imports/api/properties/SavingThrows.js

@@ -8,11 +8,22 @@ let SavingThrowSchema = new SimpleSchema ({
     type: String,
     optional: true,
   },
+  // The computed DC
   dc: {
     type: String,
     optional: true,
   },
-  // The variable name of ability the save to roll
+  // Who this saving throw applies to
+	target: {
+		type: String,
+    defaultValue: 'every',
+		allowedValues: [
+      'self',   // the character who took the action
+      'each',   // rolled once for `each` target
+      'every',  // rolled once and applied to `every` target
+    ],
+	},
+  // The variable name of save to roll
   stat: {
     type: String,
     optional: true,

app/imports/api/properties/Slots.js

@@ -22,9 +22,9 @@ let SlotSchema = new SimpleSchema({
 		type: String,
 	},
   quantityExpected: {
-    type: SimpleSchema.Integer,
-    defaultValue: 1,
-    min: 0,
+    type: String,
+    optional: true,
+    defaultValue: '1',
   },
   ignored: {
     type: Boolean,
@@ -41,12 +41,11 @@ let SlotSchema = new SimpleSchema({
 });
 
 const ComputedOnlySlotSchema = new SimpleSchema({
-	// The computed result of the effect
+	// Condition calculation results
 	slotConditionResult: {
 		type: SimpleSchema.oneOf(Number, String, Boolean),
 		optional: true,
 	},
-  // The errors encountered while computing the result
   slotConditionErrors: {
     type: Array,
     optional: true,
@@ -54,6 +53,21 @@ const ComputedOnlySlotSchema = new SimpleSchema({
   'slotConditionErrors.$':{
     type: ErrorSchema,
   },
+
+  // Quantity Expected calculation results
+  quantityExpectedResult: {
+    type: SimpleSchema.Integer,
+    optional: true,
+  },
+  quantityExpectedErrors: {
+    type: Array,
+    optional: true,
+  },
+  'quantityExpectedErrors.$':{
+    type: ErrorSchema,
+  },
+
+  // Denormalised fields
   totalFilled: {
     type: SimpleSchema.Integer,
     defaultValue: 0,

app/imports/api/properties/SpellLists.js

@@ -1,6 +1,7 @@
 import SimpleSchema from 'simpl-schema';
 import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
 import VARIABLE_NAME_REGEX from '/imports/constants/VARIABLE_NAME_REGEX.js';
+import InlineComputationSchema from '/imports/api/properties/subSchemas/InlineComputationSchema.js';
 
 let SpellListSchema = new SimpleSchema({
 	name: {
@@ -22,9 +23,27 @@ let SpellListSchema = new SimpleSchema({
 		type: String,
 		optional: true,
 	},
+  // Calculation of The attack roll bonus used by spell attacks in this list
+  attackRollBonus: {
+		type: String,
+		optional: true,
+	},
+  // Calculation of the save dc used by spells in this list
+  dc: {
+		type: String,
+		optional: true,
+	},
 });
 
 const ComputedOnlySpellListSchema = new SimpleSchema({
+  descriptionCalculations: {
+    type: Array,
+    defaultValue: [],
+    maxCount: 32,
+  },
+  'descriptionCalculations.$': InlineComputationSchema,
+
+  // maxPrepared
   maxPreparedResult: {
     type: Number,
     optional: true,
@@ -36,6 +55,32 @@ const ComputedOnlySpellListSchema = new SimpleSchema({
   'maxPreparedErrors.$':{
     type: ErrorSchema,
   },
+
+  // attackRollBonus
+  attackRollBonusResult: {
+    type: Number,
+    optional: true,
+  },
+  attackRollBonusErrors: {
+    type: Array,
+    optional: true,
+  },
+  'attackRollBonusErrors.$':{
+    type: ErrorSchema,
+  },
+
+  // dc
+  dcResult: {
+    type: Number,
+    optional: true,
+  },
+  dcErrors: {
+    type: Array,
+    optional: true,
+  },
+  'dcErrors.$':{
+    type: ErrorSchema,
+  },
 });
 
 const ComputedSpellListSchema = new SimpleSchema()

app/imports/api/properties/Spells.js

@@ -1,6 +1,5 @@
 import { ActionSchema, ComputedOnlyActionSchema } from '/imports/api/properties/Actions.js';
 import SimpleSchema from 'simpl-schema';
-import VARIABLE_NAME_REGEX from '/imports/constants/VARIABLE_NAME_REGEX.js';
 
 const magicSchools = [
 	'abjuration',
@@ -39,10 +38,6 @@ let SpellSchema = new SimpleSchema({})
     type: Boolean,
     optional: true,
   },
-	description: {
-		type: String,
-		optional: true,
-	},
 	castingTime: {
 		type: String,
 		optional: true,

app/imports/api/properties/computedOnlyPropertySchemasIndex.js

@@ -0,0 +1,52 @@
+import SimpleSchema from 'simpl-schema';
+import { ComputedOnlyActionSchema } from '/imports/api/properties/Actions.js';
+import { ComputedOnlyAdjustmentSchema } from '/imports/api/properties/Adjustments.js';
+import { ComputedOnlyAttackSchema } from '/imports/api/properties/Attacks.js';
+import { ComputedOnlyAttributeSchema } from '/imports/api/properties/Attributes.js';
+import { ComputedOnlyBuffSchema } from '/imports/api/properties/Buffs.js';
+// import { ClassLevelSchema } from '/imports/api/properties/ClassLevels.js';
+import { ComputedOnlyContainerSchema } from '/imports/api/properties/Containers.js';
+import { ComputedOnlyDamageSchema } from '/imports/api/properties/Damages.js';
+import { DamageMultiplierSchema } from '/imports/api/properties/DamageMultipliers.js';
+import { ComputedOnlyEffectSchema } from '/imports/api/properties/Effects.js';
+import { ComputedOnlyFeatureSchema } from '/imports/api/properties/Features.js';
+// import { FolderSchema } from '/imports/api/properties/Folders.js';
+import { ComputedOnlyItemSchema } from '/imports/api/properties/Items.js';
+import { ComputedOnlyNoteSchema } from '/imports/api/properties/Notes.js';
+// import { ProficiencySchema } from '/imports/api/properties/Proficiencies.js';
+import { ComputedOnlyRollSchema } from '/imports/api/properties/Rolls.js';
+import { ComputedOnlySavingThrowSchema } from '/imports/api/properties/SavingThrows.js';
+import { ComputedOnlySkillSchema } from '/imports/api/properties/Skills.js';
+import { ComputedOnlySlotSchema } from '/imports/api/properties/Slots.js';
+// import { SlotFillerSchema } from '/imports/api/properties/SlotFillers.js';
+import { ComputedOnlySpellSchema } from '/imports/api/properties/Spells.js';
+import { ComputedOnlySpellListSchema } from '/imports/api/properties/SpellLists.js';
+import { ComputedOnlyToggleSchema } from '/imports/api/properties/Toggles.js';
+
+const propertySchemasIndex = {
+  action: ComputedOnlyActionSchema,
+  adjustment: ComputedOnlyAdjustmentSchema,
+  attack: ComputedOnlyAttackSchema,
+  attribute: ComputedOnlyAttributeSchema,
+  buff: ComputedOnlyBuffSchema,
+  // classLevel: ClassLevelSchema,
+  damage: ComputedOnlyDamageSchema,
+  damageMultiplier: DamageMultiplierSchema,
+  effect: ComputedOnlyEffectSchema,
+  feature: ComputedOnlyFeatureSchema,
+  // folder: FolderSchema,
+  note: ComputedOnlyNoteSchema,
+  // proficiency: ProficiencySchema,
+  propertySlot: ComputedOnlySlotSchema,
+  roll: ComputedOnlyRollSchema,
+  savingThrow: ComputedOnlySavingThrowSchema,
+  skill: ComputedOnlySkillSchema,
+  spellList: ComputedOnlySpellListSchema,
+  spell: ComputedOnlySpellSchema,
+  toggle: ComputedOnlyToggleSchema,
+  container: ComputedOnlyContainerSchema,
+  item: ComputedOnlyItemSchema,
+  any: new SimpleSchema({}),
+};
+
+export default propertySchemasIndex;

app/imports/api/properties/computedPropertySchemasIndex.js

@@ -1,52 +1,54 @@
 import SimpleSchema from 'simpl-schema';
 import { ComputedActionSchema } from '/imports/api/properties/Actions.js';
-import { AdjustmentSchema } from '/imports/api/properties/Adjustments.js';
+import { ComputedAdjustmentSchema } from '/imports/api/properties/Adjustments.js';
 import { ComputedAttackSchema } from '/imports/api/properties/Attacks.js';
 import { ComputedAttributeSchema } from '/imports/api/properties/Attributes.js';
-import { BuffSchema } from '/imports/api/properties/Buffs.js';
+import { ComputedBuffSchema } from '/imports/api/properties/Buffs.js';
 import { ClassLevelSchema } from '/imports/api/properties/ClassLevels.js';
-import { ContainerSchema } from '/imports/api/properties/Containers.js';
-import { DamageSchema } from '/imports/api/properties/Damages.js';
+import { ConstantSchema } from '/imports/api/properties/Constants.js';
+import { ComputedContainerSchema } from '/imports/api/properties/Containers.js';
+import { ComputedDamageSchema } from '/imports/api/properties/Damages.js';
 import { DamageMultiplierSchema } from '/imports/api/properties/DamageMultipliers.js';
 import { ComputedEffectSchema } from '/imports/api/properties/Effects.js';
-import { FeatureSchema } from '/imports/api/properties/Features.js';
+import { ComputedFeatureSchema } from '/imports/api/properties/Features.js';
 import { FolderSchema } from '/imports/api/properties/Folders.js';
-import { ItemSchema } from '/imports/api/properties/Items.js';
-import { NoteSchema } from '/imports/api/properties/Notes.js';
+import { ComputedItemSchema } from '/imports/api/properties/Items.js';
+import { ComputedNoteSchema } from '/imports/api/properties/Notes.js';
 import { ProficiencySchema } from '/imports/api/properties/Proficiencies.js';
-import { RollSchema } from '/imports/api/properties/Rolls.js';
+import { ComputedRollSchema } from '/imports/api/properties/Rolls.js';
 import { ComputedSavingThrowSchema } from '/imports/api/properties/SavingThrows.js';
 import { ComputedSkillSchema } from '/imports/api/properties/Skills.js';
 import { ComputedSlotSchema } from '/imports/api/properties/Slots.js';
 import { SlotFillerSchema } from '/imports/api/properties/SlotFillers.js';
 import { ComputedSpellSchema } from '/imports/api/properties/Spells.js';
 import { ComputedSpellListSchema } from '/imports/api/properties/SpellLists.js';
-import { ToggleSchema } from '/imports/api/properties/Toggles.js';
+import { ComputedToggleSchema } from '/imports/api/properties/Toggles.js';
 
 const propertySchemasIndex = {
   action: ComputedActionSchema,
-  adjustment: AdjustmentSchema,
+  adjustment: ComputedAdjustmentSchema,
   attack: ComputedAttackSchema,
   attribute: ComputedAttributeSchema,
-  buff: BuffSchema,
+  buff: ComputedBuffSchema,
   classLevel: ClassLevelSchema,
-  damage: DamageSchema,
+  constant: ConstantSchema,
+  damage: ComputedDamageSchema,
   damageMultiplier: DamageMultiplierSchema,
   effect: ComputedEffectSchema,
-  feature: FeatureSchema,
+  feature: ComputedFeatureSchema,
   folder: FolderSchema,
-  note: NoteSchema,
+  note: ComputedNoteSchema,
   proficiency: ProficiencySchema,
   propertySlot: ComputedSlotSchema,
-  roll: RollSchema,
+  roll: ComputedRollSchema,
   savingThrow: ComputedSavingThrowSchema,
   skill: ComputedSkillSchema,
   slotFiller: SlotFillerSchema,
   spellList: ComputedSpellListSchema,
   spell: ComputedSpellSchema,
-  toggle: ToggleSchema,
-  container: ContainerSchema,
-  item: ItemSchema,
+  toggle: ComputedToggleSchema,
+  container: ComputedContainerSchema,
+  item: ComputedItemSchema,
   any: new SimpleSchema({}),
 };
 

app/imports/api/properties/propertySchemasIndex.js

@@ -5,6 +5,7 @@ import { AttackSchema } from '/imports/api/properties/Attacks.js';
 import { AttributeSchema } from '/imports/api/properties/Attributes.js';
 import { BuffSchema } from '/imports/api/properties/Buffs.js';
 import { ClassLevelSchema } from '/imports/api/properties/ClassLevels.js';
+import { ConstantSchema } from '/imports/api/properties/Constants.js';
 import { DamageSchema } from '/imports/api/properties/Damages.js';
 import { DamageMultiplierSchema } from '/imports/api/properties/DamageMultipliers.js';
 import { EffectSchema } from '/imports/api/properties/Effects.js';
@@ -30,6 +31,7 @@ const propertySchemasIndex = {
   attribute: AttributeSchema,
   buff: BuffSchema,
   classLevel: ClassLevelSchema,
+  constant: ConstantSchema,
   damage: DamageSchema,
   damageMultiplier: DamageMultiplierSchema,
   effect: EffectSchema,

app/imports/api/properties/subSchemas/InlineComputationSchema.js

@@ -0,0 +1,16 @@
+import SimpleSchema from 'simpl-schema';
+import ErrorSchema from '/imports/api/properties/subSchemas/ErrorSchema.js';
+
+const InlineComputationSchema = new SimpleSchema({
+	// The part between bracers {}
+  calculation: {
+    type: String,
+  },
+  result: {
+    type: String,
+    optional: true,
+  },
+  errors: ErrorSchema,
+});
+
+export default InlineComputationSchema;

app/imports/api/properties/subSchemas/RollDetailsSchema.js

@@ -0,0 +1,19 @@
+import SimpleSchema from 'simpl-schema';
+
+const RollDetailsSchema = new SimpleSchema({
+  number: {
+    type: Number,
+  },
+  diceSize: {
+    type: Number,
+  },
+  values: {
+    type: Array,
+    defaultValue: [],
+  },
+  'values.$': {
+    type: Number,
+  },
+});
+
+export default RollDetailsSchema;

app/imports/api/users/patreon/updatePatreonDetails.js

@@ -9,8 +9,8 @@ const getIdentity = function(accessToken, callback){
       Authorization: 'Bearer ' + accessToken,
     },
     qs: {
-      'include': 'memberships',
-      'fields[member]': 'currently_entitled_amount_cents',
+      'include': 'memberships.currently_entitled_tiers',
+      'fields[tier]': 'amount_cents,title',
     }
   }, callback);
 };
@@ -61,9 +61,18 @@ const updateIdentity = Meteor.wrapAsync(function(accessToken, userId, callback){
     }
     try {
       let identity = JSON.parse(body);
-      let membership = identity.included && identity.included[0];
-      let entitledAmount = membership && membership.attributes
-        .currently_entitled_amount_cents || 0;
+      let entitledAmount = 0;
+      if (identity && identity.included){
+        identity.included.forEach(doc => {
+          if (
+            doc.type === 'tier' &&
+            doc.attributes &&
+            doc.attributes.amount_cents > entitledAmount
+          ){
+            entitledAmount = doc.attributes.amount_cents;
+          }
+        });
+      }
       writeEntitledCents(userId, entitledAmount);
       if (callback) callback();
     } catch(error) {

app/imports/client/config.js

@@ -0,0 +1,2 @@
+Meteor.connection._bufferedWritesInterval = 0;
+//Meteor.connection._bufferedWritesMaxAge = 500;

app/imports/constants/INLINE_CALCULTION_REGEX.js

@@ -0,0 +1,3 @@
+const INLINE_CALCULATION_REGEX = /\{([^{}]*)\}/g;
+
+export default INLINE_CALCULATION_REGEX;