jschaufuss/DiceCloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed: stats with no ability selected have an ability modifier of 0 instead of NaN

Browse Source
This commit is contained in:
Stefan Zermatten
2021-02-20 15:50:25 +02:00
parent 1a2ef8a4a2
commit 4288f98f7c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/imports/api/creature/computation/engine/combineStat.js
View File

@@ -76,7 +76,7 @@ function combineAttribute(stat, aggregator, memo){
function combineSkill(stat, aggregator, memo){
// Skills are based on some ability Modifier
let ability = memo.statsByVariableName[stat.ability]
let ability = stat.ability && memo.statsByVariableName[stat.ability]
if (stat.ability && ability){
if (!ability.computationDetails.computed){
computeStat(ability, memo);
@@ -87,6 +87,8 @@ function combineSkill(stat, aggregator, memo){
[ability._id],
ability.dependencies,
);
} else {
stat.abilityMod = 0;
}
// Combine all the child proficiencies
stat.proficiency = stat.baseProficiency || 0;