jschaufuss/DiceCloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed saving throws contaminating later saves with their result

Browse Source
This commit is contained in:
ThaumRystra
2024-10-15 21:12:55 +02:00
parent 5c7234ec62
commit 7a480e333c
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/imports/api/engine/action/applyProperties/applySavingThrowProperty.test.ts
View File

@@ -60,7 +60,7 @@ const actionTargetCreature2 = {
],
}
describe.only('Apply saving throw properties', function () {
describe('Apply saving throw properties', function () {
// Increase timeout
this.timeout(8000);

4
app/imports/api/engine/action/applyProperties/applySavingThrowProperty.ts
View File

@@ -10,8 +10,6 @@ import { getVariables } from '/imports/api/engine/loadCreatures';
import numberToSignedString from '/imports/api/utility/numberToSignedString';
import { isFiniteNode } from '/imports/parser/parseTree/constant';
// FIXME saves against multiple targets contaminate later targets scope with the ~saveFailed or ~saveSucceeded variables of the previous targets
export default async function applySavingThrowProperty(
task: PropTask, action: EngineAction, result: TaskResult, inputProvider: InputProvider
): Promise<void> {
@@ -100,8 +98,10 @@ export default async function applySavingThrowProperty(
const saveSuccess = resultValue >= dc;
if (saveSuccess) {
result.pushScope['~saveSucceeded'] = { value: true };
result.pushScope['~saveFailed'] = { value: false };
} else {
result.pushScope['~saveFailed'] = { value: true };
result.pushScope['~saveSucceeded'] = { value: false };
}
if (!prop.silent) result.appendLog({
name: saveSuccess ? 'Successful save' : 'Failed save',