Minor redesign of printed character sheets

app/imports/client/ui/creature/character/printedCharacterSheet/CharacterSheetPrinted.vue

@@ -32,7 +32,10 @@
         light
       >
         <div class="page pa-3">
-          <div class="title-block px-3 d-flex align-center">
+          <div
+            class="title-block px-3 d-flex align-center"
+            style="page-break-after: avoid;"
+          >
             <div class="logo-background" />
             <div class="creature-name mr-3">
               {{ creature.name }}
@@ -59,7 +62,7 @@
           </div>
           <div
             class="text-right mt-3 mr-4"
-            style="font-size: 8pt; margin-bottom: -4px;"
+            style="font-size: 8pt; margin-bottom: -4px; page-break-after: avoid;"
           >
             {{ creatureUrl }}
           </div>
@@ -234,7 +237,7 @@ export default {
 .character-sheet-printed {
   background: white;
   color: black;
-  font-size: 11pt;
+  font-size: 10pt;
 }
 
 .character-sheet-printed * {
@@ -247,6 +250,14 @@ export default {
   padding: 4px;
 }
 
+.character-sheet-printed p {
+  margin-bottom: 8px;
+}
+
+.character-sheet-printed .double-border > .label:first-child {
+  margin-bottom: 8px;
+}
+
 .character-sheet-printed .column-layout, .character-sheet-printed .column-layout.wide-columns {
   position:relative;
   width: 100%;
@@ -256,6 +267,10 @@ export default {
   column-fill: balance-all;
 }
 
+.character-sheet-printed .column-layout {
+  column-width: 200px;
+}
+
 .character-sheet-printed .column-layout>div {
   position:relative;
 }
@@ -267,9 +282,10 @@ export default {
   opacity: 1 !important;
 }
 .character-sheet-printed .creature-name {
-  font-size: 24pt;
+  font-size: 16pt;
   background-color: white;
 }
+
 .character-sheet-printed .logo-background {
   width: 60px;
   height: 60px;
@@ -284,6 +300,10 @@ export default {
   max-width: unset;
 }
 
+.character-sheet-printed .tree-node-title {
+  min-height: unset !important;
+}
+
 .character-sheet-printed .double-border {
   position: relative;
   padding: 11px 10px;
@@ -291,6 +311,8 @@ export default {
   border-image-slice: 110 126 fill;
   border-image-width: 16px;
   border-image-repeat: stretch;
+  box-decoration-break: clone;
+  page-break-inside: avoid;
 }
 
 .character-sheet-printed .octagon-border {
@@ -298,6 +320,8 @@ export default {
   padding: 4px 20px;
   border-image: url(/images/print/octagonBorder.png) 124 118 fill;
   border-image-width: 22px;
+  box-decoration-break: clone;
+  page-break-inside: avoid;
 }
 
 .character-sheet-printed .span-all {
@@ -322,6 +346,7 @@ export default {
 
 .character-sheet-printed .span-all {
   column-span: all;
+  display: block;
 }
 
 @media screen {
@@ -337,7 +362,7 @@ export default {
 @media print {
   @page { 
       size: auto;
-      margin: 8mm 8mm 8mm 8mm;  
+      margin: 8mm;  
   }
   body {  
       margin: 0;  

app/imports/client/ui/creature/character/printedCharacterSheet/PrintedInventory.vue

@@ -2,83 +2,72 @@
   <div
     class="inventory"
   >
-    <column-layout wide-columns>
-      <div class="span-all">
-        <div class="double-border">
-          <div class="label text-center">
-            Inventory
-          </div>
-          <div class="d-flex inventory-stat">
-            <v-icon>$vuetify.icons.injustice</v-icon>
-            Weight Carried:
-            {{ weightCarried }} lb
-          </div>
-          <div class="d-flex inventory-stat">
-            <v-icon>$vuetify.icons.cash</v-icon>
-            Net worth:
-            <coin-value
-              class="ml-2"
-              :value="variables && variables.valueTotal && variables.valueTotal.value|| 0"
-            />
-          </div>
-          <div class="d-flex inventory-stat">
-            <v-icon>$vuetify.icons.spell</v-icon>
-            Items attuned:
-            {{ variables.itemsAttuned && variables.itemsAttuned.value }}
-          </div>
-        </div>
+    <div class="double-border">
+      <div class="label text-center">
+        Inventory
       </div>
-      <div class="span-all">
-        <div class="octagon-border label text-center">
-          Equipped
-        </div>
+      <div class="d-flex inventory-stat">
+        <v-icon>$vuetify.icons.injustice</v-icon>
+        Weight Carried:
+        {{ weightCarried }} lb
       </div>
-      <div
-        v-for="item in equippedItems"
-        :key="item._id"
-      >
-        <printed-item
-          class="double-border"
-          :model="item"
+      <div class="d-flex inventory-stat">
+        <v-icon>$vuetify.icons.cash</v-icon>
+        Net worth:
+        <coin-value
+          class="ml-2"
+          :value="variables && variables.valueTotal && variables.valueTotal.value|| 0"
         />
       </div>
-      <div class="span-all">
-        <div class="octagon-border label text-center">
-          Carried
-        </div>
-      </div>
       <div
-        v-for="item in carriedItems"
-        :key="item._id"
+        v-if="variables.itemsAttuned && variables.itemsAttuned.value"
+        class="d-flex inventory-stat"
       >
+        <v-icon>$vuetify.icons.spell</v-icon>
+        Items attuned:
+        {{ variables.itemsAttuned && variables.itemsAttuned.value }}
+      </div>
+    </div>
+    <div class="double-border my-2">
+      <div class="label text-center">
+        Equipped
+      </div>
+      <column-layout wide-columns>
         <printed-item
-          class="double-border"
+          v-for="item in equippedItems"
+          :key="item._id"
           :model="item"
         />
+      </column-layout>
+    </div>
+    <div class="double-border my-2">
+      <div class="label text-center">
+        Carried
       </div>
-      <template
-        v-for="container in containersWithoutAncestorContainers"
-      >
-        <div 
-          :key="container._id"
-          class="span-all"
-        >
-          <printed-container
-            class="octagon-border"
-            :model="container"
-          />
-        </div>
-        <div
+      <column-layout wide-columns>
+        <printed-item
+          v-for="item in carriedItems"
+          :key="item._id"
+          :model="item"
+        />
+      </column-layout>
+    </div>
+    <div
+      v-for="container in containersWithoutAncestorContainers"
+      :key="container._id"
+      class="double-border my-2"
+    >
+      <printed-container
+        :model="container"
+      />
+      <column-layout wide-columns>
+        <printed-item
           v-for="item in container.items"
           :key="item._id"
-        >
-          <printed-item
-            class="double-border"
-            :model="item"
-          />
-        </div>
-      </template>
-    </column-layout>
+          :model="item"
+        />
+      </column-layout>
+    </div>
   </div>
 </template>
 
@@ -90,7 +79,7 @@ import getParentRefByTag from '/imports/api/creature/creatureProperties/methods/
 import BUILT_IN_TAGS from '/imports/constants/BUILT_IN_TAGS.js';
 import CoinValue from '/imports/client/ui/components/CoinValue.vue';
 import stripFloatingPointOddities from '/imports/api/engine/computation/utility/stripFloatingPointOddities.js';
-import PrintedItem from '/imports/client/ui/creature/character/printedCharacterSheet/components/PrintedItem.vue';
+import PrintedLineItem from '/imports/client/ui/creature/character/printedCharacterSheet/components/PrintedLineItem.vue';
 import PrintedContainer from '/imports/client/ui/creature/character/printedCharacterSheet/components/PrintedContainer.vue';
 import CreatureVariables from '/imports/api/creature/creatures/CreatureVariables.js';
 
@@ -98,7 +87,7 @@ export default {
   components: {
     ColumnLayout,
     CoinValue,
-    PrintedItem,
+    PrintedItem: PrintedLineItem,
     PrintedContainer,
   },
   props: {
@@ -233,15 +222,17 @@ export default {
 </script>
 
 <style lang="css" scoped>
-
 .label {
-  font-size: 14pt;
+  font-size: 12pt;
   font-variant: small-caps;
   flex-grow: 1;
 }
 
+.inventory .double-border {
+  box-decoration-break: slice;
+}
 .inventory-stat {
-  font-size: 12pt;
+  font-size: 11pt;
   line-height: 32px;
 }
 .inventory-stat > .v-icon {

app/imports/client/ui/creature/character/printedCharacterSheet/PrintedStats.vue

@@ -1,21 +1,29 @@
 <template lang="html">
   <div class="stats">
-    <column-layout>
+    <div
+      class="d-flex wrap justify-space-between px-2 pt-3 pb-1"
+      style="page-break-after: avoid"
+    >
       <div
         v-for="ability in abilities"
         :key="ability._id"
       >
         <div
-          class="ability"
+          class="ability ma-0"
         >
           <div class="score">
-            <div class="double-border top big-number">
-              <template v-if="creature.settings.swapScoresAndMods">
-                {{ ability.total }}
-              </template>
-              <template v-else>
-                {{ numberToSignedString(ability.modifier) }}
-              </template>
+            <div class="double-border top">
+              <div class="label text-center mb-0">
+                {{ ability.name }}
+              </div>
+              <div class="big-number mb-1">
+                <template v-if="creature.settings.swapScoresAndMods">
+                  {{ ability.total }}
+                </template>
+                <template v-else>
+                  {{ numberToSignedString(ability.modifier) }}
+                </template>
+              </div>
             </div>
             <div class="bottom">
               <template v-if="creature.settings.swapScoresAndMods">
@@ -26,12 +34,10 @@
               </template>
             </div>
           </div>
-          <div class="double-border name label">
-            {{ ability.name }}
-          </div>
         </div>
       </div>
-
+    </div>
+    <column-layout>
       <div
         v-for="toggle in toggles"
         :key="toggle._id"
@@ -105,7 +111,7 @@
           <div class="label">
             Total: {{ healthBar.total }}
           </div>
-          <div style="height: 60px;" />
+          <div style="height: 40px;" />
           <div
             style="text-align: center;"
             class="label"
@@ -136,7 +142,7 @@
               {{ hitDie.total }}{{ hitDie.hitDiceSize }}
             </span>
           </div>
-          <div style="height: 60px;" />
+          <div style="height: 40px;" />
           <div
             style="text-align: center;"
             class="label"
@@ -232,6 +238,13 @@
             :model="save"
             :data-id="save._id"
           />
+          <div
+            v-for="(effect) in saveConditionals"
+            :key="effect._id"
+            class="mt-2"
+          >
+            * {{ effect.text }}
+          </div>
           <div class="label text-center">
             Saving Throws
           </div>
@@ -250,6 +263,13 @@
             :model="skill"
             :data-id="skill._id"
           />
+          <div
+            v-for="(effect) in skillConditionals"
+            :key="effect._id"
+            class="mt-2"
+          >
+            * {{ effect.text }}
+          </div>
           <div class="label text-center">
             Skills
           </div>
@@ -261,69 +281,20 @@
         <div
           class="double-border"
         >
-          <printed-skill
-            v-for="weapon in weapons"
-            :key="weapon._id"
-            hide-modifier
-            :model="weapon"
-            :data-id="weapon._id"
-          />
+          <p>
+            <b>Weapons:</b> {{ weapons.map(p => p.name).join(', ') }}
+          </p>
+          <p>
+            <b>Armor:</b> {{ armors.map(p => p.name).join(', ') }}
+          </p>
+          <p>
+            <b>Tools:</b> {{ tools.map(p => p.name).join(', ') }}
+          </p>
+          <p>
+            <b>Languages:</b> {{ languages.map(p => p.name).join(', ') }}
+          </p>
           <div class="label text-center">
-            Weapons
-          </div>
-        </div>
-      </div>
-      <div
-        v-if="armors && armors.length"
-      >
-        <div
-          class="double-border"
-        >
-          <printed-skill
-            v-for="armor in armors"
-            :key="armor._id"
-            hide-modifier
-            :model="armor"
-            :data-id="armor._id"
-          />
-          <div class="label text-center">
-            Armor
-          </div>
-        </div>
-      </div>
-      <div
-        v-if="tools && tools.length"
-      >
-        <div
-          class="double-border"
-        >
-          <printed-skill
-            v-for="tool in tools"
-            :key="tool._id"
-            hide-modifier
-            :model="tool"
-            :data-id="tool._id"
-          />
-          <div class="label text-center">
-            Tools
-          </div>
-        </div>
-      </div>
-      <div
-        v-if="languages && languages.length"
-      >
-        <div
-          class="double-border"
-        >
-          <printed-skill
-            v-for="language in languages"
-            :key="language._id"
-            hide-modifier
-            :model="language"
-            :data-id="language._id"
-          />
-          <div class="label text-center">
-            Languages
+            Proficiencies
           </div>
         </div>
       </div>
@@ -381,6 +352,7 @@ import numberToSignedString from '../../../../../api/utility/numberToSignedStrin
 import PrintedSkill from '/imports/client/ui/creature/character/printedCharacterSheet/components/PrintedSkill.vue';
 import PrintedDamageMultipliers from '/imports/client/ui/creature/character/printedCharacterSheet/components/PrintedDamageMultipliers.vue';
 import PropertyDescription from '/imports/client/ui/properties/viewers/shared/PropertyDescription.vue';
+import { uniqBy } from 'lodash';
 
 const getProperties = function (creature, filter, options = {
   sort: { order: 1 }
@@ -483,9 +455,31 @@ export default {
     savingThrows() {
       return getSkillOfType(this.creature, 'save');
     },
+    saveConditionals(){
+      const conditionals = [];
+      this.savingThrows?.forEach(prop => {
+        prop?.effects?.forEach(effect => {
+          if (effect.operation === 'conditional') {
+            conditionals.push(effect);
+          }
+        });
+      });
+      return uniqBy(conditionals, '_id');
+    },
     skills() {
       return getSkillOfType(this.creature, 'skill');
     },
+    skillConditionals(){
+      const conditionals = [];
+      this.skills?.forEach(prop => {
+        prop?.effects?.forEach(effect => {
+          if (effect.operation === 'conditional') {
+            conditionals.push(effect);
+          }
+        });
+      });
+      return uniqBy(conditionals, '_id');
+    },
     tools() {
       return getSkillOfType(this.creature, 'tool');
     },
@@ -557,10 +551,10 @@ export default {
   align-items: center;
 }
 .ability .top {
-  min-width: 64px;
+  min-width: 86px;
   text-align: center;
-  margin-bottom: -10px;
-  padding: 14px;
+  margin: 4px 4px -10px;
+  padding: 8px;
   z-index: 1;
 }
 .ability .bottom {

app/imports/client/ui/creature/character/printedCharacterSheet/components/PrintedAction.vue

@@ -3,36 +3,21 @@
     class="action-card"
     :class="cardClasses"
   >
-    <div class="label text-center">
-      {{ actionTypeName }}
-    </div>
-    <div class="d-flex align-center">
+    <div class="d-flex align-center mb-2">
+      <div class="roll-bonus">
+        <template v-if="!onHitDamage && rollBonus">
+          {{ rollBonus }}
+        </template>
+      </div>
+      <div class="action-title text-center flex-grow-1">
+        {{ model.name || propertyName }}
+      </div>
       <div class="avatar">
-        <div
-          v-if="rollBonus"
-        >
-          <template v-if="rollBonus && !rollBonusTooLong">
-            {{ rollBonus }}
-          </template>
-          <property-icon
-            v-else
-            :model="model"
-            color="rgba(0,0,0,0.7)"
-          />
-        </div>
         <property-icon
-          v-else
           :model="model"
           color="rgba(0,0,0,0.7)"
         />
       </div>
-      <div
-        class="action-header flex d-flex column justify-center pl-1"
-      >
-        <div class="action-title my-1">
-          {{ model.name || propertyName }}
-        </div>
-      </div>
     </div>
     <div
       v-if="Number.isFinite(model.uses)"
@@ -40,7 +25,7 @@
     >
       {{ model.uses }} uses
     </div>
-    <div class="pb-3">
+    <div>
       <div
         v-if="model.resources && model.resources.attributesConsumed.length ||
           model.resources.itemsConsumed.length"
@@ -65,14 +50,35 @@
       <template v-if="model.summary">
         <markdown-text :markdown="model.summary.value || model.summary.text" />
       </template>
-      <v-divider v-if="children && children.length" />
+      <div
+        v-if="onHitDamage"
+      >
+        <span class="damage">
+          {{ rollBonus }}
+        </span>
+        <span>
+          to hit
+        </span>
+      </div>
+      <div v-if="onHitDamage">
+        <span class="damage">
+          {{ onHitDamage.damage }}
+        </span>
+        <span>
+          {{ onHitDamage.suffix }}
+        </span>
+      </div>
       <tree-node-list
-        v-if="children && children.length"
+        v-else-if="children && children.length"
         start-expanded
+        show-external-details
         :children="children"
         @selected="e => $emit('sub-click', e)"
       />
     </div>
+    <div class="action-subtitle text-center">
+      {{ actionTypeName }}
+    </div>
   </div>
 </template>
 
@@ -87,6 +93,8 @@ import TreeNodeList from '/imports/client/ui/components/tree/TreeNodeList.vue';
 import { nodeArrayToTree } from '/imports/api/parenting/nodesToTree.js';
 import CreatureProperties from '/imports/api/creature/creatureProperties/CreatureProperties.js';
 import { some } from 'lodash';
+import applyEffectsToCalculationParseNode from '/imports/api/engine/actions/applyPropertyByType/shared/applyEffectsToCalculationParseNode.js';
+import resolve, { Context, toString } from '/imports/parser/resolve.js';
 
 export default {
   components: {
@@ -148,7 +156,24 @@ export default {
         'free': 'Free Action',
         'long': 'Long Action'
       }[this.model.actionType] || this.model.actionType
-    }
+    },
+    onHitDamage() {
+      /**
+       * Only match a property who has exactly one to-hit child with one damage under that
+       */
+      if (this.children?.length !== 1) return;
+      if (this.children[0]?.node?.type !== 'branch') return;
+      if (this.children[0].children?.length !== 1) return;
+      if (this.children[0].children[0]?.node?.type !== 'damage') return;
+      if (this.children[0].children[0].children?.length !== 0) return;
+      const damage = this.children[0].children[0]?.node;
+      applyEffectsToCalculationParseNode(damage.amount);
+      const { result } = resolve('compile', damage.amount.parseNode, {});
+      return {
+        damage: toString(result),
+        suffix: damage.damageType + (damage.damageType !== 'healing' ? ' damage ' : '')
+      };
+    },
   },
   meteor: {
     children() {
@@ -187,28 +212,39 @@ export default {
   transition: box-shadow .4s cubic-bezier(0.25, 0.8, 0.25, 1),
     transform 0.075s ease;
 }
-
-.avatar {
+.roll-bonus {
   font-size: 18pt;
-  text-align: center;
-  min-width: 40px;
-  min-height: 40px;
+  flex-basis: 24px;
+}
+.avatar {
+  min-width: 24px;
+  min-height: 24px;
+  line-height: 24px;
 }
 
 .label {
   font-size: 10pt;
-  font-variant: small-caps;
+  font-variant: all-small-caps;
   flex-grow: 1;
 }
 
+.damage {
+  font-size: 12pt;
+  font-weight: 500;
+}
 .action-title {
-  font-size: 16px;
-  font-weight: 400;
-  line-height: 24px;
-  position: relative;
-  text-align: left;
-  transition: .3s cubic-bezier(.25, .8, .5, 1);
-  width: 100%;
+  font-size: 12pt;
+  font-weight: 600;
+  min-height: 24px;
+  display: flex;
+  align-items: center;
+  justify-content: center;
+  font-variant: all-small-caps;
+}
+
+.action-subtitle {
+  font-variant: all-small-caps;
+  font-size: 11pt;
 }
 
 .resources {

app/imports/client/ui/creature/character/printedCharacterSheet/components/PrintedLineItem.vue

@@ -0,0 +1,122 @@
+<template lang="html">
+  <div class="printed-line-item d-flex align-start mb-0">
+    <div class="quantity">
+      {{ model.quantity !== 1 ? model.quantity : undefined }}
+    </div>
+    <div class="text flex-grow-1">
+      {{ title }}
+      <template v-if="attunementText">
+        ({{ attunementText }})
+      </template>
+    </div>
+    <div class="weight-value d-flex flex-column align-end">
+      <div
+        v-if="model.quantity !== 1"
+        class="each d-flex align-center"
+      >
+        <coin-value
+          v-if="model.value"
+          class="value text-no-wrap"
+          :value="model.value"
+        />
+        <div
+          class="weight text-no-wrap"
+        >
+          <template
+            v-if="model.weight"
+          >
+            {{ model.weight }} lb
+          </template>
+        </div>
+      </div>
+      <div class="total d-flex align-center">
+        <coin-value
+          v-if="totalValue"
+          class="value text-no-wrap"
+          :value="totalValue"
+        />
+        <div
+          class="weight text-no-wrap"
+        >
+          <template
+            v-if="model.weight"
+          >
+            {{ totalWeight }} lb
+          </template>
+        </div>
+      </div>
+    </div>
+  </div>
+</template>
+
+<script lang="js">
+import PROPERTIES from '/imports/constants/PROPERTIES.js';
+import stripFloatingPointOddities from '/imports/api/engine/computation/utility/stripFloatingPointOddities.js';
+import CoinValue from '/imports/client/ui/components/CoinValue.vue';
+
+export default {
+  components: {
+    CoinValue,
+  },
+  props: {
+    model: {
+      type: Object,
+      required: true,
+    },
+  },
+  computed: {
+    title() {
+      let model = this.model;
+      if (!model) return;
+      if (model.quantity !== 1) {
+        if (model.plural) {
+          return model.plural;
+        } else if (model.name) {
+          return model.name;
+        }
+      } else if (model.name) {
+        return model.name;
+      }
+      let prop = PROPERTIES[model.type]
+      return prop && prop.name;
+    },
+    totalValue() {
+      return stripFloatingPointOddities(this.model.value * this.model.quantity);
+    },
+    totalWeight() {
+      return stripFloatingPointOddities(this.model.weight * this.model.quantity);
+    },
+    attunementText() {
+      if (this.model.requiresAttunement) {
+        if (this.model.attuned) return 'Attuned';
+        return 'Requires attunement';
+      }
+      return undefined;
+    }
+  },
+}
+</script>
+
+<style lang="css" scoped>
+  .quantity {
+    flex-basis: 32px;
+    font-weight: 500;
+    text-align: center;
+  }
+  .each {
+    font-weight: 300;
+  }
+  .total {
+
+  }
+  .weight-value {
+  }
+  .value {
+    min-width: 40px;
+    text-align: end;
+  }
+  .weight {
+    min-width: 40px;
+    text-align: end;
+  }
+</style>

app/imports/client/ui/creature/character/printedCharacterSheet/components/PrintedSkill.vue

@@ -11,7 +11,7 @@
           :value="model.proficiency"
           class="prof-icon"
         />
-        <div class="prof-mod ml-2 mr-4 text-right">
+        <div class="prof-mod mr-3 text-right">
           {{ displayedModifier }}
         </div>
         <v-icon
@@ -88,7 +88,7 @@ export default {
 
 <style lang="css" scoped>
 .printed-skill{
-  min-height: 30px;
+  min-height: 0;
 }
 
 .prof-icon {