jschaufuss/DiceCloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed subtle trigger bugs that break LoV hit dice extension

Browse Source
This commit is contained in:
Thaum Rystra
2024-05-15 16:06:56 +02:00
parent 4fc897deec
commit 1266794db7
7 changed files with 83 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
app/imports/api/engine/computation/computeComputation/computeByType/computeTrigger.js
View File

@@ -8,17 +8,32 @@ export default function computeTrigger(computation, node) {
if (prop.inactive) return;
// Link triggers to all the properties that would fire them when applied
if (prop.event === 'doActionProperty') {
getEffectTagTargets(prop, computation).forEach(targetId => {
const targetProp = computation.propsById[targetId];
// Only apply if the trigger matches this property type
if (targetProp.type !== prop.actionPropertyType) return;
let triggerIdArray = get(targetProp, `triggerIds.${prop.timing}`);
if (!triggerIdArray) {
triggerIdArray = [];
set(targetProp, `triggerIds.${prop.timing}`, triggerIdArray);
}
triggerIdArray.push(prop._id);
});
const tagTargets = getEffectTagTargets(prop, computation);
switch (prop.event) {
case 'doActionProperty':
tagTargets.forEach(targetId => {
const targetProp = computation.propsById[targetId];
// Only apply if the trigger matches this property type
if (targetProp.type !== prop.actionPropertyType) return;
setTrigger(prop, targetProp);
});
break;
case 'damageProperty':
tagTargets.forEach(targetId => {
const targetProp = computation.propsById[targetId];
// Only apply to attributes
if (targetProp.type !== 'attribute') return;
setTrigger(prop, targetProp);
});
break;
}
}
function setTrigger(prop, targetProp) {
let triggerIdArray = get(targetProp, `triggerIds.${prop.timing}`);
if (!triggerIdArray) {
triggerIdArray = [];
set(targetProp, `triggerIds.${prop.timing}`, triggerIdArray);
}
triggerIdArray.push(prop._id);
}