From fd79bc2bb3d4da7f6fe46641243f1919bbfab4fe Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Tue, 26 Jul 2022 14:09:51 +0200
Subject: [PATCH] Removed empty dependency loop errors

---
 .../computation/computeCreatureComputation.js      | 14 ++++++++------
 .../creature/character/errors/CharacterErrors.vue  | 13 ++++---------
 .../character/errors/DependencyLoopError.vue       |  1 -
 3 files changed, 12 insertions(+), 16 deletions(-)

diff --git a/app/imports/api/engine/computation/computeCreatureComputation.js b/app/imports/api/engine/computation/computeCreatureComputation.js
index be866e1b..88dde8c7 100644
--- a/app/imports/api/engine/computation/computeCreatureComputation.js
+++ b/app/imports/api/engine/computation/computeCreatureComputation.js
@@ -56,12 +56,14 @@ function pushDependenciesToStack(nodeId, graph, stack, computation){
         oriented: true
       });
       const loop = pather.find(nodeId, nodeId);
-      computation.errors.push({
-        type: 'dependencyLoop',
-        details: {
-          nodes: loop.map(node => node.id)
-        },
-      });
+      if (loop.length) {
+        computation.errors.push({
+          type: 'dependencyLoop',
+          details: {
+            nodes: loop.map(node => node.id)
+          },
+        });
+      }
     }
     stack.push(linkedNode);
   }, true);
diff --git a/app/imports/ui/creature/character/errors/CharacterErrors.vue b/app/imports/ui/creature/character/errors/CharacterErrors.vue
index f86ba265..d15963a9 100644
--- a/app/imports/ui/creature/character/errors/CharacterErrors.vue
+++ b/app/imports/ui/creature/character/errors/CharacterErrors.vue
@@ -1,5 +1,5 @@
 <template>
-  <div v-if="creature && creature.computeErrors">
+  <div v-if="creature && errors && errors.length">
     <v-btn
       fab
       small
@@ -28,7 +28,7 @@
         v-if="expanded"
         class="character-sheet-errors"
       >
-        <template v-for="(error, index) in creature.computeErrors">
+        <template v-for="(error, index) in errors">
           <dependency-loop-error
             v-if="error.type === 'dependencyLoop'"
             :key="index + 'dependencyLoopError'"
@@ -84,13 +84,8 @@ export default {
   },
   computed: {
     errors() {
-      if (!this.creature || !this.creature.computeErrors) return;
-      return this.creature.computeErrors.map(error => {
-        error.text = error.type;
-        if (error.type === 'dependencyLoop') {
-          error.text = 'Dependency Loop Detected';
-        }
-      });
+      if (!this.creature || !this.creature.computeErrors) return [];
+      return this.creature.computeErrors;
     },
   },
   watch: {
diff --git a/app/imports/ui/creature/character/errors/DependencyLoopError.vue b/app/imports/ui/creature/character/errors/DependencyLoopError.vue
index 7036963c..d8e7d632 100644
--- a/app/imports/ui/creature/character/errors/DependencyLoopError.vue
+++ b/app/imports/ui/creature/character/errors/DependencyLoopError.vue
@@ -1,6 +1,5 @@
 <template>
   <v-alert
-    v-if="model && model.details && model.details.nodes && model.details.nodes.length"
     border="bottom"
     colored-border
     elevation="2"