From e89d415e7eb97b1727d5465e89addce520f3fcf6 Mon Sep 17 00:00:00 2001 From: Stefan Zermatten Date: Wed, 9 Mar 2022 08:24:55 +0200 Subject: [PATCH] Fixed error handling of compute engine crashes --- app/imports/api/engine/computeCreature.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/app/imports/api/engine/computeCreature.js b/app/imports/api/engine/computeCreature.js index 611597c8..a45188bf 100644 --- a/app/imports/api/engine/computeCreature.js +++ b/app/imports/api/engine/computeCreature.js @@ -12,11 +12,19 @@ export default function computeCreature(creatureId){ writeAlteredProperties(computation); writeScope(creatureId, computation.scope); } catch (e){ + const errorText = e.reason || e.message || e.toString(); computation.errors.push({ type: 'crash', - details: e.reason || e.message || e.toString(), + details: {error: errorText}, }); - console.error(e); + const logError = { + creatureId, + computeError: errorText, + }; + if (e.stack){ + logError.location = e.stack.split('\n')[1]; + } + console.error(logError); } finally { writeErrors(creatureId, computation.errors); }