From d24fb5661d5193a5ab9a16475a951d7d92f07e86 Mon Sep 17 00:00:00 2001 From: Stefan Zermatten Date: Sat, 30 May 2020 23:56:55 +0200 Subject: [PATCH] re-enabled computation on client side for optimistic UI --- app/imports/api/creature/computation/recomputeCreature.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/imports/api/creature/computation/recomputeCreature.js b/app/imports/api/creature/computation/recomputeCreature.js index 733c4904..83ea1e36 100644 --- a/app/imports/api/creature/computation/recomputeCreature.js +++ b/app/imports/api/creature/computation/recomputeCreature.js @@ -72,13 +72,11 @@ const calculationPropertyTypes = [ * - Write the computed results back to the database */ export function recomputeCreatureById(creatureId){ - // Skipping computation on the client can result in the server being made to - // do work that isn't possible, in exchange for dramatic performance gains - if (Meteor.isClient) return; let props = getActiveProperties({ ancestorId: creatureId, filter: {type: {$in: calculationPropertyTypes}}, includeUntoggled: true, + // TODO filter out expensive fields, particularly icon field }); let computationMemo = new ComputationMemo(props); computeMemo(computationMemo);