jschaufuss/DiceCloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed issue where duplicated point buys cause row-id collision in dep graph

Browse Source
This commit is contained in:
Thaum Rystra
2023-09-18 13:31:48 +02:00
parent c251b70ff6
commit c7bb4b8097
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/imports/api/engine/computation/buildComputation/linkTypeDependencies.js
View File

@@ -259,19 +259,23 @@ function linkPointBuy(dependencyGraph, prop) {
dependOnCalc({ dependencyGraph, prop, key: 'max' }); dependOnCalc({ dependencyGraph, prop, key: 'max' });
dependOnCalc({ dependencyGraph, prop, key: 'cost' }); dependOnCalc({ dependencyGraph, prop, key: 'cost' });
dependOnCalc({ dependencyGraph, prop, key: 'total' }); dependOnCalc({ dependencyGraph, prop, key: 'total' });
prop.values?.forEach(row => { prop.values?.forEach((row, index) => {
// Get a unique id for the row because it might be shared among duplicated point buy tables
// prop._id is forced unique by the database, so it can be used instead
const uniqueRowId = prop._id + '_row_' + index;
// Wrap the document in a new object so we don't bash it unintentionally // Wrap the document in a new object so we don't bash it unintentionally
const pointBuyRow = { const pointBuyRow = {
...row, ...row,
_id: uniqueRowId,
type: 'pointBuyRow', type: 'pointBuyRow',
tableName: prop.name, tableName: prop.name,
tableId: prop._id, tableId: prop._id,
} }
dependencyGraph.addNode(row._id, pointBuyRow); dependencyGraph.addNode(pointBuyRow._id, pointBuyRow);
linkVariableName(dependencyGraph, pointBuyRow); linkVariableName(dependencyGraph, pointBuyRow);
dependOnCalc({ dependencyGraph, pointBuyRow, key: 'row.min' }); dependOnCalc({ dependencyGraph, pointBuyRow, key: 'min' });
dependOnCalc({ dependencyGraph, pointBuyRow, key: 'row.max' }); dependOnCalc({ dependencyGraph, pointBuyRow, key: 'max' });
dependOnCalc({ dependencyGraph, pointBuyRow, key: 'row.cost' }); dependOnCalc({ dependencyGraph, pointBuyRow, key: 'cost' });
}); });
if (prop.inactive) return; if (prop.inactive) return;
} }