Improved subscription permissions, should now work as expected for public documents

2020-11-12 10:48:46 +02:00
parent cd84b2562a
commit bd056ab042
3 changed files with 18 additions and 40 deletions
--- a/app/imports/api/sharing/sharingPermissions.js
+++ b/app/imports/api/sharing/sharingPermissions.js
@@ -88,11 +88,11 @@ export function assertDocEditPermission(doc, userId){
 }

 export function assertViewPermission(doc, userId) {
-  assertIdValid(userId);
  assertdocExists(doc);
+  if (doc.public) return true;
+  assertIdValid(userId);
  if (
    doc.owner === userId ||
-    doc.public ||
    _.contains(doc.readers, userId) ||
    _.contains(doc.writers, userId)
  ){