From a80d070533bbab8a1b7cf8439334559b4a1b476f Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Wed, 30 Jan 2019 14:10:46 +0200
Subject: [PATCH] Refactored ability dialogs as generalised attribute dialogs

---
 app/imports/ui/character/StatsTab.vue                  |  2 +-
 app/imports/ui/components/AbilityListTile.Story.vue    |  2 +-
 .../{AbilityDialog.vue => AttributeDialog.vue}         |  2 +-
 ...ialogContainer.vue => AttributeDialogContainer.vue} | 10 +++++-----
 app/imports/ui/dialogStack/DialogComponentIndex.js     |  8 ++++----
 5 files changed, 12 insertions(+), 12 deletions(-)
 rename app/imports/ui/components/{AbilityDialog.vue => AttributeDialog.vue} (95%)
 rename app/imports/ui/components/{AbilityDialogContainer.vue => AttributeDialogContainer.vue} (72%)

diff --git a/app/imports/ui/character/StatsTab.vue b/app/imports/ui/character/StatsTab.vue
index 09df9e68..dbbad957 100644
--- a/app/imports/ui/character/StatsTab.vue
+++ b/app/imports/ui/character/StatsTab.vue
@@ -162,7 +162,7 @@
 		methods: {
 			clickAbility({elementId, abilityId}){
 				this.$store.commit("pushDialogStack", {
-					component: "ability-dialog-container",
+					component: "attribute-dialog-container",
 					elementId,
 					data: {_id: abilityId},
 				});
diff --git a/app/imports/ui/components/AbilityListTile.Story.vue b/app/imports/ui/components/AbilityListTile.Story.vue
index 01de0a89..e3308698 100644
--- a/app/imports/ui/components/AbilityListTile.Story.vue
+++ b/app/imports/ui/components/AbilityListTile.Story.vue
@@ -103,7 +103,7 @@
 		methods: {
 			click({ability, elementId}){
 				store.commit("pushDialogStack", {
-					component: "ability-dialog",
+					component: "attribute-dialog",
 					elementId,
 					data: ability,
 				});
diff --git a/app/imports/ui/components/AbilityDialog.vue b/app/imports/ui/components/AttributeDialog.vue
similarity index 95%
rename from app/imports/ui/components/AbilityDialog.vue
rename to app/imports/ui/components/AttributeDialog.vue
index 2c5ef169..cfa1ca3f 100644
--- a/app/imports/ui/components/AbilityDialog.vue
+++ b/app/imports/ui/components/AttributeDialog.vue
@@ -4,7 +4,7 @@
       {{name}}
     </div>
     <v-layout align-center column>
-			<div class="display-3 mod">
+			<div class="display-3 mod" v-if="typeof mod === 'number'">
 				{{numberToSignedString(mod)}}
 			</div>
 			<div class="display-1 value">
diff --git a/app/imports/ui/components/AbilityDialogContainer.vue b/app/imports/ui/components/AttributeDialogContainer.vue
similarity index 72%
rename from app/imports/ui/components/AbilityDialogContainer.vue
rename to app/imports/ui/components/AttributeDialogContainer.vue
index 0fe0bb83..38f358f6 100644
--- a/app/imports/ui/components/AbilityDialogContainer.vue
+++ b/app/imports/ui/components/AttributeDialogContainer.vue
@@ -1,22 +1,22 @@
 <template lang="html">
-  <ability-dialog
-		v-bind="ability"
+  <attribute-dialog
+		v-bind="attribute"
 		v-on="{clickedEffect}"
 	/>
 </template>
 
 <script>
-	import AbilityDialog from '/imports/ui/components/AbilityDialog.vue';
+	import AttributeDialog from '/imports/ui/components/AttributeDialog.vue';
 	import Attributes from '/imports/api/creature/properties/Attributes.js';
 	export default {
 		components: {
-			AbilityDialog,
+			AttributeDialog,
 		},
 		props: {
 			_id: String,
 		},
 		meteor: {
-			ability(){
+			attribute(){
 				return Attributes.findOne(this._id);
 			},
 		},
diff --git a/app/imports/ui/dialogStack/DialogComponentIndex.js b/app/imports/ui/dialogStack/DialogComponentIndex.js
index 82426493..e722af04 100644
--- a/app/imports/ui/dialogStack/DialogComponentIndex.js
+++ b/app/imports/ui/dialogStack/DialogComponentIndex.js
@@ -1,7 +1,7 @@
-import AbilityDialog from '/imports/ui/components/AbilityDialog.vue';
-import AbilityDialogContainer from '/imports/ui/components/AbilityDialogContainer.vue';
+import AttributeDialog from '/imports/ui/components/AttributeDialog.vue';
+import AttributeDialogContainer from '/imports/ui/components/AttributeDialogContainer.vue';
 
 export default {
-  AbilityDialog,
-  AbilityDialogContainer,
+  AttributeDialog,
+  AttributeDialogContainer,
 };