From a40cae132790bbd5793dbf488584dacff30b217c Mon Sep 17 00:00:00 2001 From: ThaumRystra Date: Sat, 9 Nov 2024 15:49:36 +0200 Subject: [PATCH] Removed stray console logging closes Creatures summoned to tabletops from libraries are missing their properties #373 --- app/imports/api/docs/Docs.ts | 2 +- .../api/engine/action/functions/mutationToPropUpdates.ts | 1 - app/imports/api/parenting/parentingFunctions.ts | 4 ++-- .../tabletop/methods/addCreaturesFromLibraryToTabletop.ts | 4 ---- app/imports/client/ui/components/ImageUploadInput.vue | 7 +------ .../client/ui/components/snackbars/SnackbarQueue.js | 1 - app/imports/client/ui/creature/actions/ActionDialog.vue | 2 -- .../ui/creature/character/characterSheetTabs/StatsTab.vue | 3 --- app/imports/client/ui/library/LibraryBrowser.vue | 1 - app/imports/client/ui/pages/FunctionReference.vue | 1 - app/imports/client/ui/pages/LibraryBrowser.vue | 1 - app/imports/client/ui/properties/forms/DamageForm.vue | 1 - .../client/ui/properties/forms/DamageMultiplierForm.vue | 2 +- .../tabletop/selectedCreatureBar/SelectedCreatureBar.vue | 3 --- app/imports/parser/functions.ts | 3 +-- 15 files changed, 6 insertions(+), 30 deletions(-) diff --git a/app/imports/api/docs/Docs.ts b/app/imports/api/docs/Docs.ts index bb7de8f6..accf8247 100644 --- a/app/imports/api/docs/Docs.ts +++ b/app/imports/api/docs/Docs.ts @@ -97,7 +97,7 @@ if (Meteor.isClient) { } else if (Meteor.isServer) { Meteor.startup(() => { if (!Docs.findOne()) { - console.log('No docs found, filling documentation with defaults'); + console.info('No docs found, filling documentation with defaults'); Assets.getText('docs/defaultDocs.json', (error, string) => { const docs = JSON.parse(string) docs.forEach(doc => Docs.insert(doc)); diff --git a/app/imports/api/engine/action/functions/mutationToPropUpdates.ts b/app/imports/api/engine/action/functions/mutationToPropUpdates.ts index d500e17c..a7671c1c 100644 --- a/app/imports/api/engine/action/functions/mutationToPropUpdates.ts +++ b/app/imports/api/engine/action/functions/mutationToPropUpdates.ts @@ -35,7 +35,6 @@ export default function mutationToPropUpdates(mutation: Mutation) { } // Remove creature properties if (mutation.removals) for (const removeOne of mutation.removals) { - console.log(removeOne); bulkWriteOps.push({ deleteOne: { filter: { diff --git a/app/imports/api/parenting/parentingFunctions.ts b/app/imports/api/parenting/parentingFunctions.ts index 21856923..efbab728 100644 --- a/app/imports/api/parenting/parentingFunctions.ts +++ b/app/imports/api/parenting/parentingFunctions.ts @@ -729,7 +729,7 @@ export function calculateNestedSetOperations(docs: TreeDoc[]) { const top = stack[stack.length - 1]; if (visitedNodes.has(top)) { // We've arrived at this node again for some reason, this shouldn't happen - console.log('visited already, parent loop maybe?') + console.warn('visited already, parent loop maybe?') stack.pop(); } else if (visitedChildren.has(top)) { // We've arrived at this node after visiting the children, @@ -793,7 +793,7 @@ export function applyNestedSetProperties(docs: T[]): Forest - \ No newline at end of file + diff --git a/app/imports/client/ui/components/snackbars/SnackbarQueue.js b/app/imports/client/ui/components/snackbars/SnackbarQueue.js index 67d5c488..e59eb2c7 100644 --- a/app/imports/client/ui/components/snackbars/SnackbarQueue.js +++ b/app/imports/client/ui/components/snackbars/SnackbarQueue.js @@ -5,7 +5,6 @@ const globalState = Vue.observable({ queue: [] }); let lastSnackbarId = 0; function snackbar(data) { - console.log(data); globalState.queue.push({ data, //{text OR content, callback, callbackName} // content is logContent id: ++lastSnackbarId, diff --git a/app/imports/client/ui/creature/actions/ActionDialog.vue b/app/imports/client/ui/creature/actions/ActionDialog.vue index 7929101b..fc1579d0 100644 --- a/app/imports/client/ui/creature/actions/ActionDialog.vue +++ b/app/imports/client/ui/creature/actions/ActionDialog.vue @@ -240,8 +240,6 @@ export default { }, async castSpell(suggestedParams) { this.userInput = suggestedParams; - console.log(this.action); - console.log(this.action.root); this.activeInputParams = { creatureId: this.action.creatureId, }; diff --git a/app/imports/client/ui/creature/character/characterSheetTabs/StatsTab.vue b/app/imports/client/ui/creature/character/characterSheetTabs/StatsTab.vue index 63a1c5f6..2b8ba12a 100644 --- a/app/imports/client/ui/creature/character/characterSheetTabs/StatsTab.vue +++ b/app/imports/client/ui/creature/character/characterSheetTabs/StatsTab.vue @@ -570,9 +570,6 @@ export default { propArray = []; set(properties, propPath, propArray); } - if (!propArray?.push) { - console.log({propArray}); - } propArray.push(prop); } return { skipChildren }; diff --git a/app/imports/client/ui/library/LibraryBrowser.vue b/app/imports/client/ui/library/LibraryBrowser.vue index 05d5ff58..2b1b5ac9 100644 --- a/app/imports/client/ui/library/LibraryBrowser.vue +++ b/app/imports/client/ui/library/LibraryBrowser.vue @@ -117,7 +117,6 @@ export default { }, }, methods: { - log: console.log, insertLibrary(){ if (this.paidBenefits){ this.$store.commit('pushDialogStack', { diff --git a/app/imports/client/ui/pages/FunctionReference.vue b/app/imports/client/ui/pages/FunctionReference.vue index 99231bbd..22072678 100644 --- a/app/imports/client/ui/pages/FunctionReference.vue +++ b/app/imports/client/ui/pages/FunctionReference.vue @@ -51,7 +51,6 @@ export default { let f = functions[name]; fns.push({name, ...f}); } - console.log(fns); return fns; } } diff --git a/app/imports/client/ui/pages/LibraryBrowser.vue b/app/imports/client/ui/pages/LibraryBrowser.vue index 7c5cc52b..537453b6 100644 --- a/app/imports/client/ui/pages/LibraryBrowser.vue +++ b/app/imports/client/ui/pages/LibraryBrowser.vue @@ -144,7 +144,6 @@ export default { subscribe, }, ack); } else { - console.log('sub fail') ack('Library or Library Collection not found') } }, diff --git a/app/imports/client/ui/properties/forms/DamageForm.vue b/app/imports/client/ui/properties/forms/DamageForm.vue index 3b6ff212..59daedd7 100644 --- a/app/imports/client/ui/properties/forms/DamageForm.vue +++ b/app/imports/client/ui/properties/forms/DamageForm.vue @@ -171,7 +171,6 @@ export default { }, methods: { saveChange({ path, value, ack }) { - console.log({ path, value, ack }); this.$emit('change', {path: [ 'save', ...path ], value, ack}) this.$emit('change', {path: [ 'silent' ], value: true, ack}) }, diff --git a/app/imports/client/ui/properties/forms/DamageMultiplierForm.vue b/app/imports/client/ui/properties/forms/DamageMultiplierForm.vue index 3319dccc..ad4191be 100644 --- a/app/imports/client/ui/properties/forms/DamageMultiplierForm.vue +++ b/app/imports/client/ui/properties/forms/DamageMultiplierForm.vue @@ -111,7 +111,7 @@ export default { }, methods: { error(e) { - console.log({ e }) + console.error(e) } } }; diff --git a/app/imports/client/ui/tabletop/selectedCreatureBar/SelectedCreatureBar.vue b/app/imports/client/ui/tabletop/selectedCreatureBar/SelectedCreatureBar.vue index fde79ec9..da43b395 100644 --- a/app/imports/client/ui/tabletop/selectedCreatureBar/SelectedCreatureBar.vue +++ b/app/imports/client/ui/tabletop/selectedCreatureBar/SelectedCreatureBar.vue @@ -217,9 +217,6 @@ export default { } }, methods: { - log(e) { - console.log(e); - }, hoverIcon(e, icon) { if (this.selectedIcon) return; // this.menuX = e.clientX - (e.clientX % 44); diff --git a/app/imports/parser/functions.ts b/app/imports/parser/functions.ts index 43461522..45c52567 100644 --- a/app/imports/parser/functions.ts +++ b/app/imports/parser/functions.ts @@ -154,7 +154,6 @@ const parserFunctions: { [name: string]: ParserFunction } = { // mark the N smallest elements as dropped for (let i = 0; i < numberToDrop; i += 1) { - console.log('dropped ' + sortedArray[i].value); sortedArray[i].disabled = true; sortedArray[i].disabledBy = 'dropLowest'; } @@ -273,4 +272,4 @@ function anyNumberOf(type) { return argumentArray; } -export default parserFunctions; \ No newline at end of file +export default parserFunctions;