Settling on a data structure to balance compatibility

with not being wrong
2023-11-09 16:08:04 +02:00
parent 6ce7542c4b
commit 9e5b6b11e1
22 changed files with 312 additions and 338 deletions
--- a/app/imports/api/properties/Skills.js
+++ b/app/imports/api/properties/Skills.js
@@ -134,14 +134,21 @@ let ComputedOnlySkillSchema = createPropertySchema({
    removeBeforeCompute: true,
  },
  // A list of effect ids targeting this skill
-  effects: {
+  'effectIds': {
    type: Array,
    optional: true,
    removeBeforeCompute: true,
  },
-  'effects.$': {
-    type: Object,
-    blackbox: true,
+  'effectIds.$': {
+    type: String,
+  },
+  'proficiencyIds': {
+    type: Array,
+    optional: true,
+    removeBeforeCompute: true,
+  },
+  'proficiencyIds.$': {
+    type: String,
  },
 })