From 99e4e8d6bb99819f910b9ca87acbd3234a652f67 Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Mon, 15 Aug 2022 10:53:38 +0200
Subject: [PATCH] Fixed some issues with effect tag targeting

---
 .../computation/buildComputation/linkTypeDependencies.js      | 4 ++--
 app/imports/api/properties/subSchemas/computedField.js        | 1 +
 app/imports/ui/properties/viewers/shared/PropertyField.vue    | 1 +
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/imports/api/engine/computation/buildComputation/linkTypeDependencies.js b/app/imports/api/engine/computation/buildComputation/linkTypeDependencies.js
index 5e907acc..ad566b58 100644
--- a/app/imports/api/engine/computation/buildComputation/linkTypeDependencies.js
+++ b/app/imports/api/engine/computation/buildComputation/linkTypeDependencies.js
@@ -178,8 +178,8 @@ function getTargetListFromTags(tags, computation){
   const targetTagIdLists = [];
   if (!tags) return [];
   tags.forEach(tag => {
-    const idList = computation.propsWithTag[tag];
-    if (idList) targetTagIdLists.push(idList);
+    const idList = computation.propsWithTag[tag] || [];
+    targetTagIdLists.push(idList);
   });
   const targets = intersection(...targetTagIdLists);
   return targets;
diff --git a/app/imports/api/properties/subSchemas/computedField.js b/app/imports/api/properties/subSchemas/computedField.js
index 0f0ef37b..0d7ad114 100644
--- a/app/imports/api/properties/subSchemas/computedField.js
+++ b/app/imports/api/properties/subSchemas/computedField.js
@@ -28,6 +28,7 @@ function computedOnlyField(field){
     [`${field}.effects`]: {
       type: Array,
       optional: true,
+      removeBeforeCompute: true,
     },
     [`${field}.effects.$`]: {
       type: Object,
diff --git a/app/imports/ui/properties/viewers/shared/PropertyField.vue b/app/imports/ui/properties/viewers/shared/PropertyField.vue
index fa48a003..4f9084b1 100644
--- a/app/imports/ui/properties/viewers/shared/PropertyField.vue
+++ b/app/imports/ui/properties/viewers/shared/PropertyField.vue
@@ -51,6 +51,7 @@
         <div
           v-if="calculation && calculation.effects"
           class="flex-grow-1"
+          style="max-width: 100%;"
         >
           <inline-effect
             v-if="typeof calculation.value === 'number'"