From 99a64667c687032473fa827434b08d71b1972d6c Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Wed, 29 Apr 2015 12:31:51 +0200
Subject: [PATCH] Removed proficiency from effects

---
 .../effects/effectEdit/effectEdit.html         | 12 ------------
 .../character/effects/effectEdit/effectEdit.js | 18 +-----------------
 2 files changed, 1 insertion(+), 29 deletions(-)

diff --git a/rpg-docs/client/views/character/effects/effectEdit/effectEdit.html b/rpg-docs/client/views/character/effects/effectEdit/effectEdit.html
index eacd65a1..53de4244 100644
--- a/rpg-docs/client/views/character/effects/effectEdit/effectEdit.html
+++ b/rpg-docs/client/views/character/effects/effectEdit/effectEdit.html
@@ -52,15 +52,3 @@
 		</paper-dropdown>
 	</paper-dropdown-menu>
 </template>
-
-<template name="proficiencyEffectValue">
-	<paper-dropdown-menu class="proficiencyDropDown" label="Proficiency" flex>
-		<paper-dropdown layered class="dropdown">
-			<core-menu class="menu proficiencyMenu" selected={{value}}>
-				<paper-item name="1">Proficient</paper-item>
-				<paper-item name="0.5">Half Prof. Bonus</paper-item>
-				<paper-item name="2">Double Prof. Bonus</paper-item>
-			</core-menu>
-		</paper-dropdown>
-	</paper-dropdown-menu>
-</template>
\ No newline at end of file
diff --git a/rpg-docs/client/views/character/effects/effectEdit/effectEdit.js b/rpg-docs/client/views/character/effects/effectEdit/effectEdit.js
index 5b076c25..b4ec4779 100644
--- a/rpg-docs/client/views/character/effects/effectEdit/effectEdit.js
+++ b/rpg-docs/client/views/character/effects/effectEdit/effectEdit.js
@@ -82,7 +82,6 @@ var attributeOperations = [
 	{name: "Max", operation: "max"}
 ];
 var skillOperations = [
-	{name: "Proficiency", operation: "proficiency"},
 	{name: "Add", operation: "add"},
 	{name: "Multiply", operation: "mul"},
 	{name: "Min", operation: "min"},
@@ -128,8 +127,6 @@ Template.effectEdit.helpers({
 		if (!op) return null;
 		//operations that don't need templates
 		if (op === "advantage" || op === "disadvantage" || op === "fail") return null;
-		//proficiency template
-		if (op === "proficiency") return "proficiencyEffectValue";
 
 		//default template
 		return "regularEffectValue";
@@ -154,13 +151,7 @@ Template.effectEdit.events({
 		var oldName = Template.instance().selectedStatGroup.get();
 		if (oldName != groupName){
 			instance.selectedStatGroup.set(groupName);
-			if (groupName === "Skills" || groupName === "Saving Throws"){
-				Effects.update(this._id, {$set: {
-					operation: "proficiency",
-					value: 1,
-					calculation: ""
-				}, $unset: {stat: ""}});
-			} else if (groupName === "Weakness/Resistance"){
+			if (groupName === "Weakness/Resistance"){
 				Effects.update(this._id, {$set: {
 					value: 0.5,
 					calculation: "",
@@ -197,13 +188,6 @@ Template.effectEdit.events({
 			operation: "mul"
 		}});
 	},
-	"core-select .proficiencyDropDown": function(event){
-		var detail = event.originalEvent.detail;
-		if (!detail.isSelected) return;
-		var value = +detail.item.getAttribute("name");
-		if (value == this.value) return;
-		Effects.update(this._id, {$set: {value: value, calculation: ""}});
-	},
 	"change .effectValueInput": function(event){
 		var value = event.currentTarget.value;
 		var numValue = +value;