From 7a35c66904c48765d6db639ca1deeab548b14fc6 Mon Sep 17 00:00:00 2001 From: Stefan Zermatten Date: Wed, 11 May 2022 13:33:56 +0200 Subject: [PATCH] Removed performance logging from loading creatures --- .../api/engine/computation/buildCreatureComputation.js | 4 ++-- app/imports/api/engine/computeCreature.js | 2 -- app/imports/api/engine/loadCreatures.js | 4 ---- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/app/imports/api/engine/computation/buildCreatureComputation.js b/app/imports/api/engine/computation/buildCreatureComputation.js index f2b07158..47612830 100644 --- a/app/imports/api/engine/computation/buildCreatureComputation.js +++ b/app/imports/api/engine/computation/buildCreatureComputation.js @@ -44,7 +44,7 @@ function getProperties(creatureId) { const props = Array.from(creature.properties.values()); return props; } - console.time(`fetching from db: ${creatureId}`) + console.time(`Cache miss fetching from db: ${creatureId}`) const props = CreatureProperties.find({ 'ancestors.id': creatureId, 'removed': {$ne: true}, @@ -52,7 +52,7 @@ function getProperties(creatureId) { sort: { order: 1 }, fields: { icon: 0 }, }).fetch(); - console.timeEnd(`fetching from db: ${creatureId}`); + console.timeEnd(`Cache miss fetching from db: ${creatureId}`); return props; } diff --git a/app/imports/api/engine/computeCreature.js b/app/imports/api/engine/computeCreature.js index 84c90e8a..75064776 100644 --- a/app/imports/api/engine/computeCreature.js +++ b/app/imports/api/engine/computeCreature.js @@ -6,10 +6,8 @@ import writeErrors from './computation/writeComputation/writeErrors.js'; export default function computeCreature(creatureId){ if (Meteor.isClient) return; - console.time('Compute'); const computation = buildCreatureComputation(creatureId); computeComputation(computation, creatureId); - console.timeEnd('Compute'); } function computeComputation(computation, creatureId) { diff --git a/app/imports/api/engine/loadCreatures.js b/app/imports/api/engine/loadCreatures.js index 46090140..f7870440 100644 --- a/app/imports/api/engine/loadCreatures.js +++ b/app/imports/api/engine/loadCreatures.js @@ -9,11 +9,8 @@ export function loadCreature(creatureId, subscription) { if (loadedCreatures.has(creatureId)) { creature.subs.add(subscription); } else { - console.time(`loading to memory ${creatureId}`); creature = new LoadedCreature(subscription, creatureId); loadedCreatures.set(creatureId, creature); - console.timeEnd(`loading to memory ${creatureId}`); - console.log('Creatures in memory: ', loadedCreatures.size); } subscription.onStop(() => { unloadCreature(creatureId, subscription); @@ -29,7 +26,6 @@ function unloadCreature(creatureId, subscription) { creature.stop(); loadedCreatures.delete(creatureId); } - console.log('Creatures in memory: ', loadedCreatures.size); } class LoadedCreature {