Fixed Roll form

app/imports/api/properties/Rolls.js

@@ -1,5 +1,5 @@
 import SimpleSchema from 'simpl-schema';
-import { RollResultsSchema } from '/imports/api/properties/subSchemas/RollResultsSchema.js'
+import RollResultsSchema from '/imports/api/properties/subSchemas/RollResultsSchema.js'
 
 /**
  * Rolls are children to actions or other rolls, they are triggered with 0 or
@@ -20,8 +20,8 @@ import { RollResultsSchema } from '/imports/api/properties/subSchemas/RollResult
  *  child rolls are applied
  */
 let RollSchema = new SimpleSchema({
-  // The number to add to a d20 roll
+  // The roll
-  rollBonus: {
+  roll: {
     type: String,
     optional: true,
   },

app/imports/api/properties/subSchemas/RollResultsSchema.js

@@ -2,6 +2,13 @@ import SimpleSchema from 'simpl-schema';
 import ResultsSchema from '/imports/api/properties/subSchemas/ResultsSchema.js';
 
 let RollResultsSchema = new SimpleSchema ({
+  _id: {
+    type: String,
+    regEx: SimpleSchema.RegEx.Id,
+    autoValue(){
+      if (!this.isSet) return Random.id();
+    }
+  },
   // Expression of whether or not to apply the roll
   // Evaluates to an expression which gets compared to the roll
   // or a number which the roll must equal
@@ -15,4 +22,4 @@ let RollResultsSchema = new SimpleSchema ({
 	},
 });
 
-export { RollResultsSchema };
+export default RollResultsSchema ;

app/imports/ui/properties/forms/RollForm.vue

@@ -2,23 +2,81 @@
   <div class="roll-form">
 		<text-field
 			label="Roll"
-			prefix="d20+"
+			:value="model.roll"
-			:value="model.rollBonus"
+			@change="(value, ack) => $emit('change', {path: ['roll'], value, ack})"
-			@change="(value, ack) => $emit('change', {path: ['rollBonus'], value, ack})"
+			:error-messages="errors.roll"
-			:error-messages="errors.rollBonus"
 			:debounce-time="debounceTime"
 		/>
-		<v-combobox
-	    label="Tags"
-	    multiple
-			chips
-			deletable-chips
-			box
-			:value="model.tags"
-			@change="(value) => $emit('change', {path: ['tags'], value})"
-	  />
 		<form-sections>
+			<form-section name="Results">
+				<v-slide-x-transition group>
+					<div
+						v-for="(rollResult, index) in model.rollResults"
+						:key="rollResult._id || index"
+					>
+						<div class="layout row align-center">
+							<text-field
+								label="Comparison"
+								style="flex-grow: 1;"
+								hint="If the comparison is true, the results below will be applied"
+								:value="rollResult.comparison"
+								@change="(value, ack) => $emit('change', {path: ['rollResults', index, 'comparison'], value, ack})"
+								:error-messages="errors.rollResults && errors.rollResults[index] && errors.rollResults[index].comparison"
+								:debounce-time="debounceTime"
+							/>
+							<v-btn
+								outline
+								icon
+								large
+								class="ma-3"
+								@click="$emit('pull', {path: ['rollResults', index]})"
+							>
+								<v-icon>delete</v-icon>
+							</v-btn>
+						</div>
+						<results-form
+							:model="rollResult.results"
+							:parent-target="model.target"
+							@change="({path, value, ack}) => $emit('change', {
+								path: ['rollResults', index, 'results', ...path],
+								value,
+								ack
+								})"
+							@push="({path, value, ack}) => $emit('push', {
+								path: ['rollResults', index, 'results', ...path],
+								value,
+								ack
+								})"
+							@pull="({path, ack}) => $emit('pull', {
+								path: ['rollResults', index, 'results', ...path],
+								ack
+								})"
+						/>
+						<v-divider class="my-4"/>
+					</div>
+				</v-slide-x-transition>
+				<div class="layout row justify-center">
+					<v-btn
+						:loading="addResultLoading"
+						:disabled="addResultLoading"
+						outline
+						@click="addResult"
+					>
+						<v-icon>add</v-icon>
+						Add Result
+					</v-btn>
+				</div>
+			</form-section>
 			<form-section name="Advanced">
+				<v-combobox
+			    label="Tags"
+			    multiple
+					chips
+					deletable-chips
+					box
+					:value="model.tags"
+					@change="(value) => $emit('change', {path: ['tags'], value})"
+			  />
 			</form-section>
 		</form-sections>
   </div>
@@ -26,16 +84,18 @@
 
 <script>
 	import FormSection, {FormSections} from '/imports/ui/properties/forms/shared/FormSection.vue';
-	import AdjustmentListForm from '/imports/ui/properties/forms/AdjustmentListForm.vue';
+	import RollResultsSchema from '/imports/api/properties/subSchemas/RollResultsSchema.js';
-	import BuffListForm from '/imports/ui/properties/forms/BuffListForm.vue';
+	import ResultsForm from '/imports/ui/properties/forms/ResultsForm.vue';
 
 	export default {
 		components: {
 			FormSection,
 			FormSections,
-			AdjustmentListForm,
+			ResultsForm,
-			BuffListForm,
 		},
+		data(){return {
+			addResultLoading: false,
+		}},
 		props: {
 			stored: {
 				type: Boolean,
@@ -50,17 +110,19 @@
 			},
 			debounceTime: Number,
 		},
-		data(){return {
+		methods: {
-			rollTypes: [
+			acknowledgeAddResult(){
-				{
+				this.addResultLoading = false;
-					text: 'Roll',
+			},
-					value: 'roll',
+			addResult(){
-				}, {
+				this.addResultLoading = true;
-					text: 'Saving Throw',
+				this.$emit('push', {
-					value: 'savingThrow',
+					path: ['rollResults'],
-				},
+					value: RollResultsSchema.clean({}),
-			],
+					ack: this.acknowledgeAddResult,
-		};},
+				});
+			},
+		},
 	};
 </script>
 

app/imports/ui/properties/forms/shared/schemaFormMixin.js

@@ -46,11 +46,18 @@ const schemaFormMixin = {
 			if (ack) ack();
 		},
     push({path, value, ack}){
-      get(this.model, path).push(value);
+      let array = get(this.model, path);
+      if (!array || !array.join){
+        throw `${path.join('.')} is ${array}, doesn't have "join"`
+      }
+      array.push(value);
 			if (ack) ack();
     },
     pull({path, ack}){
       let {object, key} = resolvePath(this.model, path);
+      if (!object || !object.splice){
+        throw `${path.join('.')} is ${object}, doesnt have "splice"`
+      }
       object.splice(key, 1);
       if (ack) ack();
     },