From 73cee52fff9706a146a16ecc81b1497d94b55359 Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Wed, 20 May 2015 16:11:59 +0200
Subject: [PATCH] Fixed a bug in combining multiple resistances/vulnerabilities

---
 rpg-docs/Model/Character/Characters.js | 33 +++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/rpg-docs/Model/Character/Characters.js b/rpg-docs/Model/Character/Characters.js
index 11e354e5..bc35df51 100644
--- a/rpg-docs/Model/Character/Characters.js
+++ b/rpg-docs/Model/Character/Characters.js
@@ -179,7 +179,38 @@ var attributeBase = function(charId, statName){
 		{charId: charId, stat: statName, enabled: true}
 	).fetch();
 	effects = _.groupBy(effects, "operation");
-	var value = _.contains(DAMAGE_MULTIPLIERS, statName) ? 1 : 0;
+	var isMultiplier = _.contains(DAMAGE_MULTIPLIERS, statName);
+	var value = 0;
+
+	//if it's a damage multiplier, we treat it specially
+	if (isMultiplier){
+		var resistCount = 0;
+		var vulnCount = 0;
+		var multiplierEvaluationFail = false;
+		_.each(effects.mul, function(effect){
+			var val = evaluateEffect(charId, effect);
+			if (val === 0.5){ //resistance
+				resistCount += 1;
+			} else if (val === 2){ //vulnerability
+				vulnCount += 1;
+			} else if (val === 0){ //imunity
+				return 0; //imunity is absolute
+			} else {
+				multiplierEvaluationFail = true;
+			}
+		});
+		if (multiplierEvaluationFail){
+			//we can't work it out correctly, set the value to 1
+			//and try work it out using regular maths below
+			value = 1;
+		} else if (resistCount && !vulnCount){
+			return 0.5;
+		} else if (!resistCount && vulnCount){
+			return 2;
+		} else {
+			return 1;
+		}
+	}
 
 	//start with the highest base value
 	_.each(effects.base, function(effect){