Improved how effects on calculated fields are displayed

2024-10-29 16:47:55 +02:00
parent b90cc2e467
commit 681d1e5739
5 changed files with 55 additions and 36 deletions
--- a/app/imports/api/engine/computation/buildComputation/parseCalculationFields.js
+++ b/app/imports/api/engine/computation/buildComputation/parseCalculationFields.js
@@ -103,7 +103,7 @@ function subDocsExist(prop, key) {

 export function removeEmptyCalculations(prop) {
  prop._computationDetails.emptyCalculations.forEach(calcObj => {
-    if (!calcObj.effects?.length) {
+    if (!calcObj.effectIds?.length && !calcObj.proficiencyIds?.length) {
      unset(prop, calcObj._key);
    }
  });