From 665a9d716a60ea8f549ff25bdc3bab973881c938 Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Wed, 20 Feb 2019 09:27:37 +0200
Subject: [PATCH] Unset modifiers of attributes that aren't abilities

---
 app/imports/api/creature/creatureComputation.js   | 2 ++
 app/imports/api/creature/properties/Attributes.js | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/app/imports/api/creature/creatureComputation.js b/app/imports/api/creature/creatureComputation.js
index 8dda1b87..29b24f77 100644
--- a/app/imports/api/creature/creatureComputation.js
+++ b/app/imports/api/creature/creatureComputation.js
@@ -119,6 +119,8 @@ function writeAttributes(char) {
     }
     if (typeof att.mod === 'number'){
       op.updateMany.update.$set.mod = att.mod;
+    } else {
+      op.updateMany.update.$unset = {mod: 1};
     }
     return op;
   });
diff --git a/app/imports/api/creature/properties/Attributes.js b/app/imports/api/creature/properties/Attributes.js
index b3903688..6a16dbf8 100644
--- a/app/imports/api/creature/properties/Attributes.js
+++ b/app/imports/api/creature/properties/Attributes.js
@@ -50,10 +50,12 @@ attributeSchema = schema({
 		type: Number,
 		optional: true,
 	},
+	// The computed value of the attribute
   value: {
     type: Number,
 		defaultValue: 0,
   },
+	// The computed modifier, provided the attribute is an ability
 	mod: {
 		type: SimpleSchema.Integer,
 		optional: true,