From 599c9f0de042b8d8c33256b68f26e9dbc8f80302 Mon Sep 17 00:00:00 2001 From: ThaumRystra <9525416+ThaumRystra@users.noreply.github.com> Date: Sun, 16 Jun 2024 12:35:09 +0200 Subject: [PATCH] Fixed rare compute crash when having empty action resources --- .../computeComputation/computeByType/computeAction.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/imports/api/engine/computation/computeComputation/computeByType/computeAction.ts b/app/imports/api/engine/computation/computeComputation/computeByType/computeAction.ts index 6087f646..ea51f905 100644 --- a/app/imports/api/engine/computation/computeComputation/computeByType/computeAction.ts +++ b/app/imports/api/engine/computation/computeComputation/computeByType/computeAction.ts @@ -19,12 +19,12 @@ export default function computeAction(computation: CreatureComputation, node: No } }); prop.resources.itemsConsumed?.forEach(itemConsumed => { - if (!itemConsumed.itemId || itemConsumed.available < itemConsumed.quantity?.value) { + if (!itemConsumed?.itemId || itemConsumed.available < itemConsumed.quantity?.value) { prop.insufficientResources = true; } }); prop.resources.attributesConsumed?.forEach(attConsumed => { - if (!attConsumed.variableName) return; + if (!attConsumed?.variableName) return; if (!(attConsumed.available >= attConsumed.quantity?.value)) { prop.insufficientResources = true; } @@ -37,7 +37,7 @@ function computeResources(computation, node) { resources.attributesConsumed.forEach(attConsumed => { if (!attConsumed.variableName) return; const att = computation.scope[attConsumed.variableName]; - if (!att._id) return; + if (!att?._id) return; attConsumed.available = att.value; attConsumed.statName = att.name; });