jschaufuss/DiceCloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensured property exists before attempting to damage it

Browse Source
This commit is contained in:
Stefan Zermatten
2021-03-01 13:32:46 +02:00
parent a97be2f93a
commit 4d548c901c
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/imports/api/creature/creatureProperties/methods/damageProperty.js
View File

@@ -24,6 +24,9 @@ const damageProperty = new ValidatedMethod({
run({_id, operation, value}) { run({_id, operation, value}) {
// Check permissions // Check permissions
let property = CreatureProperties.findOne(_id); let property = CreatureProperties.findOne(_id);
if (!property) throw new Meteor.Error(
'Damage property failed', 'Property doesn\'t exist'
);
let rootCreature = getRootCreatureAncestor(property); let rootCreature = getRootCreatureAncestor(property);
assertEditPermission(rootCreature, this.userId); assertEditPermission(rootCreature, this.userId);
// Check if property can take damage // Check if property can take damage
@@ -34,9 +37,10 @@ const damageProperty = new ValidatedMethod({
`Property of type "${property.type}" can't be damaged` `Property of type "${property.type}" can't be damaged`
); );
} }
damagePropertyWork({property, operation, value}); let result = damagePropertyWork({property, operation, value});
// Dependencies can't be changed through damage, only recompute deps // Dependencies can't be changed through damage, only recompute deps
recomputePropertyDependencies(property); recomputePropertyDependencies(property);
return result;
}, },
}); });