From 4288f98f7c694cc51704f512626bd0e6a0f506e4 Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Sat, 20 Feb 2021 15:50:25 +0200
Subject: [PATCH] Fixed: stats with no ability selected have an ability
 modifier of 0 instead of NaN

---
 app/imports/api/creature/computation/engine/combineStat.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/imports/api/creature/computation/engine/combineStat.js b/app/imports/api/creature/computation/engine/combineStat.js
index da417234..d6a53929 100644
--- a/app/imports/api/creature/computation/engine/combineStat.js
+++ b/app/imports/api/creature/computation/engine/combineStat.js
@@ -76,7 +76,7 @@ function combineAttribute(stat, aggregator, memo){
 
 function combineSkill(stat, aggregator, memo){
   // Skills are based on some ability Modifier
-  let ability = memo.statsByVariableName[stat.ability]
+  let ability = stat.ability && memo.statsByVariableName[stat.ability]
   if (stat.ability && ability){
     if (!ability.computationDetails.computed){
       computeStat(ability, memo);
@@ -87,6 +87,8 @@ function combineSkill(stat, aggregator, memo){
       [ability._id],
       ability.dependencies,
     );
+  } else {
+    stat.abilityMod = 0;
   }
   // Combine all the child proficiencies
   stat.proficiency = stat.baseProficiency || 0;