From 3950db86722e91453e01807c35ecd672e68713a7 Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Wed, 7 Jun 2023 14:58:32 +0200
Subject: [PATCH] Passive bonus now gets +-5 with adv/disadvantage

---
 .../computeVariable/computeVariableAsSkill.js        | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/app/imports/api/engine/computation/computeComputation/computeByType/computeVariable/computeVariableAsSkill.js b/app/imports/api/engine/computation/computeComputation/computeByType/computeVariable/computeVariableAsSkill.js
index b13ac43b..336a5ab7 100644
--- a/app/imports/api/engine/computation/computeComputation/computeByType/computeVariable/computeVariableAsSkill.js
+++ b/app/imports/api/engine/computation/computeComputation/computeByType/computeVariable/computeVariableAsSkill.js
@@ -66,6 +66,18 @@ export default function computeVariableAsSkill(computation, node, prop) {
   }
   // Passive bonus
   prop.passiveBonus = aggregator.passiveAdd;
+  // +/- 5 to passive bonus if the skill has advantage/disadvantage
+  if (
+    prop.advantage === 1
+    && Number.isFinite(prop.passiveBonus)
+  ) {
+    prop.passiveBonus += 5;
+  } else if (
+    prop.advantage === -1
+    && Number.isFinite(prop.passiveBonus)
+  ) {
+    prop.bassiveBonus -= 5;
+  }
   // conditional benefits
   prop.conditionalBenefits = aggregator.conditional;
   // Roll bonuses