Effects targeting calculations by tag now work in the engine and actions

app/imports/ui/properties/forms/EffectForm.vue

@@ -10,6 +10,7 @@
     <smart-select
       label="Operation"
       append-icon="mdi-menu-down"
+      :disabled="model.targetByTags"
       :hint="operationHint"
       :error-messages="errors.operation"
       :menu-props="{transition: 'slide-y-transition', lazy: true}"
@@ -192,6 +193,7 @@
 			displayedIcon: 'add',
 			iconClass: '',
       addExtraTagsLoading: false,
+      oldOperation: undefined,
 			operations: [
 				{value: 'base', text: 'Base Value'},
 				{value: 'add', text: 'Add'},
@@ -274,8 +276,15 @@
       changeTargetByTags(value){
         if(value === 'stats'){
           this.$emit('change', {path: ['targetByTags'], value: undefined});
+          if (this.oldOperation && this.oldOperation !== this.model.operation){
+            this.$emit('change', {path: ['operation'], value: this.oldOperation});
+          }
         } else if (value === 'tags'){
           this.$emit('change', {path: ['targetByTags'], value: true});
+          if (this.model.operation !== 'add'){
+            this.oldOperation = this.model.operation;
+            this.$emit('change', {path: ['operation'], value: 'add'});
+          }
         }
       },
       addExtraTags(){

app/imports/ui/properties/forms/shared/ComputedField.vue

@@ -12,7 +12,7 @@
         {{ model.value }}
       </template>
     </text-field>
-    <calculation-error-list :errors="model.errors" />
+    <calculation-error-list :errors="errorList" />
   </div>
 </template>
 
@@ -29,6 +29,15 @@ export default {
       default: () => ({}),
     },
   },
+  computed: {
+    errorList(){
+      if (this.model.parseError){
+        return [this.model.parseError, ...this.model.errors];
+      } else {
+        return this.model.errors;
+      }
+    }
+  }
 }
 </script>