From 2f04d9ec1c52dd89404aad2e479a6b3a06430ab2 Mon Sep 17 00:00:00 2001
From: Andrew Zhu <me@andrew-zhu.com>
Date: Thu, 7 Feb 2019 15:45:45 -0800
Subject: [PATCH] remove server check overrides

---
 app/lib/constants/characterAssetAllowDeny.js | 7 +++----
 app/lib/functions/parenting.js               | 3 ---
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/app/lib/constants/characterAssetAllowDeny.js b/app/lib/constants/characterAssetAllowDeny.js
index 70277148..65730cfb 100644
--- a/app/lib/constants/characterAssetAllowDeny.js
+++ b/app/lib/constants/characterAssetAllowDeny.js
@@ -12,20 +12,19 @@ Meteor.methods({
 
 CHARACTER_SUBSCHEMA_ALLOW = {
 	// the user must be logged in, and the user must be a writer of the character
-	// or we must be the server
 	insert: function(userId, doc) {
 		var char = Characters.findOne(
 			doc.charId,
 			{fields: {owner: 1, writers: 1}}
 		);
-		return (userId && char.owner === userId || _.contains(char.writers, userId) || Meteor.isServer);
+		return (userId && char.owner === userId || _.contains(char.writers, userId));
 	},
 	update: function(userId, doc, fields, modifier) {
 		var char = Characters.findOne(
 			doc.charId,
 			{fields: {owner: 1, writers: 1}}
 		);
-		return (userId && char.owner === userId || _.contains(char.writers, userId) || Meteor.isServer);
+		return (userId && char.owner === userId || _.contains(char.writers, userId));
 	},
 	remove: function(userId, doc) {
 		var char = Characters.findOne(
@@ -33,7 +32,7 @@ CHARACTER_SUBSCHEMA_ALLOW = {
 			{fields: {owner: 1, writers: 1}}
 		);
 		if (!char) return true;
-		return userId && char.owner === userId || _.contains(char.writers, userId) || Meteor.isServer;
+		return userId && char.owner === userId || _.contains(char.writers, userId);
 	},
 	fetch: ["charId"],
 };
diff --git a/app/lib/functions/parenting.js b/app/lib/functions/parenting.js
index d26dc885..82ecf204 100644
--- a/app/lib/functions/parenting.js
+++ b/app/lib/functions/parenting.js
@@ -132,9 +132,6 @@ makeParent = function(collection, donatedKeys){
 };
 
 var checkPermission = function(userId, charId){
-	if (Meteor.isServer) {  // we always trust server
-		return true;
-	}
 	var char = Characters.findOne(charId, {fields: {owner: 1, writers: 1}});
 	if (!char)
 		throw new Meteor.Error("Access Denied, no charId",