From 1795316664c2479a582d24f60aa1e7592c1da28e Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Wed, 17 May 2023 13:22:58 +0200
Subject: [PATCH] Fixed regression: missing target field

---
 .../client/ui/properties/forms/EffectForm.vue | 21 ++++++++++++++++---
 .../ui/properties/forms/ProficiencyForm.vue   | 20 ++++++++++++++++--
 2 files changed, 36 insertions(+), 5 deletions(-)

diff --git a/app/imports/client/ui/properties/forms/EffectForm.vue b/app/imports/client/ui/properties/forms/EffectForm.vue
index bfcafcb4..c274bdad 100644
--- a/app/imports/client/ui/properties/forms/EffectForm.vue
+++ b/app/imports/client/ui/properties/forms/EffectForm.vue
@@ -69,7 +69,7 @@
       @change="changeTargetByTags"
     />
 
-    <v-slide-x-transition mode="out-in">
+    <v-slide-y-transition hide-on-leave>
       <smart-combobox
         v-if="!model.targetByTags"
         label="Stats"
@@ -92,10 +92,25 @@
         @push="e => $emit('push', e)"
         @pull="e => $emit('pull', e)"
       />
-    </v-slide-x-transition>
+    </v-slide-y-transition>
+    <v-expand-transition>
+      <v-col
+        v-if="model.targetByTags"
+        cols="12"
+      >
+        <text-field
+          label="Target field"
+          :value="model.targetField"
+          hint="Target a specific calculation field on the affected properties"
+          placeholder="Default field"
+          persistent-placeholder
+          :error-messages="errors.targetField"
+          @change="change('targetField', ...arguments)"
+        />
+      </v-col>
+    </v-expand-transition>
     <form-sections
       v-if="$slots.default"
-      class="mt-4"
     >
       <slot />
     </form-sections>
diff --git a/app/imports/client/ui/properties/forms/ProficiencyForm.vue b/app/imports/client/ui/properties/forms/ProficiencyForm.vue
index 3efab228..efcf185a 100644
--- a/app/imports/client/ui/properties/forms/ProficiencyForm.vue
+++ b/app/imports/client/ui/properties/forms/ProficiencyForm.vue
@@ -34,7 +34,7 @@
       <v-col
         cols="12"
       >
-        <v-slide-x-transition mode="out-in">
+        <v-slide-y-transition hide-on-leave>
           <tag-targeting
             v-if="model.targetByTags"
             :model="model"
@@ -56,8 +56,24 @@
             :error-messages="errors.stats"
             @change="change('stats', ...arguments)"
           />
-        </v-slide-x-transition>
+        </v-slide-y-transition>
       </v-col>
+      <v-expand-transition>
+        <v-col
+          v-if="model.targetByTags"
+          cols="12"
+        >
+          <text-field
+            label="Target field"
+            :value="model.targetField"
+            hint="Target a specific calculation field on the affected properties"
+            placeholder="Default field"
+            persistent-placeholder
+            :error-messages="errors.targetField"
+            @change="change('targetField', ...arguments)"
+          />
+        </v-col>
+      </v-expand-transition>
     </v-row>
     <form-sections
       v-if="$slots.default"