From 13a0d664334bbf4cb623e074aacb68da892c3ec3 Mon Sep 17 00:00:00 2001
From: Thaum Rystra <stefanzermatten@gmail.com>
Date: Thu, 21 May 2020 12:47:02 +0200
Subject: [PATCH] Disabled various buttons when the user doesn't have edit
 permission

---
 app/imports/ui/creature/CreatureForm.vue      |   9 +
 .../ui/creature/CreatureFormDialog.vue        |  10 +
 .../ui/creature/character/CharacterSheet.vue  |  16 +-
 .../characterSheetTabs/InventoryTab.vue       |   4 +
 .../characterSheetTabs/SpellsTab.vue          |   4 +
 .../character/characterSheetTabs/TreeTab.vue  |   4 +
 .../components/attributes/HealthBar.vue       | 223 ++++++++++--------
 .../components/attributes/HitDiceListTile.vue |   7 +-
 .../components/attributes/ResourceCard.vue    |  78 +++---
 .../attributes/SpellSlotListTile.vue          | 137 +++++++----
 10 files changed, 303 insertions(+), 189 deletions(-)

diff --git a/app/imports/ui/creature/CreatureForm.vue b/app/imports/ui/creature/CreatureForm.vue
index 72129184..67908e28 100644
--- a/app/imports/ui/creature/CreatureForm.vue
+++ b/app/imports/ui/creature/CreatureForm.vue
@@ -5,6 +5,7 @@
       :value="model.name"
       :error-messages="errors.name"
       :debounce-time="debounceTime"
+      :disabled="disabled"
       @change="(value, ack) => $emit('change', {path: ['name'], value, ack})"
     />
     <text-field
@@ -12,6 +13,7 @@
       :value="model.alignment"
       :error-messages="errors.alignment"
       :debounce-time="debounceTime"
+      :disabled="disabled"
       @change="(value, ack) => $emit('change', {path: ['alignment'], value, ack})"
     />
     <text-field
@@ -19,6 +21,7 @@
       :value="model.gender"
       :error-messages="errors.gender"
       :debounce-time="debounceTime"
+      :disabled="disabled"
       @change="(value, ack) => $emit('change', {path: ['gender'], value, ack})"
     />
     <text-field
@@ -27,6 +30,7 @@
       :value="model.picture"
       :error-messages="errors.picture"
       :debounce-time="debounceTime"
+      :disabled="disabled"
       @change="(value, ack) => $emit('change', {path: ['picture'], value, ack})"
     />
     <text-field
@@ -35,6 +39,7 @@
       :value="model.avatarPicture"
       :error-messages="errors.avatarPicture"
       :debounce-time="debounceTime"
+      :disabled="disabled"
       @change="(value, ack) => $emit('change', {path: ['avatarPicture'], value, ack})"
     />
     <!--
@@ -44,18 +49,21 @@
 					label="Use variant encumbrance"
 					:input-value="model.settings.useVariantEncumbrance"
 					:error-messages="errors.useVariantEncumbrance"
+          :disabled="disabled"
 					@change="value => $emit('change', {path: ['settings','useVariantEncumbrance'], value})"
 				/>
 				<v-switch
 					label="Hide spells tab"
 					:input-value="model.settings.hideSpellcasting"
 					:error-messages="errors.hideSpellcasting"
+          :disabled="disabled"
 					@change="value => $emit('change', {path: ['settings','hideSpellcasting'], value})"
 				/>
 				<v-switch
 					label="Swap ability scores and modifiers"
 					:input-value="model.settings.swapStatAndModifier"
 					:error-messages="errors.swapStatAndModifier"
+          :disabled="disabled"
 					@change="value => $emit('change', {path: ['settings','swapStatAndModifier'], value})"
 				/>
 			</form-section>
@@ -88,6 +96,7 @@ export default {
 			type: Boolean,
 		},
 		debounceTime: Number,
+    disabled: Boolean,
 	},
 };
 </script>
diff --git a/app/imports/ui/creature/CreatureFormDialog.vue b/app/imports/ui/creature/CreatureFormDialog.vue
index bd6510cf..ca6bb79a 100644
--- a/app/imports/ui/creature/CreatureFormDialog.vue
+++ b/app/imports/ui/creature/CreatureFormDialog.vue
@@ -6,6 +6,7 @@
     <div>
       <creature-form
         :model="model"
+        :disabled="editPermission === false"
         @change="change"
       />
     </div>
@@ -25,6 +26,7 @@ import Creatures from '/imports/api/creature/Creatures.js';
 import {updateCreature} from '/imports/api/creature/Creatures.js';
 import DialogBase from '/imports/ui/dialogStack/DialogBase.vue';
 import CreatureForm from '/imports/ui/creature/CreatureForm.vue'
+import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
 
 export default {
 	components: {
@@ -39,6 +41,14 @@ export default {
 		model(){
 			return Creatures.findOne(this._id);
 		},
+    editPermission(){
+      try {
+        assertEditPermission(this.model, Meteor.userId());
+        return true;
+      } catch (e) {
+        return false;
+      }
+    },
 	},
 	methods: {
 		change({path, value, ack}){
diff --git a/app/imports/ui/creature/character/CharacterSheet.vue b/app/imports/ui/creature/character/CharacterSheet.vue
index 381a5c36..3d3b9663 100644
--- a/app/imports/ui/creature/character/CharacterSheet.vue
+++ b/app/imports/ui/creature/character/CharacterSheet.vue
@@ -48,17 +48,13 @@
   //TODO add a "no character found" screen if shown on a false address
   // or on a character the user does not have permission to view
 	import Creatures from '/imports/api/creature/Creatures.js';
-	import removeCreature from '/imports/api/creature/removeCreature.js';
-	import isDarkColor from '/imports/ui/utility/isDarkColor.js';
-	import { mapMutations } from 'vuex';
-	import { theme } from '/imports/ui/theme.js';
 	import StatsTab from '/imports/ui/creature/character/characterSheetTabs/StatsTab.vue';
 	import FeaturesTab from '/imports/ui/creature/character/characterSheetTabs/FeaturesTab.vue';
 	import InventoryTab from '/imports/ui/creature/character/characterSheetTabs/InventoryTab.vue';
 	import SpellsTab from '/imports/ui/creature/character/characterSheetTabs/SpellsTab.vue';
 	import PersonaTab from '/imports/ui/creature/character/characterSheetTabs/PersonaTab.vue';
 	import TreeTab from '/imports/ui/creature/character/characterSheetTabs/TreeTab.vue';
-	import { recomputeCreature } from '/imports/api/creature/computation/recomputeCreature.js';
+  import { assertEditPermission } from '/imports/api/creature/creaturePermissions.js';
 
 	export default {
 		components: {
@@ -81,7 +77,7 @@
 		},
     reactiveProvide: {
       name: 'context',
-      include: ['creature'],
+      include: ['creature', 'editPermission'],
     },
     onMounted(){
       this.$store.commit('setPageTitle', this.creature && this.creature.name || 'Character Sheet');
@@ -100,6 +96,14 @@
 			creature(){
 				return Creatures.findOne(this.creatureId) || {};
 			},
+      editPermission(){
+        try {
+          assertEditPermission(this.creature, Meteor.userId());
+          return true;
+        } catch (e) {
+          return false;
+        }
+      },
 		},
 	}
 </script>
diff --git a/app/imports/ui/creature/character/characterSheetTabs/InventoryTab.vue b/app/imports/ui/creature/character/characterSheetTabs/InventoryTab.vue
index 63c0a2ca..2ffb80ae 100644
--- a/app/imports/ui/creature/character/characterSheetTabs/InventoryTab.vue
+++ b/app/imports/ui/creature/character/characterSheetTabs/InventoryTab.vue
@@ -5,6 +5,7 @@
         <toolbar-card color="">
           <v-spacer slot="toolbar" />
           <v-switch
+            v-if="context.editPermission !== false"
             slot="toolbar"
             v-model="organize"
             label="Organize"
@@ -53,6 +54,9 @@ export default {
 		ContainerCard,
     ToolbarCard,
 	},
+  inject: {
+    context: { default: {} }
+  },
 	props: {
 		creatureId: String,
 	},
diff --git a/app/imports/ui/creature/character/characterSheetTabs/SpellsTab.vue b/app/imports/ui/creature/character/characterSheetTabs/SpellsTab.vue
index b692b88b..6cfd8075 100644
--- a/app/imports/ui/creature/character/characterSheetTabs/SpellsTab.vue
+++ b/app/imports/ui/creature/character/characterSheetTabs/SpellsTab.vue
@@ -5,6 +5,7 @@
         <v-card>
           <v-card-text>
             <v-switch
+              v-if="context.editPermission !== false"
               v-model="organize"
               label="Organize"
               class="justify-end"
@@ -48,6 +49,9 @@ export default {
 		CreaturePropertiesTree,
 		SpellListCard,
 	},
+  inject: {
+    context: { default: {} }
+  },
 	props: {
 		creatureId: {
       type: String,
diff --git a/app/imports/ui/creature/character/characterSheetTabs/TreeTab.vue b/app/imports/ui/creature/character/characterSheetTabs/TreeTab.vue
index bd6dfd2b..4ec482ff 100644
--- a/app/imports/ui/creature/character/characterSheetTabs/TreeTab.vue
+++ b/app/imports/ui/creature/character/characterSheetTabs/TreeTab.vue
@@ -21,6 +21,7 @@
         >
           <v-spacer />
           <v-switch
+            v-if="context.editPermission !== false"
             v-model="organize"
             label="Organize"
             class="mx-3"
@@ -153,6 +154,9 @@
       PropertyIcon,
       LabeledFab,
     },
+    inject: {
+      context: { default: {} }
+    },
     props: {
       creatureId: {
         type: String,
diff --git a/app/imports/ui/properties/components/attributes/HealthBar.vue b/app/imports/ui/properties/components/attributes/HealthBar.vue
index 52fdff64..cb9ce2c4 100644
--- a/app/imports/ui/properties/components/attributes/HealthBar.vue
+++ b/app/imports/ui/properties/components/attributes/HealthBar.vue
@@ -1,103 +1,128 @@
 <template>
-	<v-layout
-		row
-		wrap
-		align-center
-		justify-center
-		style="min-height: 48px;"
-		:class="{ hover }"
-		class="my-3 health-bar"
-		:data-id="_id"
-	>
-		<div
-			class="subheading text-truncate pa-2 name"
-			@mouseover="hover = true"
-			@mouseleave="hover = false"
-			@click="$emit('click')"
-		>
-			{{ name }}
-		</div>
-		<v-flex style="height: 20px; flex-basis: 300px; flex-grow: 100;">
-			<v-layout
-				column
-				align-center
-				@click="edit"
-				style="cursor: pointer;"
-				class="bar"
-			>
-				<v-progress-linear
-					:value="(value / maxValue) * 100"
-					height="20"
-					color="green lighten-1"
-					class="ma-0"
-				>
-				</v-progress-linear>
-				<span
-					class="value"
-					style="margin-top: -20px; z-index: 1; font-size: 15px; font-weight: 600; height: 20px;"
-				>
-					{{ value }} / {{ maxValue }}
-				</span>
-			</v-layout>
-			<transition name="transition">
-				<v-toolbar
-					v-if="editing"
-					justify-center
-					height="48"
-					flat
-					class="transparent toolbar"
-				>
-					<v-spacer />
-					<v-btn-toggle
-						:value="operation === 'add' ? 0: operation === 'subtract' ? 1 : null"
-						@click="$refs.editInput.focus()"
-						class="mr-2"
-					>
-						<v-btn
-							@click="toggleAdd(); $nextTick(() => $refs.editInput.focus())"
-							class="filled"
-						>
-							<v-icon>add</v-icon>
-						</v-btn>
-						<v-btn
-							@click="toggleSubtract(); $nextTick(() => $refs.editInput.focus())"
-							class="filled"
-						>
-							<v-icon>remove</v-icon>
-						</v-btn>
-					</v-btn-toggle>
-					<v-text-field
-						solo
-						hide-details
-						type="number"
-						v-if="editing"
-						ref="editInput"
-						style="max-width: 120px;"
-						min="0"
-						:value="editValue"
-						:prepend-inner-icon="operationIcon(operation)"
-						@focus="$event.target.select()"
-						@keypress="keypress"
-					>
-					</v-text-field>
-					<v-btn small fab @click="commitEdit" class="filled" color="red">
-						<v-icon>done</v-icon>
-					</v-btn>
-					<v-btn small fab @click="cancelEdit" class="mx-0 filled">
-						<v-icon>close</v-icon>
-					</v-btn>
-					<v-spacer />
-				</v-toolbar>
-			</transition>
-		</v-flex>
-		<transition name="background-transition">
-			<div v-if="editing" class="page-tint" @click="cancelEdit" />
-		</transition>
-	</v-layout>
+  <v-layout
+    row
+    wrap
+    align-center
+    justify-center
+    style="min-height: 48px;"
+    :class="{ hover }"
+    class="my-3 health-bar"
+    :data-id="_id"
+  >
+    <div
+      class="subheading text-truncate pa-2 name"
+      @mouseover="hover = true"
+      @mouseleave="hover = false"
+      @click="$emit('click')"
+    >
+      {{ name }}
+    </div>
+    <v-flex style="height: 20px; flex-basis: 300px; flex-grow: 100;">
+      <v-layout
+        column
+        align-center
+        style="cursor: pointer;"
+        class="bar"
+        @click="edit"
+      >
+        <v-progress-linear
+          :value="(value / maxValue) * 100"
+          height="20"
+          color="green lighten-1"
+          class="ma-0"
+        />
+        <span
+          class="value"
+          style="margin-top: -20px; z-index: 1; font-size: 15px; font-weight: 600; height: 20px;"
+        >
+          {{ value }} / {{ maxValue }}
+        </span>
+      </v-layout>
+      <transition name="transition">
+        <v-toolbar
+          v-if="editing"
+          justify-center
+          height="48"
+          flat
+          class="transparent toolbar"
+        >
+          <v-spacer />
+          <v-btn-toggle
+            :value="operation === 'add' ? 0: operation === 'subtract' ? 1 : null"
+            class="mr-2"
+            @click="$refs.editInput.focus()"
+          >
+            <v-btn
+              :disabled="context.editPermission === false"
+              class="filled"
+              @click="toggleAdd(); $nextTick(() => $refs.editInput.focus())"
+            >
+              <v-icon>add</v-icon>
+            </v-btn>
+            <v-btn
+              :disabled="context.editPermission === false"
+              class="filled"
+              @click="toggleSubtract(); $nextTick(() => $refs.editInput.focus())"
+            >
+              <v-icon>remove</v-icon>
+            </v-btn>
+          </v-btn-toggle>
+          <v-text-field
+            v-if="editing"
+            ref="editInput"
+            solo
+            hide-details
+            type="number"
+            style="max-width: 120px;"
+            min="0"
+            :value="editValue"
+            :prepend-inner-icon="operationIcon(operation)"
+            :disabled="context.editPermission === false"
+            @focus="$event.target.select()"
+            @keypress="keypress"
+          />
+          <v-btn
+            small
+            fab
+            class="filled"
+            color="red"
+            @click="commitEdit"
+          >
+            <v-icon>done</v-icon>
+          </v-btn>
+          <v-btn
+            small
+            fab
+            class="mx-0 filled"
+            @click="cancelEdit"
+          >
+            <v-icon>close</v-icon>
+          </v-btn>
+          <v-spacer />
+        </v-toolbar>
+      </transition>
+    </v-flex>
+    <transition name="background-transition">
+      <div
+        v-if="editing"
+        class="page-tint"
+        @click="cancelEdit"
+      />
+    </transition>
+  </v-layout>
 </template>
 
 <script>
 	export default {
+    inject: {
+      context: { default: {} }
+    },
+		props: {
+			value: Number,
+			maxValue: Number,
+			name: String,
+			_id: String,
+		},
 		data() {
 			return {
 				editing: false,
@@ -106,12 +131,6 @@
 				hover: false,
 			};
 		},
-		props: {
-			value: Number,
-			maxValue: Number,
-			name: String,
-			_id: String,
-		},
 		methods: {
 			edit() {
 				this.editing = true;
@@ -138,7 +157,7 @@
 					case 'set':
 						return 'forward';
 					case 'add':
-					  return 'add';
+            return 'add';
 					case 'subtract':
 						return 'remove';
 				}
diff --git a/app/imports/ui/properties/components/attributes/HitDiceListTile.vue b/app/imports/ui/properties/components/attributes/HitDiceListTile.vue
index b98aff68..997e1b03 100644
--- a/app/imports/ui/properties/components/attributes/HitDiceListTile.vue
+++ b/app/imports/ui/properties/components/attributes/HitDiceListTile.vue
@@ -17,7 +17,7 @@
           <v-btn
             icon
             small
-            :disabled="currentValue >= model.value"
+            :disabled="currentValue >= model.value || context.editPermission === false"
             @click="increment(1)"
           >
             <v-icon>arrow_drop_up</v-icon>
@@ -25,7 +25,7 @@
           <v-btn
             icon
             small
-            :disabled="currentValue <= 0"
+            :disabled="currentValue <= 0 || context.editPermission === false"
             @click="increment(-1)"
           >
             <v-icon>arrow_drop_down</v-icon>
@@ -68,6 +68,9 @@ import ComputedForCreature from '/imports/ui/components/computation/ComputedForC
 export default {
   components: {
     Computed: ComputedForCreature,
+  },
+  inject: {
+    context: { default: {} }
   },
 	props: {
     model: {
diff --git a/app/imports/ui/properties/components/attributes/ResourceCard.vue b/app/imports/ui/properties/components/attributes/ResourceCard.vue
index 120c8330..8e0a7d92 100644
--- a/app/imports/ui/properties/components/attributes/ResourceCard.vue
+++ b/app/imports/ui/properties/components/attributes/ResourceCard.vue
@@ -1,37 +1,51 @@
 <template lang="html">
-	<v-card class="resource-card layout row" :class="hover ? 'elevation-8': ''">
-		<div class="buttons layout column justify-center pl-3">
-			<v-btn icon small :disabled="currentValue >= value" @click="increment(1)">
-				<v-icon>arrow_drop_up</v-icon>
-			</v-btn>
-			<v-btn icon small :disabled="currentValue <= 0" @click="increment(-1)">
-				<v-icon>arrow_drop_down</v-icon>
-			</v-btn>
-		</div>
-		<div
-			class="layout row align-center value pl-2 pr-3"
-		>
-			<div class="display-1">{{currentValue}}</div>
-			<div class="title ml-2 max-value">/{{value}}</div>
-		</div>
-		<div
-			class="content layout row align-center pr-3"
-			@click="click"
-			@mouseover="hover = true"
-			@mouseleave="hover = false"
-		>
-			<div class="text-truncate ">
-				{{name}}
-			</div>
-		</div>
-	</v-card>
+  <v-card
+    class="resource-card layout row"
+    :class="hover ? 'elevation-8': ''"
+  >
+    <div class="buttons layout column justify-center pl-3">
+      <v-btn
+        icon
+        small
+        :disabled="currentValue >= value || context.editPermission === false"
+        @click="increment(1)"
+      >
+        <v-icon>arrow_drop_up</v-icon>
+      </v-btn>
+      <v-btn
+        icon
+        small
+        :disabled="currentValue <= 0 || context.editPermission === false"
+        @click="increment(-1)"
+      >
+        <v-icon>arrow_drop_down</v-icon>
+      </v-btn>
+    </div>
+    <div
+      class="layout row align-center value pl-2 pr-3"
+    >
+      <div class="display-1">
+        {{ currentValue }}
+      </div>
+      <div class="title ml-2 max-value">
+        /{{ value }}
+      </div>
+    </div>
+    <div
+      class="content layout row align-center pr-3"
+      @click="click"
+      @mouseover="hover = true"
+      @mouseleave="hover = false"
+    >
+      <div class="text-truncate ">
+        {{ name }}
+      </div>
+    </div>
+  </v-card>
 </template>
 
 <script>
 	export default {
-		data(){ return{
-			hover: false,
-		}},
 		props: {
 			_id: String,
 			name: String,
@@ -39,6 +53,12 @@
 			value: Number,
 			damage: Number,
 		},
+		data(){ return{
+			hover: false,
+		}},
+    inject: {
+      context: { default: {} }
+    },
 		computed: {
 			currentValue(){
 				return this.value - (this.damage || 0);
diff --git a/app/imports/ui/properties/components/attributes/SpellSlotListTile.vue b/app/imports/ui/properties/components/attributes/SpellSlotListTile.vue
index 4f96f2b7..2b3ee07f 100644
--- a/app/imports/ui/properties/components/attributes/SpellSlotListTile.vue
+++ b/app/imports/ui/properties/components/attributes/SpellSlotListTile.vue
@@ -1,61 +1,92 @@
 <template lang="html">
-	<v-list-tile class="spell-slot-list-tile" :class="{hover}">
+  <v-list-tile
+    class="spell-slot-list-tile"
+    :class="{hover}"
+  >
+    <v-list-tile-action>
+      <div
+        v-if="value > 4"
+        class="layout row align-center"
+      >
+        <div class="buttons layout column justify-center">
+          <v-btn
+            icon
+            small
+            :disabled="
+              currentValue >= value ||
+                context.editPermission === false
+            "
+            @click="increment(1)"
+          >
+            <v-icon>arrow_drop_up</v-icon>
+          </v-btn>
+          <v-btn
+            icon
+            small
+            :disabled="
+              currentValue <= 0 ||
+                context.editPermission === false
+            "
+            @click="increment(-1)"
+          >
+            <v-icon>arrow_drop_down</v-icon>
+          </v-btn>
+        </div>
+        <div
+          class="layout row value"
+          style="align-items: baseline;"
+        >
+          <div class="display-1">
+            {{ currentValue }}
+          </div>
+          <div class="title ml-2 max-value">
+            /{{ value }}
+          </div>
+        </div>
+      </div>
 
-		<v-list-tile-action>
+      <div
+        v-else
+        class="layout row align-center justify-end slot-buttons"
+      >
+        <v-btn
+          v-for="i in value"
+          :key="i"
+          icon
+          small
+          :disabled="
+            !(i === currentValue || i === currentValue + 1) ||
+              context.editPermission === false
+          "
+          @click="increment(i > currentValue ? 1 : -1)"
+        >
+          <v-icon>
+            {{
+              i > currentValue ?
+                'radio_button_unchecked' :
+                'radio_button_checked'
+            }}
+          </v-icon>
+        </v-btn>
+      </div>
+    </v-list-tile-action>
 
-			<div class="layout row align-center" v-if="value > 4">
-				<div class="buttons layout column justify-center">
-					<v-btn icon small :disabled="currentValue >= value" @click="increment(1)">
-						<v-icon>arrow_drop_up</v-icon>
-					</v-btn>
-					<v-btn icon small :disabled="currentValue <= 0" @click="increment(-1)">
-						<v-icon>arrow_drop_down</v-icon>
-					</v-btn>
-				</div>
-				<div class="layout row value" style="align-items: baseline;">
-					<div class="display-1">{{currentValue}}</div>
-					<div class="title ml-2 max-value">/{{value}}</div>
-				</div>
-			</div>
-
-			<div class="layout row align-center justify-end slot-buttons" v-else>
-				<v-btn
-					icon
-					small
-					v-for="i in value"
-					:disabled="!(i === currentValue || i === currentValue + 1)"
-					:key="i"
-					@click="increment(i > currentValue ? 1 : -1)"
-				>
-					<v-icon>{{
-						i > currentValue ?
-						'radio_button_unchecked' :
-						'radio_button_checked'
-					}}</v-icon>
-				</v-btn>
-			</div>
-
-		</v-list-tile-action>
-
-		<v-list-tile-content
-			class="content ml-2"
-			@click="click"
-			@mouseover="hover = true"
-			@mouseleave="hover = false"
-		>
-			<v-list-tile-title>
-				{{name}}
-			</v-list-tile-title>
-		</v-list-tile-content>
-	</v-list-tile>
+    <v-list-tile-content
+      class="content ml-2"
+      @click="click"
+      @mouseover="hover = true"
+      @mouseleave="hover = false"
+    >
+      <v-list-tile-title>
+        {{ name }}
+      </v-list-tile-title>
+    </v-list-tile-content>
+  </v-list-tile>
 </template>
 
 <script>
 import numberToSignedString from '/imports/ui/utility/numberToSignedString.js';
 export default {
-	data(){ return{
-		hover: false,
-	}},
 	props: {
 		_id: String,
 		name: String,
@@ -66,6 +97,12 @@ export default {
 			default: 0,
 		},
 	},
+	data(){ return{
+		hover: false,
+	}},
+  inject: {
+    context: { default: {} }
+  },
 	computed: {
 		currentValue(){
 			return this.value - this.damage;