From c55d572134faeef25a1ead797820eb5b9060b4fa Mon Sep 17 00:00:00 2001 From: Stefan Zermatten Date: Wed, 16 Nov 2022 23:52:08 +0200 Subject: [PATCH 1/3] Bumped version --- app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/package.json b/app/package.json index e4cc506b..ba3a017b 100644 --- a/app/package.json +++ b/app/package.json @@ -1,6 +1,6 @@ { "name": "dicecloud", - "version": "2.0.43", + "version": "2.0.44", "description": "Unofficial Online Realtime D&D 5e App", "license": "GPL-3.0", "repository": { From 56bd41f43574f3c4b21843b7fa7d6a557623846b Mon Sep 17 00:00:00 2001 From: Jonpot Date: Mon, 21 Nov 2022 15:49:01 -0800 Subject: [PATCH 2/3] Fix skill.md typo --- app/private/docs/property/skill.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/private/docs/property/skill.md b/app/private/docs/property/skill.md index 51185673..5b25b9ad 100644 --- a/app/private/docs/property/skill.md +++ b/app/private/docs/property/skill.md @@ -1,6 +1,6 @@ # Skills -Skills represent things the creature can be proficient in. Skills can have their values or behavior modifier by [effects](/docs/property/effect), and their proficiencies modified by [proficiencies](/docs/property/proficiency). +Skills represent things the creature can be proficient in. Skills can have their values or behavior modified by [effects](/docs/property/effect), and their proficiencies modified by [proficiencies](/docs/property/proficiency). --- From 9f8c3f0f3dd9f0800c9163c9005ad0ea1291f316 Mon Sep 17 00:00:00 2001 From: Jonpot Date: Mon, 21 Nov 2022 16:20:48 -0800 Subject: [PATCH 3/3] Update applyAction.js As per the docs, $attackDiceRoll should be the value of the d20 before modifiers, and $attackRoll should the the total value, after modifiers. Pre-patch, the former variable is never defined, and the latter variable has the wrong value. --- .../api/engine/actions/applyPropertyByType/applyAction.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/imports/api/engine/actions/applyPropertyByType/applyAction.js b/app/imports/api/engine/actions/applyPropertyByType/applyAction.js index becf0775..ab9ed8e1 100644 --- a/app/imports/api/engine/actions/applyPropertyByType/applyAction.js +++ b/app/imports/api/engine/actions/applyPropertyByType/applyAction.js @@ -163,8 +163,9 @@ function rollAttack(attack, scope) { value = rollDice(1, 20)[0]; resultPrefix = `1d20 [${value}] ${rollModifierText}` } - scope['$attackRoll'] = { value }; + scope['$attackDiceRoll'] = { value }; const result = value + attack.value; + scope['$attackRoll'] = { result }; const { criticalHit, criticalMiss } = applyCrits(value, scope); return { resultPrefix, result, value, criticalHit, criticalMiss }; }