From 0373feb2ea9cdfd348d6a34962be1c72f17ecdca Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Tue, 7 May 2019 09:18:53 +0200
Subject: [PATCH 1/3] Fixed issue where effects in libraries would appear
 editable to subscribers

---
 .../views/library/libraryItemDialog/libraryItemDialog.js      | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/client/views/library/libraryItemDialog/libraryItemDialog.js b/app/client/views/library/libraryItemDialog/libraryItemDialog.js
index 3f82c681..14e47b78 100644
--- a/app/client/views/library/libraryItemDialog/libraryItemDialog.js
+++ b/app/client/views/library/libraryItemDialog/libraryItemDialog.js
@@ -66,7 +66,9 @@ Template.libraryItemDialog.helpers({
     return Template.instance().subscriptionsReady();
   },
   cantEdit(){
-    let item = LibraryItems.findOne(this.itemId);
+    // Get itemId from the top level template data regardless of current context
+    let itemId = Blaze.getData(Template.instance().view).itemId;
+    let item = LibraryItems.findOne(itemId);
     if (!item) return;
     let library = Libraries.findOne(item.library);
     if (!library) return;

From c84342b21a86b0b04990a220f308316dea997532 Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Tue, 7 May 2019 09:19:12 +0200
Subject: [PATCH 2/3] Fixed styling of item library dialog on small screens

---
 .../views/library/libraryItemDialog/library-item-dialog.css | 3 +++
 .../views/library/libraryItemDialog/libraryItemDialog.html  | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)
 create mode 100644 app/client/views/library/libraryItemDialog/library-item-dialog.css

diff --git a/app/client/views/library/libraryItemDialog/library-item-dialog.css b/app/client/views/library/libraryItemDialog/library-item-dialog.css
new file mode 100644
index 00000000..9f92db96
--- /dev/null
+++ b/app/client/views/library/libraryItemDialog/library-item-dialog.css
@@ -0,0 +1,3 @@
+.library-item-dialog paper-input {
+  min-width: 160px;
+}
diff --git a/app/client/views/library/libraryItemDialog/libraryItemDialog.html b/app/client/views/library/libraryItemDialog/libraryItemDialog.html
index cdb41347..d9551924 100644
--- a/app/client/views/library/libraryItemDialog/libraryItemDialog.html
+++ b/app/client/views/library/libraryItemDialog/libraryItemDialog.html
@@ -1,5 +1,5 @@
 <template name="libraryItemDialog">
-  <div class="fit base-dialog layout vertical">
+  <div class="fit base-dialog layout vertical library-item-dialog">
 		<app-toolbar>
       <paper-icon-button id="backButton"
 							   icon="arrow-back">
@@ -34,7 +34,7 @@
       <div style="margin-top: 8px;">
         <div class="paper-font-subhead">Effects</div>
         {{#each indexedEffects}}
-          <div class="effect layout horizontal center wrap">
+          <div class="effect layout horizontal center wrap" style="margin-bottom: 32px;">
             <paper-dropdown-menu label="Operation" class="operationMenu" disabled="{{cantEdit}}">
   						<paper-listbox class="dropdown-content"  selected={{operationIndex operation}}>
                 <paper-item label="Base Value" name="base"> Base Value </paper-item>
@@ -59,7 +59,7 @@
       <div style="margin-top: 8px;">
         <div class="paper-font-subhead">Attacks</div>
         {{#each indexedAttacks}}
-          <div class="effect layout horizontal center wrap">
+          <div class="effect layout horizontal center wrap" style="margin-bottom: 32px">
             <paper-input class="LibraryItemAttackBonusInput flex" label="Attack Bonus" value={{attackBonus}} disabled="{{cantEdit}}"></paper-input>
             <paper-input class="LibraryItemAttackDamageInput flex" label="Damage" value={{damage}} disabled="{{cantEdit}}"></paper-input>
             <paper-input class="LibraryItemAttackDetailsInput flex" label="Details" value={{details}} disabled="{{cantEdit}}"></paper-input>

From 39c91f58e418b789b7f208e5beaaf1a0d973e1da Mon Sep 17 00:00:00 2001
From: Stefan Zermatten <stefanzermatten@gmail.com>
Date: Tue, 7 May 2019 09:25:06 +0200
Subject: [PATCH 3/3] Swapped weight and value in library item dialog to be
 consistent with the inventory

---
 .../views/library/libraryItemDialog/libraryItemDialog.html      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/client/views/library/libraryItemDialog/libraryItemDialog.html b/app/client/views/library/libraryItemDialog/libraryItemDialog.html
index d9551924..d8238f23 100644
--- a/app/client/views/library/libraryItemDialog/libraryItemDialog.html
+++ b/app/client/views/library/libraryItemDialog/libraryItemDialog.html
@@ -24,8 +24,8 @@
         </paper-checkbox>
       </div>
       <div class="layout horizontal center wrap">
-        <paper-input id="libraryItemValueInput" class="flex" label="Value" type="number" value={{item.value}} disabled="{{cantEdit}}"></paper-input>
         <paper-input id="libraryItemWeightInput" class="flex" label="Weight" type="number" value={{item.weight}} disabled="{{cantEdit}}"></paper-input>
+        <paper-input id="libraryItemValueInput" class="flex" label="Value" type="number" value={{item.value}} disabled="{{cantEdit}}"></paper-input>
         <paper-checkbox id="attunementCheckbox" class="flex" checked={{item.requiresAttunement}} disabled="{{cantEdit}}">
           Requires Attunement
         </paper-checkbox>